Am Montag, 5. August 2013 um 08:22:19, schrieb Scott Kostyshak <skost...@lyx.org> > On Mon, Aug 5, 2013 at 8:09 AM, Kornel Benko <kor...@lyx.org> wrote: > > Am Montag, 5. August 2013 um 08:01:08, schrieb Scott Kostyshak > > <skost...@lyx.org> > > > >> On Mon, Aug 5, 2013 at 5:56 AM, Pavel Sanda <sa...@lyx.org> wrote: > > > >> > Scott Kostyshak wrote: > > > >> >> > Sorry, I meant "This is also a test for lyx2lyx, isn't it?" > > > >> >> > > > >> >> My opinion is that we should update those documents. I agree that it > > > >> > > > > >> > attic is just garbage and it is somewhat absurd that test should fail > > > >> > because of some contents in there. Please create proper tests for > > > >> > things you want to test and do not impose some future maintenance > > > >> > burden like "we should keep stuff in attic up-to-date". > > > >> > > > >> OK. Attached is a patch. > > > >> > > > >> Scott > > > > > > > > Why not check earlier? > > Indeed, that is better. I think you can commit that (if you agree with > it). Both Vincent and Pavel are in favor of not testing attic. > > Scott
I do not agree. We should check attic too IMHO (or else do not provide it).
Therefore I prefer you to commit :)
Kornel
signature.asc
Description: This is a digitally signed message part.
