Op 5 aug. 2013 23:25 schreef "Richard Heck" <rgh...@lyx.org> het volgende: > > On 08/04/2013 05:43 PM, Richard Heck wrote: >> >> >> The attached patch explains the problem and offers a simple solution. This is master-only, and it needs to go into 2.1. OK? > > > Someone want to approve this? or not? > >> Richard >> >
First, please shorten the subject line to around 60 chars. Second, it is ugly that PreviewImage depends on Buffer. Third, it doesn't feel good to leave behind preview images, just in case the export XHTML needs them. Fourth, I don't like removing files in a destructor in the first place. It should be a conscious decision to do that. Compare also hideDialogs calls in Inset destructors. If you would need to delete the files explicitly, it would also be easier to not delete them when appropriate. Fifth, do you use isClone to detect whether we are exporting ? Seems like a hack that deserves a comment. But you'll probably want a solution to the problem, but that's difficult to come up with right away. Vincent
