Re: nonbreakdash screws up TOC

2008-10-12 Thread Abdelrazak Younes
On 13/10/2008 08:20, Jürgen Spitzmüller wrote: Jürgen Spitzmüller wrote: Export to plaintext does not produce a dash at all in the TOC. Seems that textString is currently broken in general (the same happens for other special characters and for spaces at least). It has to do

Re: nonbreakdash screws up TOC

2008-10-12 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > > Export to plaintext does not produce a dash > > at all in the TOC. > > Seems that textString is currently broken in general (the same happens for > other special characters and for spaces at least). It has to do with TocBackend::updateItem passing asString(AS_STR_LABE

Re: Sanitize backreferences in hyperref

2008-10-12 Thread Pavel Sanda
Uwe Stöhr wrote: > > Is it possible to convert between pageref and pagebackref? > > It is, this is the third issue. Simply deleting information in lyx2lyx is > not an option. I changed it now so that pagebackref is converted to > backref=page, otherwise this would be a dataloss. > > > to me hyper

Re: Sanitize backreferences in hyperref

2008-10-12 Thread Pavel Sanda
Uwe Stöhr wrote: > - the option "backref" is the same as "backref=section" so we shouldn't > provide an "On" option as this only leads to confusion if this is true we can simplify it even more, because this line become useless > + string tmp = backref == "true" ? "" : "=" + backref; > Attac

Re: Sanitize backreferences in hyperref

2008-10-12 Thread Uwe Stöhr
There are 3 issues in your patch: According to ftp://ftp.fu-berlin.de/tex/CTAN/macros/latex/contrib/hyperref/backref.pdf - the option is "page", not "pages" (my fault) - the option "backref" is the same as "backref=section" so we shouldn't provide an "On" option as this only leads to confusion

Re: [Cvslog] r26860 - in /lyx-devel/trunk: development/FORMAT lib/lyx2...

2008-10-12 Thread Pavel Sanda
Richard Heck wrote: >>> So the parameters for GuiDocument now include the effects of loaded >>> modules. And what I'm not sure about is whether that is correct. If it >>> is, we have a different bug, namely, that adding or removing a module >>> doesn't update the document class. >>> >>> That sai

Re: [Cvslog] r26860 - in /lyx-devel/trunk: development/FORMAT lib/lyx2...

2008-10-12 Thread rgheck
Pavel Sanda wrote: Richard Heck wrote: With the introduction of modules came a distinction between the base class and the document class. The former corresponds to the main layout file; the latter is that plus the modules (or the document-specific layout, or whatever else there could be). T

Re: [patch] Selection painting in Insets

2008-10-12 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > > I renamed the Row::left_margin_sel back to Row::begin_margin_sel > > because > > of RTL text. > > > > Is there yet a verdict for this patch ? i tested the last version and from the functional point of view it was ok. but i know nothing about painting, so somebo

Re: Sanitize backreferences in hyperref

2008-10-12 Thread Pavel Sanda
Richard Heck wrote: > Pavel Sanda wrote: >> +def revert_backref_options(document): >> +' Remove pageref additional options ' >> +i = find_token(document.header, "\\pdf_pageref", 0) >> +if i != -1: >> +del document.header[i] >> + >> + >> +def convert_backref_options(document): >>

Re: [Cvslog] r26860 - in /lyx-devel/trunk: development/FORMAT lib/lyx2...

2008-10-12 Thread Pavel Sanda
Richard Heck wrote: > With the introduction of modules came a distinction between the base class > and the document class. The former corresponds to the main layout file; the > latter is that plus the modules (or the document-specific layout, or > whatever else there could be). The way the code

changeset 26871

2008-10-12 Thread Uwe Stöhr
What is this? This makes no sense to me. Maybe I am wrong, but you cannot assume an encoding from the length of a comment. So you introduced a bug when I use the same comment but use plain ASCII. Besides this, XeTeX support is planned for LyX 1.7, LyX 1.6 is feature frozen. So I don't understand

Re: [patch] make tex2lyx utf8 encoding in some cases

2008-10-12 Thread Uwe Stöhr
Andre Poenitz schrieb: Ok. I don't see really the big problem here. #3035 is about getting a few spaces not right as far as I can tell from the pdf output I see. While this is certainly not nice it is hardly "major", and I also don't understand why this is so fundamental that it stops any furt

about tex2lyx and Unicode

2008-10-12 Thread Uwe Stöhr
>> So, does this completely fix this? Or is there still work to be done >> with the inputenc stuff? > > I guess there's a lot left. But I'll approach that on a case-by-case > base. Better get known cases right instead of being stuck for years > while waiting for perfect solutions to appear magical

Re: [patch] make tex2lyx utf8 encoding in some cases

2008-10-12 Thread Andre Poenitz
On Sat, Oct 11, 2008 at 01:42:53PM +0200, Uwe Stöhr wrote: > Andre Poenitz schrieb: > >> I tend to send them in a second mail marked by "Urmph" or similar. > > I got it now, it is OK by me. > >>> But besides this, I'm very happy that someone started to work on >>> tex2lyx's Unicode support. As I w

Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Uwe Stöhr
Abdelrazak Younes schrieb: My opinion: this code is a mess and is very fragile because it _is_ a mess; if we don't fix it now, it will turn out to be a source of a lot of unpredictable bugs. I spent a lot time getting the babel code bug free. Maybe the code is not the best looking, but it is

Re: [patch] Selection painting in Insets

2008-10-12 Thread Vincent van Ravesteijn
Vincent van Ravesteijn wrote: > This patch solves some problems with painting selections in Insets. > These are: > - multiline selections paint in left margin of the main text > (bug 5270), > - the margins to the left and right side of the inset are not correct, > - wrong painting of e.g. a multil

Re: [patch] potential fix for #4299

2008-10-12 Thread rgheck
Andre Poenitz wrote: On Sun, Oct 12, 2008 at 11:43:57AM -0400, rgheck wrote: Andre Poenitz wrote: Ok? I've been following this a bit, and I'm VERY happy you're doing this. As Uwe said, tex2lyx has been stuck in neutral for a long time for this reason. So, does this compl

Re: Sanitize backreferences in hyperref

2008-10-12 Thread rgheck
Pavel Sanda wrote: +def revert_backref_options(document): +' Remove pageref additional options ' +i = find_token(document.header, "\\pdf_pageref", 0) +if i != -1: +del document.header[i] + + +def convert_backref_options(document): +' We have lost pagebackref option in favo

Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Abdelrazak Younes
On 12/10/2008 20:02, Abdelrazak Younes wrote: On 12/10/2008 19:22, Uwe Stöhr wrote: I wrote: I fear you have to revert your commit, as you broke the whole babel handling. That means currently only English documents are output correctly as babel is not loaded! This problem turned out to be r

Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Abdelrazak Younes
On 12/10/2008 20:07, Abdelrazak Younes wrote: On 12/10/2008 20:02, Abdelrazak Younes wrote: On 12/10/2008 19:22, Uwe Stöhr wrote: I wrote: I fear you have to revert your commit, as you broke the whole babel handling. That means currently only English documents are output correctly as babel i

Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Abdelrazak Younes
On 12/10/2008 20:02, Abdelrazak Younes wrote: On 12/10/2008 19:22, Uwe Stöhr wrote: I wrote: I fear you have to revert your commit, as you broke the whole babel handling. That means currently only English documents are output correctly as babel is not loaded! This problem turned out to be r

Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Abdelrazak Younes
On 12/10/2008 19:22, Uwe Stöhr wrote: I wrote: I fear you have to revert your commit, as you broke the whole babel handling. That means currently only English documents are output correctly as babel is not loaded! This problem turned out to be really serious as it makes certain documents un

Re: [patch] support for Mongolian

2008-10-12 Thread Abdelrazak Younes
On 12/10/2008 15:16, Uwe Stöhr wrote: Abdelrazak Younes schrieb: I did some cleanup so that this can be done easily now. The advantage would be that any new special babel language could be added easily if we put this info in lib/languages. I'm not happy about this. Your patch is the step in

Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Uwe Stöhr
I wrote: I fear you have to revert your commit, as you broke the whole babel handling. That means currently only English documents are output correctly as babel is not loaded! This problem turned out to be really serious as it makes certain documents uncompilable. To be able to work on the d

Re: [patch] potential fix for #4299

2008-10-12 Thread Andre Poenitz
On Sun, Oct 12, 2008 at 11:43:57AM -0400, rgheck wrote: > Andre Poenitz wrote: >> Ok? >> >> > I've been following this a bit, and I'm VERY happy you're doing this. As > Uwe said, tex2lyx has been stuck in neutral for a long time for this > reason. > > So, does this completely fix this? Or is

Sanitize backreferences in hyperref

2008-10-12 Thread Pavel Sanda
hi, towards bug http://bugzilla.lyx.org/show_bug.cgi?id=5340 to sum up: hyperref manual incorrectly states, that \backref is boolean while in fact its string with false/section/pages/slides args. this way our tex output \backref=true won't work. we need to support these plus "pages" arg collides/

Re: [patch] potential fix for #4299

2008-10-12 Thread rgheck
Andre Poenitz wrote: Ok? I've been following this a bit, and I'm VERY happy you're doing this. As Uwe said, tex2lyx has been stuck in neutral for a long time for this reason. So, does this completely fix this? Or is there still work to be done with the inputenc stuff? rh

Re: [Cvslog] r26860 - in /lyx-devel/trunk: development/FORMAT lib/lyx2...

2008-10-12 Thread rgheck
[EMAIL PROTECTED] wrote: Author: spitz Date: Sun Oct 12 11:36:00 2008 New Revision: 26860 URL: http://www.lyx.org/trac/changeset/26860 Log: ** fix bug 2114. Fileformat change. ** fix bug 5343 (patch from Richard, prerequisite for the other fix) I thought about this for quite a while last nig

Re: Breakable slash hotkey

2008-10-12 Thread Jürgen Spitzmüller
Jan Engelhardt wrote: > >Does it work for you if you change the binding in your bind file to > > > >\bind "~S-C-slash" "specialchar-insert slash" > > No. Strange. I did this change anyway, since it strikes me correct. Jürgen

Re: Breakable slash hotkey

2008-10-12 Thread Jan Engelhardt
On Sunday 2008-10-12 06:01, Jürgen Spitzmüller wrote: >Jan Engelhardt wrote: >> According to the hotkeys as listed in the Insert>Special Character menu, >> to create the breakable slash, I am supposed to hit Ctrl-Shift-/ . >> But trying to attempt that actually gives the equivalent of Ctrl-? (on >>

Re: [patch] make tex2lyx utf8 encoding in some cases

2008-10-12 Thread Andre Poenitz
On Sun, Oct 12, 2008 at 03:41:29PM +0200, Uwe Stöhr wrote: > Andre Poenitz schrieb: > >>> So my proposal is to look at the inputenc option. When no option is >>> given or there is no inputenc package, we use plain ASCII as also >>> LaTeX would do this. >> >> In this file there is no inputenc fiel

Re: [patch] make tex2lyx utf8 encoding in some cases

2008-10-12 Thread Uwe Stöhr
Andre Poenitz schrieb: So my proposal is to look at the inputenc option. When no option is given or there is no inputenc package, we use plain ASCII as also LaTeX would do this. In this file there is no inputenc field but still non-7bit chars. XeLaTeX seems to assume utf8 by default. Yes i

[patch] potential fix for #4299

2008-10-12 Thread Andre Poenitz
Ok? Index: preamble.cpp === --- preamble.cpp(revision 26861) +++ preamble.cpp(working copy) @@ -512,7 +512,18 @@ static regex const usercommands("User specified LaTeX commands");

Re: babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Pavel Sanda
Uwe Stöhr wrote: > I fear you have to revert your commit, as you broke the whole babel > handling. That means currently only English documents are output correctly > as babel is not loaded! i agree with Uwe thats quite dangerous to touch the babel bussiness in rc mode. pavel

Re: [patch] make tex2lyx utf8 encoding in some cases

2008-10-12 Thread Andre Poenitz
On Sun, Oct 12, 2008 at 03:06:50PM +0200, Uwe Stöhr wrote: > Andre Poenitz schrieb: > >>> http://bugzilla.lyx.org/show_bug.cgi?id=4299 >> >> Well, the problem here, is of course, that the .tex file does not contain any >> hint what kind of encoding the file contents has. > > I don't think so. LaTeX

babel handling completely broken!!! - was: Re: [patch] support for Mongolian

2008-10-12 Thread Uwe Stöhr
I wrote: Abdelrazak Younes wrote: I did some cleanup so that this can be done easily now. The advantage would be that any new special babel language could be added easily if we put this info in lib/languages. I'm not happy about this. Your patch is the step in the right direction, so I'm n

Re: [patch] support for Mongolian

2008-10-12 Thread Uwe Stöhr
Abdelrazak Younes schrieb: I did some cleanup so that this can be done easily now. The advantage would be that any new special babel language could be added easily if we put this info in lib/languages. I'm not happy about this. Your patch is the step in the right direction, so I'm not against

Re: [patch] make tex2lyx utf8 encoding in some cases

2008-10-12 Thread Uwe Stöhr
Andre Poenitz schrieb: http://bugzilla.lyx.org/show_bug.cgi?id=4299 Well, the problem here, is of course, that the .tex file does not contain any hint what kind of encoding the file contents has. I don't think so. LaTeX has to be informed about the encoding a file has, the same as we have to

Re: [patch] make tex2lyx utf8 encoding in some cases

2008-10-12 Thread Andre Poenitz
On Sat, Oct 11, 2008 at 01:42:53PM +0200, Uwe Stöhr wrote: > Andre Poenitz schrieb: > >> I tend to send them in a second mail marked by "Urmph" or similar. > > I got it now, it is OK by me. > >>> But besides this, I'm very happy that someone started to work on >>> tex2lyx's Unicode support. As I w

Re: r26683 - in /lyx-devel/trunk/src: ConverterCache.cpp Expo...

2008-10-12 Thread Georg Baum
Richard Heck wrote: > Thanks for noticing You are welcome. I stumbled apon it when I wanted to check my answer to the guy in the users list. Georg

Better announcements for test releases

2008-10-12 Thread Uwe Stöhr
It turned out that people misunderstand our beta and release candidate announcements. So I know from cases where people switched with their Ph.D. thesis from the stable LyX 1.5.6 to LyX 1.6.0RC3 an now suffer from our regression bugs and crashes. Our current announcement reads: "We encourage u

Re: Breakable slash hotkey

2008-10-12 Thread Jürgen Spitzmüller
Jan Engelhardt wrote: > According to the hotkeys as listed in the Insert>Special Character menu, > to create the breakable slash, I am supposed to hit Ctrl-Shift-/ . > But trying to attempt that actually gives the equivalent of Ctrl-? (on > an US keyboard), which currently just gives me the questio

Re: nonbreakdash screws up TOC

2008-10-12 Thread Jürgen Spitzmüller
Jan Engelhardt wrote: > Using a nonbreakdash in a header screws up its entry in the TOC when > exported to pdflatex or DVI. fixed. > Export to plaintext does not produce a dash > at all in the TOC. Seems that textString is currently broken in general (the same happens for other special charact

Re: [patch] Re: Assertion failed with old-style latex index insets

2008-10-12 Thread Jürgen Spitzmüller
rgheck wrote: > No, this just looks like an oversight from before, probably mine. > > We really ought to have written: >      name  "" > in this case. But we don't. Indeed. I committed the patch. Jürgen

Re: [patch] support for Mongolian

2008-10-12 Thread Abdelrazak Younes
On 12/10/2008 01:37, Uwe Stöhr wrote: > I don't like to see so many special cases on the code. Would not it be > possible to put this information directly into lib/languages and to read it > from there? In principle yes, but this is something for LyX 1.7 as this would change a lot. I did so