Attached find a series of RTL patches which we need OKs for in order
to commit.
1) rtlboundary.patch --- fixes bug 3754: Cursor movement at RTL-LTR
boundary (http://bugzilla.lyx.org/show_bug.cgi?id=3754)
2) rtlcursorx.patch --- fixes issue (3) of bug 3551: Cursor movement
in and around in
Stefan Schimanski wrote:
> With another OK I could even commit it and fix the problem for the
> next RC.
Could you point us towards the relevant qt bug entry?
Jürgen
It is a Qt 4.3 bug. The Qt demo application show the same
behavior. Here is a simple fix for the time being. We can add an
upper version limit as soon as Trolltech announces a fix. I
reported the bug to them.
Stefan
Thanks Stefan, it works fine!
Do I understand the code correctly that (s
Jürgen Spitzmüller wrote:
> maybe someone else has?
>
> The following needs to be done:
>
>
> def convert_graphics_rotation(document):
>
> if we have a graphics inset that has the rotateAngle param and either the
> width, height or scaled param, then add the param scaleBeforeRotation. Else
> do not
Surely there are standard user interface conventions available for
deciding on what should be done in such cases.
Window closing etc. has been around for getting onto two decades.
Something doesn't sound right when developers have to have long
discussions on it.
Aren't these types of rules bui
http://bugzilla.lyx.org/show_bug.cgi?id=3512
Two eps images (escher-lsd.eps and mobius.eps) are broken and crash gs on
compilation. I fixed those two images with eps2eps.
OK to commit?
Jürgen
Jean-Marc Lasgouttes wrote:
> The whole patch seems to make sense.
+1
Jürgen
Stefan Schimanski wrote:
> + // possibly the row metrics are outdated and the endpos() was
> computed + // before the paragraph was changed (e.g. by backspace)
> + end_ = std::min(par.size(), row.endpos()) - 1;
> +
This solution looks OK to me for now.
Jürgen
Jean-Marc Lasgouttes wrote:
> No, I think the right fix is to use this instead in the caller:
I don't understand.
Jürgen
> "Richard" == Richard Heck <[EMAIL PROTECTED]> writes:
Richard> The attached patch does the greying out. OK to commit?
OK for me.
Richard> This leaves the question whether having both "Close" and
Richard> "Close Window" is confusing. Stefan is right in what he says
Richard> here: Close View
> "Richard" == Richard Heck <[EMAIL PROTECTED]> writes:
Richard> The attached patch addresses this bug. The idea is to leave
Richard> the TOC, and all other "buffer dependent" dialogs, open when
Richard> closing one buffer, if there is still one open.
Richard> Abdel said he was OK with this p
> "Richard" == Richard Heck <[EMAIL PROTECTED]> writes:
Richard> This patch fixes this problem by changing the label to "Add
Richard> Printer Name to Printer Command" and changing the tooltip to
Richard> "Check this box if you will sometimes use a printer other
Richard> than the default".
I a
> "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes:
Stefan> Ok, 1/3 of the height makes sense, will use that instead. Need
Stefan> another OK...
The whole patch seems to make sense.
JMarc
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes:
Dov> But then you have a somewhat weird situation, where you're at the
Dov> end of a line, and pressing delete deletes from the beginning of
Dov> the next line, where the cursor "isn't". That does not seem
Dov> natural to me... (Of course it
Am 03.06.2007 um 23:12 schrieb Dov Feldstern:
Stefan Schimanski wrote:
* rtlspaces.patch: There is a inconsistency between the font of
spaces at RTL<->LTR boundaries. The whole space problem is
discussed in http://permalink.gmane.org/gmane.editors.lyx.devel/
80783. An illustration of the c
Stefan Schimanski wrote:
* rtlspaces.patch: There is a inconsistency between the font of
spaces at RTL<->LTR boundaries. The whole space problem is discussed
in http://permalink.gmane.org/gmane.editors.lyx.devel/80783. An
illustration of the current situation and the one after this patch
are v
Stefan Schimanski wrote:
Am 03.06.2007 um 21:28 schrieb Dov Feldstern:
Stefan Schimanski wrote:
1) In Text2.cpp, in the condition "if (cur.boundary() &&
!bidi.isBoundary...", it should be:
return setCursor(cur, cur.pit(), cur.pos(), true, false);
and not, as you have:
return se
Am 03.06.2007 um 21:28 schrieb Dov Feldstern:
Stefan Schimanski wrote:
1) In Text2.cpp, in the condition "if (cur.boundary() && !
bidi.isBoundary...", it should be:
return setCursor(cur, cur.pit(), cur.pos(), true, false);
and not, as you have:
return setCursor(cur, cur.pit(), c
Ok, 1/3 of the height makes sense, will use that instead.
Need another OK...
Stefan
Stefan, you won't believe this! On Friday I also wrote a patch for
this --- but I just don't have the time to work on LyX...:( I was
going to just clean it up and send it in any day...
Anyhow, naturally
Richard Heck schrieb:
This patch fixes this problem by changing the label to "Add Printer
Name to Printer Command" and changing the tooltip to "Check this box
if you will sometimes use a printer other than the default".
OK to commit?
- Use printer name explicitely
+ Check this bo
Hi!
Here's another patch I have in the works. I only recently was finally
able to reliably reproduce it, and once I understood what the problem
is, the fix is fairly easy. However, I may very well not be aware of all
the aspects of keymaps, so please look at this carefully.
To see the bug, y
Stefan Schimanski wrote:
If that's too risky / too hard until after the 1.5.0 release, then I
prefer your previous solution, of forcing a recalculation of the
metrics before calling computeTables --- as you pointed out to me,
even though we'll be computing the metrics twice that way, it's
prob
Stefan, you won't believe this! On Friday I also wrote a patch for this
--- but I just don't have the time to work on LyX...:( I was going to
just clean it up and send it in any day...
Anyhow, naturally my patch is pretty similar to yours. The only
significant difference is that I saw that in
Stefan Schimanski wrote:
1) In Text2.cpp, in the condition "if (cur.boundary() &&
!bidi.isBoundary...", it should be:
return setCursor(cur, cur.pit(), cur.pos(), true, false);
and not, as you have:
return setCursor(cur, cur.pit(), cur.pos() + 1, true, false);
(the + 1 is wrong; see
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> http://bugzilla.lyx.org/show_bug.cgi?id=3793 This crash only
Jürgen> happens when you use a language that has non-ascii chars in a
Jürgen> message (such as fr_FR: "Table des Matières" in the reported
Jürgen> case)
Jürgen> Th
> "José" == José Matos <[EMAIL PROTECTED]> writes:
José> Firefox works like that, File->Close closes the current window
José> and if there are no more windows it quits.
It closes the tab, actually.
JMarc
> Question: Would it be possible to change the file format at this stage
> of development? E.g., to
i remember jose has written somewhere that yes. fileformat cant be changed
only after 1.5.0 is out to maintain 1.5.x series stable.
> Any comments or suggestions for a better solution?
just two i
This patch fixes this problem by changing the label to "Add Printer Name
to Printer Command" and changing the tooltip to "Check this box if you
will sometimes use a printer other than the default".
OK to commit?
rh
--
==
Richar
On Sun, Jun 03, 2007 at 07:59:33PM +0200, Michael Gerz wrote:
> Hi,
>
> while working on de.po, I noticed a few cosmetical things in
> beamer.layout (extra spaces, fake formatting that doesn't work
> well etc).
>
> Attached please find a patch that cleans up the layout file. OK?
>
> Michael
L
Michael Gerz schrieb:
Jean-Marc Lasgouttes schrieb:
Michael> In the LyX document header, we have to list all authors for
Michael> which a change is tracked in the document. That means that we
Michael> have to iterate through the complete document and check
Michael> whether there is any change fo
Jean-Marc Lasgouttes schrieb:
Michael> In the LyX document header, we have to list all authors for
Michael> which a change is tracked in the document. That means that we
Michael> have to iterate through the complete document and check
Michael> whether there is any change for a given author whenev
Hello,
there is a crash and i can tell the reason. As i have no time investigate further i post to the list
what i already found out.
to reproduce:
1. start lyx
2. open a document that contains insets
3. open another window (new window)
4. close the second window
5. close the document in the f
Hi,
while working on de.po, I noticed a few cosmetical things in
beamer.layout (extra spaces, fake formatting that doesn't work well etc).
Attached please find a patch that cleans up the layout file. OK?
Michael
Index: beamer.layout
The attached patch addresses this bug. The idea is to leave the TOC, and
all other "buffer dependent" dialogs, open when closing one buffer, if
there is still one open.
Abdel said he was OK with this patch if I could prove it didn't crash
anything. I've tried to do so by opening every dialog
Jürgen Spitzmüller wrote:
http://bugzilla.lyx.org/show_bug.cgi?id=3793
This crash only happens when you use a language that has non-ascii chars in a
message (such as fr_FR: "Table des Matières" in the reported case)
The fix seems straightforward to me.
And to me.
OK to apply?
So far
Stefan Schimanski wrote:
Am 02.06.2007 um 18:28 schrieb Richard Heck:
Regarding this bug: http://bugzilla.lyx.org/show_bug.cgi?id=3794.
It seems to me something needs to be done about this soon. The
question is what. I'd propose doing two things: (i) The Close Window
menu entry should be disa
Bo Peng wrote:
> OK.
+1.
Jürgen
On 6/3/07, Michael Gerz <[EMAIL PROTECTED]> wrote:
By request of Pavel... awaiting another OK.
Michal
Index: src/frontends/qt4/ui/ListingsUi.ui
===
--- src/frontends/qt4/ui/ListingsUi.ui (Revision 18639)
+++ src/frontends/qt4/ui/L
By request of Pavel... awaiting another OK.
Michal
Index: src/frontends/qt4/ui/ListingsUi.ui
===
--- src/frontends/qt4/ui/ListingsUi.ui (Revision 18639)
+++ src/frontends/qt4/ui/ListingsUi.ui (Arbeitskopie)
@@ -117,7 +117,7 @@
Pavel Sanda schrieb:
* 'Program Listing' entry has no shortcut in menu
Well, considering the size of the "Insert" menu, not all entries can
have a shortcut.
i don't see that 's' is used.
It is - by "Short Title"
Michael
Dear Developers,
Many thanks for Lyx 1.5.0 release candidate.
I noticed this:
When I use Altgrey 5 on my keyboard, this does not give ° (textdegree).
Also, Altgrey 3 does not give ^. The majority of other Altgr
combinations work.
However, when I press Altgrey and keep key 5 pressed, the res
On 02.06.2007, at 00:39, Tim Michelsen wrote:
I just want to add something from a users experience with math in
normal text.
As far as I can recall, one reason that I particularly wanted
this feature
was to enable me to see more clearly whether or not I had spaces
between
a formula and th
> >* 'Program Listing' entry has no shortcut in menu
> >
> Well, considering the size of the "Insert" menu, not all entries can
> have a shortcut.
i don't see that 's' is used.
> >* the current situation for math panels is bit unintuitive - from the
> > naming of menu entries "Math" and "Math
Pavel Sanda schrieb:
Pavel Sanda wrote:
* not translated some items in listings dialog
(already reported few days ago)
Which ones?
Language, Dialect, Side, Space as symbol, Space in string as symbol,
Extended character table, More parameters.
It may be ok after new remerge
Pavel Sanda schrieb:
Hello,
While updating translation I run into few problems:
* not translated some items in listings dialog
(already reported few days ago)
Everything is fixed now!
* combo boxes in listings dialog dont get resized accordingly
to the length of the strings inside th
Am 03.06.2007 um 15:29 schrieb Michael Gerz:
Stefan Schimanski schrieb:
Slight correction of the EPM patch: there are these exceptions of
the logic to avoid double spaces:
abc [WERBEH|] def"
abc [ WERBEH]|def"
abc|[WERBEH ]def"
abc[|WERBEH] def"
All 4 should be possible, i.e. a space shoul
Pavel Sanda wrote:
> Language, Dialect, Side, Space as symbol, Space in string as symbol,
> Extended character table, More parameters.
>
> It may be ok after new remerge, because imho the previous po files were
> remerged before patches for this (I already sent translation to
> po-updates yesterday
> Pavel Sanda wrote:
> > * not translated some items in listings dialog
> > (already reported few days ago)
>
> Which ones?
Language, Dialect, Side, Space as symbol, Space in string as symbol,
Extended character table, More parameters.
It may be ok after new remerge, because imho the previous
Stefan Schimanski schrieb:
Slight correction of the EPM patch: there are these exceptions of the
logic to avoid double spaces:
abc [WERBEH|] def"
abc [ WERBEH]|def"
abc|[WERBEH ]def"
abc[|WERBEH] def"
All 4 should be possible, i.e. a space should be inserted. The last
two don't fulfill the co
Am Samstag, 2. Juni 2007 20:10 schrieb Micha Feigin:
> On Fri, 01 Jun 2007 11:35:45 +0200
> Georg Baum <[EMAIL PROTECTED]> wrote:
>
> > Jean-Marc Lasgouttes wrote:
> > > I really feel that what this is trying to fix is a bug in the qt
> > > dialog. I have never seen people feeling forced to add
http://bugzilla.lyx.org/show_bug.cgi?id=3793
This crash only happens when you use a language that has non-ascii chars in a
message (such as fr_FR: "Table des Matières" in the reported case)
The fix seems straightforward to me.
OK to apply?
Jürgen
Index: src/Messages.cpp
===
Hi!
Was there any reason to ignore the cursor shape in the Qt frontend?
Here is a patch:
Index: src/frontends/qt4/GuiWorkArea.cpp
===
--- src/frontends/qt4/GuiWorkArea.cpp (Revision 18626)
+++ src/frontends/qt4/GuiWorkArea.cpp (
Michael Gerz wrote:
> did you make them untranslateable on purpose?
Yes.
> I must confess that it is very hard to find a proper translation
> for "common", "primitive", and
> "plain", especially as no definition is given for the English terms :-)
> Thus, I will not complain if we keep the Engl
Slight correction of the EPM patch: there are these exceptions of the
logic to avoid double spaces:
abc [WERBEH|] def"
abc [ WERBEH]|def"
abc|[WERBEH ]def"
abc[|WERBEH] def"
All 4 should be possible, i.e. a space should be inserted. The last
two don't fulfill the condition that the previous
Michael Gerz wrote:
> IOW we should move from dvipdfm to dvipdfmx?
This is already done.
If dvipdfmx is installed, LyX uses that. Else, it falls back to dvipdfm.
Jürgen
[EMAIL PROTECTED] schrieb:
Modified: lyx-devel/trunk/src/frontends/qt4/QListings.cpp
URL:
http://www.lyx.org/trac/file/lyx-devel/trunk/src/frontends/qt4/QListings.cpp?rev=18624
==
--- lyx-devel/trunk/src/frontends/qt4/QL
On Sat, Jun 02, 2007 at 06:17:46PM +0200, Stefan Schimanski wrote:
> Another possibility of course (which I proposed somewhere in the
> other thread about the backspace case of Dov) is so redo the metrics
> of the current paragraph before setting the current font again. But
> then I guess the
Jürgen Spitzmüller schrieb:
Herbert Voss wrote:
-> XeTeX
So dvipdfmx is still the right thing to choose, unless people use XeTeX (where
they currently need to change the converters manually anyway).
Jürgen
IOW we should move from dvipdfm to dvipdfmx?
Michael
Helge Hafting schrieb:
Mostly new stuff:
* outlines
* view source code
* listings dialog
* Some older untranslated pieces all over the place
Helge Hafting
Committed.
Michael
* rtlspaces.patch: There is a inconsistency between the font of
spaces at RTL<->LTR boundaries. The whole space problem is
discussed in http://permalink.gmane.org/gmane.editors.lyx.devel/
80783. An illustration of the current situation and the one after
this patch are visible at http://artic
Dov Feldstern wrote:
> Peter Kümmel wrote:
>> I've applied attached patch which only eats page up/down keys on x11
>> and fixes the scrollbar scrolling bug. This is a conservative approach.
>>
>> And because we really need more testing until the release it
>> is now in svn (I know, I know, I know,.
Pavel Sanda wrote:
> * not translated some items in listings dialog
> (already reported few days ago)
Which ones?
Jürgen
José, what is your opinion about all that. I guess you don't follow
the thread anymore.
Stefan
Am 03.06.2007 um 09:36 schrieb Stefan Schimanski:
1) In Text2.cpp, in the condition "if (cur.boundary() && !
bidi.isBoundary...", it should be:
return setCursor(cur, cur.pit(), cur.pos(), tr
If that's too risky / too hard until after the 1.5.0 release, then
I prefer your previous solution, of forcing a recalculation of the
metrics before calling computeTables --- as you pointed out to me,
even though we'll be computing the metrics twice that way, it's
probably negligible next t
1) In Text2.cpp, in the condition "if (cur.boundary() && !
bidi.isBoundary...", it should be:
return setCursor(cur, cur.pit(), cur.pos(), true, false);
and not, as you have:
return setCursor(cur, cur.pit(), cur.pos() + 1, true, false);
(the + 1 is wrong; see what happens at the end
65 matches
Mail list logo
