Ekkehart Schlicht wrote:
> Joost Verburg wrote:
>> Ekkehart Schlicht wrote:
>>> I just found out that Lyx does not know the Latex command \limits
>>> which produces the limits of integrals etc. above and below the
>>> integral operator. Maybe it is worthwhile to implement it. With regard
>>> to te
"Bo Peng" <[EMAIL PROTECTED]> writes:
| > We have abondoned Coding_Rules(?) a long time ago and used 'do whatever
| > the majority in src/* does'
|
| Because it is easier to change the rules than change source code. BTW,
| the style I like is:
|
| class ThisClass
| {
| int thisFunction();
|
|
Andre Poenitz <[EMAIL PROTECTED]> writes:
| We have abondoned Coding_Rules(?) a long time ago and used 'do whatever
| the majority in src/* does'
No.
--
Lgb
Just submitted a bug (http://bugzilla.lyx.org/show_bug.cgi?id=2665) in
case that this is not considered in the CT patches
Bo
How about adding
#ifdef _USE_PCH
#include
#endif
Even this does not satisfy msvc. msvc replaces things before (and
include) pch.h with precompiled headers generated by pch.cpp, and
leaves one #endif in the .cpp file, which of course results in
trouble. Note that pragma does not work in this ca
In LyX version 1.4.1 on Mac OS X 10.4.6 the labels of equations
overlays the equation. This is different from bug # 681
Screen shot here:
http://www.flickr.com/photos/[EMAIL PROTECTED]/172899674/
Best,
Bryan
Ekkehart Schlicht wrote:
Joost Verburg wrote:
Ekkehart Schlicht wrote:
I just found out that Lyx does not know the Latex command \limits
which produces the limits of integrals etc. above and below the
integral operator. Maybe it is worthwhile to implement it. With
regard to tex2lyx it may be
On Thu, Jun 22, 2006 at 08:39:37PM +0200, Enrico Forestieri wrote:
> When trying to import xxx.tex (attached) lyx (both 1.4 and 1.5) crashes.
> The file xxx.lyx (attached, too) is produced, so it is lyx that is
> crashing when trying to load it.
>
> LyX 1.3.7 loads xxx.lyx without problems.
Addi
Joost Verburg wrote:
Ekkehart Schlicht wrote:
I just found out that Lyx does not know the Latex command \limits
which produces the limits of integrals etc. above and below the
integral operator. Maybe it is worthwhile to implement it. With regard
to tex2lyx it may be useful as well, as \intop
Angus Leeming wrote:
Seriously, it would make a lot of sense to check your
diffs to the originals into the LyX repository.
(Did Lars give you write access yet?)
I will upload the diffs once I get access.
Joost
We have abondoned Coding_Rules(?) a long time ago and used 'do whatever
the majority in src/* does'
Because it is easier to change the rules than change source code. BTW,
the style I like is:
class ThisClass
{
int thisFunction();
private:
int m_member;
}
int g_someGlobalStuff;
Bo
On Wed, Jun 21, 2006 at 10:24:31AM +, Angus Leeming wrote:
> I think it's just because we decided it improves readability. These things
> should be read from right to left:
>QRect const &
>A reference to a const QRect
>
>char const * const
>A const pointer to a const char.
Wel
On Tue, Jun 20, 2006 at 01:09:15PM +0200, Peter Kümmel wrote:
> + if (width != -1 && height != -1 && posx != -1 && posy != -1) {
> + view.initNormalGeometry(QRect(posx, posy, width, height));
> + view.resize(width, height);
> + view.move(posx, posy);
> +
On Mon, Jun 19, 2006 at 11:50:10AM -0500, Bo Peng wrote:
> We do not have this in .C either. As I have said, I see no reason why
> not include pch.h.
Because this gets far too expensive on compilers that don't have
precompiled headers.
Andre'
On Tue, Jun 20, 2006 at 12:52:29PM +0200, Lars Gullik Bjønnes wrote:
> | FWIW, I agree with Andre virtual functions in the public interface of
> | classes is a very nice and powerful feature of C++. I use it a lot.
>
> Well, using NVI does not reduce the powerfullness of the feature IMHO.
It does
On Mon, Jun 19, 2006 at 09:39:58PM +0200, Lars Gullik Bjønnes wrote:
> Andre Poenitz <[EMAIL PROTECTED]> writes:
>
> | On Mon, Jun 19, 2006 at 06:36:25PM +0200, Lars Gullik Bjønnes wrote:
> | > | stdafx.h contains all commonly used headers. msvc knows from a
> | > | compiler flag (or by default) t
On Wed, Jun 21, 2006 at 08:48:08PM +0200, Lars Gullik Bjønnes wrote:
> "Bo Peng" <[EMAIL PROTECTED]> writes:
>
> | > | Unless you can convince me with more benefits of the current approach,
> | >
> | > No, It is _you_ that has to convice me.
> |
> | I have listed benefits and costs, you simply sa
On Mon, Jun 19, 2006 at 09:42:59PM +0200, Lars Gullik Bjønnes wrote:
> Andre Poenitz <[EMAIL PROTECTED]> writes:
>
> | And to not try to force Lars making changes. We'd end up with ideas like
> | 'do not use virtual functions in the public interface of classes' and a
> | free demonstration that it
On Mon, Jun 19, 2006 at 09:45:13PM +0200, Lars Gullik Bjønnes wrote:
> | In src/*?
> |
> | I wait for your counting.
> |
> | I posted the result of mine.
>
> Are you saying that 30 vs 15 is conclusive?
In this country you can change any law you wish with such a majority.
Apart from that, about
On Mon, Jun 19, 2006 at 09:41:57PM +0200, Lars Gullik Bjønnes wrote:
> Andre Poenitz <[EMAIL PROTECTED]> writes:
>
> | On Mon, Jun 19, 2006 at 05:48:29PM +0200, Abdelrazak Younes wrote:
> | > By the way, this is written nowhere and I had the impression that
> | > "gui_instance_" style was the rul
Joost Verburg wrote:
> Angus Leeming wrote:
>> Joost, have you spoken to the Aspell
>> people about your work?
>
> The new Windows installer comes with
> many tools that are required to use
> all LyX features. dvipost for change
> tracking in output, aiksaurus for
> the English thesaurus, Aspe
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> Do you want me to convert that to a class?
No, I want you to initialize the variables when you create an
instance of the thing:
> struct ScrollbarParameters
> {
+ ScrollbarParameters()
+ : height(0),
+ : position(0),
+
On Mon, Jun 19, 2006 at 11:50:10AM -0500, Bo Peng wrote:
> We do not have this in .C either. As I have said, I see no reason why
> not include pch.h.
Because this gets far too expensive on compilers that don't have
precompiled headers.
pch.h consists of 'commonly used header files'. If I put pc
When trying to import xxx.tex (attached) lyx (both 1.4 and 1.5) crashes.
The file xxx.lyx (attached, too) is produced, so it is lyx that is
crashing when trying to load it.
LyX 1.3.7 loads xxx.lyx without problems.
backtrace:
Program received signal SIGSEGV, Segmentation fault.
0x00264a60 in Par
Ekkehart Schlicht wrote:
I just found out that Lyx does not know the Latex command \limits which
produces the limits of integrals etc. above and below the integral
operator. Maybe it is worthwhile to implement it. With regard to tex2lyx
it may be useful as well, as \intop which is an alias for
Hi,
I just found out that Lyx does not know the Latex command \limits which
produces the limits of integrals etc. above and below the integral
operator. Maybe it is worthwhile to implement it. With regard to tex2lyx
it may be useful as well, as \intop which is an alias for \int\limits.
Cheer
On Thursday 22 June 2006 17:30, Abdelrazak Younes wrote:
>
> PODs I mean...
I like this more:
http://www.parashift.com/c++-faq-lite/intrinsic-types.html#faq-26.7
--
José Abílio
On Thursday 22 June 2006 17:30, Abdelrazak Younes wrote:
> Abdelrazak Younes wrote:
> > Angus Leeming wrote:
> >
> > What POS means anyway?
>
> PODs I mean...
Plain Old Data:
http://www.fnal.gov/docs/working-groups/fpcltf/Pkg/ISOcxx/doc/POD.html
--
José Abílio
On Thu, Jun 22, 2006 at 04:05:34PM +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
...
> Running under gdb, I noticed that InsetCollapsable::metrics is called
> twice when creating a new note inset. The reason is that it is called
> twice in Ins
Abdelrazak Younes wrote:
Angus Leeming wrote:
What POS means anyway?
PODs I mean...
How do I do that from msvc? I reckon I still have to do that in an
external console right?
You specify it when you create the msvs project. msvs starts scons
which loads the option when it builds lyx. That is to say, you can
still use boost=, nls= etc, just do not use mode=release (debug will
n
Bo Peng wrote:
Another bug report ;-)
When compiling directly from MSVC (by pressing F7), scons is apparently
called with "rebuild=lyx". This is a problem because any modified file
won't be compiled again, only the lyx final linking happens. So I always
have to call scons from a command line.
Angus Leeming wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Index: BufferView.h
===
+struct ScrollbarParameters
I get nervous when I see a class containing PODs but without a default
constructor. I'd prefer to see
S
Angus Leeming wrote:
Joost, have you spoken to the Aspell people about your work?
The new Windows installer comes with many tools that are required to use
all LyX features. dvipost for change tracking in output, aiksaurus for
the English thesaurus, Aspell for spell checking, the dtl tools for
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> With this patch I further reduce the need for the workArea_ member in
> BufferView::pimpl.
Looks good.
> And the good news is that, with this patch and msvc2005, the UserGuide
> PageDown scrolling test is now at *18* seconds whereas it was at *34*
Another bug report ;-)
When compiling directly from MSVC (by pressing F7), scons is apparently
called with "rebuild=lyx". This is a problem because any modified file
won't be compiled again, only the lyx final linking happens. So I always
have to call scons from a command line.
Patch submitted.
Bo Peng wrote:
Absolutely not... pch is in now way required.
(I have even contemplated removing the support for the autotools
build. Note that autoconf/automake has no support for pch, that is
something I added.)
That is good. I have almost finished a msvc patch. If my tests show no
significant
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | Hello,
| > | | One more brick to the wall: 16/17 seconds for UserGuide now.
| > ... and please keep this one out of personal/younes, let's
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | Hello,
| > | | One more brick to the wall: 16/17 seconds for UserGuide now.
| > This has to be checked/fixed on xform/gtk/qt3 as well.
|
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | Hello,
| > | | One more brick to the wall: 16/17 seconds for UserGuide now.
| > ... and please keep this one out of personal/younes, let's handle
| > this
| > one dire
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Hello,
|
| One more brick to the wall: 16/17 seconds for UserGuide now.
... and please keep this one out of personal/younes, let's handle this
one direclty in trunk.
But this patch depends on my cleanup code already.
Absolutely not... pch is in now way required.
(I have even contemplated removing the support for the autotools
build. Note that autoconf/automake has no support for pch, that is
something I added.)
That is good. I have almost finished a msvc patch. If my tests show no
significant performance boo
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | Hello,
| > | | One more brick to the wall: 16/17 seconds for UserGuide now.
| > This has to be checked/fixed on xform/gtk/qt3 as well.
|
| I know and I am afraid of t
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Hello,
|
| One more brick to the wall: 16/17 seconds for UserGuide now.
This has to be checked/fixed on xform/gtk/qt3 as well.
I know and I am afraid of the work involved in fixing them. Could we
take a decision on
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Hello,
|
| One more brick to the wall: 16/17 seconds for UserGuide now.
... and please keep this one out of personal/younes, let's handle this
one direclty in trunk.
--
Lgb
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Hello,
|
| One more brick to the wall: 16/17 seconds for UserGuide now.
This has to be checked/fixed on xform/gtk/qt3 as well.
(and the code deleted not just commented out)
Also... the backend should not have any concept of scrollbar at all...
th
"Bo Peng" <[EMAIL PROTECTED]> writes:
| I am not quite enthusiastic about pch since my benchmarks show less
| than 10% of performance improvement (autotools). However, I had the
| feeling that to compete with autotools, this is a must have feature
| for scons (among other things like distcheck).
Hello,
One more brick to the wall: 16/17 seconds for UserGuide now.
Abdel.
Log:
This patch reduce the number of calls to BufferView::updateScrollbar()
to the bare minimum, that is in GuiWorkArea::paintEvent(). All other
calls are useless since we make sure that the scrollbar is updated if
a
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>> And do you think it would be too difficult to fix the real cause?
Martin> My patch does that... imperfectly. The value is now sensible,
Martin> but often a bit generous.
Yes, I saw that afterwards, but failed to edit the message co
> How about adding
>
> #ifdef _USE_PCH
> #include
> #endif
I think that you could put that in the scons generated "common/config.h"
and stay in peace with Lars and the LyX source code ;-)
That will not work since msvc will scan the source code itself, not
into config.h.
> and change --includ
Quoting Peter Kümmel <[EMAIL PROTECTED]>:
> Abdelrazak Younes wrote:
> >>
> >> I think we should use QMainWindow::centralWidget().width/height instead.
> >
> > In this particular case, yes. But I would prefer to fix the problem at
> > the source: We don't need the width and height on BufferView cr
Hello,
With this patch I further reduce the need for the workArea_ member in
BufferView::pimpl. Basically, on addition to the small fixes,
updateSrollbar now only update the internal SrollbarParameter which is
then read by GuiWorkArea on each update. This saves at least two calls
to updateScr
On Thu, 2006-06-22 at 12:23 +0200, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> I suppose the speed-up patch exposed this bug, i.e., that a
> Martin> tabular cell with a non-fixed width does not transmit a
> Martin> sensible mi.base.textwid
Edwin Leuven wrote:
Edwin Leuven wrote:
Abdelrazak Younes wrote:
Is it with the table toolbar or the table dialog?
both
if i insert a table, select it, and unset all borders with toolbar i
still see a grid
there seems to be a problem with drawing, not with the dialog or toolbar
i looke
Edwin Leuven wrote:
Abdelrazak Younes wrote:
Is it with the table toolbar or the table dialog?
both
if i insert a table, select it, and unset all borders with toolbar i
still see a grid
there seems to be a problem with drawing, not with the dialog or toolbar
i looked at this more closel
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> I suppose the speed-up patch exposed this bug, i.e., that a
Martin> tabular cell with a non-fixed width does not transmit a
Martin> sensible mi.base.textwidth to any textinsets it contains. Now
Martin> that we use this (or the de
On Thu, Jun 22, 2006 at 11:10:57AM +0200, Georg Baum wrote:
> Abdelrazak Younes wrote:
>
> > Georg Baum wrote:
> >> Look also at the QApplication problem: I asked for testing by windows
> >> people, and the only response I got was from Peter. I am not motivated at
> >> all to continue fixing bugs
Angus Leeming wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
By the way, could you explain me the rationale behind the
BufferView_pimpl class? I cannot see any advantage of duplicating the
Bufferview interface and I am very tempted to merge the two.
The Pimpls in the src directory exist
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> By the way, could you explain me the rationale behind the
> BufferView_pimpl class? I cannot see any advantage of duplicating the
> Bufferview interface and I am very tempted to merge the two.
The Pimpls in the src directory exist to reduce compila
Angus Leeming wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Angus Leeming wrote:
So a summary of this patch might be: A BufferView requires a
valid WorkArea, so make the code do that. (ATM, the code logic
is inverted.)
No, you got it wrong, that's exactly the opposite I want to achiev
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Quite frankly I don't think the use of PCH is a panacea. I
Abdelrazak> think it is just an excuse for badly written code. By
Abdelrazak> using forward declaration (class foo) in header you reduce
Abdelrazak> considerab
Juergen Spitzmueller wrote:
> Georg Baum wrote:
>> when updating my tree with the font patch I got conflicts. I guess that
>> the removal of the paper options was not done on purpose? If that was an
>> accident, I am going to put the attached patch in.
>
> Yes, that was an accident (the upcasing
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> Angus Leeming wrote:
> > So a summary of this patch might be: A BufferView requires a
> > valid WorkArea, so make the code do that. (ATM, the code logic
> > is inverted.)
> No, you got it wrong, that's exactly the opposite I want to achieve: a
> Wo
Georg Baum wrote:
> when updating my tree with the font patch I got conflicts. I guess that
> the removal of the paper options was not done on purpose? If that was an
> accident, I am going to put the attached patch in.
Yes, that was an accident (the upcasing of the font family gui names was
inte
Abdelrazak Younes wrote:
> Georg Baum wrote:
>> Look also at the QApplication problem: I asked for testing by windows
>> people, and the only response I got was from Peter. I am not motivated at
>> all to continue fixing bugs for other people if they can't be bothered to
>> even test the patches.
Bo Peng wrote:
And that is only thing I absolutely refuse. Not a single included
header file should ever be removed from any source because of some
pch.h.
Nothing will be more portable.
How about adding
#ifdef _USE_PCH
#include
#endif
I think that you could put that in the scons generated
Lars Gullik Bjønnes wrote:
Angus Leeming <[EMAIL PROTECTED]> writes:
| Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > The title says it all. This is one more step in the eradication of
| > workArea_ inside BufferView!
|
| Totally sane.
But instead we get both the width and height of the w
Abdelrazak Younes wrote:
Angus Leeming wrote:
Is it safe? Who owns the view() now? Can a race occur such that
someone tries to
access a view() after it has been deleted? Remember, things like
asynchronous
loading of graphics really play havoc with simple program flow.
No, no, please read the
Lars Gullik Bjønnes wrote:
Angus Leeming <[EMAIL PROTECTED]> writes:
| Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > Here is the next step on my GUI API cleanup. Only qt4 for now.
| > Committed to the "younes" branch. Comments welcome.
|
| Summary
| ===
| So a summary of this patch mig
Angus Leeming wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Here is the next step on my GUI API cleanup. Only qt4 for now.
Committed to the "younes" branch. Comments welcome.
Summary
===
So a summary of this patch might be: A BufferView requires a valid WorkArea, so
make the code do
Georg Baum wrote:
Am Mittwoch, 21. Juni 2006 18:59 schrieb Bo Peng:
Regarding conservativeness, I do feel that we should do more in the
user (and developer) friendliness end. The idea that a normal user
will read tutorial and follow the instructions is plainly wrong. There
are also some discrim
On Wednesday 21 June 2006 17:59, Bo Peng wrote:
> There
> are also some discrimination against windows system so
> windows-specific changes are harder to be accepted (e.g. space in
> path, scons, .C=>,cpp conversion, msvc/pch). Scons still managed to
> get in though. :-)
Please don't confuse our
72 matches
Mail list logo
