Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> With this patch I further reduce the need for the workArea_ member in
> BufferView::pimpl.
Looks good.
> And the good news is that, with this patch and msvc2005, the UserGuide
> PageDown scrolling test is now at *18* seconds whereas it was at *34*
> seconds previously! It is now faster than qt3 on my machine (which is 22s).
;-)
> Index: BufferView.h
> ===================================================================
> +struct ScrollbarParameters
I get nervous when I see a class containing PODs but without a default
constructor. I'd prefer to see
ScrollbarParameters() { reset(); }
> Index: BufferView_pimpl.h
> ===================================================================
> + ScrollbarParameters const & scrollbarParameters() const;
> + ///
Do you need this accessor as well as BufferView::scrollbarParameters()? I guess
you guarantee that you don't modify the variable when you use the accessor.
> + ///
> + int width() const;
> + ///
> + int height() const;
Doxygen comments please. width, height in what units? Of what?
> Index: frontends/qt4/GuiWorkArea.C
> ===================================================================
> +
> + buffer_view_->updateScrollbar();
> +
> + ScrollbarParameters const & scroll_ =
> buffer_view_->scrollbarParameters();
> +
> + verticalScrollBar()->setTracking(false);
> + setScrollbarParams(scroll_.height, scroll_.position,
> + scroll_.lineScrollHeight);
> + verticalScrollBar()->setTracking(true);
Hmmm... why is change tracking settable from the WorkArea? (Totally ignorant
about this CT stuff but surely it's a property of the Buffer, not the View?)
Angus
