[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid added a comment. In D77047#1956774 , @omjavaid wrote: > In D77047#1954696 , @labath wrote: > > > > There is no physical hardware currently available to test SVE and we make > > > use of QEMU for the purpos

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This patch breaks on TestMemoryCache.py lldb AArch64/Linux. we ll have to revert it untill fixed FAIL: test_memory_cache_dwarf (TestMemoryCache.MemoryCacheTestCase) Test the MemoryCa

[Lldb-commits] [PATCH] D77793: Fix LLDB elf core dump register access for ARM/AArch64

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: danielkiss, kristof.beyls. This patch adds support to access AArch64 FP SIMD core dump registers and adds a test case to verify registers. This patches fixes a bug where doing "register read --all" cause

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading for lldb

omjavaid added a comment. For anyone reviewing this: Orignal RFC with all the required documentation insight into Arm Memory Tagging Extension can be found here: https://lists.llvm.org/pipermail/lldb-dev/2020-August/016402.html @DavidSpickett this calls for some documentation update in a futur

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add MTE memory tag reading to lldb-server

omjavaid added a comment. This patch looks quite neat overall I have a few minor questions, comments and suggestions. 1. To get the review going consider further splitting up these patches into separate chunks containing, for example MemoryTagHandler API and related unit tests, GDB remote addo

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading for lldb

omjavaid added a comment. This patch also looks quite good. Some minor nits inline and also move gdb* changes into a single patch with both client and server side code. Comment at: lldb/include/lldb/Target/Process.h:1701 + /// handler that can be used to maniupulate those mem

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add MTE memory tag reading to lldb-server

omjavaid added a comment. In D95601#2563613 , @DavidSpickett wrote: > To get the review going consider further splitting up these patches into > separate chunks containing, for example MemoryTagHandler API and related unit > tests, GDB remote addons,

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. thanks @DavidSpickett for the review. I have updated diff incorporating you suggestions. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:454 bool NativeRegisterContextLinux_arm64::IsSVE(unsigned reg) const { - if

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 323928. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp l

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid added a comment. Subsequent update will resolve review comments. @DavidSpickett thanks for review. much appreciated Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:79 + m_mte_ctrl_reg = 0; + DavidSpickett wrote:

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 324017. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 324018. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:104 + + return 0; +} DavidSpickett wrote: > Do I understand correctly that this will be filled in in a further patch? So > right now it's only re

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

omjavaid updated this revision to Diff 324021. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96459/new/ https://reviews.llvm.org/D96459 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp lldb/source/Plugins/Process/Linux/NativeProcessLinux.h lldb/source/Plugins/Process

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid added a comment. We are using SVE read/write in this test to make sure we do not overlap register offsets while calculating offsets for the dynamic registers. Further dynamic register sets should also be readable. Comment at: lldb/test/API/commands/register/register

[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

omjavaid added inline comments. Comment at: lldb/docs/index.rst:80 (*) Support for Windows is under active development. Basic functionality is -expected to work, with functionality improving rapidly. +expected to work, with functionality improving rapidly. ARM support is +more e

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

omjavaid added a comment. This looks fine to me builds ok on AArch64/Linux with no testsuite regressions. I am wondering Whats the need for version checks? you are excluding hardware breakpoint mangement code from the build but then that lldb-server executable may well run on FreeBSD version wh

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

omjavaid added a comment. In D96548#2573245 , @mgorny wrote: > In D96548#2572770 , @omjavaid wrote: > >> I am wondering Whats the need for version checks? you are excluding hardware >> breakpoint mangement code fro

[Lldb-commits] [PATCH] D97017: [lldb-server] Exit the DataAvailableCallback loop when `done` or `interrupt` are set

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:950 // We are ready to exit the debug monitor. m_exit_now = true; m_mainloop.RequestTermination(); May be we can set m_exit_now inste

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2566347 , @labath wrote: > I'm sorry, my response times are pretty slow these days. > > I'm thinking about this `ConfigureRegisterInfos` business. I get that the > vector length is variable, and so we need to refresh it

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 325433. omjavaid added a comment. This moves ConfigureRegisterInfos into constructor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_ar

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

omjavaid updated this revision to Diff 325434. omjavaid added a comment. Rebased after updates to parent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96459/new/ https://reviews.llvm.org/D96459 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp lldb/source/Plugins/Pro

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 325435. omjavaid added a comment. Rebased after updates to parent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/sour

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 325441. omjavaid added a comment. Review comments resolved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/commands/register/registe

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1128 + if (error.Success()) m_sve_header_is_valid = true; DavidSpickett wrote: > Indent here > > Actually, for these you could just do `m_sv

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 325493. omjavaid added a comment. Ran clang format and fixed typos. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/sou

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:16 +self.assertTrue(reg_value.IsValid(), +'Verify we have a register named "%s"' % (name)) +self.assertE

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 325517. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/commands/register/register/aarch64_dynamic_regset/Makefile lldb/test/API/com

[Lldb-commits] [PATCH] D97498: [LLDB] Support GDB remote g packet partial read

omjavaid created this revision. omjavaid added a reviewer: labath. omjavaid requested review of this revision. GDB remote protocol does not specify length of g packet for register read. It depends on remote to include all or exclude certain registers from g packet. In case a register or set of r

[Lldb-commits] [PATCH] D97284: [lldb][AArch64] Add MTE CPU feature test predicate

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This is accepted with a caveat above. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1288 +for line in f.readlines(): +if line.st

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

omjavaid added a comment. This looks good overall except for one comment inline. Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:43 + +ptrdiff_t MemoryTagManagerAArch64MTE::AddressDiff(lldb::addr_t addr1, +

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

omjavaid added a comment. I guess we also need LLDB API interface for reading/writing memory tags. So that we can do something like process.ReadMemoryTags() from python. Do you plan on adding it in a later patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D97498: [LLDB] Support GDB remote g packet partial read

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG536783170f08: Support GDB remote g packet partial read (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:43 + +ptrdiff_t MemoryTagManagerAArch64MTE::AddressDiff(lldb::addr_t addr1, + lldb::addr_t addr2) const { -

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added a comment. This looks good apart from minor nits inline Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; ptrace request is a success if number of tags requested is not equal to no

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

omjavaid added inline comments. Comment at: lldb/source/Plugins/Architecture/AArch64/ArchitectureAArch64.cpp:36 + if (machine != llvm::Triple::aarch64 && machine != llvm::Triple::aarch64_be && + machine != llvm::Triple::aarch64_32) { +return nullptr; D

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:81 + Status error = ReadSVEHeader(); + uint32_t opt_regset = RegisterInfoPOSIX_arm64::eRegsetEnableDefault; + if (error.Success()) { rovka wrote

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 329232. omjavaid added a comment. This update fixes review comments highlighted by @rovka CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinu

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

omjavaid updated this revision to Diff 329235. omjavaid added a comment. Rebased after changes in parent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96459/new/ https://reviews.llvm.org/D96459 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp lldb/source/Plugins/Pro

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 329239. omjavaid added a comment. Rebased after changes to parent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/sour

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 329240. omjavaid added a comment. Minor fix to write unique value to all z/p registers when writing them using register write command. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:45 + +self.expect("register read ffr", substrs=[p_regs_value]) + DavidSpickett wrote: > omjavaid wrote: > > DavidSpicke

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 329269. omjavaid added a comment. fixes review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/commands/register/register/a

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:96 +if 'Scalable Vector Extension Registers' in registerSet.GetName(): +self.assertTrue(self.isAArch64SVE( +

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 329273. omjavaid added a comment. FIxes stale diff uploaded by mistake. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/commands/regi

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid added a comment. In D96463#2613498 , @DavidSpickett wrote: > Did you forget to add the changes? I don't see any diff for the last update. Sorry about that. Check the latest diff should be fixed now. CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 329280. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/commands/register/register/aarch64_dynamic_regset/Makefile lldb/test/API/com

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/main.c:13 + // Wait for lldb-server to stop us + while (1) { + } infinite loop in test program may not be a good idea. Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; DavidSpickett wrote: > DavidSpickett wrote: > > DavidSpickett wrote: > > > omjavaid wrote: > > > > ptrace request i

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1345 + + tags.resize((range.GetByteSize() / details->manager->GetGranuleSize()) * + details->manager->GetBytesPerTag()); is there a difference betwe

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. @labath @rovka any further comments on this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2613244 , @labath wrote: > In D96458#2578760 , @omjavaid wrote: > >> In D96458#2566347 , @labath wrote: >> >>> I'm sorry, my response time

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2613948 , @labath wrote: > In D96458#2613894 , @omjavaid wrote: > >> ConfigureRegisterContext is called only once in the lifetime of a core from >> RegisterContextCorePOSIX_arm64

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2614101 , @labath wrote: > In D96458#2614076 , @omjavaid wrote: > >> In D96458#2613948 , @labath wrote: >> >>> In D96458#2613894

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; DavidSpickett wrote: > omjavaid wrote: > > DavidSpickett wrote: > > > DavidSpickett wrote: > > > > DavidSpickett wr

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2618846 , @labath wrote: > Would something like F15819833: reginfo.diff > do the trick? It needs a bit of cleanup > (I haven't actually removed `ConfigureRegisterInfos` function yet

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 330187. omjavaid added a comment. This update incorporates changes written by @labath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_ar

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 330189. omjavaid added a comment. Updated after changes in parent. Also removed D96459 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 330190. omjavaid added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/commands/register/register/aarch64_dynamic

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2624962 , @labath wrote: > Thanks. This looks much better, but there is still one thing which bugs me > about the register info constructor. Currently, there are three paths through > that constructor: > > 1. when we d

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2625554 , @omjavaid wrote: > In D96458#2624962 , @labath wrote: > >> Thanks. This looks much better, but there is still one thing which bugs me >> about the register info constru

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

omjavaid requested changes to this revision. omjavaid added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp:63 + // should be removed once full PAC support is added. + return pc & 0x000F; +}

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; DavidSpickett wrote: > omjavaid wrote: > > DavidSpickett wrote: > > > omjavaid wrote: > > > > DavidSpickett wrote:

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 331830. omjavaid added a comment. This update address review comments from @labath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 331834. omjavaid added a comment. This update further cleans up and removes static functions that calculated m_register_info_p GetRegisterInfoPtr and m_register_info_count GetRegisterInfoCount CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/ne

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 331835. omjavaid added a comment. Rebased after changes to parent D96458 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRe

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 331836. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/commands/register/register/aarch64_dynamic_regset/Makefile lldb/test/API/com

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

omjavaid added a comment. In D98619#2640734 , @labath wrote: > `REQUIRES: x86` disables the test in those builds, which don't have the X86 > target enabled (in the build config). That is exactly what we want here -- > the test is not actually running thi

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

omjavaid added a comment. In D98619#2641136 , @labath wrote: > In D98619#2641104 , @omjavaid wrote: > >> In D98619#2640734 , @labath wrote: >> >>> `REQUIRES: x86` disables th

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

omjavaid added a comment. In D98529#2643850 , @jasonmolenda wrote: > In D98529#2631946 , @DavidSpickett > wrote: > >> TCR_ELx begins at 1 (see `D13.2.123 TCR_EL1, Translation Control Register >> (EL1)` in the arm

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 332617. omjavaid added a comment. Herald added a subscriber: emaste. Pulling GetAuxValue from NativeProcessELF. @labath what do you think. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/sourc

[Lldb-commits] [PATCH] D99491: [LLDB] Fix cleanup error in TestVSCode_disconnect.test_launch

omjavaid created this revision. omjavaid added reviewers: clayborg, labath. omjavaid requested review of this revision. TestVSCode_disconnect.test_launch fails with clean up error because disconnect gets called twice once from the test case and once from the tear down hook. This patch disables d

[Lldb-commits] [PATCH] D99491: [LLDB] Fix cleanup error in TestVSCode_disconnect.test_launch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42c3b5e5b6ff: Fix cleanup error in TestVSCode_disconnect.test_launch (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Git

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

omjavaid added inline comments. Comment at: lldb/include/lldb/Target/Process.h:79 void SetExtraStartupCommands(const Args &args); + uint64_t GetPointerAuthenticationAddressMask() const; + void SetPointerAuthenticationAddressMask(const uint64_t mask); This fu

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

omjavaid added inline comments. Comment at: lldb/include/lldb/Target/Process.h:79 void SetExtraStartupCommands(const Args &args); + uint64_t GetPointerAuthenticationAddressMask() const; + void SetPointerAuthenticationAddressMask(const uint64_t mask); pcc wro

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ab677180091: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D96463?vs=331

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6d3d21cd1cb: [LLDB] Add support for Arm64/Linux dynamic register sets (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM G

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1164b4e29572: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers (authored by omjavaid). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [PATCH] D99497: [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events

omjavaid added a comment. I am going ahead and commit this change till we find a better way to fix the sync issue. sleep time set to 2s now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99497/new/ https://reviews.llvm.org/D99497 ___ lldb-co

[Lldb-commits] [PATCH] D99497: [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events

This revision was automatically updated to reflect the committed changes. Closed by commit rGb468f0e165ed: [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D99497?vs=333819&id=

[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

omjavaid created this revision. omjavaid added reviewers: labath, DavidSpickett. Herald added subscribers: danielkiss, kristof.beyls. omjavaid requested review of this revision. This adds support for reading AArch64 Pointer Authentication regset from elf-core file. Also includes a test-case for th

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 PAC elf-core stack unwinder support

omjavaid created this revision. omjavaid added reviewers: labath, justincohen, jasonmolenda, DavidSpickett. Herald added subscribers: danielkiss, kristof.beyls. omjavaid requested review of this revision. This patch adds a new field to Process class which represents no of bits used for addresses b

[Lldb-commits] [PATCH] D99947: [LLDB] AArch64 Linux PAC unwinder support

omjavaid created this revision. omjavaid added reviewers: labath, DavidSpickett. Herald added subscribers: danielkiss, kristof.beyls. omjavaid requested review of this revision. This patch adds support to detect and set address bits in use by the current AArch64 process. We are going to utilize AA

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 PAC elf-core stack unwinder support

omjavaid added a comment. In D99944#2684280 , @jasonmolenda wrote: > Hi Omair, sorry for the delay in looking at this. It seems like we have two > overlapping patches here, @justincohen patch in > https://reviews.llvm.org/D98886 and this one. > > I'm

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

omjavaid added a comment. In D100515#2690225 , @jasonmolenda wrote: > Thanks Jonas, I think this change to Process can cover > > Omair's use case, where the number of bits are used hardcoded. > > The Darwin use case were ProcessGDBRemote, DynamicL

[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

omjavaid updated this revision to Diff 340680. omjavaid added a comment. Resolved review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99941/new/ https://reviews.llvm.org/D99941 Files: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp lldb/source/Plugins/

[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

omjavaid marked an inline comment as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:32 + if (pac_data.GetByteSize() > sizeof(uint64_t)) +opt_regsets.Set(RegisterInfoPOSIX_arm64::eRegsetMaskPAuth); +

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 PAC elf-core stack unwinder support

omjavaid updated this revision to Diff 340686. omjavaid added a comment. Moved mask calculation to ABISysV_arm64 class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99944/new/ https://reviews.llvm.org/D99944 Files: lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp lldb/source/Plug

[Lldb-commits] [PATCH] D99947: [LLDB] AArch64 Linux PAC unwinder support

omjavaid updated this revision to Diff 340702. omjavaid added a comment. Fixed review comments and rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99947/new/ https://reviews.llvm.org/D99947 Files: lldb/test/API/functionalities/unwind/aarch64_unwind_pac/Makefile lldb/test/AP

[Lldb-commits] [PATCH] D99947: [LLDB] AArch64 Linux PAC unwinder support

omjavaid added a comment. In D99947#2718954 , @DavidSpickett wrote: > Did the changes in `GDBRemoteRegisterContext.cpp` > (https://reviews.llvm.org/D99947?id=335484#inline-940747 ) get moved to > another diff? We no longer need to configure Address bit

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

omjavaid created this revision. omjavaid added reviewers: labath, DavidSpickett. Herald added subscribers: danielkiss, kristof.beyls. omjavaid requested review of this revision. AArch64 architecture support virtual addresses with some of the top bits ignored. These ignored bits can host memory ta

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

omjavaid accepted this revision. omjavaid added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/linux/aarch64/mte_memory_region/TestAArch64LinuxMTEMemoryRegion.py:42 if self.process().GetState() == lldb.eStateExited:

[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69a326925071: Support AArch64 PAC elf-core register read (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

omjavaid updated this revision to Diff 342357. omjavaid added a comment. This merges separate patch D99947 for Linux into this one. Linux specific changes are no longer required as we have moved mask calculation into ABISysV_arm64 class. CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

omjavaid updated this revision to Diff 342608. omjavaid added a comment. This fixes review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101361/new/ https://reviews.llvm.org/D101361 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:888 + // consolidated data address mask after ignoring the top byte. + if (!ReadPAuthMask().Fail()) +mask |= m_pac_mask.data_mask; DavidSpick

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.cpp:476 + return hit_addr & ((1ULL << 56) - 1); +} DavidSpickett wrote: > I think it was fine where it was, my point was just to check whether FreeB

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

omjavaid added a comment. This looks ok to me apart from some cosmetic nits. Also you may figure out a way to clean up the whole address including pauth now after D99944 is merged. Comment at: lldb/include/lldb/Target/MemoryTagManager.h:72 +

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added a comment. it look good to me but I have some final minor nits inline. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1458 + + struct iovec tags_vec; + uint8_t *dest = &tags[0]; may be rename to tags_iovec? because reading

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid marked 3 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:240 + // Update SVE registers in case there is change in configuration. + ConfigureRegisterContext(); + ---

<    1   2   3   4   5   6   >