omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
This is accepted with a caveat above.
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1288
+ for line in f.readlines():
+ if line.startswith("Features"):
+ features = line.split(':')[1].split()
----------------
On AArch64 targets CPU features in cpuinfo file are written as Features while
on x86 they are written as flags.
So Either we change the function name to reflect it can only be used for
AArch64 or keep the previous logic to make it architecture independent.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97284/new/
https://reviews.llvm.org/D97284
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
