omjavaid added inline comments.
================ Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1128 + if (error.Success()) m_sve_header_is_valid = true; ---------------- DavidSpickett wrote: > Indent here > > Actually, for these you could just do `m_sve_header_is_valid = > error.Success()`, no if needed. Assuming setting it false here is also fine, > which it might not be. I guess this is inline with rest of the code in this file. Also avoiding write every time may well be a tiny bit faster as we avoid flushing the cache line to which m_sve_header_is_valid belongs. ================ Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.cpp:276 + if (opt_regsets & eRegsetEnableMTE) + m_mte_regset_enabled = true; } ---------------- DavidSpickett wrote: > (like earlier) would it be ok to remove the if? > ``` > m_mte_regset_enabled = opt_regsets & eRegsetEnableMTE; > ``` I think here as well if do write eveytime regardless of true/false we might end up refreshing the whole data set contained in cache against a RegisterInfoPOSIX_arm64 object. What do you think? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
