omjavaid requested changes to this revision.
omjavaid added inline comments.
This revision now requires changes to proceed.


================
Comment at: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp:63
+  // should be removed once full PAC support is added.
+  return pc & 0x0000000FFFFFFFFF;
+}
----------------
How did you come up with this 36bit mask for PC reg I think this mask is not 
appropriate for Linux virtual address space which is 52 or 48 bits in length.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98529/new/

https://reviews.llvm.org/D98529

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to