omjavaid added inline comments.
================ Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:45 + + self.expect("register read ffr", substrs=[p_regs_value]) + ---------------- DavidSpickett wrote: > omjavaid wrote: > > DavidSpickett wrote: > > > Do we need an ffr read if we have a read/write below? > > Yes. > > There are two values which are being verified: > > First we verify value that was written by our assembly code. > > After that we use debugger to write and read back values. > Ok but then should the second r/w be of a different value? > > program writes A - we read A, so the read works > we write A - we read A, was that our A or the program's A? Second read/write was different value but a fixed value was being used for testing all z/p registers. I have updated this rev to add unique values which are still different from what is written by the main.c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits