[Lldb-commits] [PATCH] D59850: [Platform] Remove Kalimba Platform

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added subscribers: jdoerfert, MaskRay, arichardson, mgorny, emaste. Herald added a reviewer: espindola. Herald added a project: LLDB. Yesterday I stumbled upon the initialization code for the "Kalimba" platform. It lo

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

JDevlieghere created this revision. JDevlieghere added reviewers: zturner, stella.stamenova, davide. Herald added a subscriber: mgorny. Herald added a project: LLDB. JDevlieghere added a reviewer: labath. Since there's no dlopen on Windows, we need a cross platform abstraction. The LibraryLoader

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

JDevlieghere updated this revision to Diff 192388. JDevlieghere marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59854/new/ https://reviews.llvm.org/D59854 Files: lldb/include/lldb/Host/LibraryLoader.h lldb/source/Host/CMakeLists.txt lldb/source/Host/

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

JDevlieghere added a comment. Thanks for the review, Adrian! Comment at: lldb/include/lldb/Host/LibraryLoader.h:17 +public: + LibraryLoader(const char *library, bool close = true); + ~LibraryLoader(); amccarth wrote: > amccarth wrote: > > I'm curious why anyo

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

JDevlieghere added a comment. In D59854#1443891 , @jingham wrote: > It isn't safe to pass "data()" of a StringRef to dlsym. Why? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59854/new/ https://reviews.llvm.org/D59854 __

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

JDevlieghere updated this revision to Diff 192392. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. `data()` -> `str().c_str()` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59854/new/ https://reviews.llvm.org/D59854 Files: lldb/include/lldb/Host/LibraryLo

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

JDevlieghere abandoned this revision. JDevlieghere added a comment. Apparently Phabricator is again not importing e-mail replies. As I said per e-mail, I didn't know about the existence of DynamicLibrary in LLVM and only checked LLDB for prior art. CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D59850: [Platform] Remove Kalimba Platform

JDevlieghere closed this revision. JDevlieghere added a comment. r357086 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59850/new/ https://reviews.llvm.org/D59850 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D59850: [Platform] Remove Kalimba Platform

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. Apparently this needs to be accepted for me to close it. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59850/new/ https://review

[Lldb-commits] [PATCH] D59911: Don't abort() in lldb_assert and document why.

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Can you please also update the RST docs? (https://lldb.llvm.org/new-www/) Comment at: lldb/www/source.html:83 + Assertions. +

[Lldb-commits] [PATCH] D59911: Don't abort() in lldb_assert and document why.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Works for me. In D59911#1445917 , @labath wrote: > In D59911#1445392 , @JDevlieghere > wrote: > >

[Lldb-commits] [PATCH] D59968: [Cmake] Unify python variables

JDevlieghere created this revision. JDevlieghere added reviewers: zturner, stella.stamenova, labath, sgraenitz. Herald added subscribers: lldb-commits, abidh, mgorny. Herald added a project: LLDB. Both FindPythonInterp and FindPythonLibs do two things, they'll set some variables (PYTHON_LIBRARIES

[Lldb-commits] [PATCH] D59970: [CMake] Untangle linking of dependencies

JDevlieghere updated this revision to Diff 192745. JDevlieghere added a comment. And move python to the ScriptInterpreter CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59970/new/ https://reviews.llvm.org/D59970 Files: lldb/source/Core/CMakeLists.txt lldb/source/Plugins/ScriptInterp

[Lldb-commits] [PATCH] D59972: [Python] Remove readline module

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added subscribers: jdoerfert, mgorny. Herald added a project: LLDB. Todd added this empty readline module to workaround an issue with an old version of Python on Ubuntu in 2014 (18841). In the meantime, Python seems

[Lldb-commits] [PATCH] D59970: [CMake] Untangle linking of dependencies

JDevlieghere created this revision. JDevlieghere added reviewers: zturner, stella.stamenova, labath, sgraenitz. Herald added a subscriber: mgorny. Herald added a project: LLDB. The utility library shouldn't depend on curses, libedit or python since it uses none of them. Move the first two to libC

[Lldb-commits] [PATCH] D59976: [Python] Remove Python include from ScriptInterpreterPython.h

JDevlieghere created this revision. JDevlieghere added reviewers: zturner, davide. Herald added a subscriber: abidh. Herald added a project: LLDB. This patch limits the scope of the python header to the python script interpreter plugin by removing the include from ScriptInterpreterPython.h. To m

[Lldb-commits] [PATCH] D59972: [Python] Remove readline module

This revision was automatically updated to reflect the committed changes. Closed by commit rL357277: [Python] Remove readline module (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[Lldb-commits] [PATCH] D59968: [Cmake] Unify python variables

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357282: [Cmake] Unify python variables (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D59968?vs=192735&id=192858#toc Repository: rLLDB LLDB CHANGES S

[Lldb-commits] [PATCH] D59970: [CMake] Untangle linking of dependencies

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357287: [CMake] Move link dependencies where they are used. (authored by JDevlieghere, committed by ). Changed prior t

[Lldb-commits] [PATCH] D59976: [Python] Remove Python include from ScriptInterpreterPython.h

JDevlieghere updated this revision to Diff 192892. JDevlieghere added a comment. Herald added a subscriber: jdoerfert. Make ScriptInterpreterPython abstract. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59976/new/ https://reviews.llvm.org/D59976 Files: lldb/source/API/SBHostOS.cpp

[Lldb-commits] [PATCH] D59976: [Python] Remove Python include from ScriptInterpreterPython.h

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Thanks for the review, Pavel! Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1229-1230 + Locker locker(this, +ScriptInterpreterPythonImpl::Locker

[Lldb-commits] [PATCH] D59976: [Python] Remove Python include from ScriptInterpreterPython.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL357307: [Python] Remove Python include from ScriptInterpreterPython.h (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [PATCH] D60022: [Process] Fix WriteMemory return value

JDevlieghere added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWriteMemory.py:10 + +@skipIfXmlSupportMissing +def test(self): Why does this test depend on XML support? Repository: rLLDB LLDB CHAN

[Lldb-commits] [PATCH] D60022: [Process] Fix WriteMemory return value

JDevlieghere added a comment. Thanks Ismail, the patch LGTM, assuming I understand the code correctly. FWIW I think this function is a good example of how early returns might prevent something like this from happening in the future. If you agree and have the bandwidth, feel free to refactor it,

[Lldb-commits] [PATCH] D60092: [Process] Use early returns in Process::WriteMemory (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: mib, davide. Herald added a subscriber: abidh. Herald added a project: LLDB. I found the code of Process::WriteMemory particularly hard to follow when reviewing Ismail's change in D60022 . This sim

[Lldb-commits] [PATCH] D60092: [Process] Use early returns in Process::WriteMemory (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL357428: [Process] Use early returns in Process::WriteMemory (NFC) (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

JDevlieghere added a comment. Hey Tatyana, what's the plan with regards to testing this? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D60178: [Reproducers] Capture return values of functions returning by ptr/ref

JDevlieghere created this revision. JDevlieghere added reviewers: labath, friss. Herald added a reviewer: jfb. Herald added a subscriber: abidh. Herald added a project: LLDB. For some reason I had convinced myself that functions returning by pointer or reference do not require recording their res

[Lldb-commits] [PATCH] D60178: [Reproducers] Capture return values of functions returning by ptr/ref

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Herald added a subscriber: dexonsmith. Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:679 + template const Result &RecordResult(const Result &r) { +UpdateBoundary(); +i

[Lldb-commits] [PATCH] D60178: [Reproducers] Capture return values of functions returning by ptr/ref

JDevlieghere updated this revision to Diff 193581. JDevlieghere added a comment. - Add tests for lldb-instr - Feedback Pavel CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60178/new/ https://reviews.llvm.org/D60178 Files: lldb/include/lldb/Utility/ReproducerInstrumentation.h lldb/li

[Lldb-commits] [PATCH] D60178: [Reproducers] Capture return values of functions returning by ptr/ref

This revision was automatically updated to reflect the committed changes. Closed by commit rL357639: [Reproducers] Capture return values of functions returning by ptr/ref (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[Lldb-commits] [PATCH] D60300: [testsuite] Split Objective-C data formatter

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, davide, labath. Herald added a project: LLDB. JDevlieghere updated this revision to Diff 193822. JDevlieghere added a comment. Fix CF test The testcase for objective-c data formatters is very big as it checks a bunch of

[Lldb-commits] [PATCH] D60300: [testsuite] Split Objective-C data formatter

JDevlieghere updated this revision to Diff 193822. JDevlieghere added a comment. Fix CF test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60300/new/ https://reviews.llvm.org/D60300 Files: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/ObjCDat

[Lldb-commits] [PATCH] D60300: [testsuite] Split Objective-C data formatter

JDevlieghere updated this revision to Diff 193909. JDevlieghere marked 5 inline comments as done. JDevlieghere added a comment. Code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60300/new/ https://reviews.llvm.org/D60300 Files: lldb/packages/Python/lldbsuite/test/fu

[Lldb-commits] [PATCH] D60300: [testsuite] Split Objective-C data formatter

JDevlieghere added a comment. In D60300#1455790 , @davide wrote: > I think this is good regardless for readability, but I would really > appreciate if we can collect some numbers to see how effective this change > actually is. I see 120 -> 12 seconds o

[Lldb-commits] [PATCH] D60300: [testsuite] Split Objective-C data formatter

This revision was automatically updated to reflect the committed changes. Closed by commit rL357786: [testsuite] Split Objective-C data formatter (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D60300: [testsuite] Split Objective-C data formatter

JDevlieghere added a comment. In D60300#1456485 , @aprantl wrote: > > What's the motivation behind all the `@no_debug_info_test` decorators? Are > > those codepaths guaranteed to be tested elsewhere? > > As a rule of thumb I'd say, let's only stick `@no_d

[Lldb-commits] [PATCH] D60400: Remove unneeded #ifdef SWIGs

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60400/new/ https://reviews.llvm.org/D60400 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D60442: Add missing space between \btrue

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60442/new/ https://reviews.llvm.org/D60442

[Lldb-commits] [PATCH] D60442: Add missing space between \btrue

JDevlieghere added a comment. Please let me know if you don't have commit access (yet) and need someone to commit this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60442/new/ https://reviews.llvm.org/D60442 ___

[Lldb-commits] [PATCH] D60442: Add missing space between \btrue

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357980: Add missing space between \btrue (authored by JDevlieghere, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llvm.org/D60442?vs=194263&id=194264#toc

[Lldb-commits] [PATCH] D60442: Fix doxygen warnings for lldb-cpp-doc target

JDevlieghere added a comment. In D60442#1459378 , @kkleine wrote: > I think I don't have commit access (yet) and would like if someone can commit > this for me. It was my first commit to the LLDB project and I wanted to get > familiar with phabricator an

[Lldb-commits] [PATCH] D60443: Fix doxygen warning about function argument

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60443/new/ https://reviews.llvm.org/D60443 ___

[Lldb-commits] [PATCH] D60443: Fix doxygen warning about function argument

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357983: Fix doxygen warning about function argument (authored by JDevlieghere, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llvm.org/D60443?vs=194265&id=

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

JDevlieghere added a comment. In D55718#1453084 , @tatyana-krasnukha wrote: > Hi, currently we have a private build server that executes the test-suite on > ARC. There are failures for now, mostly due to unimplemented features for ARC > like expressions

[Lldb-commits] [PATCH] D60508: [NFC] Remove ASCII lines from comments

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added subscribers: jsji, abidh, arphaman, atanasyan, MaskRay, kbarton, arichardson, javed.absar, ki.stfu, nemanjai, emaste. Herald added a reviewer: espindola. Herald added a reviewer: jfb. Herald added a project: LLDB

[Lldb-commits] [PATCH] D60508: [NFC] Remove ASCII lines from comments

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358135: [NFC] Remove ASCII lines from comments (authored by JDevlieghere, committed by ). Changed prior to commit: h

[Lldb-commits] [PATCH] D60563: [pexepect] Add a small sleep between pexect calls

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide. Herald added a project: LLDB. When we upgraded pexpect to a more recent version, we experienced issues where pexpect was sending commands faster to LLDB could process. The problem was especially apparent on CI syst

[Lldb-commits] [PATCH] D60563: [pexepect] Add a small sleep between pexect calls

JDevlieghere added a comment. To give a little more context: the particular issue I was looking at (TestCommandScriptImmediateOutput) occurs with sendline. We send a bunch of commands and always check for the prompt. I can reproduce the error when piping the test commands directly to LLDB. Re

[Lldb-commits] [PATCH] D60563: [pexepect] Add a small sleep between pexect calls

JDevlieghere abandoned this revision. JDevlieghere added a comment. Apparently Pavel already investigated and fixed this in r357459. We also discussed a better way to make this work by checking the echo of the command passed to sendline. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D60566: [test] Convert CommandScriptImmediateOutput from pexpect to lit

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide. Herald added a project: LLDB. This converts the CommandScriptImmediateOutput test from a python test using pexpect to a regular lit test. Repository: rLLDB LLDB https://reviews.llvm.org/D60566 Files: lldb/l

[Lldb-commits] [PATCH] D60566: [test] Convert CommandScriptImmediateOutput from pexpect to lit

JDevlieghere updated this revision to Diff 194685. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Feedback Pavel CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60566/new/ https://reviews.llvm.org/D60566 Files: lldb/lit/Commands/CommandScriptImmediateOutp

[Lldb-commits] [PATCH] D60566: [test] Convert CommandScriptImmediateOutput from pexpect to lit

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358180: [test] Convert CommandScriptImmediateOutput from pexpect to lit (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D60566?vs=194685&id=194692#toc Re

[Lldb-commits] [PATCH] D60599: Move postfix expression code out of the NativePDB plugin

JDevlieghere added a comment. Makes sense, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60599/new/ https://reviews.llvm.org/D60599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D60667: Allow direct comparison of ConstString against StringRef

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks for doing this, Raphael! I wonder if there's situations where this could be confusing/not what you'd expect, but I can't immediately think of anything. If t

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. We need to define these variables in the cache and make sure the test suite knows about them. For lldb-instr for example, which lives in lit/tools/lldb-instr, you'd have

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

JDevlieghere added a comment. In D60780#1468927 , @labath wrote: > LLDB_TOOL_$TOOL_BUILD would be a better name for consistency with llvm. In > fact, if we started using the llvm cmake macros like `add_llvm_subdirectory`, > it would handle this automatic

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

JDevlieghere added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:145 + +macro(add_lldb_optional_tool_subdirectory name) + add_llvm_subdirectory(LLDB TOOL ${name}) Let's drop optional from the name Comment at: lldb/lit/lit.site.

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60780/new/ https://reviews.llvm.org/D60780

[Lldb-commits] [PATCH] D60984: [Reproducers] Limit logging to calls that cross the API boundary.

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, jingham, labath. Herald added a project: LLDB. We recently moved API logging into the instrumentation macros. This made that logging is now consistent and abstracted behind a macro for every API functions, independen

[Lldb-commits] [PATCH] D154643: [lldb] Prevent crash when completing ambiguous subcommands

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. Fix a crash when trying to complete an ambiguous subcommand. Take `set s tar` for example: here `s` is ambiguous between `set` and `show`. Press

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

JDevlieghere added a comment. Is the reason this is necessary because the apple accelerator tables would emit an entry for both the mangled and demangled name? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154617/new/ https://reviews.llvm.org/D154

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

JDevlieghere accepted this revision. JDevlieghere added a comment. In D154617#4478402 , @fdeazeve wrote: > In D154617#4478369 , @JDevlieghere > wrote: > >> Is the reason this is necessary because the apple accele

[Lldb-commits] [PATCH] D154649: [lldb] Fix dead lock issue when loading modules in Scripted Process

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. Might be worth adding a little comment there to make sure we remember why the check is there in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154649/new/ https://

[Lldb-commits] [PATCH] D154752: runCmd should print the command before running it in case of crashes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154752/new/ https://reviews.llvm.org/D154752 _

[Lldb-commits] [PATCH] D154890: [lldb][NFCI] Avoid construction of temporary std::strings in Variable

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154890/new/ https://reviews.llvm.org/D154890 ___

[Lldb-commits] [PATCH] D154643: [lldb] Prevent crash when completing ambiguous subcommands

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb10b01cca85: [lldb] Prevent crash when completing ambiguous subcommands (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D154643?vs=537829&id=

[Lldb-commits] [PATCH] D155037: Improve error messaging when debugserver fails to complete attaching to another process on Darwin systems

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo code duplication. Comment at: lldb/tools/debugserver/source/RNBRemote.cpp:3639-3644 + struct proc_bsdshortinfo proc; + int ppid = 0; + if (proc_pid

[Lldb-commits] [PATCH] D155129: [lldb] Move CommandOverrideCallbackWithResult to lldb_private namespace

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155129/new/ https://reviews.llvm.org/D155129 ___

[Lldb-commits] [PATCH] D155221: [lldb] Support compressed CTF

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, mib. Herald added a project: All. JDevlieghere requested review of this revision. Add support for compressed CTF data. The flags in the header can indicate whether the CTF body is compressed with zlib deflate. This pa

[Lldb-commits] [PATCH] D154668: [lldb] Support Compact C Type Format (CTF) section

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5aa4cff4323: [lldb] Support Compact C Type Format (CTF) section (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Git

[Lldb-commits] [PATCH] D154862: [lldb] Support Compact C Type Format (CTF)

This revision was automatically updated to reflect the committed changes. Closed by commit rGee44310a48b7: [lldb] Support Compact C Type Format (CTF) (authored by JDevlieghere). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

JDevlieghere added inline comments. Comment at: lldb/source/API/SBStructuredData.cpp:51-53 + const lldb::SBDebugger &debugger) { + return debugger.CreateStructuredDataFromScriptObject(obj); +} mib wrote: > bulbazord wrote:

[Lldb-commits] [PATCH] D155221: [lldb] Support compressed CTF

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG0e285a13eb7f: [lldb] Support compressed CTF (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. `ASSERT_EQ` should call `operator==` under the hood. Why would that be flakey on arm64? Can we achieve this by changing the implementation to reimplement this with `FileS

[Lldb-commits] [PATCH] D155030: [lldb][NFCI] Avoid construction of temporary std::strings in RegisterValue

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155030/new/ https://reviews.llvm.org/D155030 ___

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. I'm okay with the ABI break given that this (1) hasn't made it into a release yet, (2) it is under active development by Ismail himself and (3) has existing adopters beyo

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. LGTM. I agree with Adrian: we can go ahead and land this to unblock the bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155198/new/ https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBScriptObject.h:47 +private: + std::shared_ptr m_opaque_sp; +}; Does this need to be a shared pointer as opposed to a unique pointer? If so please add a comment why. Comm

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks for bearing with me. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155161/new/ https://reviews.llvm.org/D155161 _

[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156270/new/ https://reviews.llvm.org/D156270 ___

[Lldb-commits] [PATCH] D156279: [lldb] Increase the default timeouts when running under ASan

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, bulbazord, rupprecht. Herald added a project: All. JDevlieghere requested review of this revision. Increase the default timeouts when running under ASan. We had something similar before we adopted tablegen, but the larger

[Lldb-commits] [PATCH] D156279: [lldb] Increase the default timeouts when running under ASan

This revision was automatically updated to reflect the committed changes. Closed by commit rG94e8fefe385c: [lldb] Increase the default timeouts when running under ASan (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: Michael137, bulbazord, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Separate parsing CTF and creating LLDB types. This is a prerequisite to parsing forward references and recursive type

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h:101 + struct Value { +Value(llvm::StringRef name, uint32_t value) : name(name), value(value){}; +llvm::StringRef name; ---

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

JDevlieghere updated this revision to Diff 544880. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156447/new/ https://reviews.llvm.org/D156447 Files: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h lldb/source/Plugins/SymbolFile/CTF/SymbolF

[Lldb-commits] [PATCH] D156483: [lldb] Support CTF forward declarations

JDevlieghere created this revision. JDevlieghere added reviewers: Michael137, bulbazord, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Add support for CTF forward declarations. https://reviews.llvm.org/D156483 Files: lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D156490: [lldb] Fix CTF parsing of large structs

JDevlieghere created this revision. JDevlieghere added reviewers: Michael137, bulbazord, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Fix CTF parsing of large structs. If the size of a struct exceeds a certain threshold, the offset is encoded using tw

[Lldb-commits] [PATCH] D156483: [lldb] Support CTF forward declarations

JDevlieghere updated this revision to Diff 544925. JDevlieghere added a comment. Address @bulbazord's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156483/new/ https://reviews.llvm.org/D156483 Files: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h lldb/source/Plugins/Symbol

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h:108 + uint32_t size, std::vector values) + : CTFType(eEnum, uid, name), nelems(nelems), size(size) { +assert(values.size(

[Lldb-commits] [PATCH] D156498: [lldb] Support recursive record types in CTF

JDevlieghere created this revision. JDevlieghere added reviewers: Michael137, bulbazord, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Support recursive record types in CTF. We are now more lazy when creating LLDB types. When encountering a record type

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG0a5e0d3fad8d: [lldb] Split CTF parsing and type creation (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://r

[Lldb-commits] [PATCH] D156483: [lldb] Support CTF forward declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c70a3d9178f: [lldb] Support CTF forward declarations (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D156483?vs=544925&id=545324#toc Reposit

[Lldb-commits] [PATCH] D156490: [lldb] Fix CTF parsing of large structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9867df64a31: [lldb] Fix CTF parsing of large structs (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://r

[Lldb-commits] [PATCH] D156498: [lldb] Support recursive record types in CTF

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp:508 ctf_record.name.data(), tag_kind, eLanguageTypeC); + m_compiler_types[record_type.GetOpaqueQual

[Lldb-commits] [PATCH] D156606: [lldb] Improve memory usage by freeing CTF types (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: Michael137. Herald added a project: All. JDevlieghere requested review of this revision. Improve memory usage by reducing the lifetime of CTF types. Once a CTF type has been converted to a (complete) LLDB type, there's no need to

[Lldb-commits] [PATCH] D156498: [lldb] Support recursive record types in CTF

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. JDevlieghere marked 2 inline comments as done. Closed by commit rG12f3d97fc68b: [lldb]

[Lldb-commits] [PATCH] D156606: [lldb] Improve memory usage by freeing CTF types (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68918125c116: [lldb] Improve memory usage by freeing CTF types (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

JDevlieghere added a comment. This broke the standalone bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ I was able to reproduce the issue locally and reverting this commit fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D156763: [lldb] Fix building LLDB standlone without framework

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156763/new/ https://reviews.llvm.org/D156763

<    1   2   3   4   5   6   7   8   9   10   >