JDevlieghere added inline comments.
================
Comment at: lldb/cmake/modules/AddLLDB.cmake:145
+
+macro(add_lldb_optional_tool_subdirectory name)
+ add_llvm_subdirectory(LLDB TOOL ${name})
----------------
Let's drop optional from the name
================
Comment at: lldb/lit/lit.site.cfg.py.in:21
config.lldb_disable_python = @LLDB_DISABLE_PYTHON@
+config.has_lldb_instr = "@LLDB_TOOL_LLDB_INSTR_BUILD@"
+config.has_lldb_vscode = "@LLDB_TOOL_LLDB_VSCODE_BUILD@"
----------------
You can use `llvm_canonicalize_cmake_booleans` to make it a real boolean
similar to config.have_zlib
Also, maybe use "have" instead of "has" for consistency?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60780/new/
https://reviews.llvm.org/D60780
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
