JDevlieghere added a comment. In D60780#1468927 <https://reviews.llvm.org/D60780#1468927>, @labath wrote:
> LLDB_TOOL_$TOOL_BUILD would be a better name for consistency with llvm. In > fact, if we started using the llvm cmake macros like `add_llvm_subdirectory`, > it would handle this automatically, including creating the cache variable. > > The only difference would be that the variable would default to "On", whereas > you seem to want default-off. (I'm a bit torn on whether this is good. On one > hand, I understand the desire to not build this stuff, but on the other, this > creates an inconsistency with llvm, which builds everything by default, and > consistency is a good thing.) > > Also, I'd like to nominate lldb-mi as an additional optional feature. :) +1 on everything Pavel said. I'd also prefer to keep this on by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60780/new/ https://reviews.llvm.org/D60780 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
