JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed.
Can you please also update the RST docs? (https://lldb.llvm.org/new-www/) ================ Comment at: lldb/www/source.html:83 + <li>Assertions. + Assertions (from <tt>assert.h</tt>) should be used liberally to assert internal consistency. + Assertions shall <em>never</em> be used to detect invalid user input, such as malformed DWARF. ---------------- What happens with asserts in release builds? If they don't cause the process to abort, then they're strictly worse than lldb_assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59911/new/ https://reviews.llvm.org/D59911 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
