[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: This is failing on Windows on Arm, started here: https://lab.llvm.org/buildbot/#/builders/141/builds/8891 ``` AssertionError: False is not true : breakpoint not hit, stopped_events=[{'body': {'exitCode': 0}, 'event': 'exited', 'seq': 0, 'type': 'event'}] Config=aarch64-C:

[Lldb-commits] [lldb] c82b30c - [lldb][lldb-dap] Disable assembly breakpoint test on Windows

2025-05-22 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-05-22T09:48:31Z New Revision: c82b30c13463073b359695a83d1dc1b7fc1c8088 URL: https://github.com/llvm/llvm-project/commit/c82b30c13463073b359695a83d1dc1b7fc1c8088 DIFF: https://github.com/llvm/llvm-project/commit/c82b30c13463073b359695a83d1dc1b7fc1c8088.diff LOG

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: Looks like a Windows/PDB/COFF vs. Linux/DWARF/ELF difference. We can't break on a function when there's no debug information. It's not due to the architecture. So if you feel like coming up with a hack to make it work, the failure should reproduce on x64 Windows as well. P

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: Such a hack might be breaking on a place that does have debug information and stepping into one that doesn't, then placing a breakpoint on subsequent assembly lines. Might be. Didn't try it because it seemed like it might defeat the point of the test as it wouldn't place t

[Lldb-commits] [lldb] [lldb] Disable some unwind plans for discontinuous functions (PR #140927)

2025-05-22 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Looks good to me. https://github.com/llvm/llvm-project/pull/140927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-22 Thread David Spickett via lldb-commits
@@ -0,0 +1,592 @@ +//===-- RPCServerSourceEmitter.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Convert Maintainers file from reStructuredText -> Markdown (PR #140958)

2025-05-22 Thread David Spickett via lldb-commits
@@ -0,0 +1,241 @@ +# LLDB Maintainers + +This file is a list of the [maintainers](https://llvm.org/docs/DeveloperPolicy.html#maintainers) for LLDB. + +## Current Maintainers + +The following people are the active maintainers for the project. Please reach out to them for code rev

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-22 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: I think this is good strategy -- take the existing implementation of `.` and improve that later. I have one comment about the location of the members, but otherwise, I think this looks good. https://github.com/llvm/llvm-project/pull/138093

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-22 Thread Pavel Labath via lldb-commits
@@ -88,6 +89,42 @@ class IdentifierNode : public ASTNode { std::string m_name; }; +class MemberOfNode : public ASTNode { +public: + MemberOfNode(uint32_t location, ASTNodeUP base, bool is_arrow, + std::string name, lldb::DynamicValueType use_dynamic, +

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-22 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/138093 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] attempt to fix test_disassemble (PR #140975)

2025-05-22 Thread Ely Ronnen via lldb-commits
eronnen wrote: @medismailben can you share the cmake build arguments that you use for mac? https://github.com/llvm/llvm-project/pull/140975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-22 Thread Ely Ronnen via lldb-commits
eronnen wrote: I Haven't attempted, unfortunately I only own a x64 laptop, I can attempt to reproduce on a VM later https://github.com/llvm/llvm-project/pull/139969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb] Convert Maintainers file from reStructuredText -> Markdown (PR #140958)

2025-05-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM. I got us to a point where every file in llvm-project is `Maintainers.*` but didn't have the appetite to make them all Markdown yet. https://github.com/llvm/llvm-project/pull/140958 __

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: Let's see what I find first, sometimes these things are quite simple to fix. https://github.com/llvm/llvm-project/pull/139969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [clang] [flang] [lld] [lldb] [llvm] [mlir] [polly] [CMake] respect LLVMConfig.cmake's LLVM_DEFINITIONS in standalone builds (PR #138587)

2025-05-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu-no-asserts` running on `doug-worker-6` while building `bolt,clang,flang,lld,lldb,mlir,polly` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/bui

[Lldb-commits] [lldb] 491619a - [LLDB] Add array subscription and integer parsing to DIL (#138551)

2025-05-22 Thread via lldb-commits
Author: Ilia Kuklin Date: 2025-05-22T16:15:11+05:00 New Revision: 491619a25003c499be16708562206f9a81bff5f7 URL: https://github.com/llvm/llvm-project/commit/491619a25003c499be16708562206f9a81bff5f7 DIFF: https://github.com/llvm/llvm-project/commit/491619a25003c499be16708562206f9a81bff5f7.diff L

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-22 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd closed https://github.com/llvm/llvm-project/pull/138551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-22 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi updated https://github.com/llvm/llvm-project/pull/138687 >From a47e4642e6ebcbe6b5466ff118968bac83ccf1e9 Mon Sep 17 00:00:00 2001 From: HemangGadhavi Date: Tue, 6 May 2025 07:59:45 -0500 Subject: [PATCH 1/2] [lldb][AIX] get host info for AIX (cont..) --- lldb/s

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-22 Thread Hemang Gadhavi via lldb-commits
@@ -54,6 +54,12 @@ TEST_F(HostInfoTest, GetHostname) { EXPECT_TRUE(HostInfo::GetHostname(s)); } +TEST_F(HostInfoTest, GetProgramFileSpec) { + // Test GetProgramFileSpec() HemangGadhavi wrote: Done https://github.com/llvm/llvm-project/pull/138687 _

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-22 Thread Hemang Gadhavi via lldb-commits
@@ -54,6 +54,12 @@ TEST_F(HostInfoTest, GetHostname) { EXPECT_TRUE(HostInfo::GetHostname(s)); } +TEST_F(HostInfoTest, GetProgramFileSpec) { + // Test GetProgramFileSpec() + FileSpec filespec = HostInfo::GetProgramFileSpec(); + EXPECT_FALSE(filespec.GetFilename().IsEmpty()

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-22 Thread Hemang Gadhavi via lldb-commits
@@ -90,6 +90,31 @@ TEST(Host, LaunchProcessSetsArgv0) { ASSERT_THAT(exit_status.get_future().get(), 0); } +TEST(Host, FindProcesses) { + SubsystemRAII subsystems; + + if (test_arg != 0) +exit(0); + + ProcessLaunchInfo info; + ProcessInstanceInfoList processes; + Pro

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread Michael Buch via lldb-commits
@@ -0,0 +1,57 @@ +// clang-format off + +// REQUIRES: target-windows +// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s +// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run" -o "fr v" -o c | FileCheck %s + +#include Michael1

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-22 Thread Hemang Gadhavi via lldb-commits
HemangGadhavi wrote: > The failure is in lldb_private::HostInfoBase::GetArchitecture. To fix this, > you need to `Initialize()` the HostInfo class. Thank you @labath. Thanks for the guidance, it worked. Could you please review and give your comments. https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-22 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi edited https://github.com/llvm/llvm-project/pull/138687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-22 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi updated https://github.com/llvm/llvm-project/pull/138687 >From a47e4642e6ebcbe6b5466ff118968bac83ccf1e9 Mon Sep 17 00:00:00 2001 From: HemangGadhavi Date: Tue, 6 May 2025 07:59:45 -0500 Subject: [PATCH 1/2] [lldb][AIX] get host info for AIX (cont..) --- lldb/s

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread via lldb-commits
@@ -0,0 +1,57 @@ +// clang-format off + +// REQUIRES: target-windows +// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s +// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run" -o "fr v" -o c | FileCheck %s + +#include Nerixyz

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread Michael Buch via lldb-commits
@@ -0,0 +1,57 @@ +// clang-format off + +// REQUIRES: target-windows +// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s +// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run" -o "fr v" -o c | FileCheck %s + +#include Michael1

[Lldb-commits] [lldb] b63c1c4 - [lldb] Disable some unwind plans for discontinuous functions (#140927)

2025-05-22 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-22T14:18:35+02:00 New Revision: b63c1c47b78a3c7af3014c4c77d1aad87ec78729 URL: https://github.com/llvm/llvm-project/commit/b63c1c47b78a3c7af3014c4c77d1aad87ec78729 DIFF: https://github.com/llvm/llvm-project/commit/b63c1c47b78a3c7af3014c4c77d1aad87ec78729.diff

[Lldb-commits] [lldb] [lldb] Disable some unwind plans for discontinuous functions (PR #140927)

2025-05-22 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/140927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/141063 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/141063 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread David Spickett via lldb-commits
@@ -93,13 +93,6 @@ function(add_lldb_library name) set(libkind STATIC) endif() - #PIC not needed on Win - # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options DavidSpickett wrote: Do we in fact use target_compile_options? Or do

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-05-22 Thread Hu Jialun via lldb-commits
SuibianP wrote: The FIFO file served two purposes, - Send real target PID back to debugger - Synchronisation: Prevent premature execution of target And the original implementation 0f0462c states the reason against socket and signal, > I'm using this instead of using a signal or a similar mecha

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread David Spickett via lldb-commits
@@ -0,0 +1,57 @@ +// clang-format off + +// REQUIRES: target-windows +// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s +// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run" -o "fr v" -o c | FileCheck %s + +#include DavidSpi

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread Michael Buch via lldb-commits
@@ -0,0 +1,57 @@ +// clang-format off + +// REQUIRES: target-windows +// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s +// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run" -o "fr v" -o c | FileCheck %s + +#include Michael1

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/141063 Like the comment says, this really is a no-op and has no offect on the generated build commants. >From 5eac5e7976005c74d5e1d669a64596688b3d8d25 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 22 May 2025

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Nothing in lldb sets this. And even if they did, llvm_add_library should know how to handle that. --- Full diff: https://github.com/llvm/llvm-project/pull/141066.diff 1 Files Affected: - (modified) lldb/cma

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-22 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/141066 Nothing in lldb sets this. And even if they did, llvm_add_library should know how to handle that. >From b2d4e92fcc647d36671c5de682e3af2d1978de0f Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 22 May 202

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread Pavel Labath via lldb-commits
@@ -93,13 +93,6 @@ function(add_lldb_library name) set(libkind STATIC) endif() - #PIC not needed on Win - # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options labath wrote: I believe we don't -- and I think that's the right thi

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread David Spickett via lldb-commits
@@ -93,13 +93,6 @@ function(add_lldb_library name) set(libkind STATIC) endif() - #PIC not needed on Win - # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options DavidSpickett wrote: Sounds reasonable, I've been bitten by distro c

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/141063 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [flang] [lld] [lldb] [llvm] [mlir] [polly] [CMake] respect LLVMConfig.cmake's LLVM_DEFINITIONS in standalone builds (PR #138587)

2025-05-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running on `aix-ppc64` while building `bolt,clang,flang,lld,lldb,mlir,polly` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/37

[Lldb-commits] [lldb] 5df819f - Revert "[LLDB] Add array subscription and integer parsing to DIL" (#141059)

2025-05-22 Thread via lldb-commits
Author: Ilia Kuklin Date: 2025-05-22T17:33:01+05:00 New Revision: 5df819ffb32530dff9342a970ffd1527ea1c31bb URL: https://github.com/llvm/llvm-project/commit/5df819ffb32530dff9342a970ffd1527ea1c31bb DIFF: https://github.com/llvm/llvm-project/commit/5df819ffb32530dff9342a970ffd1527ea1c31bb.diff L

[Lldb-commits] [lldb] Revert "[LLDB] Add array subscription and integer parsing to DIL" (PR #141059)

2025-05-22 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd closed https://github.com/llvm/llvm-project/pull/141059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make AddressRange dump easier on the eye (PR #141062)

2025-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141062.diff 7 Files Affected: - (modified) lldb/source/Core/AddressRange.cpp (+7-4) - (modified) lldb/test/Shell/SymbolFile/Breakpad/stack-cfi-parsi

[Lldb-commits] [lldb] [lldb] Make AddressRange dump easier on the eye (PR #141062)

2025-05-22 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/141062 None >From 298dcd8cc367050e7dcb6dd8644073305c72c6e7 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 22 May 2025 14:53:44 +0200 Subject: [PATCH] [lldb] Make AddressRange dump easier on the eye --- lldb/s

[Lldb-commits] [lldb] [lldb-dap] In DAP unit tests, add helpers for loading a CoreFile. (PR #140738)

2025-05-22 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/140738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-22 Thread Pavel Labath via lldb-commits
@@ -100,29 +100,25 @@ function(add_lldb_library name) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") labath wrote: Yes, kinda, although it's moot while it's unused. However, the idea was that if someone explicitly asks for an OBJECT library, he should get

[Lldb-commits] [lldb] [lldb-dap] In DAP unit tests, add helpers for loading a CoreFile. (PR #140738)

2025-05-22 Thread Jonas Devlieghere via lldb-commits
@@ -10,8 +10,16 @@ add_lldb_unittest(DAPTests VariablesTest.cpp LINK_LIBS +liblldb lldbDAP +lldbUtilityHelpers LLVMTestingSupport LINK_COMPONENTS Support ) + +set(test_inputs + linux-x86_64.out + linux-x86_64.core JDevliegher

[Lldb-commits] [lldb] Revert "[LLDB] Add array subscription and integer parsing to DIL" (PR #141059)

2025-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) Changes Reverts llvm/llvm-project#138551 --- Patch is 21.24 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/141059.diff 13 Files Affected: - (modified) lldb/docs/dil-expr-

[Lldb-commits] [lldb] Revert "[LLDB] Add array subscription and integer parsing to DIL" (PR #141059)

2025-05-22 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd created https://github.com/llvm/llvm-project/pull/141059 Reverts llvm/llvm-project#138551 >From b2e110036df39bb33163b5cd6c8dacf9253b6b33 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Thu, 22 May 2025 17:29:24 +0500 Subject: [PATCH] Revert "[LLDB] Add array subscrip

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Like the comment says, this really is a no-op and has no offect on the generated build commants. --- Full diff: https://github.com/llvm/llvm-project/pull/141063.diff 1 Files Affected: - (modified) lldb/cmak

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-22 Thread David Spickett via lldb-commits
@@ -100,29 +100,25 @@ function(add_lldb_library name) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") DavidSpickett wrote: Should you remove OBJECT from: ``` cmake_parse_arguments(PARAM "MODULE;SHARED;STATIC;OBJECT;PLUGIN;FRAMEWORK;NO_INTERNAL_DEPENDE

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-22 Thread David Spickett via lldb-commits
@@ -100,29 +100,25 @@ function(add_lldb_library name) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") DavidSpickett wrote: > And even if they did, llvm_add_library should know how to handle that. Oh is this why you left those bits in? https://github.com/ll

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-22 Thread David Spickett via lldb-commits
@@ -100,29 +100,25 @@ function(add_lldb_library name) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") DavidSpickett wrote: Also the bit: ``` elseif (PARAM_OBJECT) set(libkind OBJECT) ``` https://github.com/llvm/llvm-project/pull/141066

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-22 Thread John Harrison via lldb-commits
@@ -1102,3 +1103,28 @@ def is_feature_enabled(): return "%s is not supported on this system." % feature return skipTestIfFn(is_feature_enabled) + + +def skipIfBinaryToLarge(path: Optional[str], maxSize: int): +"""Skip the test if a binary is to large. +

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #141102)

2025-05-22 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd created https://github.com/llvm/llvm-project/pull/141102 None >From ad2c40ea689c71074237287989fa7ae01bd428e4 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Thu, 22 May 2025 16:15:11 +0500 Subject: [PATCH 1/2] [LLDB] Add array subscription and integer parsing to DIL

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #141102)

2025-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) Changes --- Patch is 21.53 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/141102.diff 13 Files Affected: - (modified) lldb/docs/dil-expr-lang.ebnf (+7-2) - (modified) l

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #141102)

2025-05-22 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: @labath This code ``` llvm::Expected num_children = synthetic->GetNumChildren(child_idx + 1); ``` didn't work for `std::vector` on Windows on AArch64, got a buildbot error there: https://lab.llvm.org/buildbot/#/builders/141/builds/8906 ``` AssertionError: ':1:7: array index

[Lldb-commits] [lldb] [lldb] Make AddressRange dump easier on the eye (PR #141062)

2025-05-22 Thread Pavel Labath via lldb-commits
@@ -11,7 +11,7 @@ image show-unwind -n func0 # CHECK-NEXT: This UnwindPlan is sourced from the compiler: yes. # CHECK-NEXT: This UnwindPlan is valid at all instruction locations: no. # CHECK-NEXT: This UnwindPlan is for a trap handler function: no. -# CHECK-NEXT: Address range

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #141102)

2025-05-22 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd edited https://github.com/llvm/llvm-project/pull/141102 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits