https://github.com/labath created
https://github.com/llvm/llvm-project/pull/141066
Nothing in lldb sets this. And even if they did, llvm_add_library should know
how to handle that.
>From b2d4e92fcc647d36671c5de682e3af2d1978de0f Mon Sep 17 00:00:00 2001
From: Pavel Labath <pa...@labath.sk>
Date: Thu, 22 May 2025 15:50:01 +0200
Subject: [PATCH] [lldb/cmake] Remove special handling of OBJECT libraries
Nothing in lldb sets this. And even if they did, llvm_add_library should
know how to handle that.
---
lldb/cmake/modules/AddLLDB.cmake | 36 ++++++++++++++------------------
1 file changed, 16 insertions(+), 20 deletions(-)
diff --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake
index 0a81ec5092185..cd6ce47ca5ca2 100644
--- a/lldb/cmake/modules/AddLLDB.cmake
+++ b/lldb/cmake/modules/AddLLDB.cmake
@@ -100,29 +100,25 @@ function(add_lldb_library name)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")
endif()
- if (PARAM_OBJECT)
- add_library(${name} ${libkind} ${srcs})
- else()
- if(PARAM_ENTITLEMENTS)
- set(pass_ENTITLEMENTS ENTITLEMENTS ${PARAM_ENTITLEMENTS})
- endif()
+ if(PARAM_ENTITLEMENTS)
+ set(pass_ENTITLEMENTS ENTITLEMENTS ${PARAM_ENTITLEMENTS})
+ endif()
- if(LLDB_NO_INSTALL_DEFAULT_RPATH)
- set(pass_NO_INSTALL_RPATH NO_INSTALL_RPATH)
- endif()
+ if(LLDB_NO_INSTALL_DEFAULT_RPATH)
+ set(pass_NO_INSTALL_RPATH NO_INSTALL_RPATH)
+ endif()
- llvm_add_library(${name} ${libkind} ${srcs}
- LINK_LIBS ${PARAM_LINK_LIBS}
- DEPENDS ${PARAM_DEPENDS}
- ${pass_ENTITLEMENTS}
- ${pass_NO_INSTALL_RPATH}
- )
+ llvm_add_library(${name} ${libkind} ${srcs}
+ LINK_LIBS ${PARAM_LINK_LIBS}
+ DEPENDS ${PARAM_DEPENDS}
+ ${pass_ENTITLEMENTS}
+ ${pass_NO_INSTALL_RPATH}
+ )
- if(CLANG_LINK_CLANG_DYLIB)
- target_link_libraries(${name} PRIVATE clang-cpp)
- else()
- target_link_libraries(${name} PRIVATE ${PARAM_CLANG_LIBS})
- endif()
+ if(CLANG_LINK_CLANG_DYLIB)
+ target_link_libraries(${name} PRIVATE clang-cpp)
+ else()
+ target_link_libraries(${name} PRIVATE ${PARAM_CLANG_LIBS})
endif()
# A target cannot be changed to a FRAMEWORK after calling install() because
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
