llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) <details> <summary>Changes</summary> Like the comment says, this really is a no-op and has no offect on the generated build commants. --- Full diff: https://github.com/llvm/llvm-project/pull/141063.diff 1 Files Affected: - (modified) lldb/cmake/modules/AddLLDB.cmake (-7) ``````````diff diff --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake index 0a81ec5092185..41f9b28a0ab39 100644 --- a/lldb/cmake/modules/AddLLDB.cmake +++ b/lldb/cmake/modules/AddLLDB.cmake @@ -93,13 +93,6 @@ function(add_lldb_library name) set(libkind STATIC) endif() - #PIC not needed on Win - # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options - # or omit this logic instead. - if (NOT WIN32) - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") - endif() - if (PARAM_OBJECT) add_library(${name} ${libkind} ${srcs}) else() `````````` </details> https://github.com/llvm/llvm-project/pull/141063 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
