https://github.com/labath created
https://github.com/llvm/llvm-project/pull/141063
Like the comment says, this really is a no-op and has no offect on the
generated build commants.
>From 5eac5e7976005c74d5e1d669a64596688b3d8d25 Mon Sep 17 00:00:00 2001
From: Pavel Labath <pa...@labath.sk>
Date: Thu, 22 May 2025 15:07:21 +0200
Subject: [PATCH] [lldb/cmake] Remove a no-op statement
Like the comment says, this really is a no-op and has no offect on the
generated build commants.
---
lldb/cmake/modules/AddLLDB.cmake | 7 -------
1 file changed, 7 deletions(-)
diff --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake
index 0a81ec5092185..41f9b28a0ab39 100644
--- a/lldb/cmake/modules/AddLLDB.cmake
+++ b/lldb/cmake/modules/AddLLDB.cmake
@@ -93,13 +93,6 @@ function(add_lldb_library name)
set(libkind STATIC)
endif()
- #PIC not needed on Win
- # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options
- # or omit this logic instead.
- if (NOT WIN32)
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")
- endif()
-
if (PARAM_OBJECT)
add_library(${name} ${libkind} ${srcs})
else()
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
