================
@@ -0,0 +1,57 @@
+// clang-format off
+
+// REQUIRES: target-windows
+// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s
+// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run" 
-o "fr v" -o c | FileCheck %s
+
+#include <bitset>
----------------
Michael137 wrote:

Hmm right that makes sense. Should we then have a Windows data-formatter 
subdirectory in 
`lldb/test/API/functionalities/data-formatter/data-formatter-stl`? We should 
ideally have two test configurations:

1. Tests that ensure we at least don't crash when using the MSVC STL? I.e., 
`std::optional` and `std::shared_ptr`. This would test your current PR
2. Tests for libc++ on Windows (which AFAIU, isn't the recommended 
configuration on Windows but is definitely used in the wild)

Not sure how easy it is to set up (2). That shouldn't block this PR, but would 
be nice to get around to it.

But (1) should be doable. Though not sure how equipped the API test 
infrastructure is to compile against MSVC STL. Worst case we could go for Shell 
tests there like you did here

CC @DavidSpickett @labath @omjavaid for opinions on Windows testing

https://github.com/llvm/llvm-project/pull/140761
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to