zturner added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbSymUid.h:46
+ // due to the debug magic at the beginning of the
stream.
+ uint64_t global : 1; // True if this is from the globals stream.
+ uint64_t modi : 16; // For
zturner added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:913
+
+ uint32_t section_idx = section - 1;
+ if (section_idx >= section_list->GetSize())
zturner wrote:
> lemo wrote:
> > comment explaining the - 1 ?
>
aleksandr.urakov updated this revision to Diff 171267.
aleksandr.urakov added a comment.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.
That's done!
https://reviews.llvm.org/D53368
Files:
include/lldb/Symbol/SymbolFile.h
include/lldb/Symbol/SymbolVendor.h
Author: zturner
Date: Fri Oct 26 02:06:38 2018
New Revision: 345373
URL: http://llvm.org/viewvc/llvm-project?rev=345373&view=rev
Log:
[NativePDB] Add the ability to dump dump global variables.
LLDB has the ability to display global variables, even without a running
process, via the target variabl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345373: [NativePDB] Add the ability to dump dump global
variables. (authored by zturner, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53731
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, stella.stamenova.
aleksandr.urakov added a project: LLDB.
Herald added a subscriber: lldb-commits.
This one fixes tests compilation preserving the type of the `scope` parameter.
Repository:
rLLDB LLDB
https://r
Ahh, I meant to remind you, because I noticed this when I was looking
through the SymbolFilePDB code recently. I think the LLVM guideline is not
to use so much auto. The generally accepted rule is that we can use for
the result of make_shared, make_unique, and result of iterator types, but
otherw
zturner added a subscriber: aleksandr.urakov.
zturner added a comment.
Ahh, I meant to remind you, because I noticed this when I was looking
through the SymbolFilePDB code recently. I think the LLVM guideline is not
to use so much auto. The generally accepted rule is that we can use for
the resu
aleksandr.urakov added a comment.
Ok, thanks! I didn't know about such rule. I'll reduce usages of auto :)
As for such an obvious changes, is it ok to commit them without a review? Or is
it still preferable to create reviews for them?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53749
zturner added a comment.
For trivial changes it's ok to submit without review. This is true for
cleanup and trivial refactor, but especially for build break like this
one., and even more so if you consider yourself code owner in the
corresponding code area.
Repository:
rLLDB LLDB
https://rev
For trivial changes it's ok to submit without review. This is true for
cleanup and trivial refactor, but especially for build break like this
one., and even more so if you consider yourself code owner in the
corresponding code area.
On Fri, Oct 26, 2018 at 2:29 AM Aleksandr Urakov via Phabricator
Author: aleksandr.urakov
Date: Fri Oct 26 02:36:26 2018
New Revision: 345374
URL: http://llvm.org/viewvc/llvm-project?rev=345374&view=rev
Log:
[PDB] Fix `SymbolFilePDBTests` after r345313
Differential Revision: https://reviews.llvm.org/D53749
Modified:
lldb/trunk/unittests/SymbolFile/PDB/Sym
aleksandr.urakov added a comment.
Ok, good!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53749
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345374: [PDB] Fix `SymbolFilePDBTests` after r345313
(authored by aleksandr.urakov, committed by ).
Changed prior to c
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, stella.stamenova, labath.
aleksandr.urakov added a project: LLDB.
Herald added a subscriber: lldb-commits.
When evaluating expressions the generic arguments registers are required by
ABI. This patch defines them.
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, asmith, stella.stamenova.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor, JDevlieghere, aprantl.
This patch contains several small fixes, which makes it possible to evaluat
zturner added a subscriber: aleksandr.urakov.
zturner added a comment.
Lgtm
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53753
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: jingham, zturner, boris.ulasevich.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor.
This patch fixes the next situation. On Windows `clang-cl` makes no stub before
the `main` functi
aleksandr.urakov added a comment.
Thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53753
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: aleksandr.urakov
Date: Fri Oct 26 07:15:34 2018
New Revision: 345385
URL: http://llvm.org/viewvc/llvm-project?rev=345385&view=rev
Log:
[Windows] Define generic arguments registers for Windows x64
Summary:
When evaluating expressions the generic arguments registers are required by ABI.
Thi
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345385: [Windows] Define generic arguments registers for
Windows x64 (authored by aleksandr.urakov, committed by ).
Herald
Hui added inline comments.
Comment at: source/Plugins/Process/Windows/Common/ProcessWindows.cpp:712
+lldb::addr_t ProcessWindows::DoAllocateMemory(size_t size, uint32_t
permissions,
+ Status &error) {
Looks to me th
Hui added inline comments.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:819
if (!section_list)
m_entry_point_address.SetOffset(offset);
else
This still needs to be the offset into the section.
Repository:
rLLDB LLDB
https://re
clayborg added a comment.
My issue with adding "exact_match" is it renders a few of the arguments useless:
size_t FindTypes(
const SymbolContext &sc,
llvm::StringRef name,
const CompilerDeclContext *parent_decl_ctx,
bool exact_match,
...);
With exact_match "parent_decl_ct
Ok, that reasoning makes sense, I’ll see what i can do
On Fri, Oct 26, 2018 at 9:25 AM Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg added a comment.
>
> My issue with adding "exact_match" is it renders a few of the arguments
> useless:
>
> size_t FindTypes(
> co
zturner added a subscriber: clayborg.
zturner added a comment.
Ok, that reasoning makes sense, I’ll see what i can do
https://reviews.llvm.org/D53662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: shafik
Date: Fri Oct 26 10:00:48 2018
New Revision: 345402
URL: http://llvm.org/viewvc/llvm-project?rev=345402&view=rev
Log:
[DataFormatters] Adding formatters for libc++ std::u16string and std::u32string
rdar://problem/41302849
Differential Revision: https://reviews.llvm.org/D53656
Mod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345402: [DataFormatters] Adding formatters for libc++
std::u16string and std::u32string (authored by shafik, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.
A couple of comments, but looks good otherwise. I'd wait for someone else to
have a look as well.
Comment at: source/Plugins/Process/Windows/Common/Proce
Author: jmolenda
Date: Fri Oct 26 12:40:18 2018
New Revision: 345422
URL: http://llvm.org/viewvc/llvm-project?rev=345422&view=rev
Log:
Remove an early-return from Driver::ParseArgs that
was added as a part of D52604 / r343348. If the
lldb driver is run without any arguments, .lldbinit
file readi
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This seems safe, but you certainly want to add a comment explaining why you are
doing this.
We find the expression breakpoint by calling ObjectFile::GetEntryPointAddress
on the ma
Author: jdevlieghere
Date: Fri Oct 26 16:01:25 2018
New Revision: 345435
URL: http://llvm.org/viewvc/llvm-project?rev=345435&view=rev
Log:
Fix and rename broken test for `settings write`.
I committed this test without updating the old `settings export` to
settings write. Since the functionality w
JDevlieghere updated this revision to Diff 171376.
JDevlieghere retitled this revision from "[FileSpec] Add VFS support to
FileSpec convenience methods." to "[FileSystem] Extend file system and have it
use the VFS.".
JDevlieghere edited the summary of this revision.
JDevlieghere added a comment.
JDevlieghere created this revision.
JDevlieghere added reviewers: zturner, labath, jingham, clayborg.
JDevlieghere added a project: LLDB.
This patch moves the EnumerateDirectory functionality and related enums and
typedefs from FileSpec to FileSystem. The long term goal is to remove this
method
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, zturner, jingham.
JDevlieghere added a project: LLDB.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.
This patch removes the `GetByteSize` method from FileSpec and updates its uses
with ca
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53788
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
zturner accepted this revision.
zturner added a comment.
I always wondered if we actually even need methods like this in `FileSystem`
given that they already exist in `llvm::sys::fs`. Is it possible to just call
the llvm methods directly, or is it still helpful to call the ones in
`FileSystem`
malaperle updated this revision to Diff 171388.
malaperle added a comment.
Convert to lit test, convert some code to an early return, clang-format.
https://reviews.llvm.org/D52953
Files:
lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
lit/tools/lldb-mi/breakpoint/inputs/break-
38 matches
Mail list logo
