zturner added a subscriber: aleksandr.urakov. zturner added a comment. Ahh, I meant to remind you, because I noticed this when I was looking through the SymbolFilePDB code recently. I think the LLVM guideline is not to use so much auto. The generally accepted rule is that we can use for the result of make_shared, make_unique, and result of iterator types, but otherwise we prefer to explicitly spell the types out. You don't have to go and submit another patch on top of this one to fix it again, it's just something to keep in mind.
That said, thanks for fixing this for me. Sorry for the break. Repository: rLLDB LLDB https://reviews.llvm.org/D53749 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
