For trivial changes it's ok to submit without review. This is true for cleanup and trivial refactor, but especially for build break like this one., and even more so if you consider yourself code owner in the corresponding code area.
On Fri, Oct 26, 2018 at 2:29 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.urakov added a comment. > > Ok, thanks! I didn't know about such rule. I'll reduce usages of auto :) > > As for such an obvious changes, is it ok to commit them without a review? > Or is it still preferable to create reviews for them? > > > Repository: > rLLDB LLDB > > https://reviews.llvm.org/D53749 > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
