stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land.
A couple of comments, but looks good otherwise. I'd wait for someone else to have a look as well. ================ Comment at: source/Plugins/Process/Windows/Common/ProcessWindows.cpp:959 + // It may be an expression evaluation crash. + SetPrivateState(eStateStopped); } ---------------- Are we going to determine later whether it is supposed to be a crash or just never crash on second chance exceptions? ================ Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:1085 + } else + set = &m_namespaces; + assert(set); ---------------- Nit: Maybe add curly braces here. Since the if statement has them, the code is easier to read if the else does as well. Repository: rLLDB LLDB https://reviews.llvm.org/D53759 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
