zturner added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:913 + + uint32_t section_idx = section - 1; + if (section_idx >= section_list->GetSize()) ---------------- zturner wrote: > lemo wrote: > > comment explaining the - 1 ? > I'm going to be totally honest here. I don't understand this code at all. I > copied it from the `SymbolFilePDB` implementation. It seems to work :-/ Ok, I thought about this some, it's actually pretty simple. I'll add a comment. https://reviews.llvm.org/D53731 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
