[Lldb-commits] [lldb] [lldb-dap] Assorted small fixes for runInTerminal (PR #140908)

2025-05-22 Thread Hu Jialun via lldb-commits
SuibianP wrote: I don't have commit access and please kindly help commit on my behalf when you see fit. https://github.com/llvm/llvm-project/pull/140908 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `ppc64le-flang-rhel-clang` running on `ppc64le-flang-rhel-test` while building `clang-tools-extra,clang,lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/2

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #138416)

2025-05-22 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. This looks good to me. https://github.com/llvm/llvm-project/pull/138416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang-tools-extra,clang,lldb` at step 6 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/32614

[Lldb-commits] [lldb] [lldb] Adding a new decorator for CMAKE_BUILD_TYPE. (PR #141159)

2025-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes In lldb-dap, we have existing tests that are known to be unstable when lldb and lldb-dap are built in the Debug configuration. This decorator lets us skip those tests in CI jobs that are to slow with those c

[Lldb-commits] [lldb] [lldb] Adding a new decorator for CMAKE_BUILD_TYPE. (PR #141159)

2025-05-22 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/141159 In lldb-dap, we have existing tests that are known to be unstable when lldb and lldb-dap are built in the Debug configuration. This decorator lets us skip those tests in CI jobs that are to slow with those conf

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-22 Thread John Harrison via lldb-commits
ashgti wrote: This patch has grown a bit due to discovering a number of issues in some of the tests. I think I'll try splitting it up into smaller patches instead. https://github.com/llvm/llvm-project/pull/140777 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-22 Thread John Harrison via lldb-commits
@@ -1102,3 +1103,28 @@ def is_feature_enabled(): return "%s is not supported on this system." % feature return skipTestIfFn(is_feature_enabled) + + +def skipIfBinaryToLarge(path: Optional[str], maxSize: int): +"""Skip the test if a binary is to large. +

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,53 @@ +#!/usr/bin/env python3 +""" +Usage: LLDB_MAJOR_VERSION LLDB_MINOR_VERSION LLDB_PATCH_VERSION + +This script uncomments and populates the versioning information in lldb-defines.h +""" + +import argparse +import os +import re + +LLDB_VERSION_REGEX = re.compile(

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,16 @@ +//===-- lldb-defines.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,17 @@ +// Run the convert script on it, then run the framework include fix on it. The framework version fix script +// expects that all lldb references have been renamed to lldb-rpc in order for it to modify the includes +// to go into the framework.

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-22 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/140777 >From e50ea7d279adcb181f68a7156b5fc12d1047f402 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 20 May 2025 11:09:35 -0700 Subject: [PATCH 1/3] [lldb-dap] Test gardening, enabling tests and improving doc

[Lldb-commits] [lldb] [lldb-dap] Assorted small fixes for runInTerminal (PR #140908)

2025-05-22 Thread John Harrison via lldb-commits
ashgti wrote: I have a change to remove the size check on the binary and yea, these tests are broken on macOS for sure. If this is submitted, then I'll rebase my changes on this, otherwise I also have a patch that could fix this. https://github.com/llvm/llvm-project/pull/140908 __

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `amdgpu-offload-ubuntu-22-cmake-build-only` running on `rocm-docker-ubu-22` while building `clang-tools-extra,clang,lldb` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/203/builds

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-22 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > There is functionality in lldb/scripts/framework-header-fix.sh that does the > same thing. Can you remove this functionality from that script too? Yeah, I can remove that. The ultimate goal I want here is: 1. Fixing up the versioning takes place in its own script (the one

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-22 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138028 >From 0b83514cde0b6fa2adc8c31a082a03770248ae4e Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 13:37:15 -0700 Subject: [PATCH] [lldb][RPC] Upstream Python scripts As part of upstre

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-22 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138028 >From 31161db1c9b0bd040513eb8ff4504c29d1e6c04f Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 13:37:15 -0700 Subject: [PATCH] [lldb][RPC] Upstream Python scripts As part of upstre

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-22 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,20 @@ +// Copy lldb-defines.h from source. +# RUN: mkdir -p %t/input +# RUN: mkdir -p %t/output +# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input chelcassanova wrote: Nice, I didn't know that about llvm-lit. I'll change everything to us

[Lldb-commits] [lldb] [lldb-dap] Assorted small fixes for runInTerminal (PR #140908)

2025-05-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/140908 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-22 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @labath So I moved the behavior to platform, I agree it's cleaner this way. One area that I couldn't decide is if the ValueObj should be constructed in Platform or not. Because Thread calls out to platform I just decided to call the existing method, but I wanted your feedback on

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-9-cmake-build-only` running on `rocm-docker-rhel-9` while building `clang-tools-extra,clang,lldb` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/10

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-22 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/140150 >From 94d78d5ea7866fe896381319c875d6b9c3d34c90 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 15 May 2025 13:57:11 -0700 Subject: [PATCH 01/11] Update ThreadElfCore --- lldb/include/lldb/Target/UnixSi

[Lldb-commits] [lldb] [lldb-dap] Fix address comparison in DisassembleRequestHandler (PR #140975)

2025-05-22 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140975 >From 419aa75b4f0d3fe54a3e08c8223906224bad2822 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Thu, 22 May 2025 02:44:31 +0200 Subject: [PATCH 1/3] [lldb-dap] attempt to fix test_disassemble --- lldb/test/API/

[Lldb-commits] [lldb] [lldb-dap] Fix address comparison in DisassembleRequestHandler (PR #140975)

2025-05-22 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/140975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix address comparison in DisassembleRequestHandler (PR #140975)

2025-05-22 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/tools/lldb-dap/Handler/DisassembleRequestHandler

[Lldb-commits] [lldb] [lldb-dap] Fix address comparison in DisassembleRequestHandler (PR #140975)

2025-05-22 Thread Ely Ronnen via lldb-commits
eronnen wrote: @medismailben I tested locally and now the test should be fixed https://github.com/llvm/llvm-project/pull/140975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-8-cmake-build-only` running on `rocm-docker-rhel-8` while building `clang-tools-extra,clang,lldb` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/10

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Jan Svoboda via lldb-commits
jansvoboda11 wrote: Thanks, I'll fix those ASAP. https://github.com/llvm/llvm-project/pull/139584 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-22 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: There is functionality in `lldb/scripts/framework-header-fix.sh` that does the same thing. Can you remove this functionality from that script too? https://github.com/llvm/llvm-project/pull/141116 ___ lldb-commit

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: > Thanks, I'll fix those ASAP. @jansvoboda11 Please feel free to add me as a reviewer. I am happy to build things with your fix. https://github.com/llvm/llvm-project/pull/139584 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @jansvoboda11 I also see: ``` clang-tools-extra/clang-tidy/plugin/ClangTidyPlugin.cpp:45:51: error: too few arguments to function call, expected 2, have 1 45 | Context->setDiagnosticsEngine(DiagEngine.get()); | ~

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-22 Thread via lldb-commits
@@ -88,6 +89,42 @@ class IdentifierNode : public ASTNode { std::string m_name; }; +class MemberOfNode : public ASTNode { +public: + MemberOfNode(uint32_t location, ASTNodeUP base, bool is_arrow, + std::string name, lldb::DynamicValueType use_dynamic, +

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-22 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/138093 >From fe9ac0fa05bb43ea718214746f0ea9b7eefc929a Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Thu, 1 May 2025 00:05:57 -0700 Subject: [PATCH 1/5] [LLDB] Add field member operators to DIL Add the arrow and pe

[Lldb-commits] [lldb] [lldb] Convert Maintainers file from reStructuredText -> Markdown (PR #140958)

2025-05-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/140958 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 48ace3f - [lldb] Convert Maintainers file from reStructuredText -> Markdown (#140958)

2025-05-22 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-22T13:04:13-07:00 New Revision: 48ace3f872e4d844471cd1e821502dece3fe2bc0 URL: https://github.com/llvm/llvm-project/commit/48ace3f872e4d844471cd1e821502dece3fe2bc0 DIFF: https://github.com/llvm/llvm-project/commit/48ace3f872e4d844471cd1e821502dece3fe2bc0.d

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/141122 >From a839dde6f9be0d3cbec73b9c001144b6cdbdc732 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 21 May 2025 23:26:14 +0100 Subject: [PATCH 1/5] [lldb][lldb-dap] support DataBreakpointBytes capability ---

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `clang-tools-extra,clang,lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/2022

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-quick` running on `linaro-clang-aarch64-quick` while building `clang-tools-extra,clang,lldb` at step 4 "build stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/17038 H

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/141122 >From a839dde6f9be0d3cbec73b9c001144b6cdbdc732 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 21 May 2025 23:26:14 +0100 Subject: [PATCH 1/4] [lldb][lldb-dap] support DataBreakpointBytes capability ---

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Jan Svoboda via lldb-commits
jansvoboda11 wrote: Are those in the upstream repo? If so, where are they coming from? I have a sparse checkout, so it's possible I missed some non-Clang and non-LLDB usages of `DiagnosticOptions`. https://github.com/llvm/llvm-project/pull/139584 ___

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-22 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/141116 >From 70c3d439f67c331823a218b76feef7fddd34c4d6 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 22 May 2025 11:00:06 -0700 Subject: [PATCH] [lldb][headers] Create script to fix up versioning Th

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-win-fast` running on `as-builder-3` while building `clang-tools-extra,clang,lldb` at step 6 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/2/builds/24607 Here

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: > > @jansvoboda11 I've revered your PR due buildbot failures above (and my > > local build failures with the same error messages). I'm happy to try your > > revised patch to see if it build cleanly. Thanks! > > I already forward-fixed both failures: > [d25f95f](https://g

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Jan Svoboda via lldb-commits
jansvoboda11 wrote: Reverted the revert, since the build now fails due to the forward-fixes not being reverted... https://github.com/llvm/llvm-project/pull/139584 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `arc-builder` running on `arc-worker` while building `clang-tools-extra,clang,lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/3/builds/16354 Here is the relevant

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Jan Svoboda via lldb-commits
jansvoboda11 wrote: > @jansvoboda11 I've revered your PR due buildbot failures above (and my local > build failures with the same error messages). I'm happy to try your revised > patch to see if it build cleanly. Thanks! I already forward-fixed both failures: d25f95fdbc5314f30618912e18f00ad4dd

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/135778 >From 8070e1a391d876ccbab25dac6d2a6d2d77f16069 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 15 Apr 2025 12:25:41 +0100 Subject: [PATCH 1/5] [lldb] Add test for jumping by offset Signed-off-by: Ebuka E

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @jansvoboda11 I've revered your PR due buildbot failures above (and my local build failures with the same error messages). I'm happy to try your revised patch to see if it build cleanly. Thanks! https://github.com/llvm/llvm-project/pull/139584 _

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-22 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py lldb/packa

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes This adds the support for `supportsBreakpointInfoBytes` to set watchpoint on a address range. --- Full diff: https://github.com/llvm/llvm-project/pull/141122.diff 7 Files Affected: - (modified) lldb/packa

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-22 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/141122 This adds the support for `supportsBreakpointInfoBytes` to set watchpoint on a address range. >From a839dde6f9be0d3cbec73b9c001144b6cdbdc732 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 21 May 2025

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-22 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/scripts/version-header-fix.py `` View the diff from darker

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-22 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Beautiful https://github.com/llvm/llvm-project/pull/141066 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-22 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/141116 >From 6b43888f8eaf5d28c4fa58e716cc2c534f325c3e Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 22 May 2025 11:00:06 -0700 Subject: [PATCH] [lldb][headers] Create script to fix up versioning Th

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

2025-05-22 Thread Michael Spencer via lldb-commits
https://github.com/Bigcheese approved this pull request. lgtm. I agree this makes the lifetime clearer. https://github.com/llvm/llvm-project/pull/139584 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes This commit creates a Python script that fixes up the versioning information in lldb-defines.h. It also moves the build logic for fixing up the lldb headers from being in the framework only to bein

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-22 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/141116 This commit creates a Python script that fixes up the versioning information in lldb-defines.h. It also moves the build logic for fixing up the lldb headers from being in the framework only to being in th

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #141102)

2025-05-22 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd edited https://github.com/llvm/llvm-project/pull/141102 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make AddressRange dump easier on the eye (PR #141062)

2025-05-22 Thread Pavel Labath via lldb-commits
@@ -11,7 +11,7 @@ image show-unwind -n func0 # CHECK-NEXT: This UnwindPlan is sourced from the compiler: yes. # CHECK-NEXT: This UnwindPlan is valid at all instruction locations: no. # CHECK-NEXT: This UnwindPlan is for a trap handler function: no. -# CHECK-NEXT: Address range

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #141102)

2025-05-22 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: @labath This code ``` llvm::Expected num_children = synthetic->GetNumChildren(child_idx + 1); ``` didn't work for `std::vector` on Windows on AArch64, got a buildbot error there: https://lab.llvm.org/buildbot/#/builders/141/builds/8906 ``` AssertionError: ':1:7: array index

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #141102)

2025-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) Changes --- Patch is 21.53 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/141102.diff 13 Files Affected: - (modified) lldb/docs/dil-expr-lang.ebnf (+7-2) - (modified) l

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #141102)

2025-05-22 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd created https://github.com/llvm/llvm-project/pull/141102 None >From ad2c40ea689c71074237287989fa7ae01bd428e4 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Thu, 22 May 2025 16:15:11 +0500 Subject: [PATCH 1/2] [LLDB] Add array subscription and integer parsing to DIL

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-22 Thread John Harrison via lldb-commits
@@ -1102,3 +1103,28 @@ def is_feature_enabled(): return "%s is not supported on this system." % feature return skipTestIfFn(is_feature_enabled) + + +def skipIfBinaryToLarge(path: Optional[str], maxSize: int): +"""Skip the test if a binary is to large. +

[Lldb-commits] [lldb] [lldb-dap] In DAP unit tests, add helpers for loading a CoreFile. (PR #140738)

2025-05-22 Thread Jonas Devlieghere via lldb-commits
@@ -10,8 +10,16 @@ add_lldb_unittest(DAPTests VariablesTest.cpp LINK_LIBS +liblldb lldbDAP +lldbUtilityHelpers LLVMTestingSupport LINK_COMPONENTS Support ) + +set(test_inputs + linux-x86_64.out + linux-x86_64.core JDevliegher

[Lldb-commits] [lldb] [lldb-dap] In DAP unit tests, add helpers for loading a CoreFile. (PR #140738)

2025-05-22 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/140738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-22 Thread Pavel Labath via lldb-commits
@@ -100,29 +100,25 @@ function(add_lldb_library name) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") labath wrote: Yes, kinda, although it's moot while it's unused. However, the idea was that if someone explicitly asks for an OBJECT library, he should get

[Lldb-commits] [clang] [flang] [lld] [lldb] [llvm] [mlir] [polly] [CMake] respect LLVMConfig.cmake's LLVM_DEFINITIONS in standalone builds (PR #138587)

2025-05-22 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running on `aix-ppc64` while building `bolt,clang,flang,lld,lldb,mlir,polly` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/37

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread David Spickett via lldb-commits
@@ -0,0 +1,57 @@ +// clang-format off + +// REQUIRES: target-windows +// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s +// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run" -o "fr v" -o c | FileCheck %s + +#include DavidSpi

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-05-22 Thread Hu Jialun via lldb-commits
SuibianP wrote: The FIFO file served two purposes, - Send real target PID back to debugger - Synchronisation: Prevent premature execution of target And the original implementation 0f0462c states the reason against socket and signal, > I'm using this instead of using a signal or a similar mecha

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-22 Thread David Spickett via lldb-commits
@@ -100,29 +100,25 @@ function(add_lldb_library name) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") DavidSpickett wrote: > And even if they did, llvm_add_library should know how to handle that. Oh is this why you left those bits in? https://github.com/ll

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-22 Thread David Spickett via lldb-commits
@@ -100,29 +100,25 @@ function(add_lldb_library name) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") DavidSpickett wrote: Also the bit: ``` elseif (PARAM_OBJECT) set(libkind OBJECT) ``` https://github.com/llvm/llvm-project/pull/141066

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-22 Thread David Spickett via lldb-commits
@@ -100,29 +100,25 @@ function(add_lldb_library name) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") DavidSpickett wrote: Should you remove OBJECT from: ``` cmake_parse_arguments(PARAM "MODULE;SHARED;STATIC;OBJECT;PLUGIN;FRAMEWORK;NO_INTERNAL_DEPENDE

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/141063 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread David Spickett via lldb-commits
@@ -93,13 +93,6 @@ function(add_lldb_library name) set(libkind STATIC) endif() - #PIC not needed on Win - # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options DavidSpickett wrote: Sounds reasonable, I've been bitten by distro c

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread Pavel Labath via lldb-commits
@@ -93,13 +93,6 @@ function(add_lldb_library name) set(libkind STATIC) endif() - #PIC not needed on Win - # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options labath wrote: I believe we don't -- and I think that's the right thi

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Nothing in lldb sets this. And even if they did, llvm_add_library should know how to handle that. --- Full diff: https://github.com/llvm/llvm-project/pull/141066.diff 1 Files Affected: - (modified) lldb/cma

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-22 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/141066 Nothing in lldb sets this. And even if they did, llvm_add_library should know how to handle that. >From b2d4e92fcc647d36671c5de682e3af2d1978de0f Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 22 May 202

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/141063 Like the comment says, this really is a no-op and has no offect on the generated build commants. >From 5eac5e7976005c74d5e1d669a64596688b3d8d25 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 22 May 2025

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread David Spickett via lldb-commits
@@ -93,13 +93,6 @@ function(add_lldb_library name) set(libkind STATIC) endif() - #PIC not needed on Win - # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options DavidSpickett wrote: Do we in fact use target_compile_options? Or do

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/141063 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/141063 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Like the comment says, this really is a no-op and has no offect on the generated build commants. --- Full diff: https://github.com/llvm/llvm-project/pull/141063.diff 1 Files Affected: - (modified) lldb/cmak

[Lldb-commits] [lldb] [lldb] Make AddressRange dump easier on the eye (PR #141062)

2025-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141062.diff 7 Files Affected: - (modified) lldb/source/Core/AddressRange.cpp (+7-4) - (modified) lldb/test/Shell/SymbolFile/Breakpad/stack-cfi-parsi

[Lldb-commits] [lldb] [lldb] Make AddressRange dump easier on the eye (PR #141062)

2025-05-22 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/141062 None >From 298dcd8cc367050e7dcb6dd8644073305c72c6e7 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 22 May 2025 14:53:44 +0200 Subject: [PATCH] [lldb] Make AddressRange dump easier on the eye --- lldb/s

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread Michael Buch via lldb-commits
@@ -0,0 +1,57 @@ +// clang-format off + +// REQUIRES: target-windows +// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s +// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run" -o "fr v" -o c | FileCheck %s + +#include Michael1

[Lldb-commits] [lldb] Revert "[LLDB] Add array subscription and integer parsing to DIL" (PR #141059)

2025-05-22 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd closed https://github.com/llvm/llvm-project/pull/141059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5df819f - Revert "[LLDB] Add array subscription and integer parsing to DIL" (#141059)

2025-05-22 Thread via lldb-commits
Author: Ilia Kuklin Date: 2025-05-22T17:33:01+05:00 New Revision: 5df819ffb32530dff9342a970ffd1527ea1c31bb URL: https://github.com/llvm/llvm-project/commit/5df819ffb32530dff9342a970ffd1527ea1c31bb DIFF: https://github.com/llvm/llvm-project/commit/5df819ffb32530dff9342a970ffd1527ea1c31bb.diff L

[Lldb-commits] [lldb] Revert "[LLDB] Add array subscription and integer parsing to DIL" (PR #141059)

2025-05-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) Changes Reverts llvm/llvm-project#138551 --- Patch is 21.24 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/141059.diff 13 Files Affected: - (modified) lldb/docs/dil-expr-

[Lldb-commits] [lldb] Revert "[LLDB] Add array subscription and integer parsing to DIL" (PR #141059)

2025-05-22 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd created https://github.com/llvm/llvm-project/pull/141059 Reverts llvm/llvm-project#138551 >From b2e110036df39bb33163b5cd6c8dacf9253b6b33 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Thu, 22 May 2025 17:29:24 +0500 Subject: [PATCH] Revert "[LLDB] Add array subscrip

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b63c1c4 - [lldb] Disable some unwind plans for discontinuous functions (#140927)

2025-05-22 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-22T14:18:35+02:00 New Revision: b63c1c47b78a3c7af3014c4c77d1aad87ec78729 URL: https://github.com/llvm/llvm-project/commit/b63c1c47b78a3c7af3014c4c77d1aad87ec78729 DIFF: https://github.com/llvm/llvm-project/commit/b63c1c47b78a3c7af3014c4c77d1aad87ec78729.diff

[Lldb-commits] [lldb] [lldb] Disable some unwind plans for discontinuous functions (PR #140927)

2025-05-22 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/140927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread Michael Buch via lldb-commits
@@ -0,0 +1,57 @@ +// clang-format off + +// REQUIRES: target-windows +// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s +// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run" -o "fr v" -o c | FileCheck %s + +#include Michael1

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread via lldb-commits
@@ -0,0 +1,57 @@ +// clang-format off + +// REQUIRES: target-windows +// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s +// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run" -o "fr v" -o c | FileCheck %s + +#include Nerixyz

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-22 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi updated https://github.com/llvm/llvm-project/pull/138687 >From a47e4642e6ebcbe6b5466ff118968bac83ccf1e9 Mon Sep 17 00:00:00 2001 From: HemangGadhavi Date: Tue, 6 May 2025 07:59:45 -0500 Subject: [PATCH 1/2] [lldb][AIX] get host info for AIX (cont..) --- lldb/s

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-22 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi edited https://github.com/llvm/llvm-project/pull/138687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-22 Thread Hemang Gadhavi via lldb-commits
HemangGadhavi wrote: > The failure is in lldb_private::HostInfoBase::GetArchitecture. To fix this, > you need to `Initialize()` the HostInfo class. Thank you @labath. Thanks for the guidance, it worked. Could you please review and give your comments. https://github.com/llvm/llvm-project/pull/

  1   2   >