Jlalond wrote: @labath So I moved the behavior to platform, I agree it's cleaner this way. One area that I couldn't decide is if the ValueObj should be constructed in Platform or not. Because Thread calls out to platform I just decided to call the existing method, but I wanted your feedback on this because it does feel somewhat split purpose. It might make sense to move the code into platform and have thread call platform to create the SP, the issue is that the value object needs a target reference.
https://github.com/llvm/llvm-project/pull/140150 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
