[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

mib updated this revision to Diff 339882. mib added a comment. Update BreakpointResolver column default value and fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100965/new/ https://reviews.llvm.org/D100965 Files: lldb/include/lldb/Breakp

[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

mib updated this revision to Diff 339881. mib added a comment. Update `LineEntry` unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100965/new/ https://reviews.llvm.org/D100965 Files: lldb/include/lldb/Breakpoint/BreakpointResolverFileLin

[Lldb-commits] [PATCH] D100965: [lldb] Refactor (FileSpec+Line) to SourceLocationSpec (NFCI)

mib updated this revision to Diff 339878. mib marked 3 inline comments as done. mib added a comment. Address @JDevlieghere & @jingham feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100965/new/ https://reviews.llvm.org/D100965 Files: ll

[Lldb-commits] [PATCH] D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console

wallace added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py:939 if log_file: adaptor_env['LLDBVSCODE_LOG'] = log_file self.process = subprocess.Popen([executable], JDevliegh

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 339867. mib edited the summary of this revision. mib added a comment. - Move boolean attributes to the end of the class. - Fix deleted default constructor issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

wallace created this revision. wallace added reviewers: clayborg, teemperor. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As a follow up of https://reviews.llvm.org/D99989#inline-953343, I'm now storing std::string instead of cha

[Lldb-commits] [PATCH] D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py:939 if log_file: adaptor_env['LLDBVSCODE_LOG'] = log_file self.process = subprocess.Popen([executable], Shou

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

wallace abandoned this revision. wallace added a comment. not needed anymore because of D99974 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80659/new/ https://reviews.llvm.org/D80659 _

[Lldb-commits] [PATCH] D70882: Add environment var LLDBVSCODE_SKIP_INIT_FILES to lldb-vscode

wallace abandoned this revision. wallace added a comment. not needed anymore because of D99974 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70882/new/ https://reviews.llvm.org/D70882 _

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace created this revision. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When the number of shared libs is massive, there could be hundreds of thousands of short lived progress events sent to the IDE, which makes it irresponsi

[Lldb-commits] [PATCH] D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2934 +// We first find out which variable names are duplicated +std::unordered_map variable_name_counts; +for (auto i = start_idx; i < end_idx; ++i) { teemperor wrote: >

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

jingham added a comment. In D98370#2710058 , @werat wrote: > In D98370#2709828 , @jingham wrote: > >> Be careful here. There are really two kinds of persistent variables: >> "expression results" and variables crea

[Lldb-commits] [lldb] 91d3f73 - [lldb] Update register state parsing for JSON crashlogs

Author: Jonas Devlieghere Date: 2021-04-22T16:40:59-07:00 New Revision: 91d3f73937b603b168a2be40f57a81efcc37da86 URL: https://github.com/llvm/llvm-project/commit/91d3f73937b603b168a2be40f57a81efcc37da86 DIFF: https://github.com/llvm/llvm-project/commit/91d3f73937b603b168a2be40f57a81efcc37da86.d

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

clayborg added a comment. I would be fine with DWARFDie getting bigger to 24B. These objects are used temporarily and not used as part of the storage of all of a DWARFUnit's DIEs. DWARFUnit objects store an array of DWARFDebugInfoEntry objects and those are what we care about not getting bigger

[Lldb-commits] [PATCH] D101094: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication()

teemperor added inline comments. Comment at: lldb/source/Plugins/InstrumentationRuntime/MainThreadChecker/InstrumentationRuntimeMainThreadChecker.cpp:273 + ThreadSP new_thread_sp = std::make_shared( + *process_sp, tid, PCs, pcs_are_call_addresses); shafi

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

werat added a comment. In D98370#2709828 , @jingham wrote: > Be careful here. There are really two kinds of persistent variables: > "expression results" and variables created in the expression parser. The > former are by design constant. The idea is t

[Lldb-commits] [PATCH] D101094: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication()

shafik added inline comments. Comment at: lldb/source/Plugins/InstrumentationRuntime/MainThreadChecker/InstrumentationRuntimeMainThreadChecker.cpp:273 + ThreadSP new_thread_sp = std::make_shared( + *process_sp, tid, PCs, pcs_are_call_addresses); A nitpic

[Lldb-commits] [PATCH] D101094: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. friss marked an inline comment as done. Closed by commit rG91e90cf62207: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication() (authored by friss). R

[Lldb-commits] [lldb] 91e90cf - lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication()

Author: Fred Riss Date: 2021-04-22T13:32:43-07:00 New Revision: 91e90cf622074633009788a220a354043a609dee URL: https://github.com/llvm/llvm-project/commit/91e90cf622074633009788a220a354043a609dee DIFF: https://github.com/llvm/llvm-project/commit/91e90cf622074633009788a220a354043a609dee.diff LOG

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

jankratochvil added a comment. Checked in a regression fix: rG18a85276426b9604a9ceca8c528b694964dd8d7c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91679/new/ https://reviews.l

[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

jankratochvil added a comment. The regression was due to the `help process trace` command which surprisingly ends up in `GDBRemoteCommunicationClient::SendTraceSupported` which was crashing on `libipt`-enabled builds. Fixed by: rG18a85276426b9604a9ceca8c528b694964dd8d7c

[Lldb-commits] [lldb] 18a8527 - [trace][intel-pt] Fix a crash on unconsumed Expected's Error

Author: Jan Kratochvil Date: 2021-04-22T22:27:08+02:00 New Revision: 18a85276426b9604a9ceca8c528b694964dd8d7c URL: https://github.com/llvm/llvm-project/commit/18a85276426b9604a9ceca8c528b694964dd8d7c DIFF: https://github.com/llvm/llvm-project/commit/18a85276426b9604a9ceca8c528b694964dd8d7c.diff

[Lldb-commits] [PATCH] D101091: [lldb] [Process/elf-core] Fix reading NetBSD/i386 core dumps

mgorny updated this revision to Diff 339768. mgorny added a comment. Use split code branches for i386 and amd64. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101091/new/ https://reviews.llvm.org/D101091 Files: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp lldb/source/Plu

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

teemperor added a comment. I assume you don't have a commit access, so I'm going to land this for you tomorrow. Thanks again for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100977/new/ https://reviews.llvm.org/D100977 ___

[Lldb-commits] [PATCH] D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request

teemperor added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2934 +// We first find out which variable names are duplicated +std::unordered_map variable_name_counts; +for (auto i = start_idx; i < end_idx; ++i) { clayborg wrote:

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

jingham added a comment. In D98370#2708672 , @werat wrote: > In D98370#2705741 , @jingham wrote: > >> Sure. But but when I was poking around at it a little bit, it seems like >> the other use cases already work, a

[Lldb-commits] [PATCH] D101094: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication()

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks for addressing my critical feedback. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101094/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D101094: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication()

friss updated this revision to Diff 339746. friss added a comment. Use make_shared Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101094/new/ https://reviews.llvm.org/D101094 Files: lldb/source/Plugins/InstrumentationRuntime/MainThreadChecker/In

[Lldb-commits] [lldb] 007158a - Skip unreliable LLDB tests when running under asan

Author: Adrian Prantl Date: 2021-04-22T11:55:43-07:00 New Revision: 007158ac42c785cd59aab8bc4b4b39085b960a58 URL: https://github.com/llvm/llvm-project/commit/007158ac42c785cd59aab8bc4b4b39085b960a58 DIFF: https://github.com/llvm/llvm-project/commit/007158ac42c785cd59aab8bc4b4b39085b960a58.diff

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 339743. mib marked an inline comment as done. mib edited the summary of this revision. mib added a comment. Addressed @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://review

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib marked 9 inline comments as done. mib added inline comments. Comment at: lldb/include/lldb/Utility/SourceLocationSpec.h:160 + /// file_spec and line number. An empty \a pattern matches everything. + static bool Match(const SourceLocationSpec &pattern, +c

[Lldb-commits] [PATCH] D101094: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication()

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/InstrumentationRuntime/MainThreadChecker/InstrumentationRuntimeMainThreadChecker.cpp:272-274 + HistoryThread *history_thread = + new HistoryThread(*process_sp, tid, PCs, pcs_are_call_addresses); ThreadS

[Lldb-commits] [lldb] a62cbd9 - [lldb] Include thread name in crashlog.py output

Author: Jonas Devlieghere Date: 2021-04-22T11:38:53-07:00 New Revision: a62cbd9a0211d08bace8794b435996890feb44d4 URL: https://github.com/llvm/llvm-project/commit/a62cbd9a0211d08bace8794b435996890feb44d4 DIFF: https://github.com/llvm/llvm-project/commit/a62cbd9a0211d08bace8794b435996890feb44d4.d

[Lldb-commits] [PATCH] D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2934 +// We first find out which variable names are duplicated +std::unordered_map variable_name_counts; +for (auto i = start_idx; i < end_idx; ++i) { We are getting a

[Lldb-commits] [PATCH] D101094: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication()

friss created this revision. friss added reviewers: jasonmolenda, JDevlieghere. friss requested review of this revision. Herald added a project: LLDB. A couple of our Instrumentation runtimes were gathering backtraces, storing it in a StructuredData array and later creating a HistoryThread using t

[Lldb-commits] [PATCH] D101086: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores

mgorny updated this revision to Diff 339719. mgorny added a comment. Also add FPU-specific checks to `x86-32-freebsd-addr.test`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101086/new/ https://reviews.llvm.org/D101086 Files: lldb/source/Plugins/Process/elf-core/RegisterUtilities.h

[Lldb-commits] [PATCH] D101091: [lldb] [Process/elf-core] Fix reading NetBSD/i386 core dumps

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Add support for extracting basic data from NetBSD/i386 core dumps. FPU registers are not supported at the moment. https://reviews.llvm.org/D101091 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D101086: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added subscribers: pengfei, arichardson. mgorny requested review of this revision. The FreeBSD coredumps from i386 systems contain only FSAVE-style NT_FPREGSET. Since we do not really support reading that ki

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

emrekultursay added a comment. > DependsOnParam2 x; This must have been the magic glue I was missing, Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100977/new/ https://reviews.llvm.org/D100977 _

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

emrekultursay updated this revision to Diff 339694. emrekultursay added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100977/new/ https://reviews.llvm.org/D100977 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClan

[Lldb-commits] [PATCH] D91780: [lldb] Fix that the expression commands --top-level flag overwrites --allow-jit false

This revision was automatically updated to reflect the committed changes. Closed by commit rGd616a6bd107f: [lldb] Fix that the expression commands --top-level flag overwrites --allow-jit… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [lldb] d616a6b - [lldb] Fix that the expression commands --top-level flag overwrites --allow-jit false

Author: Raphael Isemann Date: 2021-04-22T18:51:03+02:00 New Revision: d616a6bd107fcc0dc74f79e174e0b4fe27b26fe6 URL: https://github.com/llvm/llvm-project/commit/d616a6bd107fcc0dc74f79e174e0b4fe27b26fe6 DIFF: https://github.com/llvm/llvm-project/commit/d616a6bd107fcc0dc74f79e174e0b4fe27b26fe6.dif

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:932 + +std::unique_ptr child_process_up{child_process}; +Extension expected_ext = is_vfork ? Extension::vfork : Extension::fork; labath wrote: > Store direc

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

werat added a comment. In D98370#2705741 , @jingham wrote: > Sure. But but when I was poking around at it a little bit, it seems like the > other use cases already work, and the only one that was failing was the case > where you call persist on a persis

Re: [Lldb-commits] [lldb] cd64273 - [lldb/ELF] Fix IDs of synthetic eh_frame symbols

On 21/04/2021 22:13, Shafik Yaghmour wrote: Having side effects in the argument to a function call just feels like a bad idea in general even if it seems obviously correct here e.g. ++last_symbol_id, Can’t we just do: uint64_t last_symbol_id = num_symbols ? symbol_table->SymbolAt

[Lldb-commits] [lldb] e5984a3 - [lldb/elf] Avoid side effects in function calls ParseUnwindSymbols

Author: Pavel Labath Date: 2021-04-22T14:31:00+02:00 New Revision: e5984a3680bef22d422beaafa73bf131d7197973 URL: https://github.com/llvm/llvm-project/commit/e5984a3680bef22d422beaafa73bf131d7197973 DIFF: https://github.com/llvm/llvm-project/commit/e5984a3680bef22d422beaafa73bf131d7197973.diff

[Lldb-commits] [lldb] e3dd82a - [lldb] Don't leak LineSequence in PDB parsers

Author: Raphael Isemann Date: 2021-04-22T14:11:01+02:00 New Revision: e3dd82ae3c4edaeb3c8f835c29566375ee25023d URL: https://github.com/llvm/llvm-project/commit/e3dd82ae3c4edaeb3c8f835c29566375ee25023d DIFF: https://github.com/llvm/llvm-project/commit/e3dd82ae3c4edaeb3c8f835c29566375ee25023d.dif

[Lldb-commits] [PATCH] D100846: [lldb] Don't leak LineSequence in PDB parsers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3dd82ae3c4e: [lldb] Don't leak LineSequence in PDB parsers (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request

teemperor reopened this revision. teemperor added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2924 +// We first find out which variable names are duplicated +

[Lldb-commits] [lldb] d2223c7 - [lldb] XFAIL TestStoppedInStaticMemberFunction on Windows

Author: Raphael Isemann Date: 2021-04-22T13:46:27+02:00 New Revision: d2223c7a49973a61cc2de62992662afa8d19065a URL: https://github.com/llvm/llvm-project/commit/d2223c7a49973a61cc2de62992662afa8d19065a DIFF: https://github.com/llvm/llvm-project/commit/d2223c7a49973a61cc2de62992662afa8d19065a.dif

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. The test below reproduces the eager layout generation (and the resulting crashes) for me. Just apply it on top and then this is good to go. Thanks for tracking this down! diff --git

[Lldb-commits] [lldb] edc869c - [lldb-vscode] Use a DenseMap to pacify overly aggressive linters

Author: Benjamin Kramer Date: 2021-04-22T13:07:39+02:00 New Revision: edc869cb57fb4cf999c8a388b48ae4ecd027bfe7 URL: https://github.com/llvm/llvm-project/commit/edc869cb57fb4cf999c8a388b48ae4ecd027bfe7 DIFF: https://github.com/llvm/llvm-project/commit/edc869cb57fb4cf999c8a388b48ae4ecd027bfe7.dif

[Lldb-commits] [lldb] 034c73d - [lldb][NFC] Fix unsigned/signed cmp warning in MainLoopTest

Author: Raphael Isemann Date: 2021-04-22T12:20:32+02:00 New Revision: 034c73d42e4655ae247fc1f72dc3d2d6c621ab23 URL: https://github.com/llvm/llvm-project/commit/034c73d42e4655ae247fc1f72dc3d2d6c621ab23 DIFF: https://github.com/llvm/llvm-project/commit/034c73d42e4655ae247fc1f72dc3d2d6c621ab23.dif

[Lldb-commits] [PATCH] D81550: [lldb] Add support for evaluating expressions in static member functions

This revision was automatically updated to reflect the committed changes. teemperor marked an inline comment as done. Closed by commit rG00764c36edf8: [lldb] Add support for evaluating expressions in static member functions (authored by teemperor). Herald added a project: LLDB. Herald added a subs

[Lldb-commits] [lldb] 00764c3 - [lldb] Add support for evaluating expressions in static member functions

Author: Raphael Isemann Date: 2021-04-22T12:14:31+02:00 New Revision: 00764c36edf88ae9806e8d57a6addb782e6ceae8 URL: https://github.com/llvm/llvm-project/commit/00764c36edf88ae9806e8d57a6addb782e6ceae8 DIFF: https://github.com/llvm/llvm-project/commit/00764c36edf88ae9806e8d57a6addb782e6ceae8.dif

[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

jankratochvil added a comment. It has caused a regression for Fedora buildbot (which is so far a silent one): https://lab.llvm.org/staging/#/builders/16/builds/4936 Failed Tests (2): lldb-api :: tools/lldb-vscode/attach/TestVSCode_attach.py lldb-api :: tools/lldb-vscode/launch/TestVSCod