Author: Raphael Isemann Date: 2021-04-22T14:11:01+02:00 New Revision: e3dd82ae3c4edaeb3c8f835c29566375ee25023d
URL: https://github.com/llvm/llvm-project/commit/e3dd82ae3c4edaeb3c8f835c29566375ee25023d DIFF: https://github.com/llvm/llvm-project/commit/e3dd82ae3c4edaeb3c8f835c29566375ee25023d.diff LOG: [lldb] Don't leak LineSequence in PDB parsers `InsertSequence` doesn't take ownership of the pointer so releasing this pointer is just leaking memory. Follow up to D100806 that was fixing other leak sanitizer test failures Reviewed By: JDevlieghere Differential Revision: https://reviews.llvm.org/D100846 Added: Modified: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp b/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp index 24b4c64a91bcf..9f48f84f51ef6 100644 --- a/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp +++ b/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp @@ -1039,7 +1039,7 @@ static void TerminateLineSequence(LineTable &table, table.AppendLineEntryToSequence(seq.get(), base_addr + block.CodeSize, last_line, 0, file_number, false, false, false, false, true); - table.InsertSequence(seq.release()); + table.InsertSequence(seq.get()); } bool SymbolFileNativePDB::ParseLineTable(CompileUnit &comp_unit) { diff --git a/lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp b/lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp index befc08158cea4..0f0757ebc9ced 100644 --- a/lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp +++ b/lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp @@ -1813,7 +1813,7 @@ bool SymbolFilePDB::ParseCompileUnitLineTable(CompileUnit &comp_unit, sequence.get(), prev_addr + prev_length, prev_line, 0, prev_source_idx, false, false, false, false, true); - line_table->InsertSequence(sequence.release()); + line_table->InsertSequence(sequence.get()); sequence = line_table->CreateLineSequenceContainer(); } _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
