wallace added inline comments.
================
Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py:939
if log_file:
adaptor_env['LLDBVSCODE_LOG'] = log_file
self.process = subprocess.Popen([executable],
----------------
JDevlieghere wrote:
> Should this be `LLDB_VSCODE_LOG`, similar to
> `LLDB_VSCODE_TEST_STDOUT_STDERR_REDIRECTION`? Most of our environment
> variables begin with `LLDB_` so I think that would be most consistent.
I agree with you, but it might be hard to change it, as that might break some
users' flow. The env var is also used inside of lldb-vscode.cpp itself
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99974/new/
https://reviews.llvm.org/D99974
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
