mgorny added inline comments.
================
Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:932
+
+ std::unique_ptr<NativeProcessProtocol> child_process_up{child_process};
+ Extension expected_ext = is_vfork ? Extension::vfork : Extension::fork;
----------------
labath wrote:
> Store directly into unique_ptr<NativeProcessLinux> above.
Heh, I suppose it started working because we no longer pass-by-reference to
`NewSubprocess()`. Cool!
================
Comment at: lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp:401-402
+ m_stop_info.reason = StopReason::eStopReasonFork;
+ m_stop_info.details.fork.child_pid = child_pid;
+ m_stop_info.details.fork.child_tid = child_pid;
+}
----------------
labath wrote:
> duplicated
Sure but that's only on Linux. FreeBSD and NetBSD use distinct thread IDs.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100208/new/
https://reviews.llvm.org/D100208
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
