mib marked 9 inline comments as done. mib added inline comments.
================ Comment at: lldb/include/lldb/Utility/SourceLocationSpec.h:160 + /// file_spec and line number. An empty \a pattern matches everything. + static bool Match(const SourceLocationSpec &pattern, + const SourceLocationSpec &location); ---------------- JDevlieghere wrote: > Would it make sense to merge this into Equal and replace the bool with an > enum value that represents > > - file + line must match, > - file + line + col must match, > - file + line + col must match if lhs has it? I simplified the API removing the `Match` method since it's the same as calling `Exact` with `bool full = false`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
