Re: [PATCH] qe: add function qe_clock_source

2007-10-09 Thread Timur Tabi
better because you can use the real name of the clock source in the DTS. That keeps the DTS from having to know the internal representation of clock sources. (BTW, when I said "I just understand", I meant "I just don't understand".)

[PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree properties

2007-10-10 Thread Timur Tabi
, 836x, and 8568 have been updated to contain the new property names only. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- This patch applies to Kumar's for-2.6.24 branch, on top of my other patch titled "qe: add function qe_clock_source". arch/powerpc/boot/dts/m

[PATCH 1/2] qe: add function qe_clock_source

2007-10-10 Thread Timur Tabi
with rx-clock-name and tx-clock-name, which use strings instead of numbers to indicate QE clock sources. Update qe_setbrg() to take an enum qe_clock instead of an integer as its first paramter. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- This patch applies to Kumar's for-2.6.24 bra

[PATCH 0/2] QE clock source improvements

2007-10-10 Thread Timur Tabi
This patch set adds a new property to make specifying QE clock sources easier, adds a function to help parse the property, updates some other functions to use an enum instead of an integer, and updates the ucc_geth driver to take advantage of all this.

[PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree properties

2007-10-10 Thread Timur Tabi
, 836x, and 8568 have been updated to contain the new property names only. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- This patch applies to Kumar's for-2.6.24 branch, on top of my other patch titled "qe: add function qe_clock_source". arch/powerpc/boot/dts/m

[PATCH 1/2] qe: add function qe_clock_source

2007-10-10 Thread Timur Tabi
with rx-clock-name and tx-clock-name, which use strings instead of numbers to indicate QE clock sources. Update qe_setbrg() to take an enum qe_clock instead of an integer as its first paramter. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- This patch applies to Kumar's for-2.6.24 bra

Re: [PATCH 0/2] QE clock source improvements

2007-10-10 Thread Timur Tabi
Sorry, please ignore this set. Something got screwed up with the patches. I'm going to resend. Timur Tabi wrote: > This patch set adds a new property to make specifying QE clock sources > easier, adds a function to help parse the property, updates some other > functions to use a

[PATCH 0/2] QE clock source improvements

2007-10-10 Thread Timur Tabi
(Replaces all previous versions of this patch) This patch set adds a new property to make specifying QE clock sources easier, adds a function to help parse the property, updates some other functions to use an enum instead of an integer, and updates the ucc_geth driver to take advantage of all thi

[PATCH 1/2] qe: add function qe_clock_source

2007-10-10 Thread Timur Tabi
with rx-clock-name and tx-clock-name, which use strings instead of numbers to indicate QE clock sources. Update qe_setbrg() to take an enum qe_clock instead of an integer as its first paramter. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- This patch applies to Kumar's for-2.

[PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree properties

2007-10-10 Thread Timur Tabi
, 836x, and 8568 have been updated to contain the new property names only. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- This patch applies to Kumar's for-2.6.24 branch, on top of my other patch titled "qe: add function qe_clock_source". arch/powerpc/boot/dts/mpc832x_mds.

Re: powerpc commits for 2.6.24

2007-10-11 Thread Timur Tabi
Kumar Gala wrote: > Just to clarify, are we closing 2.6.24 for new code after you send > Linus a pull request or are we still taking things during the two > week merge window? I certainly hope the window isn't closed! I need another week to get my UART driver in. -- Ti

Re: [PATCH v2 2/7] rheap: Changes config mechanism

2007-10-15 Thread Timur Tabi
Kumar Gala wrote: > I don't see why we can't let users select it (saying that > differently, we should let users have this ability) If you turn on the QE but don't turn on RHEAP, the build will fail. Do we want to allow that? -- Timur Tabi Linux Kernel

Re: [PATCH v2 2/7] rheap: Changes config mechanism

2007-10-15 Thread Timur Tabi
Kumar Gala wrote: >> If you turn on the QE but don't turn on RHEAP, the build will fail. >> Do we want to allow that? > > nope. Is there any way to force RHEAP to be selected when it's a user-selectable option? -- Timur Tabi Linux

Re: [PATCH 1/4 V2] booting-without-of for Freescale MSI

2008-05-09 Thread Timur Tabi
Grant Likely wrote: > But here, you are only adding section t) That's because r) and s) already exist. The person who added those sections didn't update the TOC. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev

Re: [PATCH 3/3] [POWERPC] 86xx: mpc8610_hpcd: use ULI526X driver for on-board ethernet

2008-05-09 Thread Timur Tabi
to mount NFS filesystem: Acked-By: Timur Tabi <[EMAIL PROTECTED]> After applying this patch and Anton's two ULI driver patches, the ULI drivers works great on an 8610HPCD. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev ma

[PATCH] Update defconfig for MPC8610 HPCD

2008-05-09 Thread Timur Tabi
buffers. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- Support for the Freescale generic DMA driver will have to wait until 2.6.27 because the current audio driver for the 8610 is incompatible with it. arch/powerpc/configs/mpc8610_hpcd_defconfig | 306 +++ 1 files c

Re: [PATCH] Add null pointer check to of_find_property

2008-05-12 Thread Timur Tabi
Timur Tabi wrote: > Update function of_find_property() to return NULL if the device_node passed > to it is also NULL. Otherwise, passing NULL will cause a null pointer > dereference. > > Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> Paul, please pick this up for 2.6.2

Re: [PATCH 1/3] [WATCHDOG] mpc83xx_wdt: add support for MPC86xx CPUs

2008-05-12 Thread Timur Tabi
Scott Wood wrote: It avoids confusion. I vote for renaming. Me too. How about fsl_wdt.c? Or we could come up with a name for that particular WDT device, like we did with the 85xx DMA controller. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs

Re: [PATCH 1/3] [WATCHDOG] mpc83xx_wdt: add support for MPC86xx CPUs

2008-05-12 Thread Timur Tabi
Anton Vorontsov wrote: On Mon, May 12, 2008 at 04:01:06PM -0500, Timur Tabi wrote: Scott Wood wrote: It avoids confusion. I vote for renaming. Me too. How about fsl_wdt.c? fsl_wdt sounds too generic, I think it would conflict with at least booke_wdt.c.. no? Yeah, that makes sense

Re: [PATCH 1/3] [WATCHDOG] mpc83xx_wdt: add support for MPC86xx CPUs

2008-05-12 Thread Timur Tabi
Anton Vorontsov wrote: They're completely different watchdogs... But the drivers both generally do the same thing, just with different timers? I think the best option is to just pick a name for the IP block that mpc83xx_wdt.c supports and use that name for the driver as well. __

Re: [PATCH 1/3] [WATCHDOG] mpc83xx_wdt: add support for MPC86xx CPUs

2008-05-12 Thread Timur Tabi
Anton Vorontsov wrote: I don't know the IP block name... what is it for the 83xx/86xx watchdogs? My point was that we developers should just pick a name and run with it. That's where the name "Elo" came from. None of official Freescale documentation calls the DMA controller on 85xx parts "

[PATCH v2] Update defconfig for MPC8610 HPCD

2008-05-13 Thread Timur Tabi
buffers. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- Support for the Freescale generic DMA driver will have to wait until 2.6.27 because the current audio driver for the 8610 is incompatible with it. arch/powerpc/configs/mpc8610_hpcd_defconfig | 309 +++ 1 files c

New-style I2C driver not getting probed because of_register_i2c_devices() is not setting info.driver_name

2008-05-14 Thread Timur Tabi
river_name. I don't understand why this code doesn't work for me. Most of the core I2C code has been in place for a year, and I can't see how my driver is different from any other new-style I2C driver that works on OF platforms. Can anyone help me? -- Timur Tabi

[PATCH] CS4270 node is misplaced in the MPC8610 device tree

2008-05-14 Thread Timur Tabi
The CS4270 is using the second I2C bus, not the first, on the Freescale MPC8610 HPCD, so its node in the device tree belongs under '[EMAIL PROTECTED]' and not '[EMAIL PROTECTED]'. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- Kumar, this is a must-fix for 2.6.26.

Re: Patches added to powerpc.git powerpc-next branch

2008-05-15 Thread Timur Tabi
r MPC8610 HPCD -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] Add warning for unrecognized I2C nodes in the device tree

2008-05-15 Thread Timur Tabi
Update of_find_i2c_driver in fsl_soc.c to display a warning message if an I2C node in the device tree isn't found in the i2c_devices[] array. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/fsl_soc.c |4 1 files changed, 4 insertions(+), 0 deletions(-)

[PATCH] Add CS4270 i2c data to fsl_soc.c

2008-05-15 Thread Timur Tabi
The i2c_devices[] array in fsl_soc.c lists all the I2C nodes that are supported on Freescale boards. Add an entry for the Cirrus Logic CS4270 so that a new-style CS4270 driver will work. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/fsl_soc.c |1 + 1 files chan

Re: Patches added to powerpc.git powerpc-next branch

2008-05-19 Thread Timur Tabi
k to of_find_property I have code in the ASoC repository that depends on this patch. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Patches added to powerpc.git powerpc-next branch

2008-05-19 Thread Timur Tabi
Timur Tabi wrote: > I don't want to nag, but I would like to know if and when you're planning on > pulling this patch of mine: Sorry, never mind. I just noticed that they've been pulled already. I didn't see your email about them. I must remember to check the g

Re: [PATCH] CS4270 node is misplaced in the MPC8610 device tree

2008-05-19 Thread Timur Tabi
Timur Tabi wrote: > The CS4270 is using the second I2C bus, not the first, on the Freescale > MPC8610 HPCD, so its node in the device tree belongs under '[EMAIL PROTECTED]' > and not '[EMAIL PROTECTED]'. > > Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> P

Re: [PATCH] CS4270 node is misplaced in the MPC8610 device tree

2008-05-19 Thread Timur Tabi
which of the two inputs to use. It does not bridge. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] CS4270 node is misplaced in the MPC8610 device tree

2008-05-19 Thread Timur Tabi
Timur Tabi wrote: > Anton Vorontsov wrote: > >> Hm... this should be controlled by the PIXIS' BRDCFG0's I2CSPAN and >> SERSEL bits: > > Since these pins should not have changed from one kernel version to another, > it > doesn't explain how my devi

Re: [PATCH 1/7] [POWERPC] sysdev: implement FSL GTM support

2008-05-20 Thread Timur Tabi
FIG_QUICC_ENGINE is user-selectable. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: .dtb file for mpc8641_hpcn failing on recent kernel/u-boot.

2008-05-20 Thread Timur Tabi
U-Boot that everyone knows about but no one is fixing. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: .dtb file for mpc8641_hpcn failing on recent kernel/u-boot.

2008-05-20 Thread Timur Tabi
, it's needed for any modern U-boot. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH v3][POWERPC] Update defconfig for MPC8610 HPCD

2008-05-20 Thread Timur Tabi
buffers. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- v3: enabled CONFIG_SYSVIPC. It was disabled for some reason Support for the Freescale generic DMA driver will have to wait until 2.6.27 because the current audio driver for the 8610 is incompatible with it. arch/powerpc/c

[PATCH v4][POWERPC] Update defconfig for MPC8610 HPCD

2008-05-20 Thread Timur Tabi
buffers. Enable SYSV IPC and OSS plugin support, which are needed for some OSS apps. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- v4: turn on CONFIG_SND_PCM_OSS_PLUGINS, which apparently works now Support for the Freescale generic DMA driver will have to wait until 2.6.27 because the c

Re: [PATCH 5/7] [POWERPC] 83xx: new board support: MPC8360E-RDK

2008-05-23 Thread Timur Tabi
Anton Vorontsov wrote: 3. QE Serial UCCs (tested to not work with ucc_uart driver, reason unknown, yet); How far did you get on debugging this? -- Timur Tabi Linux Kernel Developer @ Freescale ___ Linuxppc-dev mailing list Linuxppc-dev

[PATCH] Fix DMA nodes in the MPC8610 HPCD device tree

2008-05-30 Thread Timur Tabi
The node for DMA2 in the MPC8610 HPCD device tree has the wrong compatible properties. This breaks the DMA driver and the sound driver. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- I have no idea how I let this bug slip in, but this is a must-fix for 2.6.26. arch/powerpc/bo

[PATCH][POWERPC] Update fsl_soc to use cell-index property of I2C nodes

2008-06-02 Thread Timur Tabi
The Freescale MPC8610 ASoC V2 sound drivers are an example. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- This patch is for Kumar's powerpc-next branch. arch/powerpc/sysdev/fsl_soc.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/sysdev/

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-04 Thread Timur Tabi
: any driver that currently checks for index should first check cell-index, and any device tree that has index should add cell-index. In time, we can remove 'index' from the device trees. -- Timur Tabi Linux kernel developer at Freescale ___

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
ot; and/or unit address. I think we should just expand the definition of cell-index to include standard device enumeration for when it's needed. The original definition is too limited, IMHO. -- Timur Tabi Linux kernel developer at Freescale ___ Li

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
ke I said earlier, I'm in favor of expanding the definition of "cell-index". -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
e_register_simple(). Otherwise, it just keeps count of each node, and uses that count. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
e codec driver uses the adapter->nr variable. The patch I posted ensures that the two contain the same number. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
SI controllers on Freescale parts use cell-index to enumerate them. It just seems dumb to invent a new property. Will there ever be a situation where a node will contain "cell-index" and "linux,i2c-index"? -- Timur Tabi Linux kernel developer at Freescale __

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
the other hand, knows nothing about OF. It just knows whatever is passed to its I2C probe function, i.e. the i2c_adapter and i2c_client structures. So in order for the two drivers to be able to link to each other, there needs to be some code that takes data from the device tree and places it int

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
different codecs. So I could have any number of codec drivers loaded. How would I know which exported API to call? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
with a new property to provide system-level indexing, but it needs to be the same property name for each type of device. I don't want linux,i2c-index and linux,dma-index and linux,ssi-index, etc. I also don't understand why we need the linux, prefix, since device enumeration is not speci

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
ir I2C (or whatever) devices. For instance, in order to do audio playback on an MPC8610, SSI1 needs to use DMA channel 0. The SSI driver specifically needs to find the register addresses for DMA channel 0. -- Timur Tabi Linux kernel developer at Freescale _

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
driver, they cannot be dynamically assigned. I2C1 must be labeled as such. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
ch sees only I2C information, know that it's at e0003100? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
lking about every device. It's the same problem for every device. Making this problem I2C-specific is not going to solve anything. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
have to scan the aliases node and do a comparison of each phandle, one at a time, until I find a match? And when I find a match, will I need to do sscanf() in order to extract the actual index value from the property? -- Timur Tabi Linux kernel develo

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-06 Thread Timur Tabi
David Gibson wrote: Aliases aren't trivially reversible, but it shouldn't be too hard to write a helper function which will do the scan and parse you describe. How about I submit a patch adding a function called "of_get_aliased_index()"? -- Timur Tabi Linux Kernel D

Re: Using DMA interrupt on MPC8313

2008-06-13 Thread Timur Tabi
Ron Madrid wrote: I don't know why request_irq is succeeding when the fsldma and dmaengine drivers are installed. I'm using the same dts in both cases. At this point, my only suggestion is to debug the request_irq() call and see what exactly fails.

Re: Using DMA interrupt on MPC8313

2008-06-16 Thread Timur Tabi
Ron Madrid wrote: So are you implying that the request_irq function should work without any other initialization function before it? No, I'm saying that you'll get a more accurate assessment of why it fails if you see where it returns an error code. __

Re: Using DMA interrupt on MPC8313

2008-06-16 Thread Timur Tabi
Ron Madrid wrote: > I don't see a "dma" node in the mpc8377mds.dts (2.6.25). I found one in > mpc8610_hpcd.dts and > modeled it after that. The DMA hardware on the 8610 is not the same as the DMA hardware on 83xx chips. You should copy the DMA data from another 83xx DT

Re: rh_init exported twice (rheap vs. dm-region_hash)

2008-06-23 Thread Timur Tabi
eap.c to rheap_xxx. I also think renaming the rh_ calls to rhash is a good idea. -- Timur Tabi Linux Kernel Developer @ Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] fsl-diu-fb: Update Freescale DIU driver to use page_alloc_exact()

2008-06-24 Thread Timur Tabi
Update the Freescale DIU driver to use page_alloc_exact() to allocate a DMA buffer. This also eliminates the rheap-based memory allocator. We can do this now because commit 6ccf61f9 allows us to allocate 8MB physically- contiguous memory blocks. Signed-off-by: Timur Tabi <[EMAIL PROTEC

[PATCH] powerpc: fix ALSA options in Freescale 85xx and 86xx defconfigs

2008-06-24 Thread Timur Tabi
The defconfigs for Freescale 85xx and 86xx SOCs had bad choices for some audio related options. In particular, OSS emulation should be enabled, and the old ALSA API should be disabled. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- Kumar, this patch is for 2.6.27. arch/powerpc/config

[PATCH v2] powerpc: fix ALSA options in Freescale 85xx and 86xx defconfigs

2008-06-24 Thread Timur Tabi
The defconfigs for Freescale 85xx and 86xx SOCs had bad choices for some audio related options. In particular, OSS emulation should be enabled, and the old ALSA API should be disabled. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- Kumar, this version excludes the change for the 8610,

[PATCH] powerpc: remove CS4270 i2c data from fsl_soc.c

2008-06-24 Thread Timur Tabi
patch reverts commit 64f9b5ee17ee7974d7cc58d75221432d86960ba3. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- This patch is for Kumar's powerpc-next branch. arch/powerpc/sysdev/fsl_soc.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/sysdev/

Do we still need devtree_lock?

2008-06-24 Thread Timur Tabi
} } read_unlock(&devtree_lock); But the comment for devtree_lock says this: extern rwlock_t devtree_lock; /* temporary while merging */ Since arch/ppc is going away, does this meant that the lock can go away do? -- Timur Tabi Linux kernel developer at Freescale __

[PATCH] powerpc: add of_find_next_property and of_get_aliased_index

2008-06-25 Thread Timur Tabi
ot; node and returns the index of the property that points to a given node. That is, if you have an alias "serial2" that points to a serial port node, of_get_aliased_index() returns "2". Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- This patch is for 2.6.27. It applies

Re: [PATCH] powerpc: add of_find_next_property and of_get_aliased_index

2008-06-25 Thread Timur Tabi
vs. "index" vs. no index in I2C device nodes' thread is that aliases are to be used to enumerate devices. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-25 Thread Timur Tabi
of_i2c.c is going to come "online" replace what's in fsl_soc.c? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: add of_find_next_property and of_get_aliased_index

2008-06-26 Thread Timur Tabi
ook up the alias by the > device -- there is no 1-1 mapping from device to alias! Hmmm, I hadn't through about that. I guess this patch isn't such a great idea after all. I rescind it. -- Timur Tabi Linux kernel developer at Freescale ___

Re: [PATCH] powerpc: add of_find_next_property and of_get_aliased_index

2008-06-26 Thread Timur Tabi
Stefan Roese wrote: > On Thursday 26 June 2008, Timur Tabi wrote: >>> The only thing a platform should ever use aliases for is if it needs >>> to (for whatever purpose) find a specific device, that it cannot >>> identify otherwise (via "reg", ...). And th

Re: [PATCH] powerpc: add of_find_next_property andof_get_aliased_index

2008-06-26 Thread Timur Tabi
Sean MacLennan wrote: > On Thu, 26 Jun 2008 10:55:14 -0500 > "Timur Tabi" <[EMAIL PROTECTED]> wrote: > >> Well, there's a lot of disagreement on this subject. Not only do we >> not agree on a method of enumerating devices, a lot of people have a >>

Re: [PATCH] fsl-diu-fb: Update Freescale DIU driver to use page_alloc_exact()

2008-07-04 Thread Timur Tabi
On Jun 30, 2008, at 4:24 PM, Andrew Morton wrote: This is also incorrect. We cannot pass u64 or uint64_t into printk at all. We do not know what type the architectures uses to implement them. It should be cast to a known type. In this case `unsigned long long'. Ok, I'll fix these, but I'm

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-04 Thread Timur Tabi
[EMAIL PROTECTED] { // PSC2 compatible = "fsl,mpc5200b-psc-i2s","fsl,mpc5200-psc-i2s"; cell-index = <1>; cell-index should be zero-based, not one-based. ___ Linuxppc-dev mailing list Linuxppc-dev@ozl

Re: [alsa-devel] [PATCH 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers

2008-07-04 Thread Timur Tabi
On Jul 3, 2008, at 12:33 PM, Grant Likely wrote: Yes, but you hadn't written these functions when I wrote this helper. :-P. I believe ASoC v2 makes all this stuff unnecessary, but I'm waiting for v2 to hit mainline before I port forward. FYI, it took me about a month to port my drivers to AS

Re: [PATCH 1/2] Convert i2c-mpc from a platform driver into a of_platform driver, V4

2008-07-10 Thread Timur Tabi
On Jul 9, 2008, at 1:22 PM, Grant Likely wrote: On Mon, Jun 30, 2008 at 5:01 PM, Jon Smirl <[EMAIL PROTECTED]> wrote: Convert i2c-mpc to an of_platform driver. Utilize the code in drivers/of-i2c.c to make i2c modules dynamically loadable by the device tree. Timur, can you please test this

Re: [alsa-devel] [PATCH v2 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers

2008-07-14 Thread Timur Tabi
Jon Smirl wrote: > Which are we going to call it, fabric or machine? Fabric. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH v2 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers

2008-07-14 Thread Timur Tabi
t;> on the Apple code in sound/aoa. It is called fabric in that code. The >> equivalent driver is called machine in ASoC v1. > > ASoC has always called it a machine driver. Wait, I thought it's supposed to be called a fabric driver now? On PowerPC, it should be called a fabric driver

Re: [RFC] [PATCH] task_pt_regs for powerpc systems

2008-07-14 Thread Timur Tabi
Srinivasa D S wrote: > +#define task_pt_regs(tsk)(tsk)->thread.regs Shouldn't this be: #define task_pt_regs(tsk) ((tsk)->thread.regs) just to be safe? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-de

[PATCH] fix QE firmware uploading limit

2008-03-03 Thread Timur Tabi
Fix a typo in qe_upload_firmware() that prevented uploading firmware on systems with more than one RISC core. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- This patch is for 2.6.25. arch/powerpc/sysdev/qe_lib/qe.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff -

Re: Trouble with SCC UART ports when moving from ppc to powerpc

2008-03-07 Thread Timur Tabi
n cpm_common.c are a bunch of functions to manage memory allocated of the DPRAM. You might want to see who's using those functions, and how. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Confused about usercopy_64.c

2008-03-10 Thread Timur Tabi
urn n; } If access_ok() returns false, then that means that we cannot copy the data from user-space. So why are we returning 'n'? Shouldn't we return zero, to let the caller know that the function failed? -- Timur Tabi Linux kernel de

Re: [PATCH] [POWERPC] 83xx: MPC837xRDB's VSC7385 ethernet switch isn't on the MDIO bus

2008-03-17 Thread Timur Tabi
a bug where "ifconfig eth1 down" would cause a kernel panic if eth0 was also up. The root cause was a bug in rheap.c. However, this code was fixed a year ago. Could it be a similar bug? -- Timur Tabi Linux kernel developer at Freescale ___ Lin

Re: [PATCH] [POWERPC] 83xx: MPC837xRDB's VSC7385 ethernet switch isn't on the MDIO bus

2008-03-17 Thread Timur Tabi
Joakim Tjernlund wrote: > eth0 is also up, was it commit 4942bd80e83d13bf394df4a8109bee39d861820f > that fixed that bug? Yep. Unfortunately, I don't really know enough about the ucc_geth driver to know what could be wrong. I just noticed your message and remembered that old bug.

Re: [PATCH] [POWERPC] 83xx: MPC837xRDB's VSC7385 ethernet switch isn't on the MDIO bus

2008-03-18 Thread Timur Tabi
ernal bug report? If so, can you email me a detailed description of the problem? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] [POWERPC] 83xx: MPC837xRDB's VSC7385 ethernet switch isn't on the MDIO bus

2008-03-18 Thread Timur Tabi
great :) I have no control over that, sorry. You'll have to ask Jeff G or maybe Kumar to pick up those patches. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/2 v2] Driver for Freescale 8610 and 5121 DIU

2008-03-21 Thread Timur Tabi
errupt */ >> +out_be32(&(hw->int_mask), 0x1f); >> + >> +free_irq(irq, 0); >> +} > > and the free_irq() will go splat? Sorry, but I don't understand what's wrong with this code. We'll make the other changes you've suggested and repost. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/2 v2] Driver for Freescale 8610 and 5121 DIU

2008-03-24 Thread Timur Tabi
min -= min / 2; I guess this means that we reduce the amount of memory that can be available in order for the allocate to succeed. Considering that the amount of memory that we allocate is in the order of megabytes, and it really isn't that important, I would think that we don't

[PATCH] Enable CONFIG_FORCE_MAX_ZONEORDER for all PowerPC, and make selectable

2008-03-25 Thread Timur Tabi
than 4MB of physically contiguous memory. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- I tested this on a Freescale 8610 32-bit PowerPC system, and when I increased CONFIG_FORCE_MAX_ZONEORDER to 13, I was able to allocate 5MB of memory via __get_free_pages(), so this change should b

Re: [PATCH 4/5] i2c: MPC837xRDB Power Management and GPIO expander driver

2008-03-26 Thread Timur Tabi
Anton Vorontsov wrote: > +config MCU_MPC837XRDB > + tristate "MPC837XRDB MCU driver" > + depends on I2C && MPC837x_RDB && OF_GPIO The MPC8349E-mITX also has this chip. Can you include support for that board as well? -- Timur Tabi

Re: [PATCH] Enable CONFIG_FORCE_MAX_ZONEORDER for all PowerPC, and make selectable

2008-03-27 Thread Timur Tabi
Timur Tabi wrote: > This patch enables the FORCE_MAX_ZONEORDER Kconfig option for all PowerPC > systems. Previously, it was enabled only for 64-bit systems. We also make > the option selectable from the menu, so that the user can specify different > values. This is useful for 32

Re: [PATCH 1/2 v4] Driver for Freescale 8610 and 5121 DIU

2008-03-28 Thread Timur Tabi
Scott Wood wrote: > ...but not anywhere else. All user pointers should have a __user > annotation. Even in a typecast? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozla

Re: Commits added to powerpc.git master/powerpc-next branches

2008-04-01 Thread Timur Tabi
electable -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/2 v5] Add DIU platform code for MPC8610HPCD

2008-04-01 Thread Timur Tabi
Andrew Morton wrote: > The defconfig change gets almost 100% rejects and probably isn't > appropriate here and isn't very important. It's weird that you get rejects, but otherwise you're correct. defconfigs are just a convenience, anyway. -- Timur Tabi Linux ker

Re: [PATCH] Freescale QUICC Engine USB Host Controller

2008-04-03 Thread Timur Tabi
e just front-ends to the rheap code. But that's a problem for another time. > Well, there is Linux CLK API (somewhat similar to GPIO API), but PowerPC > doesn't use it yet. Yeah, I noticed that too. I'll add it to my to-do list, but I suspect that someone else will get ar

Re: Question on mpc52xx_common.c

2008-04-08 Thread Timur Tabi
Robert Schwebel wrote: > The ARM method of using just a device number is so much easier ... And I was going to suggest that the ARM guys should use device trees, too. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing l

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Timur Tabi
Kumar Gala wrote: > I'd prefer we use cell-index and not introduce "fsl,ucc". Yeah, me too. cell-index is the right property for the UCC number. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Timur Tabi
introduce "fsl,ucc". I'm ok with >> dropping device-id and model (its implied in the compatiable). > > Ok. Here it is. netdev and linux-serial Cc'ed. Do we want the first UCC to have a cell-index of 1? Maybe we should fix this off-by-one error once and for all,

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Timur Tabi
for device tree, since off by one is Linux implementation details. Fair enough. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Timur Tabi
e'll use compatible property instead. > - replace last occurrences of device-id with cell-index. > Drivers are modified for backward compatibility's sake. > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> Acked-by: Timur

Re: [PATCH 2/2] [POWERPC] UCC nodes cleanup

2008-04-11 Thread Timur Tabi
rse, this means all the code needs to change, since I think device-id is one-based. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/2] Driver for Freescale 8610 and 5121 DIU

2008-04-14 Thread Timur Tabi
of sync. What are the outstanding issues? I was under the impression that the latest patch (v5) resolved everything. In fact, the last email from you (dated 4/1) said that you picked it up, minus the defconfig. -- Timur Tabi Linux kernel dev

<    5   6   7   8   9   10   11   12   >