Some hosts (that is, FSL eSDHC) throw PIO interrupts during DMA
transfers, this causes tons of unneeded interrupts, and thus highly
degraded speed.
This patch modifies the driver so that now we only enable relevant
(DMA or PIO) interrupts during transfers.
Signed-off-by: Anton Vorontsov
tion.
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c | 19 ++-
drivers/mmc/host/sdhci.h |4
2 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index d668625..1c36a25 100644
--- a/drivers/mm
FSL eSDHC controllers losing signal/interrupt enable states after
reset, so we should re-enable them.
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c |7 +++
drivers/mmc/host/sdhci.h |2 ++
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host
FSL eSDHC controllers can support maximum block size up to 4096
bytes. The MBL (Maximum Block Length) field in the capabilities
register extended by one bit, and bits 13:15 in the block size
register reserved.
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c | 28
bits
that makes the patch difficult to reuse.
[1] http://lkml.org/lkml/2008/12/2/160
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c |6 ++
drivers/mmc/host/sdhci.h |4
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/driver
This patch adds a new driver: sdhci-of. The driver is similar to
the sdhci-pci, it contains common probe code, and controller-specific
ops and quirks.
So far there are only Freescale eSDHC ops and quirks.
Signed-off-by: Anton Vorontsov
Acked-by: Arnd Bergmann
---
drivers/mmc/host/Kconfig
On Fri, Feb 20, 2009 at 11:31:09AM -0600, Scott Wood wrote:
> Anton Vorontsov wrote:
>> diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts
>> b/arch/powerpc/boot/dts/mpc8377_mds.dts
>> index 3e3ec8f..c54b90d 100644
>> --- a/arch/powerpc/boot/dts/mpc8377_mds.dts
>
igned-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c |3 +++
drivers/mmc/host/sdhci.h |2 ++
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index f63db25..eff615d 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/driver
cts?
It's certainly possible. Though, I'm not sure if it should be of_spi's
matter. Maybe some generic "SPI GPIO chip-selects" framework, and then
OF bindings for it...
Thanks,
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
___
always asserted (i.e. there is only one
device on the SPI bus), then..
>
> m25...@2 {
> compatible = "m25p80";
> spi-max-frequency = <2500>;
>
he wkup registers block;
else if (mpc5200_is_int(gpio))
write to the int registers block;
else
...
}
That is, the same thing we do for the interrupt controllers.
(Note that these "if"s can be replaced by a table, as in
arch/powerpc/sysdev/qe_lib/qe_ic.c).
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
mc-spi-slot-bindings.patch
The OF MMC SPI bindings themselves are in the latest Linus' tree
already:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/mmc/host/of_mmc_spi.c
For m25p80 chip you should do something similar.
Hope this helps,
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
nclear how can we use the quite short
GTM timers, and how do we want to expose the GTM to userspace).
Signed-off-by: Anton Vorontsov
---
This is corrected version, with i2c1 and esdhc nodes placed inside
the sleep-nexus, as suggested by Scott Wood.
arch/powerpc/boot/dts/mpc8377_mds.dts | 6
On Tue, Mar 03, 2009 at 11:57:46AM -0600, Scott Wood wrote:
> On Tue, Mar 03, 2009 at 07:02:01PM +0300, Anton Vorontsov wrote:
> > m...@24520 {
> > @@ -226,6 +244,8 @@
> > interrupt-parent = <&ipic>;
> >
therwise we may wrongly assume that MDIO controllers are
available during sleep.
Suggested-by: Scott Wood
Signed-off-by: Anton Vorontsov
---
On Tue, Mar 03, 2009 at 12:39:38PM -0600, Scott Wood wrote:
> Anton Vorontsov wrote:
>> On Tue, Mar 03, 2009 at 11:57:46AM -0600, Scott Wood wrote
On Sat, Feb 21, 2009 at 04:57:57PM +0100, Pierre Ossman wrote:
> On Fri, 13 Feb 2009 17:40:39 +0300
> Anton Vorontsov wrote:
>
> >
> > No, on eSDHC the registers are big-endian, 32-bit width, with, for
> > example, two 16-bit "logical" registers packed int
On Sat, Feb 21, 2009 at 04:58:44PM +0100, Pierre Ossman wrote:
> On Fri, 13 Feb 2009 17:47:39 +0300
> Anton Vorontsov wrote:
>
> > @@ -831,7 +832,12 @@ static void sdhci_prepare_data(struct sdhci_host
> > *host, struct mmc_data *data)
> > sdhci_set_transfer_irqs
On Sat, Feb 21, 2009 at 04:58:33PM +0100, Pierre Ossman wrote:
> On Fri, 13 Feb 2009 17:47:22 +0300
> Anton Vorontsov wrote:
>
> > SDHCI driver must take special care when working with "triggering"
> > registers on hosts with strict 32 bit addressing.
> >
On Sat, Feb 21, 2009 at 04:58:21PM +0100, Pierre Ossman wrote:
> On Fri, 13 Feb 2009 17:47:18 +0300
> Anton Vorontsov wrote:
>
> > @@ -1110,13 +1113,18 @@ static void sdhci_request(struct mmc_host *mmc,
> > struct mmc_request *mrq)
> >
> > host->mrq =
Acked-by: line for the sdhci-of patch.
- Kconfig help text improved (thanks to Matt Sealey and M. Warner Losh).
- In "sdhci: Add quirk to suppress PIO interrupts during DMA transfers"
patch: sdhci_init() now clears SDHCI_PIO_DISABLED flag, otherwise we
won't disable PIO interru
bit
width, with big-endian addressing. That is, readb(0x2f) should turn
into readb(0x2c), and readw(0x2c) should be translated to
le16_to_cpu(readw(0x2e)).
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c | 214 -
drivers/mmc/host/sdhci.h
()
- sdhci_unmask_irqs()
- sdhci_mask_irqs()
- SDHCI_INT_ALL_MASK constant
sdhci_enable_sdio_irq() converted to these new helpers, plus the
helpers will be used by the subsequent patches.
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c | 78
Some hosts (that is, FSL eSDHC) throw PIO interrupts during DMA
transfers, this causes tons of unneeded interrupts, and thus highly
degraded speed.
This patch modifies the driver so that now we only enable relevant
(DMA or PIO) interrupts during transfers.
Signed-off-by: Anton Vorontsov
ng to "debounce" card-detection
IRQs by reading present state and disabling particular interrupts. But
with this debouncing scheme I noticed that sometimes we miss card
insertion/removal events.
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c | 17 +++--
d
This patch adds SDHCI_QUIRK_INVERTED_WRITE_PROTECT quirk. When
specified, the sdhci driver will invert WP state.
p.s. Actually, the quirk is more board-specific than
controller-specific.
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c |2 ++
drivers/mmc/host/sdhci.h |2
a bug that makes sdhci_add_host()
return -ENODEV even if callbacks were specified. This is fixed now.
Signed-off-by: Ben Dooks
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c | 22 +++---
drivers/mmc/host/sdhci.h |2 ++
2 files changed, 17 insertions(+), 7 dele
bits
that makes the patch difficult to reuse.
[1] http://lkml.org/lkml/2008/12/2/160
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c |6 ++
drivers/mmc/host/sdhci.h |4
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/driver
igned-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c |3 +++
drivers/mmc/host/sdhci.h |2 ++
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index a476616..4382f53 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/driver
FSL eSDHC controllers losing signal/interrupt enable states after
reset, so we should re-enable them.
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c |7 +++
drivers/mmc/host/sdhci.h |2 ++
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host
With this patch we can
pin up the blksz to the maximum supported block size, i.e. 2048 bytes.
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c | 20 +---
drivers/mmc/host/sdhci.h |2 ++
2 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc
This patch adds a new driver: sdhci-of. The driver is similar to
the sdhci-pci, it contains common probe code, and controller-specific
ops and quirks.
So far there are only Freescale eSDHC ops and quirks.
Signed-off-by: Anton Vorontsov
Acked-by: Arnd Bergmann
---
drivers/mmc/host/Kconfig
the changes are needed? Did you
consider other solutions?
Thanks!
p.s.
> eliminates the assumption that the PHY for the FEC is always
> attached to the FEC's own MDIO bus. With this patch, the FEC can
> use a PHY attached to any MDIO bus if it is described in the device
> tree.
A
ct device_node *np)
{
const u32 *reg;
reg = of_get_property(np, "reg", NULL);
snprintf(name, MII_BUS_ID_SIZE, "%...@%x", np->name, reg ? *reg : 0);
}
...
gfar_mdio_bus_name(bus_name, mdio);
snprintf(priv->phy_bus_id, sizeof(priv->phy_bu
On Sun, Mar 08, 2009 at 03:11:21PM +0100, Pierre Ossman wrote:
> On Wed, 4 Mar 2009 20:49:17 +0300
> Anton Vorontsov wrote:
>
> > On Sat, Feb 21, 2009 at 04:58:21PM +0100, Pierre Ossman wrote:
> > > Just modify the if-clause and
> > > things will work
h).
- In "sdhci: Add quirk to suppress PIO interrupts during DMA transfers"
patch: sdhci_init() now clears SDHCI_PIO_DISABLED flag, otherwise we
won't disable PIO interrupts after suspend.
- New patch: "sdhci: Add type checking
bit
width, with big-endian addressing. That is, readb(0x2f) should turn
into readb(0x2c), and readw(0x2c) should be translated to
le16_to_cpu(readw(0x2e)).
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/Kconfig |7 ++
drivers/mmc/host/sdhci.c | 159 ++
()
- sdhci_unmask_irqs()
- sdhci_mask_irqs()
- SDHCI_INT_ALL_MASK constant
sdhci_enable_sdio_irq() converted to these new helpers, plus the
helpers will be used by the subsequent patches.
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c | 78
Some hosts (that is, FSL eSDHC) throw PIO interrupts during DMA
transfers, this causes tons of unneeded interrupts, and thus highly
degraded speed.
This patch modifies the driver so that now we only enable relevant
(DMA or PIO) interrupts during transfers.
Signed-off-by: Anton Vorontsov
ng to "debounce" card-detection
IRQs by reading present state and disabling particular interrupts. But
with this debouncing scheme I noticed that sometimes we miss card
insertion/removal events.
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c | 17 +++--
d
This patch adds SDHCI_QUIRK_INVERTED_WRITE_PROTECT quirk. When
specified, the sdhci driver will invert WP state.
p.s. Actually, the quirk is more board-specific than
controller-specific.
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c |2 ++
drivers/mmc/host/sdhci.h |2
a bug that makes sdhci_add_host()
return -ENODEV even if callbacks were specified. This is fixed now.
Signed-off-by: Ben Dooks
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c | 22 +++---
drivers/mmc/host/sdhci.h |2 ++
2 files changed, 17 insertions(+), 7 dele
bits
that makes the patch difficult to reuse.
[1] http://lkml.org/lkml/2008/12/2/160
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c |6 ++
drivers/mmc/host/sdhci.h |4
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/driver
igned-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c |3 +++
drivers/mmc/host/sdhci.h |2 ++
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 75d0ecb..cd6dab3 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/driver
FSL eSDHC controllers losing signal/interrupt enable states after
reset, so we should re-enable them.
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c |7 +++
drivers/mmc/host/sdhci.h |2 ++
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host
With this patch we can
pin up the blksz to the maximum supported block size, i.e. 2048 bytes.
Signed-off-by: Anton Vorontsov
---
drivers/mmc/host/sdhci.c | 20 +---
drivers/mmc/host/sdhci.h |2 ++
2 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc
This patch adds a new driver: sdhci-of. The driver is similar to
the sdhci-pci, it contains common probe code, and controller-specific
ops and quirks.
So far there are only Freescale eSDHC ops and quirks.
Signed-off-by: Anton Vorontsov
Acked-by: Arnd Bergmann
---
MAINTAINERS
>;
num-chips would be more appropriate, no?
> + chip-offset = <0x200>;
I believe this is from some old code...
Thanks!
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
_flags = *prop;
> + else
> + fun->wait_flags = (FSL_UPM_WAIT_RUN_PATTERN |
> + FSL_UPM_WAIT_WRITE_BYTE);
No need for parenthesis here.
Thanks,
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
_
nclear how can we use the quite short
GTM timers, and how do we want to expose the GTM to userspace).
Signed-off-by: Anton Vorontsov
---
arch/powerpc/boot/dts/mpc8377_mds.dts | 68 ---
arch/powerpc/boot/dts/mpc8377_rdb.dts | 98 +
arch/p
therwise we may wrongly assume that MDIO controllers are
available during sleep.
Suggested-by: Scott Wood
Signed-off-by: Anton Vorontsov
---
Changes since RFC:
- Don't use compatible = "simple-bus" for gianfar nodes.
arch/powerpc/boot/dts/mpc8315erdb.dts | 80 +
pm.c
> +++ b/drivers/mtd/nand/fsl_upm.c
> @@ -23,6 +23,8 @@
> #include
> #include
>
> +#define FSL_UPM_NAND_MAX_CHIPS 4
Is there any reason to hardcode max chips? Some obscure limit in the
UPMs maybe?
Otherwise we'd better allocate the rnb_gpios dynamically, depending
On Wed, Mar 18, 2009 at 08:41:17AM +0100, Wolfgang Grandegger wrote:
> Anton Vorontsov wrote:
> > On Tue, Mar 17, 2009 at 10:12:19AM +0100, Wolfgang Grandegegr wrote:
> >> From: Wolfgang Grandegger
> >>
> >> This patch adds support for multi-chip NAND devi
ranges = <0x0 0x24520 0x20>;
Yes, will change.
I was actually asking that q in RFC, i.e. whether we want
proper ranges or these stubs (I took stubs approach since
it's already in mpc8313_rdb device tree).
Thanks,
--
Anton Voront
he "reg" property to a full
address, and thus avoids the duplicate names.
Signed-off-by: Anton Vorontsov
---
This is for 2.6.30 since we don't use ranges = <> yet.
David, I believe Kumar would like to pick this patch into his tree
along with a patch set that adds "ranges = &l
On Wed, Mar 18, 2009 at 06:28:00PM +0300, Anton Vorontsov wrote:
> On Wed, Mar 18, 2009 at 08:21:18AM -0500, Kumar Gala wrote:
> [...]
> >> arch/powerpc/platforms/83xx/mpc834x_mds.c |1 +
> >> arch/powerpc/platforms/83xx/mpc837x_mds.c |1 +
> >> arch/pow
nclear how can we use the quite short
GTM timers, and how do we want to expose the GTM to userspace).
Signed-off-by: Anton Vorontsov
---
arch/powerpc/boot/dts/mpc8377_mds.dts | 68 ---
arch/powerpc/boot/dts/mpc8377_rdb.dts | 98 +
arch/p
therwise we may wrongly assume that MDIO controllers are
available during sleep.
Suggested-by: Scott Wood
Signed-off-by: Anton Vorontsov
---
arch/powerpc/boot/dts/asp834x-redboot.dts | 82 +++-
arch/powerpc/boot/dts/mpc8315erdb.dts | 80 +++
therwise we may wrongly assume that MDIO controllers are
available during sleep.
Suggested-by: Scott Wood
Suggested-by: Kumar Gala
Signed-off-by: Anton Vorontsov
---
arch/powerpc/boot/dts/gef_sbc310.dts | 39 ---
arch/powerpc/boot/dts/gef_sbc610.dts | 39 ---
arch/power
On Wed, Mar 18, 2009 at 03:05:51PM -0500, Scott Wood wrote:
> Anton Vorontsov wrote:
>> Currently it doesn't matter where the mdio nodes are placed, but with
>> power management support (i.e. when sleep = <> properties will take
>> effect), mdio nodes place
On Wed, Mar 18, 2009 at 11:23:44PM +0300, Anton Vorontsov wrote:
> On Wed, Mar 18, 2009 at 03:05:51PM -0500, Scott Wood wrote:
> > Anton Vorontsov wrote:
> >> Currently it doesn't matter where the mdio nodes are placed, but with
> >> power management support (i.e.
On Wed, Mar 18, 2009 at 03:31:29PM -0500, Scott Wood wrote:
> Anton Vorontsov wrote:
>> On Wed, Mar 18, 2009 at 11:23:44PM +0300, Anton Vorontsov wrote:
>>> I don't see any better solution, should I just leave the core1's
>>> mdio node intact?
>>
>
On Wed, Mar 18, 2009 at 03:35:11PM -0500, Scott Wood wrote:
> Anton Vorontsov wrote:
>> On Wed, Mar 18, 2009 at 03:31:29PM -0500, Scott Wood wrote:
>>> Anton Vorontsov wrote:
>>>> On Wed, Mar 18, 2009 at 11:23:44PM +0300, Anton Vorontsov wrote:
>>>>> I
On Wed, Mar 18, 2009 at 03:46:49PM -0500, Scott Wood wrote:
> Anton Vorontsov wrote:
>> I mean do you see any problem with giving Linux knowledge of
>> the -slave name?
>
> I guess I don't really see the point, compared with just having a naked
> mdio node. The p
he reason is: with distro (pre-compiled) kernels you don't have to
re-compile anything to make the drive work.
The other option is to enable BLK_DEV_IDE_PMAC_SHORTCABLE by default,
but I'm not sure if it's safe thing to do (most probably not).
Thanks for you work on this,
-
no member named
'dev'
drivers/net/gianfar.c: In function 'gfar_resume':
drivers/net/gianfar.c:601: error: 'struct gfar_private' has no member named
'dev'
make[2]: *** [drivers/net/gianfar.o] Error 1
Fix this by converting suspend and resume routines to use
ODEV status.
Fix this by adding "fsl,gianfar-tbi" to the list of known Gianfar
MDIO buses.
Signed-off-by: Anton Vorontsov
---
drivers/net/fsl_pq_mdio.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c
index b0
evice_probe+0x5c/0x84
...
This patch fixes the issue by translating the "reg" property to a full
address, and thus avoids the duplicate names.
Signed-off-by: Anton Vorontsov
---
On Thu, Mar 19, 2009 at 03:57:10AM -0500, Kumar Gala wrote:
[...]
>> This is for 2.6.30 since we don
On Wed, Mar 18, 2009 at 03:27:22PM -0500, Scott Wood wrote:
> Anton Vorontsov wrote:
>> On Wed, Mar 18, 2009 at 03:05:51PM -0500, Scott Wood wrote:
>>> Hmm, would that imply that the mdio underneath it is disabled as well?
>>
>> Technically, yes. In practice, M
nclear how can we use the quite short
GTM timers, and how do we want to expose the GTM to userspace).
Signed-off-by: Anton Vorontsov
---
arch/powerpc/boot/dts/mpc8377_mds.dts | 68 ---
arch/powerpc/boot/dts/mpc8377_rdb.dts | 98 +
arch/p
therwise we may wrongly assume that MDIO controllers are
available during sleep.
Suggested-by: Scott Wood
Signed-off-by: Anton Vorontsov
---
arch/powerpc/boot/dts/asp834x-redboot.dts | 82 +++-
arch/powerpc/boot/dts/mpc8315erdb.dts | 80 +++
therwise we may wrongly assume that MDIO controllers are
available during sleep.
Suggested-by: Scott Wood
Suggested-by: Kumar Gala
Signed-off-by: Anton Vorontsov
---
arch/powerpc/boot/dts/gef_ppc9a.dts| 39 ---
arch/powerpc/boot/dts/gef_sbc310.dts | 39 ---
arch/power
On Thu, Mar 19, 2009 at 03:57:10AM -0500, Kumar Gala wrote:
> On Mar 18, 2009, at 2:21 PM, Anton Vorontsov wrote:
[...]
>> Signed-off-by: Anton Vorontsov
>> ---
>>
>> This is for 2.6.30 since we don't use ranges = <> yet.
>>
>> David, I believe
only tracer that requires IRQFLAGS
support) still depends on TRACE_IRQFLAGS_SUPPORT Kconfig symbol.
Signed-off-by: Anton Vorontsov
---
kernel/trace/Kconfig |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index ee70841..774aba7
so that now only top-level Makefile has to know
about the new symbol, and the rest of the kernel can stay with
using CONFIG_FRAME_POINTER.
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
___
Linuxppc-dev mailing list
Lin
This patch introduces ARCH_HAS_NORMAL_FRAME_POINTERS Kconfig symbol.
When defined, the top level Makefile won't add -fno-omit-frame-pointer
cflag (the flag is useless in PowerPC kernels, and also makes gcc
generate wrong code).
Also move ARCH_WANT_FRAME_POINTERS's help text.
Signed-off
The workarounds aren't needed any longer since the top level Makefile
doesn't pass -fno-omit-frame-pointer cflag for PowerPC.
Signed-off-by: Anton Vorontsov
---
arch/powerpc/Makefile|5 -
arch/powerpc/kernel/Makefile | 12 ++--
ar
Irqsoff, switch and preempt tracers use CALLER_ADDR macros, so they
should select FRAME_POINTER. Otherwise traces are meaningless.
Signed-off-by: Anton Vorontsov
---
kernel/trace/Kconfig |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/Kconfig b/kernel
On Fri, Mar 20, 2009 at 07:44:04PM +0300, Anton Vorontsov wrote:
> Hi all,
>
> Here is another approach to fixing tracers vs. CALLER_ADDR problem
> on PowerPC.
>
> Preface for those who don't know or forgot what the problem is:
>
> Gcc frame pointers do nothi
On Fri, Mar 20, 2009 at 08:04:28PM +0100, Ingo Molnar wrote:
>
> * Anton Vorontsov wrote:
>
> > commit 40ada30f9621fbd831ac2437b9a2a399aad34b00 ("tracing: clean
> > up menu"), despite the "clean up" in its purpose, introduced
> > behavioural c
On Fri, Mar 20, 2009 at 08:43:56PM +0100, Joakim Tjernlund wrote:
> hmm, this mail didn't seem to reach the lists. Resending
>
> Jocke
> - Forwarded by Joakim Tjernlund/Transmode on 20/03/2009 20:42 -
>
> From:
> Joakim Tjernlund
> To:
> le...@freescale.com, net...@vger.kernel.org, linu
On Fri, Mar 20, 2009 at 08:57:43PM +0100, Ingo Molnar wrote:
>
> * Anton Vorontsov wrote:
>
> > On Fri, Mar 20, 2009 at 08:04:28PM +0100, Ingo Molnar wrote:
> > >
> > > * Anton Vorontsov wrote:
> > >
> > > > commit 40ada30f9621fbd831ac
I wish the patch would be a bit shorter, but it seems like the only
way to fix the issue in a sane way. Luckily, the patch has been
tested with real PHYs and fixed-link, so no further regressions
expected.
Reported-by: Joakim Tjernlund
Signed-off-by: Anton Vorontsov
Tested-by: Joakim Tjernlund
atches to make it work in 2.6.28.7. Just make sure your
.config file has following symbols enabled:
CONFIG_MMC_SDHCI=y
CONFIG_MMC_SDHCI_PCI=y
CONFIG_MMC_RICOH_MMC=y
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
___
Linuxppc
0x1000>;
interrupts = ;
interrupt-parent = <&ipic>;
// if needed, clock-frequency = ;
};
};
Note that I'm not sure what endiannes you'll get when connecting
/sdhci-of.c:181: warning: excess elements in struct
> initializer
> drivers/mmc/host/sdhci-of.c:181: warning: (near initialization for
> 'sdhci_esdhc.ops')
> make[3]: *** [drivers/mmc/host/sdhci-of.o] Error 1
> make[2]: *** [drivers/mmc/host] Error 2
> make[1]: *** [drivers/mmc]
scribing a cpu and a nor flash, though.
No support for interrupt- and gpio-controllers. And no support for
U-Boot, I just built the dtb file into the kernel).
I never got around to clean it up and send though, but for sure,
there is absolutely no reason to duplicate the code across the
platforms.
Thank
xception list or (better) implement TRACE_IRQFLAGS_SUPPORT.
Signed-off-by: Anton Vorontsov
---
On Sat, Mar 21, 2009 at 05:18:14PM +0100, Ingo Molnar wrote:
[...]
> > > > Surely I'll look into implementing irqflags tracing, but
> > > > considering that no one ever neede
= "eTSEC";
> compatible = "gianfar";
> reg = <0x25000 0x1000>;
> + ranges = <0x0 0x25000 0x1000>;
> local-mac-address = [ 00 00 00 00 00 00 ];
> interrupts = &l
This patch fixes following build error:
CC ucc_geth.o
ucc_geth.c: In function 'ucc_geth_probe':
ucc_geth.c:3644: error: implicit declaration of function 'uec_mdio_bus_name'
make[2]: *** [ucc_geth.o] Error 1
Signed-off-by: Anton Vorontsov
---
On Tue, Mar 24, 2009
it really
doesn't cause any issues under stress?
Thanks,
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
e == sizeof(uint32_t))
> + fun->chip_offset = *prop;
> +
> fun->io_base = devm_ioremap_nocache(&ofdev->dev, io_res.start,
> io_res.end - io_res.start + 1);
> if (!fun->io_base) {
> @@ -257,8 +303,10 @@ static int __devinit fun_probe(struct of_device *ofdev,
>
> return 0;
> err2:
> - if (fun->rnb_gpio >= 0)
> - gpio_free(fun->rnb_gpio);
> + for (i = 0; i < fun->num_chips; i++) {
> + if (fun->rnb_gpio[i] >= 0)
> + gpio_free(fun->rnb_gpio[i]);
> + }
> err1:
> kfree(fun);
>
> @@ -268,12 +316,15 @@ err1:
> static int __devexit fun_remove(struct of_device *ofdev)
> {
> struct fsl_upm_nand *fun = dev_get_drvdata(&ofdev->dev);
> + int i;
>
> nand_release(&fun->mtd);
> kfree(fun->mtd.name);
>
> - if (fun->rnb_gpio >= 0)
> - gpio_free(fun->rnb_gpio);
> +for (i = 0; i < fun->num_chips; i++) {
> +if (fun->rnb_gpio[i] >= 0)
> +gpio_free(fun->rnb_gpio[i]);
> +}
code indent should use tabs where possible (not white spaces).
When the cosmetic issues are fixed, I'll readily ack this patch.
Thanks!
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
;
> Signed-off-by: Wolfgang Grandegger
Acked-by: Anton Vorontsov
[...]
> + prop = of_get_property(ofdev->node, "fsl,upm-wait-flags", &size);
> + if (prop && size == sizeof(uint32_t))
> + fun->wait_flags = *prop;
> + else
olfgang Grandegger
> ---
To me it looks good.
Acked-by: Anton Vorontsov
> .../powerpc/dts-bindings/fsl/upm-nand.txt | 39
> +++-
> 1 files changed, 37 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/powerpc/dts-bindings/fsl/upm-nan
be32((u32 __iomem *)(bd+4)))
[...]
> + out_be32((u32 __iomem *)(bd+4), (int)NULL); /* Mark it free */
How about some inline function that will self-document the bd + 4
stuff? Plus that way we'll get rid of the casts.
Note that "bd+4" should be "bd + 4".
nnect NAND to the UPM. Of which only ~10 would be sane (others are
insane, and nobody would do this. If they do, _then_ we'll fall back
to -upm-nand scheme for a particular board).
I don't see any problem with fsl,upm-addr-line-cs-offsets. It can
describe any scheme in "addr li
>ug_info->bdRingLenTx[txQ]);
Line over 80 columns.
[...]
> + if (num_freed)
> + netif_wake_queue(dev); /* We freed some buffers, so restart
> transmission */
Ditto.
Please make sure your patches pass scripts/checkpatch.pl.
Thanks,
--
Anton Vorontsov
email
> Yes, I know. I did it this way because I something broke under stress
> when ugeth->confBd[txQ] instead. The ucc_geth_tx() and
> ucc_geth_start_xmit()
> gets out of sync somehow.
Would be great if you could investigate it more. Maybe there is
a serious bug somewhere, or maybe
uot;;
Yeah, that's definitely a good idea.
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
nect() call from ucc_geth_close() to
ucc_geth_stop(), so that we'll always disconnect the PHY.
Signed-off-by: Anton Vorontsov
---
drivers/net/ucc_geth.c | 21 +++--
1 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
i
On Fri, Mar 20, 2009 at 11:49:29PM -0400, Steven Rostedt wrote:
> Ben,
>
> Can you ACK this patch? Or even take it in your tree?
Benjamin, have you had a chance to look into this? Sam, could
you also take a look?
Thanks!
> On Fri, 2009-03-20 at 19:44 +0300, Anton Vorontsov wro
301 - 400 of 1893 matches
Mail list logo
