On Tue, Mar 17, 2009 at 10:12:21AM +0100, Wolfgang Grandegegr wrote: > From: Wolfgang Grandegger <w...@grandegger.com> > > The NAND flash on the TQM8548_BE modules requires a short delay after > running the UPM pattern. The TQM8548_BE requires a further short delay > after writing out a buffer. Normally the R/B pin should be checked, but > it's not connected on the TQM8548_BE. The existing driver uses similar > fixed delay points. To manage these extra delays in a more general way, > I introduced the "wait_flags" field allowing the board-specific driver > to specify various types of extra delay. > > Signed-off-by: Wolfgang Grandegger <w...@grandegger.com> > ---
Just a nitpick... > + prop = of_get_property(ofdev->node, "wait-flags", &size); > + if (prop && size == sizeof(uint32_t)) > + fun->wait_flags = *prop; > + else > + fun->wait_flags = (FSL_UPM_WAIT_RUN_PATTERN | > + FSL_UPM_WAIT_WRITE_BYTE); No need for parenthesis here. Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
