On Sun, Mar 08, 2009 at 03:11:21PM +0100, Pierre Ossman wrote:
> On Wed, 4 Mar 2009 20:49:17 +0300
> Anton Vorontsov <avoront...@ru.mvista.com> wrote:
>
> > On Sat, Feb 21, 2009 at 04:58:21PM +0100, Pierre Ossman wrote:
> > > Just modify the if-clause and
> > > things will work.
> >
> > That would look horrid...
> >
> > if ((!(host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION) &&
> > !(sdhci_readl(host, SDHCI_PRESENT_STATE) &
> > SDHCI_CARD_PRESENT)) ||
> > (host->flags & SDHCI_DEVICE_DEAD)) {
> >
>
> There are worse ones in that code, but I see your point. :)
>
> > > Might want to add a comment also to make it more obvious what the
> > > if-clause does.
> >
> > Let's try to avoid the if-clause above? How about this:
> >
>
> Looks ok.
>
> > @@ -1096,6 +1099,7 @@ out:
> > static void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq)
> > {
> > struct sdhci_host *host;
> > + bool present;
> > unsigned long flags;
> >
> > host = mmc_priv(mmc);
>
> Can we use bool in the kernel?
Sure, it's widely used in the kernel, even in such places as
mm/ or kernel/.
Thanks for the review!
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
