On Wed, Mar 25, 2009 at 11:08:20AM +0100, Wolfgang Grandegger wrote:
> This patch adds documentation for the new NAND FSL UPM bindings for:
> 
>  NAND: FSL-UPM: add multi chip support
>  NAND: FSL-UPM: Add wait flags to support board/chip specific delays
> 
> Signed-off-by: Wolfgang Grandegger <w...@grandegger.com>
> ---

To me it looks good.

Acked-by: Anton Vorontsov <avoront...@ru.mvista.com>

>  .../powerpc/dts-bindings/fsl/upm-nand.txt          |   39 
> +++++++++++++++++++-
>  1 files changed, 37 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/powerpc/dts-bindings/fsl/upm-nand.txt 
> b/Documentation/powerpc/dts-bindings/fsl/upm-nand.txt
> index 84a04d5..0272e70 100644
> --- a/Documentation/powerpc/dts-bindings/fsl/upm-nand.txt
> +++ b/Documentation/powerpc/dts-bindings/fsl/upm-nand.txt
> @@ -5,9 +5,22 @@ Required properties:
>  - reg : should specify localbus chip select and size used for the chip.
>  - fsl,upm-addr-offset : UPM pattern offset for the address latch.
>  - fsl,upm-cmd-offset : UPM pattern offset for the command latch.
> -- gpios : may specify optional GPIO connected to the Ready-Not-Busy pin.
>  
> -Example:
> +Optional properties:
> +- fsl,upm-wait-flags : add chip-dependent short delays after running the
> +                    UPM pattern (0x1), after writing a data byte (0x2)
> +                    or after writing out a buffer (0x4).
> +- gpios : may specify optional GPIOs connected to the Ready-Not-Busy pins
> +       (R/B#). For multi-chip devices, "num-chips" GPIO definitions are
> +       required.
> +- chip-delay : chip dependent delay for transfering data from array to
> +            read registers (tR). Required if property "gpios" is not
> +            used (R/B# pins not connected).
> +- num-chips : number of chips per device for multi-chip support.
> +- chip-offset : address offset between chips for multi-chip support. The
> +             corresponding address lines are used to select the chip.
> +
> +Examples:
>  
>  u...@1,0 {
>       compatible = "fsl,upm-nand";
> @@ -26,3 +39,25 @@ u...@1,0 {
>               };
>       };
>  };
> +
> +...@3,0 {
> +     compatible = "fsl,upm-nand";
> +     reg = <3 0x0 0x800>;
> +     fsl,upm-addr-offset = <0x10>;
> +     fsl,upm-cmd-offset = <0x08>;
> +     fsl,upm-wait-flags = <0x5>;
> +     /* Multi-chip device */
> +     num-chips = <2>;
> +     chip-offset = <0x200>;
> +     chip-delay = <25>; // in micro-seconds
> +
> +     n...@0 {
> +             #address-cells = <1>;
> +             #size-cells = <1>;
> +
> +             partit...@0 {
> +                         label = "fs";
> +                         reg = <0x00000000 0x10000000>;
> +             };
> +     };
> +};
> -- 
> 1.6.0.6

-- 
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to