da case, that points to pnv_pci_ioda_dma_get_required_mask()
(platforms/powernv/pci-ioda.c)
In the p5ioc2 case, the call chain remains the same -
dma_get_required_mask() does not find either a ppc_md call or
pci_controller_ops call, so it calls __dma_get_required_mask().
Signed-off-by: And
it's currently using the
hardware).
Cc: sta...@vger.kernel.org
Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
Signed-off-by: Andrew Donnellan
Signed-off-by: Daniel Axtens
---
drivers/misc/cxl/api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
the current code.
Sounds reasonable, I'll submit a V2.
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linu
api.c
@@ -59,7 +59,7 @@ EXPORT_SYMBOL_GPL(cxl_get_phys_dev);
int cxl_release_context(struct cxl_context *ctx)
{
- if (ctx->status != CLOSED)
+ if (ctx->status >= STARTED)
return -EBUSY;
put_device(&ctx->afu->dev);
--
Andrew Donnellan Softwar
explicit names of the arguments to the callbacks in
"struct pci_controller_ops" so that the code looks consistent.
Signed-off-by: Gavin Shan
Reviewed-by: Daniel Axtens
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.c
good to me.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mailing list
Li
Shan
Reviewed-by: Daniel Axtens
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
ot;powerpc/powernv: new function to access OPAL msglog")
Signed-off-by: Andrew Donnellan
---
arch/powerpc/platforms/powernv/opal-msglog.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/opal-msglog.c
b/arch/powerpc/platforms/powernv/opal-msglog.c
index 5
On 17/02/16 23:41, Michael Ellerman wrote:
I see you've posted a v3 since I merged this, please send an incremental patch
with the changes.
http://patchwork.ozlabs.org/patch/584416/
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Develo
the cxl
driver is not detecting it. Fix is to use the proper timebase-to-time
conversion.
Signed-off-by: Frederic Barrat
Cc: # 4.3+
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2
space. The error
message logged are of the form :
cxl-pci 0004:00:00.0: ABORTING: CXL VSEC not found!
cxl-pci 0004:00:00.0: cxl_init_adapter failed: -19
Cc: Ian Munsie
Cc: Frederic Barrat
Signed-off-by: Vaibhav Jain
Looks good to me.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan
On 09/02/16 10:57, Andrew Donnellan wrote:
It is a fix - I'm a bit hazy on the details now but IIRC, Daniel Axtens
and I encountered this when doing some cxl debugging, though I think we
decided not to tag this for stable since it was a secondary issue to the
primary bug we were looking fo
will never use this event, the ABI of the event is up to each individual
AFU driver.
Signed-off-by: Ian Munsie
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)
private data structures they may use.
Signed-off-by: Michael Neuling
Signed-off-by: Ian Munsie
Reviewed-by: Matthew R. Ochs
Looks good to me.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
ed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlab
On 10/03/16 12:18, Ian Munsie wrote:
On a related matter, we should send a patch to remove some of the
leftover config options that were added to smooth the merging of
cxlflash in the first place (CXL_KERNEL_API, CXL_EEH).
I'm happy to do that after this series is merged.
--
Andrew Donn
as unknown.
Signed-off-by: Russell Currey
Indeed it looks like there isn't a fallback case.
Would it be useful to print xstop_type in the unknown case?
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Develo
wn your machine you should be looking at the
OPAL firmware log anyway, which would contain details if there was
something "new".
That's fair, would primarily help debugging in the rather corner case of
new skiboot, old kernel, and no access to the OPAL log...
--
Andrew Donnellan
s for
userspace access")
Signed-off-by: Andrew Donnellan
---
Found by Coverity Scan.
Currently, this should only affect cxlflash.
---
drivers/misc/cxl/fault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/fault.c b/drivers/misc/cxl/fault.c
index 9a8
RTAS calls)
to see if there's been a hardware error.
Change the nargs/nret check to ensure nargs is <= 15, allowing room for the
status code. Users shouldn't be calling with nret == 0, but there's no real
harm if they do, so we don't stop them.
Signed-off-by: Andrew Donn
63)))
Should it be the top two bits?
benh told me that the top bit should be enough - anything above 0x8000*
should be kernel space.
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IB
e". We also use
"huge page", but "hugepage" is more common. Therefore I wouldn't call it
a spelling error, just an internal term :)
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
On 09/04/16 16:12, Aneesh Kumar K.V wrote:
Also note that the `~` operation is wrong.
Cc: Frederic Barrat
Cc: Andrew Donnellan
Acked-by: Ian Munsie
Signed-off-by: Aneesh Kumar K.V
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1
On 29/03/16 00:42, Aneesh Kumar K.V wrote:
I noticed this when doing radix support and have a variant posted at
https://lists.ozlabs.org/pipermail/linuxppc-dev/2016-March/141036.html
I'm happy for this to be fixed in your radix series.
--
Andrew Donnellan OzLabs, ADL Can
where blank space is required. The device may
only be accessed by a single process at a time.
Signed-off-by: Suraj Jitindar Singh
I reviewed an earlier version of this patch internally and Suraj has
fixed a bunch of issues which I raised. I'm not hugely experienced with
this, but all t
Make a couple more variables static. Found by sparse.
Signed-off-by: Andrew Donnellan
---
drivers/misc/cxl/flash.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/cxl/flash.c b/drivers/misc/cxl/flash.c
index 68dd0b7..c63d61e 100644
--- a/drivers/misc/cxl
(void *)afu, CXL_KTHREAD);
+ if (IS_ERR(afu->guest->kthread_tsk)) {
+ pr_devel("cannot start state kthread\n");
+ afu->guest->kthread_tsk = NULL;
}
- return 0;
+}
+
+void stop_state_thread(struct cxl_afu
t load.
A fix to the generic code is being investigated also.
Signed-off-by: Michael Neuling
cc: sta...@vger.kernel.org # 3.8
Tested on top of 4.6-rc3 using the genwqe-echo test utility[0].
Tested-by: Andrew Donnellan
[0]
https://github.com/ibm-genwqe/genwqe-user/blob/master/tools/gen
.
This polls the PSL to ensure that the PSL is clear of IRQs for the
detached context, before removing the context from the idr.
Signed-off-by: Michael Neuling
Tested on top of 4.6-rc3 using the genwqe-echo test utility[0].
Tested-by: Andrew Donnellan
[0]
https://github.com/ibm-genwqe/genwqe
Found by smatch.
Signed-off-by: Andrew Donnellan
---
arch/powerpc/kernel/eeh_pe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/eeh_pe.c b/arch/powerpc/kernel/eeh_pe.c
index eea48d8..f0520da 100644
--- a/arch/powerpc/kernel/eeh_pe.c
+++ b/arch/powerpc
mpic_init_sys() currently doesn't check whether
subsys_system_register() succeeded or not. Check the return code of
subsys_system_register() and clean up if there's an error.
Signed-off-by: Andrew Donnellan
---
Found by Coverity Scan. Build-tested only.
---
arch/powerpc/sysdev/
On 29/04/16 14:56, Alexey Kardashevskiy wrote:
When cfg_dbg() is enabled (i.e. mapped to printk()), gcc produces
errors as the __func__ parameter is missing (pnv_pci_cfg_read() has one);
this adds the missing parameter.
Signed-off-by: Alexey Kardashevskiy
Reviewed-by: Andrew Donnellan
ntext.
Check the CXL card's link status before setting DMA options or initialising
a default context. If the link is down, print a warning and return
immediately.
Signed-off-by: Andrew Donnellan
---
drivers/misc/cxl/vphb.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/driver
d single statements in
conditionals to avoid mistakes like this, but CodingStyle disagrees...)
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
ntext.
Check the CXL card's link status before setting DMA options or initialising
a default context. If the link is down, print a warning and return
immediately.
Signed-off-by: Andrew Donnellan
---
drivers/misc/cxl/vphb.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/driver
ntext.
Check the CXL card's link status before setting DMA options or initialising
a default context. If the link is down, print a warning and return
immediately.
Signed-off-by: Andrew Donnellan
---
drivers/misc/cxl/vphb.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/driver
nsert braces so that "return false" is within if block
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linux
Export pcibios_free_controller(), so it can be used by the cxl module to
free virtual PHBs.
Signed-off-by: Andrew Donnellan
---
arch/powerpc/kernel/pci-common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
index a1d0632
) but would simply die() and OOPS. It doesn't make sense to be
staggering on if we've just tried to reboot: we should panic().
Explicitly panic() on unrecovered MCEs on PowerNV.
Update the comments appropriately.
This fixes some hangs following EEH events on cxlflash setups.
Signed-off-by
On 25/09/15 05:44, Matthew R. Ochs wrote:
Add stanza for cxlflash SCSI driver.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Reviewed-by: Brian King
Reviewed-by: Andrew Donnellan
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b
s not require an embedded fops.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Li
issues. Update some comments for clarity and
consistency. Remove extra lines and a few unneeded variables/statements.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Reviewed-by: Brian King
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
Reviewed-by: Brian King
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev
Signed-off-by: Manoj N. Kumar
Reviewed-by: Brian King
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
clean.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Reviewed-by: Brian King
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia
Signed-off-by: Manoj N. Kumar
Reviewed-by: Brian King
The commit message could explain the patch a bit better.
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
and return codes.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Reviewed-by: Brian King
Reviewed-by: Andrew Donnellan
See further comments below.
--- a/drivers/scsi/cxlflash/main.c
+++ b/drivers/scsi/cxlflash/main.c
@@ -401,8 +401,7 @@ static void wait_resp(struct afu *afu
changes were made:
- pr_debug to pr_devel
- pr_debug to pr_debug_ratelimited
- pr_err to dev_err
- pr_debug to dev_dbg
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Reviewed-by: Brian King
Reviewed-by: Andrew Donnellan
Changes mostly look fine, further comments below
-by: Manoj N. Kumar
Reviewed-by: Brian King
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
-static to allow this.
Reported-by: Matthew R. Ochs
Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
Signed-off-by: Andrew Donnellan
Signed-off-by: Ian Munsie
---
drivers/misc/cxl/api.c | 1 +
drivers/misc/cxl/cxl.h | 1 +
drivers/misc/cxl/irq.c | 2 +-
3 files changed
kernel API (cxl_release_context()) or the
userspace API (afu_release()).
Reported-by: Matthew R. Ochs
Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
Signed-off-by: Andrew Donnellan
---
drivers/misc/cxl/context.c | 3 +++
drivers/misc/cxl/irq.c | 2 --
2 files change
t;cxl: Add AFU virtual PHB and kernel API")
Signed-off-by: Andrew Donnellan
---
drivers/misc/cxl/file.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/cxl/file.c b/drivers/misc/cxl/file.c
index a30bf28..fcda6b0 100644
--- a/drivers/misc/cxl/file.c
Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https
"result" to simplify the code.
Signed-off-by: Gavin Shan
Much easier to follow!
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Austral
Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https
On 08/10/15 14:58, Gavin Shan wrote:
This simplifies pnv_eeh_set_option() to avoid unnecessary nested
if statements, to improve readability. No functional changes.
Signed-off-by: Gavin Shan
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
ff-by: Daniel Axtens
Signed-off-by: Andrew Donnellan
---
This patch depends on "powerpc/pci: export pcibios_free_controller()" [0].
[0] https://patchwork.ozlabs.org/patch/516142/
---
drivers/misc/cxl/vphb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/misc/cxl/vphb.c b/d
ff-by: Matthew R. Ochs
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev ma
tmf_slock during probe.
Signed-off-by: Matthew R. Ochs
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
evaluation for an unset bit.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Manoj N. Kumar
Reviewed-by: Brian King
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work
On 22/10/15 07:16, Matthew R. Ochs wrote:
The port selection mask of a LUN can be corrupted when the manage LUN
ioctl (DK_CXLFLASH_MANAGE_LUN) is issued more than once for any device.
> ...
Signed-off-by: Matthew R. Ochs
Reviewed-by: Andrew Donnellan
--
Andrew Donnel
.
Fix the check so that a wait_state() return value of 0 won't be considered
successful for the EEH_OPT_THAW_MMIO or EEH_OPT_THAW_DMA cases.
Cc: Gavin Shan
Signed-off-by: Andrew Donnellan
---
arch/powerpc/kernel/eeh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/a
d,remove}() and exports them so that they
can be used in PCI hotplug during EEH recovery.
[gwshan: changelog]
Signed-off-by: Wei Yang
Reviewed-by: Gavin Shan
Acked-by: Bjorn Helgaas
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm
On 26/10/15 14:15, Wei Yang wrote:
This patch adds a weak function pcibios_bus_add_device() for arch dependent
code could do proper setup. For example, powerpc could setup EEH related
resources.
Signed-off-by: Wei Yang
Acked-by: Bjorn Helgaas
Reviewed-by: Andrew Donnellan
--
Andrew
Acked-by: Gavin Shan
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev ma
Axtens
Signed-off-by: Andrew Donnellan
---
This patch is a respin of https://patchwork.ozlabs.org/patch/504976/,
incorporating comments from mpe.
As with the old patch, this patch doesn't make any changes to the return
type of cxl_pcie_cfg_addr() and casts to an __iomem type when we use
reference
count is only decremented once on detach, thus the struct pid of the
task attaching is never freed. The fix is to simply remove the call to
get_pid().
Signed-off-by: Frederic Barrat
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel
On 31/10/15 00:07, Arnd Bergmann wrote:
On Wednesday 28 October 2015 14:29:39 Andrew Donnellan wrote:
--- a/drivers/misc/cxl/vphb.c
+++ b/drivers/misc/cxl/vphb.c
@@ -128,7 +128,7 @@ static int cxl_pcie_config_info(struct pci_bus *bus,
unsigned int devfn,
return
: # 3.18+
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mailing list
Linuxppc
+
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mailing list
Linuxppc-dev
Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
Signed-off-by: Andrew Donnellan
---
drivers/misc/cxl/vphb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c
index 94b5208..9be09bb 100644
--- a/driver
>cfg_addr + (addr & ~0x3ull);
*shift = (addr & 0x3) * 8;
Which hopefully still gives you the right result! :)
Will check.
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)
On 06/11/15 10:05, Daniel Axtens wrote:
Given that there are no current users of this function, does this need
to go to stable? Does it actually fix a real (as opposed to theoretical)
bug?
I tagged it for stable on mpe's request - I'm not fussed either way.
Andrew
--
Andrew
.
Signed-off-by: Markus Elfring
Thanks for picking this up - will remember in my future patches.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia
s such I'd like to continue with the patch as is, I'm happy to drop the
stable Cc though.
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)I
On 19/11/15 14:26, Rashmica Gupta wrote:
This function has been unused since commit 14cf11af6cf6 ("powerpc: Merge enough
to start building in arch/powerpc."), so remove it.
Signed-off-by: Rashmica Gupta
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Softwar
still
miss messages printed in panic() after the dumpers are called, i.e. the
"end kernel panic" message.
Signed-off-by: Russell Currey
The code looks reasonable.
With the changes I've mentioned above:
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan So
building a mainline kernel today and expecting
it to boot on such hardware is zero.
Signed-off-by: Stewart Smith
Comment below.
Reviewed-by: Andrew Donnellan
---
arch/powerpc/platforms/powernv/opal.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/powerpc
o run mainline kernels.
So, start to remove references to OPALv2.
Signed-off-by: Stewart Smith
Was going to comment that you should've removed the OPAL v1 line in
cpuinfo, but it seems you do that in the next patch.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Softwar
PALv3
exclusively.
Signed-off-by: Stewart Smith
I haven't checked for any outstanding references you've missed here, but
I'm going to assume it compiles...
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Austr
On 27/11/15 15:45, Stewart Smith wrote:
There was already a check for OPALv3, so we just remove the if/else
check and go for it.
OPAL pre-v3 no longer exists. Anywhere.
Signed-off-by: Stewart Smith
Nothing obviously wrong that stood out to me.
Reviewed-by: Andrew Donnellan
--
Andrew
On 27/11/15 16:43, Stewart Smith wrote:
Considering you need kernel support for any new POWER processor, and we're not
about to do an OPALv4 on POWER8 or earlier - we're going to be safe :)
Not a huge problem then :)
--
Andrew Donnellan Software Engineer, OzLabs
and
On 27/11/15 16:36, Andrew Donnellan wrote:
Reviewed-by: Andrew Donnellan
And withdrawing my Reviewed-by: because apparently I'm not capable of
spotting missing semicolons, please move the semicolon from patch 2 to
this patch...
Andrew
--
Andrew Donnellan Software Eng
too.)
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
don't fully understand why this is happening, and we
also haven't tested whether this occurs for other cxl devices. In the
meantime, though, revert the commit, especially as it was intended to be a
non-functional change.
Signed-off-by: Andrew Donnellan
---
This issue was identified by
n in CAPI support.
In the meantime, revert the commit, especially as it was intended to be a
non-functional change.
Cc: Gavin Shan
Cc: Ian Munsie
Cc: Daniel Axtens
Signed-off-by: Andrew Donnellan
---
Changes from V1:
- Updated commit message to incorporate comments from Daniel Axtens
We would
Finally looking at this patch again for the first time in a couple of
months...
On 04/11/15 17:17, Andrew Donnellan wrote:
On 03/11/15 20:09, Michael Ellerman wrote:
Part of your problem is you're storing afu->crs_len which is not
__iomem in
cfg_data which is, and so that's leadi
Without the card-specific code, how does the driver behave if the new
card is plugged in?
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
On 15/12/15 08:06, Uma Krishnan wrote:
Having a date for the driver requires it to be updated quite
often. Removing the date which is not necessary. Also made
use of the existing symbol to print the driver name.
Signed-off-by: Uma Krishnan
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan
as found in linux-next, along with the SANITIZE_ALL
typo fix, on a big-endian BML system, with gcc 5.2.1. It successfully
picked up one of the shift input issues that Daniel found, so therefore...
Tested-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.do
onable.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mailing list
Linuxppc-
e of later code changes, all looks good.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
_
A few of the config prompts for powerpc self-tests have periods at the
end, which is inconsistent with the rest of the prompts. Remove the
periods.
Signed-off-by: Andrew Donnellan
---
arch/powerpc/Kconfig.debug | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch
Fix off-by-one error in opal_mce_check_early_recovery() when checking
whether the NIP falls within OPAL space.
Signed-off-by: Andrew Donnellan
---
Only very slightly more correct, but I'm fairly sure it's more correct...
---
arch/powerpc/platforms/powernv/opal.c | 2 +-
1 file
On 06/01/16 11:45, Daniel Axtens wrote:
As sparse suggests, these should be made static.
Signed-off-by: Daniel Axtens
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874
has been updated and its usage in the OPAL kmsg dumper has
been modified to support its new behaviour as an incremental flush.
Signed-off-by: Russell Currey
Looks fine to me.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com
unsigned inttotal_pe;
unsigned intreserved_pe;
Given this leaves struct ioda as the only member of the union, do we
want to get rid of the union?
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Aust
On 14/01/16 02:30, Geliang Tang wrote:
Use kobj_to_dev() instead of open-coding it.
Signed-off-by: Geliang Tang
Good simplification.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
ges.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mailing list
Linuxppc-d
allow existing drivers (cxlflash)
to start using it.
Signed-off-by: Frederic Barrat
Looks fine to me.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)
1 - 100 of 1045 matches
Mail list logo
