Re: [PATCH] macintosh: Switch i2c drivers back to use .probe()

2023-05-23 Thread Dmitry Torokhov
quot;) convert > back to (the new) .probe() to be able to eventually drop .probe_new() from > struct i2c_driver. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Dmitry Torokhov Thanks. -- Dmitry

Re: [PATCH v4 08/18] gpiolib: remove gpio_set_debounce()

2023-02-09 Thread Dmitry Torokhov
ndy Shevchenko > Signed-off-by: Andy Shevchenko Acked-by: Dmitry Torokhov Thanks. -- Dmitry

Re: [PATCH v3 04/12] gpiolib: remove gpio_set_debounce

2023-02-07 Thread Dmitry Torokhov
On Tue, Feb 07, 2023 at 04:29:44PM +0200, Andy Shevchenko wrote: > @@ -1010,14 +1009,21 @@ static int ads7846_setup_pendown(struct spi_device > *spi, > } > > ts->gpio_pendown = pdata->gpio_pendown; > - > - if (pdata->gpio_pendown_debounce) > -

[PATCH v2] soc: fsl: qe: request pins non-exclusively

2022-12-04 Thread Dmitry Torokhov
ing to the global gpio numbers space until we fix the driver to implement proper pin control. Fixes: 84582f9ed090 ("soc: fsl: qe: Avoid using gpio_to_desc()") Signed-off-by: Dmitry Torokhov --- v2: - rebased on top of soc/driver. This will conflict with c9eb6e546a23 soc: fsl: qe:

Re: [RESEND PATCH] soc: fsl: qe: request pins non-exclusively

2022-12-04 Thread Dmitry Torokhov
On Sun, Dec 04, 2022 at 01:10:19PM +0100, Arnd Bergmann wrote: > On Sun, Dec 4, 2022, at 05:50, Dmitry Torokhov wrote: > > > > SoC team, the problematic patch has been in next for a while and it > > would be great to get the fix in to make sure the driver is not broken >

[RESEND PATCH] soc: fsl: qe: request pins non-exclusively

2022-12-03 Thread Dmitry Torokhov
ing to the global gpio numbers space until we fix the driver to implement proper pin control. Fixes: 84582f9ed090 ("soc: fsl: qe: Avoid using gpio_to_desc()") Reviewed-by: Linus Walleij Signed-off-by: Dmitry Torokhov --- SoC team, the problematic patch has been in next for a while and it w

Re: [PATCH] macintosh/mac_hid.c: don't load by default

2022-11-14 Thread Dmitry Torokhov
On Tue, Nov 15, 2022 at 04:07:53AM +0100, Thomas Weißschuh wrote: > On 2022-11-14 16:16-0800, Dmitry Torokhov wrote: > > On Tue, Nov 15, 2022 at 12:54:41AM +0100, Thomas Weißschuh wrote: > >> Cc Franz who wrote the driver originally. > >> (I hope I got the correc

Re: [PATCH] macintosh/mac_hid.c: don't load by default

2022-11-14 Thread Dmitry Torokhov
On Tue, Nov 15, 2022 at 12:54:41AM +0100, Thomas Weißschuh wrote: > Cc Franz who wrote the driver originally. > (I hope I got the correct one) > > Hi Dmitry, > > On 2022-11-14 10:33-0800, Dmitry Torokhov wrote: > > On Sun, Nov 13, 2022 at 04:30:22AM +0100, Thomas Wei

Re: [PATCH] macintosh/mac_hid.c: don't load by default

2022-11-14 Thread Dmitry Torokhov
Hi Thomas, On Sun, Nov 13, 2022 at 04:30:22AM +0100, Thomas Weißschuh wrote: > There should be no need to automatically load this driver on *all* > machines with a keyboard. > > This driver is of very limited utility and has to be enabled by the user > explicitly anyway. > Furthermore its own hea

Re: [PATCH] soc: fsl: qe: request pins non-exclusively

2022-11-08 Thread Dmitry Torokhov
On November 8, 2022 2:50:07 AM PST, Linus Walleij wrote: >On Tue, Nov 8, 2022 at 4:16 AM Dmitry Torokhov > wrote: > >> Commit 84582f9ed090 ("soc: fsl: qe: Avoid using gpio_to_desc()") changed >> qe_pin_request() to request and hold GPIO corresponding to a given

[PATCH] soc: fsl: qe: request pins non-exclusively

2022-11-07 Thread Dmitry Torokhov
ing to the global gpio numbers space until we fix the driver to implement proper pin control. Fixes: 84582f9ed090 ("soc: fsl: qe: Avoid using gpio_to_desc()") Signed-off-by: Dmitry Torokhov --- Compiled only, not tested on hardware. drivers/soc/

Re: [PATCH] powerpc/warp: switch to using gpiod API

2022-10-27 Thread Dmitry Torokhov
On Mon, Sep 26, 2022 at 11:03:25PM -0700, Dmitry Torokhov wrote: > This switches PIKA Warp away from legacy gpio API and to newer gpiod > API, so that we can eventually deprecate the former. > > Because LEDs are normally driven by leds-gpio driver, but the > platform code also want

[PATCH] powerpc/sgy_cts1000: convert to using gpiod API and facelift

2022-09-27 Thread Dmitry Torokhov
quot;sgy,gpio-halt" compatible. Signed-off-by: Dmitry Torokhov --- Cross-compiled with gcc-12.1.0, not tested on hardware. arch/powerpc/platforms/85xx/sgy_cts1000.c | 132 +- 1 file changed, 53 insertions(+), 79 deletions(-) diff --git a/arch/powerpc/platforms/85xx/sgy_

[PATCH] powerpc/warp: switch to using gpiod API

2022-09-26 Thread Dmitry Torokhov
-off-by: Dmitry Torokhov --- Compiled only, no hardware to test this. arch/powerpc/boot/dts/warp.dts| 4 +- arch/powerpc/platforms/44x/warp.c | 105 ++ 2 files changed, 94 insertions(+), 15 deletions(-) diff --git a/arch/powerpc/boot/dts/warp.dts b/arch/powerpc

Re: Is PPC 44x PIKA Warp board still relevant?

2022-09-26 Thread Dmitry Torokhov
On Mon, Sep 26, 2022 at 08:41:53PM +1000, Michael Ellerman wrote: > Christophe Leroy writes: > > Hi Dmitry > > > > Le 25/09/2022 à 07:06, Dmitry Torokhov a écrit : > >> Hi Michael, Nick, > >> > >> I was wondering if PIKA Warp board still releva

Is PPC 44x PIKA Warp board still relevant?

2022-09-24 Thread Dmitry Torokhov
Hi Michael, Nick, I was wondering if PIKA Warp board still relevant. The reason for my question is that I am interested in dropping legacy gpio APIs, especially OF-specific ones, in favor of newer gpiod APIs, and arch/powerpc/platforms/44x/warp.c is one of few users of it. The code in question is

Re: [PATCH] input: i8042: Remove special PowerPC handling

2020-05-20 Thread Dmitry Torokhov
linux-next. So perhaps this should go via > the input tree. > > Dmitry do you want to take this, or should I take it via powerpc? > > Original patch is here: > > https://lore.kernel.org/lkml/20200518181043.3363953-1-natechancel...@gmail.com I'm fine with you taking it through powerpc. Acked-by: Dmitry Torokhov Also, while I have your attention ;), could you please ack or take https://lore.kernel.org/lkml/20191002214854.GA114387@dtor-ws/ as I believe this is the last user or input_polled_dev API and I would like to drop it from the tree. Thanks! -- Dmitry

Re: [PATCH] macintosh/ams-input: switch to using input device polling mode

2019-11-11 Thread Dmitry Torokhov
On Wed, Oct 02, 2019 at 02:48:54PM -0700, Dmitry Torokhov wrote: > Now that instances of input_dev support polling mode natively, > we no longer need to create input_polled_dev instance. Michael, could you please take this? Or I could push through my tree... Thanks! > > Signed-of

[PATCH] macintosh/ams-input: switch to using input device polling mode

2019-10-02 Thread Dmitry Torokhov
Now that instances of input_dev support polling mode natively, we no longer need to create input_polled_dev instance. Signed-off-by: Dmitry Torokhov --- drivers/macintosh/Kconfig | 1 - drivers/macintosh/ams/ams-input.c | 37 +++ drivers/macintosh/ams/ams.h

Re: [RESEND PATCH] Input: joystick/analog - Use get_cycles() on PPC

2018-03-14 Thread Dmitry Torokhov
On Wed, Mar 14, 2018 at 10:17:52PM +1100, Michael Ellerman wrote: > The analog joystick driver spits a warning at us: > > drivers/input/joystick/analog.c:176:2: warning: #warning Precise timer > not defined for this architecture. > > PPC has get_cycles() so use that. > > Signed-off-by: Micha

Re: [PATCH] macintosh: move mac_hid driver to input/mouse.

2017-06-08 Thread Dmitry Torokhov
On Thu, Jun 8, 2017 at 4:07 PM, Peter Hutterer wrote: > On Thu, Jun 08, 2017 at 03:18:42PM +0200, Michal Suchánek wrote: >> This is what evtest reports about my keyboard: >> >> Select the device event number [0-12]: 2 >> Input driver version is 1.0.1 >> Input device ID: bus 0x3 vendor 0x413c produ

Re: [PATCH] macintosh: move mac_hid driver to input/mouse.

2017-06-07 Thread Dmitry Torokhov
On Wed, Jun 07, 2017 at 06:53:51PM +0200, Michal Suchánek wrote: > On Sun, 28 May 2017 10:55:40 -0700 > Dmitry Torokhov wrote: > > > On Sun, May 28, 2017 at 11:47:58AM +0200, Michal Suchanek wrote: > > > On Tue, 9 May 2017 17:43:27 -0700 > > > Dmitry Torokhov

Re: [PATCH] macintosh: move mac_hid driver to input/mouse.

2017-05-28 Thread Dmitry Torokhov
On Sun, May 28, 2017 at 11:47:58AM +0200, Michal Suchanek wrote: > On Tue, 9 May 2017 17:43:27 -0700 > Dmitry Torokhov wrote: > > > Hi Michal, > > > > On Tue, May 09, 2017 at 09:14:18PM +0200, Michal Suchanek wrote: > > > There is nothing mac-specific

Re: [PATCH] macintosh: move mac_hid driver to input/mouse.

2017-05-09 Thread Dmitry Torokhov
Hi Michal, On Tue, May 09, 2017 at 09:14:18PM +0200, Michal Suchanek wrote: > There is nothing mac-specific about this driver. Non-mac hardware with > suboptimal built-in pointer devices exists. > > This makes it possible to use this emulation not only on x86 and ppc > notebooks but also on arm a

Re: [PATCH 1/2] powerpc: make use of for_each_node_by_name() instead of open-coding it

2017-01-31 Thread Dmitry Torokhov
On Tue, Jan 31, 2017 at 05:54:37PM -0800, Dmitry Torokhov wrote: > Instead of manually coding the loop with of_find_node_by_name(), let's > switch to the standard macro for iterating over nodes with given name. > > Signed-off-by: Dmitry Torokhov > --- > arch/powerpc/platf

[PATCH 2/2] powerpc: make use of for_each_node_by_type() instead of open-coding it

2017-01-31 Thread Dmitry Torokhov
Instead of manually coding the loop with of_find_node_by_type(), let's switch to the standard macro for iterating over nodes with given type. Also fixed a couple of refcount leaks in the aforementioned loops. Signed-off-by: Dmitry Torokhov --- arch/powerpc/kernel/setup-common.c

[PATCH 1/2] powerpc: make use of for_each_node_by_name() instead of open-coding it

2017-01-31 Thread Dmitry Torokhov
Instead of manually coding the loop with of_find_node_by_name(), let's switch to the standard macro for iterating over nodes with given name. Signed-off-by: Dmitry Torokhov --- arch/powerpc/platforms/83xx/mpc832x_mds.c | 2 +- arch/powerpc/platforms/83xx/mpc832x_rdb.c | 2 +- arch/po

[PATCH] powerpc/powermac: drop useless call to of_find_node_by_name

2017-01-31 Thread Dmitry Torokhov
We are not using result, so this simply results in a leaked refcount. Signed-off-by: Dmitry Torokhov --- Found by visual inspection, not tested... arch/powerpc/platforms/powermac/feature.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch

[PATCH] powerpc/powermac: fix OF node refcount leak

2017-01-31 Thread Dmitry Torokhov
We need to call of_node_put() for device nodes obtained with of_find_node_by_name(). Signed-off-by: Dmitry Torokhov --- Found by visual inspection, not tested... arch/powerpc/platforms/powermac/pic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/powermac/pic.c b

Re: [RFC] fs: add userspace critical mounts event support

2016-09-24 Thread Dmitry Torokhov
On Fri, Sep 23, 2016 at 6:37 PM, Herbert, Marc wrote: > On 03/09/2016 11:10, Dmitry Torokhov wrote: >> I was thinking if we kernel could post >> "conditions" (maybe simple stings) that it waits for, and userspace >> could unlock these "conditions". On

Re: [RFC] fs: add userspace critical mounts event support

2016-09-03 Thread Dmitry Torokhov
On Sat, Sep 3, 2016 at 11:01 AM, Linus Torvalds wrote: > On Sat, Sep 3, 2016 at 10:49 AM, Dmitry Torokhov > wrote: >> >> Unfortunately module loading and availability of firmware is very >> loosely coupled. > > The whole "let's add a new magical proc

Re: [RFC] fs: add userspace critical mounts event support

2016-09-03 Thread Dmitry Torokhov
On Fri, Sep 02, 2016 at 09:41:18PM -0700, Linus Torvalds wrote: > On Sep 2, 2016 9:20 PM, "Dmitry Torokhov" wrote: > > > > Like what? Some devices do need to have firmware loaded so we know > > their capabilities, so we really can't push the firmware loadi

Re: [RFC] fs: add userspace critical mounts event support

2016-09-02 Thread Dmitry Torokhov
On Fri, Sep 2, 2016 at 9:11 PM, Linus Torvalds wrote: > On Fri, Sep 2, 2016 at 5:20 PM, Luis R. Rodriguez wrote: >> >> Thoughts ? > > I really think this is a horrible hack. > > It's basically the kernel giving up, and relying on user space to give > a single flag, and it's broken nasty crap. Wo

Re: [PATCH v2 2/5] firmware: annotate thou shalt not request fw on init or probe

2016-08-25 Thread Dmitry Torokhov
On Thu, Aug 25, 2016 at 12:41 PM, Luis R. Rodriguez wrote: > On Thu, Aug 25, 2016 at 01:05:44PM +0200, Daniel Vetter wrote: >> On Wed, Aug 24, 2016 at 10:39 PM, Luis R. Rodriguez >> wrote: >> > Can they use initramfs for this ? >> >> Apparently that's also uncool with the embedded folks. > > Wh

Re: [PATCH 09/14] Input: touchscreen: Broadcom iProc: DT spelling s/clock-name/clock-names/

2016-04-20 Thread Dmitry Torokhov
On Wed, Apr 20, 2016 at 05:32:14PM +0200, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven Applied, thank you. > --- > .../devicetree/bindings/input/touchscreen/brcm,iproc-touchscreen.txt| 2 > +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentati

Re: [PATCH V3 00/29] bitops: add parity functions

2016-04-17 Thread Dmitry Torokhov
| 1 - > drivers/input/serio/ams_delta_serio.c| 8 +- > drivers/input/serio/pcips2.c | 2 +- > drivers/input/serio/saps2.c | 2 +- For input bits: Acked-by: Dmitry Torokhov Thanks. -- Dmitry ___

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Dmitry Torokhov
gt; > Cc: Konrad Rzeszutek Wilk > > Cc: Boris Ostrovsky > > Cc: David Vrabel > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: "H. Peter Anvin" > > Cc: x...@kernel.org > > Cc: "Roger Pau Monné" > > Cc: Dmitry Torokhov > > C

Re: [PATCH 00/27] Export I2C and OF module aliases in missing drivers

2015-07-30 Thread Dmitry Torokhov
On Thu, Jul 30, 2015 at 09:35:17AM -0700, Dmitry Torokhov wrote: > Hi Javier, > > On Thu, Jul 30, 2015 at 06:18:25PM +0200, Javier Martinez Canillas wrote: > > Hello, > > > > Short version: > > > > This series add the missing MODULE_DEVICE_TABLE() f

Re: [PATCH 00/27] Export I2C and OF module aliases in missing drivers

2015-07-30 Thread Dmitry Torokhov
Hi Javier, On Thu, Jul 30, 2015 at 06:18:25PM +0200, Javier Martinez Canillas wrote: > Hello, > > Short version: > > This series add the missing MODULE_DEVICE_TABLE() for OF and I2C tables > to export that information so modules have the correct aliases built-in > and autoloading works correctly

Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies

2013-12-15 Thread Dmitry Torokhov
On Sun, Dec 15, 2013 at 08:27:25PM -0500, David Miller wrote: > From: Mark Salter > Date: Sun, 15 Dec 2013 10:50:26 -0500 > > > On Sun, 2013-12-15 at 02:36 -0800, Dmitry Torokhov wrote: > >> How are we going to merge this? In bulk through input tree or peacemeal >

Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies

2013-12-15 Thread Dmitry Torokhov
which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig. > > New architectures are unlikely to need SERIO_I8042, so this avoids > > having an ever growing list of architectures to exclude. > > > > Signed-off-by: Mark Salter > > CC: Dmitry Torokhov > > CC: Richard Hende

Re: [PATCH 5/5] kfifo: log based kfifo API

2013-01-08 Thread Dmitry Torokhov
Hi Yuanhan, On Tue, Jan 08, 2013 at 10:57:53PM +0800, Yuanhan Liu wrote: > The current kfifo API take the kfifo size as input, while it rounds > _down_ the size to power of 2 at __kfifo_alloc. This may introduce > potential issue. > > Take the code at drivers/hid/hid-logitech-dj.c as example: >

Re: [Pv-drivers] [PATCH 192/493] scsi: remove use of __devinit

2012-11-26 Thread Dmitry Torokhov
On Mon, Nov 19, 2012 at 01:22:21PM -0500, Bill Pemberton wrote: > CONFIG_HOTPLUG is going away as an option so __devinit is no longer > needed. > ... > drivers/scsi/vmw_pvscsi.c | 6 +- For vmw_pvscsi: Acked-by: Dmitry Torokhov Th

Re: [PATCH v2 5/5] xhci: Remove recursive call to xhci_handle_event

2011-03-29 Thread Dmitry Torokhov
t admit I dislike the style with empty loop bodies, do you think we could have something like below instead? Thanks! -- Dmitry From: Dmitry Torokhov Subject: [PATCH] USB: xhci: avoid recursion in xhci_handle_event Instead of having xhci_handle_event call itself if there are more outstanding TRB

Re: [PATCH v2 3/5] xhci: Add rmb() between reading event validity & event data access.

2011-03-29 Thread Dmitry Torokhov
On Sunday, March 27, 2011 09:52:57 pm Matt Evans wrote: > On weakly-ordered systems, the reading of an event's content must occur > after reading the event's validity. > > Signed-off-by: Matt Evans > --- > Segher, thanks for the comment; explanation added. > > drivers/usb/host/xhci-ring.c |

Re: [PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver

2011-02-09 Thread Dmitry Torokhov
On Wed, Feb 09, 2011 at 04:10:55PM -0800, Ira W. Snyder wrote: > On Wed, Feb 09, 2011 at 03:42:31PM -0800, Dmitry Torokhov wrote: > > On Wed, Feb 09, 2011 at 03:35:45PM -0800, Ira W. Snyder wrote: > > > On Wed, Feb 09, 2011 at 10:27:40AM -0800, Dmitry Torokhov wrote: > > &g

Re: [PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver

2011-02-09 Thread Dmitry Torokhov
On Wed, Feb 09, 2011 at 03:35:45PM -0800, Ira W. Snyder wrote: > On Wed, Feb 09, 2011 at 10:27:40AM -0800, Dmitry Torokhov wrote: > > [ snip stuff I've already fixed in the next version ] > > > > > > > The requirement is that the device stay open during recon

Re: [PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver

2011-02-09 Thread Dmitry Torokhov
On Wed, Feb 09, 2011 at 09:35:32AM -0800, Ira W. Snyder wrote: > On Wed, Feb 09, 2011 at 12:33:25AM -0800, Dmitry Torokhov wrote: > > > + > > > + /* Warn if we are running in a degraded state, but do not fail */ > > > + if (priv->num_buffers < MAX_DATA_BUFS)

Re: [PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver

2011-02-09 Thread Dmitry Torokhov
Hi Ira, On Tue, Feb 08, 2011 at 03:37:46PM -0800, Ira W. Snyder wrote: > This driver allows userspace to access the data processing FPGAs on the > OVRO CARMA board. It has two modes of operation: > Thank you for making the changes, some more comments below. > + > +#define inode_to_dev(inode) co

Re: [PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver

2011-02-08 Thread Dmitry Torokhov
On Tue, Feb 08, 2011 at 11:11:44AM -0800, Ira W. Snyder wrote: > On Tue, Feb 08, 2011 at 09:50:29AM -0800, Dmitry Torokhov wrote: > > On Tue, Feb 08, 2011 at 09:20:46AM -0800, Ira W. Snyder wrote: > > > > > Go back and re-think my loop. This is a > > > common idi

Re: [PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver

2011-02-08 Thread Dmitry Torokhov
On Tue, Feb 08, 2011 at 09:20:46AM -0800, Ira W. Snyder wrote: > On Mon, Feb 07, 2011 at 11:33:10PM -0800, Dmitry Torokhov wrote: > > > +static void data_free_buffer(struct device *dev, struct data_buf *buf) > > > +{ > > > + /* It is ok to free a N

Re: [PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver

2011-02-07 Thread Dmitry Torokhov
Hi Ira, On Mon, Feb 07, 2011 at 03:23:40PM -0800, Ira W. Snyder wrote: > This driver allows userspace to access the data processing FPGAs on the > OVRO CARMA board. It has two modes of operation: > > 1) random access > > This allows users to poke any DATA-FPGA registers by using mmap to map > th

Re: [PATCH v3] powerpc: Add i8042 keyboard and mouse irq parsing

2010-06-01 Thread Dmitry Torokhov
On Tue, Jun 01, 2010 at 01:41:59PM +0100, Martyn Welch wrote: > Benjamin Herrenschmidt wrote: > > O > > > >> diff --git a/arch/powerpc/kernel/setup-common.c > >> b/arch/powerpc/kernel/setup-common.c > >> index 48f0a00..3d169bb 100644 > >> --- a/arch/powerpc/kernel/setup-common.c > >> +++ b/arch

Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-05-31 Thread Dmitry Torokhov
On Mon, May 31, 2010 at 10:48:32PM +0100, Richard Purdie wrote: > On Mon, 2010-05-31 at 12:09 -0700, Dmitry Torokhov wrote: > > On Mon, May 31, 2010 at 02:55:48PM +0200, Wolfram Sang wrote: > > > I2C-drivers can use the clientdata-pointer to point to private data. As > >

Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-05-31 Thread Dmitry Torokhov
Hi Wolfram, On Mon, May 31, 2010 at 02:55:48PM +0200, Wolfram Sang wrote: > I2C-drivers can use the clientdata-pointer to point to private data. As I2C > devices are not really unregistered, but merely detached from their driver, it > used to be the drivers obligation to clear this pointer during

Re: [PATCH] device_attributes: add sysfs_attr_init() for dynamic attributes

2010-03-21 Thread Dmitry Torokhov
Hi Wolfram, On Mon, Mar 22, 2010 at 07:21:17AM +0100, Wolfram Sang wrote: > Made necessary by 6992f5334995af474c2b58d010d08bc597f0f2fe. > > Found by this semantic patch: > > @ init @ > type T; > identifier A; > @@ > > T { > ... > struct device_attribute A

Re: [PATCH] [V2] powerpc: Xilinx: PS2: driver updates based on review

2008-07-23 Thread Dmitry Torokhov
ECTED]> Acked-by: Grant Likely <[EMAIL PROTECTED]> Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/serio/xilinx_ps2.c | 211 +++--- 1 files changed, 108 insertions(+), 103 deletions(-) diff --git a/drivers/input/serio/xilinx_ps2.c b

Re: [PATCH] [V3] powerpc: Xilinx: PS2: Added new XPS PS2 driver

2008-07-09 Thread Dmitry Torokhov
On Wed, Jul 9, 2008 at 12:14 PM, John Linn <[EMAIL PROTECTED]> wrote: > These look like good comments from Peter. > > Dmitry, how would you like to do this, would you prefer us to do an > incremental patch from the existing patch (V3)? Or a new V4 for the > patch? > Incremental please. I already

Re: [PATCH] [V3] powerpc: Xilinx: PS2: Added new XPS PS2 driver

2008-07-07 Thread Dmitry Torokhov
On Mon, Jul 07, 2008 at 12:27:09PM -0600, John Linn wrote: > Thanks Dmitry, appreciate the help. > > Powerpc dependencies in the Kconfig sound right. Sorry for not thinking > that thru well across all architectures. > > Do you want me to spin the patch again? > Please send me incremental patc

Re: [PATCH] [V3] powerpc: Xilinx: PS2: Added new XPS PS2 driver

2008-07-07 Thread Dmitry Torokhov
On Mon, Jul 07, 2008 at 08:38:45AM -0700, John Linn wrote: > Added a new driver for Xilinx XPS PS2 IP. This driver is > a flat driver to better match the Linux driver pattern. > > Signed-off-by: Sadanand <[EMAIL PROTECTED]> > Signed-off-by: John Linn <[EMAIL PROTECTED]> Looks good and I am ready

Re: [PATCH] [V2] powerpc: Xilinx: PS2: Added new XPS PS2 driver

2008-07-03 Thread Dmitry Torokhov
Hi John, On Thu, Jul 03, 2008 at 09:42:31AM -0700, John Linn wrote: > + > + /* Initialize the PS/2 interface */ > + mutex_lock(&drvdata->cfg_mutex); > + if (xps2_initialize(drvdata)) { > + mutex_unlock(&drvdata->cfg_mutex); > + dev_err(dev, "Could not initialize

Re: [PATCH] [V2] powerpc: Xilinx: PS2: Added new XPS PS2 driver

2008-06-30 Thread Dmitry Torokhov
On Mon, Jun 30, 2008 at 08:38:21AM -0700, John Linn wrote: > + spin_lock_init(&drvdata->lock); > + dev_set_drvdata(dev, (void *)drvdata); No need to cast to void *. > + > + if (!regs_res || !irq_res) { > + dev_err(dev, "IO resource(s) not found\n"); > + retval

Re: [PATCH] powerpc: Xilinx: PS2: Added new XPS PS2 driver

2008-06-30 Thread Dmitry Torokhov
Hi Grant, John, On Mon, Jun 30, 2008 at 11:16:28AM -0600, Grant Likely wrote: > On Mon, Jun 30, 2008 at 07:24:48AM -0700, John Linn wrote: > > +config SERIO_XILINX_XPS_PS2 > > + tristate "Xilinx XPS PS/2 Controller Support" > > + help > > + This driver supports XPS PS/2 IP from Xilinx EDK.

Re: [PATCH] remove dead MAC_ADBKEYCODES

2007-11-16 Thread Dmitry Torokhov
On Nov 16, 2007 4:44 AM, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > Wrong mailing list ;-) > > On Thu, 15 Nov 2007, Stanislav Brabec wrote: > > It seems, that current kernel source code contains no traces of > > MAC_ADBKEYCODES and no reference to keyboard_sends_linux_keycodes any > > more.

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-28 Thread Dmitry Torokhov
re-submit URB when we decide that toucvhpad needs to be reinicialized - do not repeat size detection when reinitializing the touchpad - Add missing KERN_* prefixes to messages Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/mouse/appletouch.c | 125 +

Re: [PATCH] Prevent appletouch message log spam on 17" PB

2007-10-28 Thread Dmitry Torokhov
Hi Joseph, On Sunday 28 October 2007 19:53, Joseph Jezak wrote: > Perhaps this was a debugging message? In any case, this printk > causes lots of message log spam on my PB G4 1.67" (PowerBook5,9). > > This removes the printk. > I don't think we want do delete this message outright, we just nee

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-28 Thread Dmitry Torokhov
On Sunday 28 October 2007, Johannes Berg wrote: > > > OK, then maybe instead of reverting the change outright we could try the > > patch below? > > That patch works, Any chance Benjamin could also test it? The behaviour is different from 2.6.24-rc1 since we call atp_geyser_init for all geysers n

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-27 Thread Dmitry Torokhov
pletouch - idle reset logic broke older Fountains Older models of fountains do not support change mode request and therefore shoudl be excluded from idle reset attempts. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/mouse/appletouch.c | 83

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-26 Thread Dmitry Torokhov
On 10/25/07, Benjamin Berg <[EMAIL PROTECTED]> wrote: > On Thu, 2007-25-10 at 15:23 +0200, Johannes Berg wrote: > > On Wed, 2007-10-24 at 10:29 -0400, Dmitry Torokhov wrote: > > > > > Do yo know who has powerbooks with older geyser models (0x214, 215, > > >

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-24 Thread Dmitry Torokhov
On 10/24/07, Johannes Berg <[EMAIL PROTECTED]> wrote: > On Wed, 2007-10-24 at 09:34 -0400, Dmitry Torokhov wrote: > > > Well, but what about fountains then? Regardless of the model, if there > > is a way to stop "empty" meaurements, we should do it. > >

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-24 Thread Dmitry Torokhov
On 10/24/07, Johannes Berg <[EMAIL PROTECTED]> wrote: > Hi, > > > My fault, sorry. > > No, actually, I was wrong about Geyser 1, mine is a fountain. > > > Is there a way to "plug" these Geysers? Waking up the kernel > > continuously is not nice. > > Not sure really, maybe checking for is_geyser ins

Re: [PATCH] fix appletouch geyser 1 breakage

2007-10-24 Thread Dmitry Torokhov
Hi Johannes, On 10/24/07, Johannes Berg <[EMAIL PROTECTED]> wrote: > The patch 46249ea60fbb61a72ee6929b831b1f3e6865f024 was obviously done > without testing on a Geyser 1, My fault, sorry. However Anton's device has product ID of 90x30B which is Geyser 1 as far as I understand... But yes, we shou

Re: current -git adbhid.c build error

2007-10-16 Thread Dmitry Torokhov
On Wednesday 17 October 2007, Paul Mackerras wrote: > > It was a mis-merge between 555ddbb4, which made that change and *did* > add the declaration of key, and 9a402b64, which deleted the line that > the declaration of key was added to. Oops, sorry. > > We need the patch below. Dmitry, will yo

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-23 Thread Dmitry Torokhov
On Sunday 22 July 2007 08:51, Geert Uytterhoeven wrote: > On Sun, 22 Jul 2007, Dmitry Torokhov wrote: > > On Saturday 21 July 2007 04:27, Geert Uytterhoeven wrote: > > > On Fri, 20 Jul 2007, Dmitry Torokhov wrote: > > > > I am OK with adding a new header file.

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-21 Thread Dmitry Torokhov
Hi Geert, On Saturday 21 July 2007 04:27, Geert Uytterhoeven wrote: > On Fri, 20 Jul 2007, Dmitry Torokhov wrote: > > > > I am OK with adding a new header file. I was just saying that placing > > that declaration in linux/hid.h makes about the same sense as putting >

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Fri, Jul 20, 2007 at 02:51:02PM -0400, Dmitry Torokhov wrote: > > On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > >> On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: > >> >

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: > > Hi Geert, > > > > On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > >> From: Geert Uytterhoeven &l

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
Hi Geert, On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible > > drivers/char/keyboard.c: In function 'kbd_keycode': > drivers/char/keyboard.c:1142: error: implicit declarat