On Mon, Jun 30, 2008 at 08:38:21AM -0700, John Linn wrote:
> + spin_lock_init(&drvdata->lock);
> + dev_set_drvdata(dev, (void *)drvdata);
No need to cast to void *.
> +
> + if (!regs_res || !irq_res) {
> + dev_err(dev, "IO resource(s) not found\n");
> + retval = -EFAULT;
> + goto failed1;
> + }
> +
> + drvdata->irq = irq_res->start;
> + remap_size = regs_res->end - regs_res->start + 1;
> + if (!request_mem_region(regs_res->start, remap_size, DRIVER_NAME)) {
> +
> + dev_err(dev, "Couldn't lock memory region at 0x%08X\n",
> + (unsigned int)regs_res->start);
> + retval = -EBUSY;
> + goto failed1;
> + }
> +
> + /* Fill in configuration data and add them to the list */
> + drvdata->phys_addr = regs_res->start;
> + drvdata->remap_size = remap_size;
> + drvdata->base_address = ioremap(regs_res->start, remap_size);
> + if (drvdata->base_address == NULL) {
> +
> + dev_err(dev, "Couldn't ioremap memory at 0x%08X\n",
> + (unsigned int)regs_res->start);
> + retval = -EFAULT;
> + goto failed2;
> + }
> +
> + /* Initialize the PS/2 interface */
> + down(&cfg_sem);
> + if (xps2_initialize(drvdata)) {
> + up(&cfg_sem);
> + dev_err(dev, "Could not initialize device\n");
> + retval = -ENODEV;
> + goto failed3;
> + }
> + up(&cfg_sem);
Do you need a counting semaphore here?
> +
> + dev_info(dev, "Xilinx PS2 at 0x%08X mapped to 0x%08X, irq=%d\n",
> + drvdata->phys_addr, (u32)drvdata->base_address, drvdata->irq);
> +
> + drvdata->serio.id.type = SERIO_8042;
> + drvdata->serio.write = sxps2_write;
> + drvdata->serio.open = sxps2_open;
> + drvdata->serio.close = sxps2_close;
> + drvdata->serio.port_data = drvdata;
> + drvdata->serio.dev.parent = dev;
> + snprintf(drvdata->serio.name, sizeof(drvdata->serio.name),
> + XPS2_NAME_DESC, id);
> + snprintf(drvdata->serio.phys, sizeof(drvdata->serio.phys),
> + XPS2_PHYS_DESC, id);
I bet if you make a temp variable for drvdata->serio the code size wil
shrink a tiny bit.
--
Dmitry
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
