Hi Geert, On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible > > drivers/char/keyboard.c: In function 'kbd_keycode': > drivers/char/keyboard.c:1142: error: implicit declaration of function > 'mac_hid_mouse_emulate_buttons' > > The forward declaration of mac_hid_mouse_emulate_buttons() is not visible on > m68k because it's hidden in the middle of a big #ifdef block. > > Move it to <linux/hid.h>, correct the type of the second parameter, and > include <linux/hid.h> where needed.
linux/hid.h contains definitions needed for drivers speaking HID protocol, I don't think we want to put quirks for legacy keyboard driver there. I'd just move the #ifdef within drivers/char/keyboard.c for now. BTW, I don't think that mac button emulation will work well when x86 evdev-based driver gains popularity - it "grabs" the device and so no event will flow through keyboard driver... We'd need a new solution... -- Dmitry _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
