On Sunday 28 October 2007, Johannes Berg wrote: > > > OK, then maybe instead of reverting the change outright we could try the > > patch below? > > That patch works,
Any chance Benjamin could also test it? The behaviour is different from 2.6.24-rc1 since we call atp_geyser_init for all geysers now. > minor comments: > > > Older models of fountains do not support change mode request and > > I think there's only one fountain model. I was hoping that FOUNTAIN_TP_ONLY_PRODUCT_ID (0x30A) behaves similar to Geyser in this regard. If you know that this assumption is incorrect then we need to rename atp_is_older_fountain() to atp_is_fountain() anf add this product ID to it. > > > therefore shoudl be excluded from idle reset attempts. > > typo OK > > > /* MacBook Pro (Geyser 3 & 4) initialization constants */ > > That comment is no longer correct, you should change it. > OK > > -#define ATP_GEYSER3_MODE_READ_REQUEST_ID 1 > > > + * Reinitialise the device. This usually stops stream of empty packets > > + * coming form it. > > typo "from" > Yep, thanks. -- Dmitry _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
