On Wed, Nov 21 2012, Sebastian Andrzej Siewior wrote:
> So you say "keep the patch as it with this module-parameter
> compatibility"?
I'm saying that in my opinion external behaviour of the gadgets should
not change until a configfs solution is ready and final.
As for the patch, I had some concer
Hi Praveen,
On Wednesday 14 of November 2012 15:57:16 Praveen Paneri wrote:
> Adding the transceiver to hsotg driver. Keeping the platform data
> for continuing the smooth operation for boards which still uses it
>
> Signed-off-by: Praveen Paneri
> Acked-by: Kyungmin Park
> ---
> drivers/usb/g
Hi Praveen,
See some minor comments inline.
On Wednesday 14 of November 2012 15:57:15 Praveen Paneri wrote:
> This driver uses usb_phy interface to interact with s3c-hsotg. Supports
> phy_init and phy_shutdown functions to enable/disable usb phy. Support
> will be extended to host controllers and
On Wed, Nov 21, 2012 at 11:22:57PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 11/21/2012 04:48 PM, Ming Lei wrote:
>
> > If transceiver driver is built as module, the transceiver device
> > may be added very late, so cause musb_init_controller() failed.
>
> > This patch fixes the below error
Hi,
On Wed, Nov 21, 2012 at 06:07:57PM +0200, Roger Quadros wrote:
> On 11/21/2012 05:32 PM, Alan Stern wrote:
> > On Wed, 21 Nov 2012, Roger Quadros wrote:
> >
> >> On 11/21/2012 04:52 PM, Alan Stern wrote:
> >>> On Wed, 21 Nov 2012, Felipe Balbi wrote:
> >>>
> On Thu, Nov 15, 2012 at 04:34
On Wed, Nov 21, 2012 at 11:28:36PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 11/21/2012 05:06 PM, Michael Grzeschik wrote:
>
> > This adds mx53 as the next user of the usbmisc driver and makes it
> > possible to disable the overcurrent-detection of the internal phy.
>
> > Signed-off-by: Mich
Hi,
On Wed, Nov 21, 2012 at 05:55:19PM +0200, Roger Quadros wrote:
> On 11/21/2012 03:57 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Thu, Nov 15, 2012 at 04:34:11PM +0200, Roger Quadros wrote:
> >> We don't really need a spinlock here, so get rid of it.
> >
> > can you prove it ? what if an IRQ h
hi,
On Wed, Nov 21, 2012 at 05:47:06PM +0200, Roger Quadros wrote:
> On 11/21/2012 03:52 PM, Felipe Balbi wrote:
> > On Thu, Nov 15, 2012 at 04:34:08PM +0200, Roger Quadros wrote:
> >> OMAPs till date can have upto 3 ports. We need to initialize
> >
> > s/upto/up to/
> >
> >> the port mode in HO
Hi,
On Wed, Nov 21, 2012 at 04:50:42PM +0200, Roger Quadros wrote:
> On 11/21/2012 03:45 PM, Felipe Balbi wrote:
> > On Thu, Nov 15, 2012 at 04:34:07PM +0200, Roger Quadros wrote:
> >> For some platforms e.g. OMAP5, we cannot rely on USBHOST revision
> >> to determine the number of ports available
Hi,
On Wed, Nov 21, 2012 at 04:45:27PM +0200, Roger Quadros wrote:
> >> + switch (omap->usbhs_rev) {
> >> + case OMAP_USBHS_REV1:
> >> + omap->nports = 3;
> >> + break;
> >> + case OMAP_USBHS_REV2:
> >> + omap->nports = 2;
> >> + break;
> >> + default:
> >>
On Mon, Nov 19, 2012 at 05:31:57PM -0500, Alan Stern wrote:
> On Mon, 19 Nov 2012, Sarah Sharp wrote:
>
> > On Mon, Nov 19, 2012 at 10:50:32AM -0500, Alan Stern wrote:
> > Perhaps we should only update the schedule after the configuration or
> > alt setting is installed? We could force a driver t
Hi,
On Wed, Nov 21, 2012 at 05:39:57PM +0200, Roger Quadros wrote:
> On 11/21/2012 04:03 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Wed, Nov 21, 2012 at 02:36:48PM +0200, Roger Quadros wrote:
> break;
> default:
> -dev_err(dev, "TLL version
Hello.
On 11/21/2012 05:06 PM, Michael Grzeschik wrote:
> This adds mx53 as the next user of the usbmisc driver and makes it
> possible to disable the overcurrent-detection of the internal phy.
> Signed-off-by: Michael Grzeschik
> Signed-off-by: Marc Kleine-Budde
> ---
> Changes since v2:
> *
Hello.
On 11/21/2012 04:48 PM, Ming Lei wrote:
> If transceiver driver is built as module, the transceiver device
> may be added very late, so cause musb_init_controller() failed.
> This patch fixes the below error on 3.7-rcX:
> [ 19.052490] unable to find transceiver of type USB2 PHY
> [ 1
Hello.
On 11/21/2012 01:22 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD
> Cc: linux-usb@vger.kernel.org
> Cc: net...@vger.kernel.org
> ---
> drivers/net/usb/asix_devices.c | 24 +---
> 1 file changed, 21 insertions(+), 3 del
Hi,
On Wed, Nov 21, 2012 at 05:51:05PM +0100, Sebastian Andrzej Siewior wrote:
> On Wed, Nov 21, 2012 at 10:36:37PM +0800, Ming Lei wrote:
> > On Wed, Nov 21, 2012 at 10:09 PM, Felipe Balbi wrote:
> > >> status = musb_platform_init(musb);
> > >> - if (status < 0)
> > >> + if (status
On Wed, Nov 21, 2012 at 10:36:37PM +0800, Ming Lei wrote:
> On Wed, Nov 21, 2012 at 10:09 PM, Felipe Balbi wrote:
> >> status = musb_platform_init(musb);
> >> - if (status < 0)
> >> + if (status < 0) {
> >> + /* try to defer probe if trasceiver is not ready */
> >> +
On 11/21/2012 05:32 PM, Alan Stern wrote:
> On Wed, 21 Nov 2012, Roger Quadros wrote:
>
>> On 11/21/2012 04:52 PM, Alan Stern wrote:
>>> On Wed, 21 Nov 2012, Felipe Balbi wrote:
>>>
On Thu, Nov 15, 2012 at 04:34:14PM +0200, Roger Quadros wrote:
> From: Andy Green
>
> This patch c
Michael Grzeschik a écrit :
> On Fri, Nov 16, 2012 at 05:39:42PM +0200, Alexander Shishkin wrote:
>> Matthieu CASTET writes:
>>
>>> Alexander Shishkin a écrit :
Michael Grzeschik writes:
> On Fri, Nov 16, 2012 at 03:34:23PM +0200, Alexander Shishkin wrote:
>> Michael Grzeschik
On 11/21/2012 03:58 PM, Felipe Balbi wrote:
> On Thu, Nov 15, 2012 at 04:34:12PM +0200, Roger Quadros wrote:
>> Boards like Panda require an auxiliary clock to clock the PHY
>> that is connected to one of the USB ports. This patch enables
>> board support code to provide the name and the rate of s
On Fri, Nov 16, 2012 at 05:39:42PM +0200, Alexander Shishkin wrote:
> Matthieu CASTET writes:
>
> > Alexander Shishkin a écrit :
> >> Michael Grzeschik writes:
> >>
> >>> On Fri, Nov 16, 2012 at 03:34:23PM +0200, Alexander Shishkin wrote:
> Michael Grzeschik writes:
>
> > On Fri,
On 11/21/2012 03:57 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Nov 15, 2012 at 04:34:11PM +0200, Roger Quadros wrote:
>> We don't really need a spinlock here, so get rid of it.
>
> can you prove it ? what if an IRQ happens right after disabling clocks
> on ->runtime_suspend() but before it returns
On 11/21/2012 03:54 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Nov 15, 2012 at 04:34:09PM +0200, Roger Quadros wrote:
>> Enable the optional HSIC clocks (60MHz and 480MHz) for the ports
>> that are configured in HSIC mode.
>>
>> Signed-off-by: Roger Quadros
>> ---
>> drivers/mfd/omap-usb-host.c |
On 11/21/2012 03:52 PM, Felipe Balbi wrote:
> On Thu, Nov 15, 2012 at 04:34:08PM +0200, Roger Quadros wrote:
>> OMAPs till date can have upto 3 ports. We need to initialize
>
> s/upto/up to/
>
>> the port mode in HOSTCONFIG register for all of them.
>
> why *all* of them ? Isn't it enough to ini
Hi list,
I fixed the stuff proposed by Peter Stuge and Greg K-H.
Updated patch follows.
Greetings
Martin Teichmann
commit f04e51600e8686a0f33f79b9c2dc293dc1ce5389
Author: Martin Teichmann
Date: Wed Nov 21 11:34:53 2012 +0100
Add support for Newport AGILIS motor drivers
The Newpor
On 11/21/2012 04:03 PM, Felipe Balbi wrote:
> Hi,
>
> On Wed, Nov 21, 2012 at 02:36:48PM +0200, Roger Quadros wrote:
break;
default:
- dev_err(dev, "TLL version failed\n");
- ret = -ENODEV;
- goto err_ioremap;
+ tll->n
On Wed, 21 Nov 2012, Roger Quadros wrote:
> On 11/21/2012 04:52 PM, Alan Stern wrote:
> > On Wed, 21 Nov 2012, Felipe Balbi wrote:
> >
> >> On Thu, Nov 15, 2012 at 04:34:14PM +0200, Roger Quadros wrote:
> >>> From: Andy Green
> >>>
> >>> This patch changes the management of the two GPIO for
> >>
Dear Jiri Kosina,
> On Sun, 5 Aug 2012, Marek Vasut wrote:
> > > diff --git a/drivers/hid/usbhid/hid-quirks.c
> > > b/drivers/hid/usbhid/hid-quirks.c index 903eef3..6a09570 100644
> > > --- a/drivers/hid/usbhid/hid-quirks.c
> > > +++ b/drivers/hid/usbhid/hid-quirks.c
> > > @@ -101,6 +101,7 @@ stat
On 11/06/2012 05:14 AM, Jiri Kosina wrote:
> On Mon, 5 Nov 2012, Chris J Arges wrote:
>
When an SB Arena USB headset is plugged in, it registers the volume
keys on the headset as a keyboard and continually sends events causing
issues with normal keyboard input. This quirk disables t
On 11/21/2012 04:52 PM, Alan Stern wrote:
> On Wed, 21 Nov 2012, Felipe Balbi wrote:
>
>> On Thu, Nov 15, 2012 at 04:34:14PM +0200, Roger Quadros wrote:
>>> From: Andy Green
>>>
>>> This patch changes the management of the two GPIO for
>>> "hub reset" (actually controls enable of ULPI PHY and hub
On Wed, 21 Nov 2012, Sachin Kamat wrote:
> 'new_interfaces' should be freed to avoid memory leak.
>
> Cc: Sarah Sharp
> Cc: Alan Stern
> Signed-off-by: Sachin Kamat
> ---
> drivers/usb/core/message.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/
On Wed, 21 Nov 2012, Felipe Balbi wrote:
> On Thu, Nov 15, 2012 at 04:34:14PM +0200, Roger Quadros wrote:
> > From: Andy Green
> >
> > This patch changes the management of the two GPIO for
> > "hub reset" (actually controls enable of ULPI PHY and hub reset) and
> > "hub power" (controls power to
On 11/21/2012 03:45 PM, Felipe Balbi wrote:
> On Thu, Nov 15, 2012 at 04:34:07PM +0200, Roger Quadros wrote:
>> For some platforms e.g. OMAP5, we cannot rely on USBHOST revision
>> to determine the number of ports available. In such cases we have
>
> you need to make it clear *why* we can't. Imagi
On 11/21/2012 03:43 PM, Felipe Balbi wrote:
> On Thu, Nov 15, 2012 at 04:34:06PM +0200, Roger Quadros wrote:
>> prevents getting clocks that don't exist on the platform.
>>
>> Signed-off-by: Roger Quadros
>> ---
>> drivers/mfd/omap-usb-host.c | 47
>> ---
On Wed, Nov 21, 2012 at 10:09 PM, Felipe Balbi wrote:
>> status = musb_platform_init(musb);
>> - if (status < 0)
>> + if (status < 0) {
>> + /* try to defer probe if trasceiver is not ready */
>> + status = (status == -ENODEV ? -EPROBE_DEFER : status);
>
> sti
On Wed, Nov 14, 2012 at 3:40 PM, Linus Walleij
wrote:
> From: Haipeng YU
>
> When a device is switched off by software, gserial_cleanup will
> be called, and switch off will be blocked in this function
> because wake_up_interruptible() in gs_close() can not wake_up
> the wait_event() in gserial_
Martin Teichmann wrote:
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -192,6 +192,7 @@ static struct usb_device_id id_table_combined [] = {
> { USB_DEVICE(FTDI_VID, FTDI_OPENDCC_THROTTLE_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_OPENDCC_GATEWAY_PID) },
> { USB_DEVICE(FTDI_VID, FTDI
Hi,
On Wed, Nov 21, 2012 at 09:48:33PM +0800, Ming Lei wrote:
> If transceiver driver is built as module, the transceiver device
> may be added very late, so cause musb_init_controller() failed.
>
> This patch fixes the below error on 3.7-rcX:
>
> [ 19.052490] unable to find transceiver of typ
Hi,
On Wed, Nov 21, 2012 at 02:49:41PM +0200, Roger Quadros wrote:
> On 11/21/2012 02:12 PM, Felipe Balbi wrote:
> > On Thu, Nov 15, 2012 at 04:34:03PM +0200, Roger Quadros wrote:
> >> The TLL module on OMAP5 has 3 channels.
> >> HSIC mode requires the TLL channel to be in Transparent UTMI mode.
>
Hi,
On Wed, Nov 21, 2012 at 02:45:46PM +0200, Roger Quadros wrote:
> >>spin_unlock_irqrestore(&tll->lock, flags);
> >>
> >> - return 0;
> >> + return i;
> >> }
> >> +EXPORT_SYMBOL_GPL(omap_tll_enable);
> >>
> >> -static int usbtll_runtime_suspend(struct device *dev)
> >> +int omap_tll_d
Hi,
On Wed, Nov 21, 2012 at 02:36:48PM +0200, Roger Quadros wrote:
> >>break;
> >>default:
> >> - dev_err(dev, "TLL version failed\n");
> >> - ret = -ENODEV;
> >> - goto err_ioremap;
> >> + tll->nch = DEFAULT_TLL_CHANNEL_COUNT;
> >> + de
This adds a post handling routine which is called after
ci13xxx_add_device was called. The first user is the mx25, which has to
disable the external-vbus-divider after the ude has started.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
Changes since v2:
* added defines for
This driver will be used for every Freescale SoC which has this misc
memory layout to control the basic usb handling. So better name this
driver, function and struct names in a more generic way.
Reported-by: Fabio Estevam
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
Cha
Nearly every SoC from Freescale has this non-core usb registers. This series
adds support for more users of this driver.
This series is based on Peter Chen's work. Its needed to merge his master branch
before applying this series:
https://github.com/hzpeterchen/linux-usb.git
Marc Kleine-Budde (4
From: Marc Kleine-Budde
This attaches the usbmisc_ops to the of_device_id data and
makes it possible to define special functions per soc.
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Michael Grzeschik
---
Changes since v2:
* renamed bitmask to reflect soctype mx6
drivers/usb/chipidea/usbm
On Thu, Nov 15, 2012 at 04:34:14PM +0200, Roger Quadros wrote:
> From: Andy Green
>
> This patch changes the management of the two GPIO for
> "hub reset" (actually controls enable of ULPI PHY and hub reset) and
> "hub power" (controls power to hub + eth).
looks like this should be done by the hu
From: Marc Kleine-Budde
This fixes a potential race condition where the ci13xxx_imx glue code
could be fast enough to call one of the usbmisc_ops before he got a
valid value on the static usbmisc pointer. To fix that we first set
usbmisc, then call usbmisc_set_ops().
Signed-off-by: Marc Kleine-B
This adds mx53 as the next user of the usbmisc driver and makes it
possible to disable the overcurrent-detection of the internal phy.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
Changes since v2:
* added defines for register offsets and bitmasks
* fixed disable_oc optio
From: Marc Kleine-Budde
The probe function checks usbmisc to be NULL in the beginning. Without
this patch the can only be loaded once.
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Michael Grzeschik
---
Changes since v1:
* split previous patch into two seperate.
drivers/usb/chipidea/usbmis
From: Marc Kleine-Budde
This patch adds support for a second and third clock to the usbmisc driver. On
modern freescale ARM cores like the imx51, imx53 and imx6q three clocks ("ahb",
"ipg" and "per") must be enabled in order to access the USB core.
ahb - AMBA High-Performance Bus clock domain
ip
On Thu, Nov 15, 2012 at 04:34:13PM +0200, Roger Quadros wrote:
> Instead of enabling the USB PHY clock in the board file we
> provide the PHY clock details to the driver via board platform
> data so that driver code can manage the clock.
>
> Signed-off-by: Roger Quadros
this patch is ok-ish. But
On Thu, Nov 15, 2012 at 04:34:12PM +0200, Roger Quadros wrote:
> Boards like Panda require an auxiliary clock to clock the PHY
> that is connected to one of the USB ports. This patch enables
> board support code to provide the name and the rate of such
> a clock for each of the USB ports. omap-usb
Hi,
On Thu, Nov 15, 2012 at 04:34:11PM +0200, Roger Quadros wrote:
> We don't really need a spinlock here, so get rid of it.
can you prove it ? what if an IRQ happens right after disabling clocks
on ->runtime_suspend() but before it returns ? Will this not cause a
problem for you ?
(note that I
Hi,
On Thu, Nov 15, 2012 at 04:34:09PM +0200, Roger Quadros wrote:
> Enable the optional HSIC clocks (60MHz and 480MHz) for the ports
> that are configured in HSIC mode.
>
> Signed-off-by: Roger Quadros
> ---
> drivers/mfd/omap-usb-host.c | 56 +-
> 1 f
On Thu, Nov 15, 2012 at 04:34:08PM +0200, Roger Quadros wrote:
> OMAPs till date can have upto 3 ports. We need to initialize
s/upto/up to/
> the port mode in HOSTCONFIG register for all of them.
why *all* of them ? Isn't it enough to initialize only the ones we're
going to use ? If not, why ?
> I don't see any problems in my testcase.
This looks fine to me as by the time we call tty_ldisc_release we have
already set TTY_CLOSING on both sides.
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordom
On Thu, Nov 15, 2012 at 04:34:07PM +0200, Roger Quadros wrote:
> For some platforms e.g. OMAP5, we cannot rely on USBHOST revision
> to determine the number of ports available. In such cases we have
you need to make it clear *why* we can't. Imagine someone reading this 5
years from now... he'll be
On Thu, Nov 15, 2012 at 04:34:06PM +0200, Roger Quadros wrote:
> prevents getting clocks that don't exist on the platform.
>
> Signed-off-by: Roger Quadros
> ---
> drivers/mfd/omap-usb-host.c | 47
> ---
> 1 files changed, 35 insertions(+), 12 deletions
Currently, we have a bunch of files in sysfs that display all sorts of
debugging information for the device controller, so they have to move to
debugfs where they belong. The "registers" interface have been removed,
since it doesn't fit into the current driver design as is and it's hardly
a good id
If transceiver driver is built as module, the transceiver device
may be added very late, so cause musb_init_controller() failed.
This patch fixes the below error on 3.7-rcX:
[ 19.052490] unable to find transceiver of type USB2 PHY
[ 19.072052] HS USB OTG: no transceiver configured
[ 19.0769
Create and remove debugfs entries in hdrc probe/remove instead of
start/stop of the device controller. Gadget specific will not export
anything while the controller is in host mode.
Signed-off-by: Alexander Shishkin
---
drivers/usb/chipidea/core.c |6 +-
drivers/usb/chipidea/udc.c |
Manual role switching function is there for debugging purposes, so has
to move to debugfs.
Signed-off-by: Alexander Shishkin
---
drivers/usb/chipidea/core.c | 39 --
drivers/usb/chipidea/debug.c | 54 ++
2 files changed, 54
The driver also has interrupt counters and another ring buffer for keeping
track of the order in which they arrive. This patch converts these counters
to trace points. Userspace tools such as perf can provide information on both
order and stats of the interrupts.
Signed-off-by: Alexander Shishkin
As part of the legacy from the original driver design, we retain home-grown
tracing infrastructure, complete with own ring buffer and timestamps. While
it is useful for debugging certain cases, it's a lot of extra code, which
these days is rather redundant.
This patch replaces local tracing functi
This patchset cleans up the remaining debugging bits in the driver
by either conventing them to trace points or moving to debugfs, all
the while getting rid of home-grown tracing facilities.
Trace events are accessible through perf tool. If you don't yet have
it in your testing environment, now is
On Thu, Nov 15, 2012 at 04:34:05PM +0200, Roger Quadros wrote:
> We can just hold the pointer to the platform data instead
> of creating a copy of it.
>
> Also get rid of the unnecessary missing platform data checks
> in runtime_suspend/resume. We are already checking for missing
> platform data i
Hi,
On Thu, Nov 15, 2012 at 04:34:04PM +0200, Roger Quadros wrote:
> All ports have similarly named port clocks so we can
> bunch them into a port data structure and use for loop
> to enable/disable the clocks.
>
> Signed-off-by: Roger Quadros
> ---
> drivers/mfd/omap-usb-host.c | 208
> +
On Wed, Nov 21, 2012 at 9:04 PM, Sebastian Andrzej Siewior
wrote:
> On Wed, Nov 21, 2012 at 08:39:27PM +0800, Ming Lei wrote:
>> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
>> index 774d815..ef57a60 100644
>> --- a/drivers/usb/musb/musb_core.c
>> +++ b/drivers/usb/musb
On Wed, Nov 21, 2012 at 08:39:27PM +0800, Ming Lei wrote:
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 774d815..ef57a60 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1881,8 +1881,11 @@ musb_init_controller(struct device
On 11/21/2012 02:12 PM, Felipe Balbi wrote:
> On Thu, Nov 15, 2012 at 04:34:03PM +0200, Roger Quadros wrote:
>> The TLL module on OMAP5 has 3 channels.
>> HSIC mode requires the TLL channel to be in Transparent UTMI mode.
>>
>> Signed-off-by: Roger Quadros
>> ---
>> drivers/mfd/omap-usb-tll.c |
On 11/21/2012 02:06 PM, Felipe Balbi wrote:
> On Thu, Nov 15, 2012 at 04:34:02PM +0200, Roger Quadros wrote:
>> The port clocks are not required to access the port registers,
>> they are only needed when the PORT is used. So we move the port clock
>> handling code to omap_tll_enable/disable().
>>
>
If transceiver driver is built as module, the transceiver device
may be added very late, so cause musb_init_controller() failed.
This patch fixes the below failure on 3.7-rcX:
[ 19.052490] unable to find transceiver of type USB2 PHY
[ 19.072052] HS USB OTG: no transceiver configured
[ 19.07
Since commit 89c8d91e31f2 ("tty: localise the lock") I see a dead lock
in one of my dummy_hcd + g_nokia test cases. The first run one was usually
okay, the second often resulted in a splat by lockdep and the third was
usually a dead lock.
Lockdep complained about tty->hangup_work and tty->legacy_mu
On 11/21/2012 01:57 PM, Felipe Balbi wrote:
> On Thu, Nov 15, 2012 at 04:34:01PM +0200, Roger Quadros wrote:
>> This is a handy macro to check if the port requires the
>> USB TLL module or not. Use it to Enable the TLL module and manage
>> the clocks.
>>
>> Signed-off-by: Roger Quadros
>> ---
>>
Felipe,
Thanks for reviewing.
On 11/21/2012 01:55 PM, Felipe Balbi wrote:
> On Thu, Nov 15, 2012 at 04:34:00PM +0200, Roger Quadros wrote:
>> Every channel has a functional clock that is similarly named.
>> It makes sense to use a for loop to manage these clocks as OMAPs
>> can come with upto 3 c
On Thu, Nov 15, 2012 at 04:34:03PM +0200, Roger Quadros wrote:
> The TLL module on OMAP5 has 3 channels.
> HSIC mode requires the TLL channel to be in Transparent UTMI mode.
>
> Signed-off-by: Roger Quadros
> ---
> drivers/mfd/omap-usb-tll.c | 14 ++
> 1 files changed, 14 insertion
On Thu, Nov 15, 2012 at 04:34:02PM +0200, Roger Quadros wrote:
> The port clocks are not required to access the port registers,
> they are only needed when the PORT is used. So we move the port clock
> handling code to omap_tll_enable/disable().
>
> Also get of unnecessary spinlock code in probe f
On Thu, Nov 15, 2012 at 04:34:01PM +0200, Roger Quadros wrote:
> This is a handy macro to check if the port requires the
> USB TLL module or not. Use it to Enable the TLL module and manage
> the clocks.
>
> Signed-off-by: Roger Quadros
> ---
> drivers/mfd/omap-usb-tll.c | 20 --
On Thu, Nov 15, 2012 at 04:34:00PM +0200, Roger Quadros wrote:
> Every channel has a functional clock that is similarly named.
> It makes sense to use a for loop to manage these clocks as OMAPs
> can come with upto 3 channels.
s/upto/up to
BTW, this patch is doing a lot more than "cleaning up clo
On Thu, Nov 15, 2012 at 04:33:59PM +0200, Roger Quadros wrote:
> Just a pointer to the platform data should suffice.
>
> Signed-off-by: Roger Quadros
this looks fine to me:
Acked-by: Felipe Balbi
> ---
> drivers/mfd/omap-usb-tll.c |9 -
> 1 files changed, 4 insertions(+), 5 delet
Hi,
On Wed, Nov 21, 2012 at 12:05:12PM +0200, Roger Quadros wrote:
> Hi Tony,
>
> On 11/21/2012 01:13 AM, Tony Lindgren wrote:
> > Hi Roger,
> >
> > * Kevin Hilman [121119 15:24]:
> >> Roger Quadros writes:
> >>
> >>> Kevin,
> >>>
> >>> On 11/16/2012 10:08 PM, Kevin Hilman wrote:
> Roger
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD
Cc: linux-usb@vger.kernel.org
Cc: net...@vger.kernel.org
---
drivers/net/usb/asix_devices.c | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices
Hi Tony,
On 11/21/2012 01:13 AM, Tony Lindgren wrote:
> Hi Roger,
>
> * Kevin Hilman [121119 15:24]:
>> Roger Quadros writes:
>>
>>> Kevin,
>>>
>>> On 11/16/2012 10:08 PM, Kevin Hilman wrote:
Roger Quadros writes:
> Hi,
>
> This patchset addresses the following
>
On Wed, Nov 21, 2012 at 11:32:46AM +0200, Alexander Shishkin wrote:
> Peter Chen writes:
>
> > I can use this API, how can this API consolidate both of the case
> > (OTGSC_AVV)?
>
> Ok, then how about
>
> static int hw_wait_reg(struct ci13xxx *ci, enum ci13xxx_regs reg, u32 mask,
>
Peter Chen writes:
> I can use this API, how can this API consolidate both of the case
> (OTGSC_AVV)?
Ok, then how about
static int hw_wait_reg(struct ci13xxx *ci, enum ci13xxx_regs reg, u32 mask,
u32 value, unsigned long timeout)
{
unsigned long elapse = jiffies
On 11/20/2012 11:53 PM, Michal Nazarewicz wrote:
* Felipe Balbi | 2012-11-20 14:14:47 [+0200]:
would that work ?
Assume you get through with removal of module paramters. Do we end up
with two interfaces then? One for configfs and one for sysfs?
If anyone cares about my opinion, I don't think
86 matches
Mail list logo
