Hi, On Wed, Nov 21, 2012 at 02:49:41PM +0200, Roger Quadros wrote: > On 11/21/2012 02:12 PM, Felipe Balbi wrote: > > On Thu, Nov 15, 2012 at 04:34:03PM +0200, Roger Quadros wrote: > >> The TLL module on OMAP5 has 3 channels. > >> HSIC mode requires the TLL channel to be in Transparent UTMI mode. > >> > >> Signed-off-by: Roger Quadros <rog...@ti.com> > >> --- > >> drivers/mfd/omap-usb-tll.c | 14 ++++++++++++++ > >> 1 files changed, 14 insertions(+), 0 deletions(-) > >> > >> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c > >> index 31ac7db..c48d545 100644 > >> --- a/drivers/mfd/omap-usb-tll.c > >> +++ b/drivers/mfd/omap-usb-tll.c > >> @@ -54,10 +54,13 @@ > >> > >> #define OMAP_TLL_CHANNEL_CONF(num) (0x040 + 0x004 > >> * num) > >> #define OMAP_TLL_CHANNEL_CONF_FSLSMODE_SHIFT 24 > >> +#define OMAP_TLL_CHANNEL_CONF_DRVVBUS (1 << 16) > >> +#define OMAP_TLL_CHANNEL_CONF_CHRGVBUS (1 << 15) > >> #define OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF (1 << 11) > >> #define OMAP_TLL_CHANNEL_CONF_ULPI_ULPIAUTOIDLE (1 << 10) > >> #define OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE (1 << 9) > >> #define OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE (1 << 8) > >> +#define OMAP_TLL_CHANNEL_CONF_MODE_TRANSPARENT_UTMI (2 << 1) > >> #define OMAP_TLL_CHANNEL_CONF_CHANMODE_FSLS (1 << 1) > >> #define OMAP_TLL_CHANNEL_CONF_CHANEN (1 << 0) > >> > >> @@ -96,6 +99,7 @@ > >> #define OMAP_USBTLL_REV1 0x00000015 /* OMAP3 */ > >> #define OMAP_USBTLL_REV2 0x00000018 /* OMAP 3630 */ > >> #define OMAP_USBTLL_REV3 0x00000004 /* OMAP4 */ > >> +#define OMAP_USBTLL_REV4 0x6 /* OMAP5 */ > > > > looks wrong to me. Are you sure this is what that 32-bit register reads > > out ? Bits[31:30] should read as 0b01 as per internal documentation. > > > > Yes I'm pretty sure about that. I'm on 5432 though. Not sure if 5430 > shows different.
this is really peculiar about these IPs... Anyway, if you made sure, fair enough. Just make the 0x6 more explicitly 32-bits like the other macros (0x00000006) -- balbi
signature.asc
Description: Digital signature
