[PATCH] Remove "raw devices" support.

2007-01-14 Thread Robert P. J. Day
Remove all traces of "raw devices" support. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- since this feature is listed as being obsolete since 2.6.3 and was scheduled for removal back in Dec of 2005, I figure there wasn't much harm in getting rid of it.

[PATCH][REVISED] Remove all traces of "raw device" support.

2007-01-14 Thread Robert P. J. Day
Remove all traces of raw devices support, which were officially obsolete since 2.6.3. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- crap. the "allyesconfig" build worked, except when it came to installing the sanitized headers, whose include/linux/Kbuild

Another potential kbuild cleanup -- "def_boolean"

2007-01-15 Thread Robert P. J. Day
while the kconfig parser recognizes both "def_bool" and "def_boolean", apparently no one uses the longer form, so it's probably safe to toss if there are no plans to use it in the future. rday - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

any value to fixing apparent bugs in old ISDN4Linux?

2007-01-15 Thread Robert P. J. Day
$ grep -r DE_AOC . ./.config:CONFIG_DE_AOC=y ./drivers/isdn/hisax/l3dss1.c:#ifdef HISAX_DE_AOC ./drivers/isdn/hisax/l3dss1.c:#else /* not HISAX_DE_AOC */ ./drivers/isdn/hisax/l3dss1.c:#endif /* not HISAX_DE_AOC */ ./drivers/isdn/hisax/Kconfig:config DE_AOC it seems like there's a name mismatch

Re: LEDS: S3C24XX generate name if none given

2007-01-15 Thread Robert P. J. Day
On Mon, 15 Jan 2007, Ben Dooks wrote: > Generate a name if none is passed to the S3C24XX GPIO LED driver. > > Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> > > diff -urpN -X ../dontdiff linux-2.6.19/drivers/leds/leds-s3c24xx.c > linux-2.6.19-simtec1p22/drivers/leds/leds-s3c24xx.c > --- linux-2.6.1

Re: any value to fixing apparent bugs in old ISDN4Linux?

2007-01-15 Thread Robert P. J. Day
On Mon, 15 Jan 2007, Tilman Schmidt wrote: > Robert P. J. Day schrieb: > > OTOH, since that code *is* in the allegedly obsolete old ISDN4Linux > > code, perhaps that entire part of the tree can just be junked. but if > > it's sticking around, it should probably b

[PATCH] Remove a number of "dead" config variables.

2007-01-15 Thread Robert P. J. Day
Remove Kconfig entries (and some documentation) for apparently "dead" config variables. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- A script I threw together identified the following as apparently useless config variables. By "useless," I mean that th

Re: [PATCH 2.6.20-rc5 2/4] pvrusb2: Use ARRAY_SIZE macro

2007-01-16 Thread Robert P. J. Day
On Tue, 16 Jan 2007, Ahmed S. Darwish wrote: > Use ARRAY_SIZE macro in pvrusb2-hdw.c file > > Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> ... snip ... i'm not sure it's worth submitting multiple patches to convert code expressions to the ARRAY_SIZE() macro since i was going to wait for t

[PATCH] Remove the last reference to rwlock_is_locked() macro.

2007-01-16 Thread Robert P. J. Day
Remove the lone, remaining reference to the long-deceased rwlock_is_locked() macro. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/include/asm-arm/spinlock.h b/include/asm-arm/spinlock.h index 861092f..800ba52 100644 --- a/include/asm-arm/spinlock.h +++ b/inclu

[PATCH][REVISED] Remove "dead" kernel config variables.

2007-01-16 Thread Robert P. J. Day
Remove what appear to be a number of dead kernel config variables, that apparently have no effect on the build process. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- whoops, ignore that last patch. it contained a single line change to a defconfig file, which is a silly th

[PATCH] Remove apparently unused IPDDP_DECAP kernel config variable.

2007-01-16 Thread Robert P. J. Day
Remove an apparently unused, Appletalk-related kernel config variable IPDDP_DECAP. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- the kernel config variable IPDDP_DECAP seems superfluous given where else one finds the string "IPDDP_DECAP" in the kernel source

how exactly is the macro SPIN_LOCK_UNLOCKED going to be removed?

2007-01-16 Thread Robert P. J. Day
(the following applies equally well to RW_LOCK_UNLOCKED.) according to Documentation/spinlocks.txt: == Macros SPIN_LOCK_UNLOCKED and RW_LOCK_UNLOCKED are deprecated and will be removed soon. So for any new code dynamic initialization should be used: spin

Re: [PATCH 2.6.20-rc5 2/4] pvrusb2: Use ARRAY_SIZE macro

2007-01-16 Thread Robert P. J. Day
On Tue, 16 Jan 2007, Randy Dunlap wrote: > On Tue, 16 Jan 2007 03:36:16 -0500 (EST) Robert P. J. Day wrote: > > > On Tue, 16 Jan 2007, Ahmed S. Darwish wrote: > > > > > Use ARRAY_SIZE macro in pvrusb2-hdw.c file > > > > > > Signed-off-by: Ahmed S.

"obsolete" versus "deprecated", and a new config option?

2007-01-17 Thread Robert P. J. Day
a couple random thoughts on the notion of obsolescence and deprecation. first, there are places in the kernel (primarily Kconfig files) and the documentation that unnecessarily conflate these two properties. as a simple example, consider drivers/pcmcia/Kconfig: ===

Re: "obsolete" versus "deprecated", and a new config option?

2007-01-17 Thread Robert P. J. Day
On Wed, 17 Jan 2007, Bill Davidsen wrote: > Robert P. J. Day wrote: > > a couple random thoughts on the notion of obsolescence and > > deprecation. > > [...horrible example deleted...] > > > so is that ioctl obsolete or deprecated? those aren't the

[PATCH] Introduce two new maturlty levels: DEPRECATED and OBSOLETE.

2007-01-17 Thread Robert P. J. Day
To go along with the EXPERIMENTAL kernel config status, introduce two new states: DEPRECATED and OBSOLETE. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- just adding these config variables to init/Kconfig shouldn't affect the current build status, but it will allow de

Re: "obsolete" versus "deprecated", and a new config option?

2007-01-17 Thread Robert P. J. Day
On Wed, 17 Jan 2007, [EMAIL PROTECTED] wrote: > On Wed, 17 Jan 2007 11:51:27 EST, "Robert P. J. Day" said: > > > > in any event, what about introducing a new config variable, > > OBSOLETE, under "Code maturity level options"? this would seem to be &g

Re: [PATCH] Introduce two new maturlty levels: DEPRECATED and OBSOLETE.

2007-01-17 Thread Robert P. J. Day
On Wed, 17 Jan 2007, H. Peter Anvin wrote: > DEPRECATED should presumably default to Y; OBSOLETE to n. you presume correctly. rday - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.or

Re: [PATCH] Introduce two new maturlty levels: DEPRECATED and OBSOLETE.

2007-01-17 Thread Robert P. J. Day
On Wed, 17 Jan 2007, H. Peter Anvin wrote: > DEPRECATED should presumably default to Y; OBSOLETE to n. crap, now i see what you were getting at -- i forgot to assign defaults. i'll resubmit, but i'll wait for anyone to suggest any better help content if they have a better idea. rday - To unsubs

[PATCH] Add new categories of DEPRECATED and OBSOLETE.

2007-01-17 Thread Robert P. J. Day
Next to EXPERIMENTAL, add two new kernel config categories of DEPRECATED and OBSOLETE. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- speak now or forever ... too late. diff --git a/init/Kconfig b/init/Kconfig index a3f83e2..433dd30 100644 --- a/init/Kconfig +++ b/init/K

Re: "obsolete" versus "deprecated", and a new config option?

2007-01-17 Thread Robert P. J. Day
On Wed, 17 Jan 2007, [EMAIL PROTECTED] wrote: > On Wed, 17 Jan 2007 17:04:20 EST, "Robert P. J. Day" said: > > > > How much of the 'OBSOLETE' code should just be labelled 'BROKEN' > > > instead? > > > > the stuff that's actu

Re: [PATCH] Add new categories of DEPRECATED and OBSOLETE.

2007-01-18 Thread Robert P. J. Day
On Thu, 18 Jan 2007, Cedric Le Goater wrote: > Robert P. J. Day wrote: > > Next to EXPERIMENTAL, add two new kernel config categories of > > DEPRECATED and OBSOLETE. > > What about adding some printks when DEPRECATED and OBSOLETE are set > ? like in print_tainted() for

Re: [PATCH] Introduce two new maturlty levels: DEPRECATED and OBSOLETE.

2007-01-18 Thread Robert P. J. Day
On Thu, 18 Jan 2007, Jan Engelhardt wrote: > > >On Wed, 17 Jan 2007, H. Peter Anvin wrote: > > > >> DEPRECATED should presumably default to Y; OBSOLETE to n. > > > >crap, now i see what you were getting at -- i forgot to assign > >defaults. i'll resubmit, but i'll wait for anyone to suggest any >

[PATCH] Centralize the macro definition of "__packed".

2007-01-18 Thread Robert P. J. Day
Centralize the attribute macro definition of "__packed" so no subsystem has to do that explicitly. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- compile tested to make sure the HFS subsystem still builds. now there's just 50 gazillion usages of "__attri

Re: [PATCH] Make CARDBUS_MEM_SIZE and CARDBUS_IO_SIZE customizable

2007-01-18 Thread Robert P. J. Day
On Thu, 18 Jan 2007, Ralf Baechle wrote: > On Fri, Jan 19, 2007 at 12:23:46AM +0900, Atsushi Nemoto wrote: > > > CARDBUS_MEM_SIZE was increased to 64MB on 2.6.20-rc2, but larger size > > might result in allocation failure for the reserving itself on some > > platforms (for example typical 32bit MI

Re: [PATCH] Centralize the macro definition of "__packed".

2007-01-18 Thread Robert P. J. Day
On Thu, 18 Jan 2007, Robert P. J. Day wrote: > Centralize the attribute macro definition of "__packed" so no > subsystem has to do that explicitly. ummm ... might want to ignore this submission, i want to do some tweaking first. sorry. rday - To unsubscribe from this lis

Re: [PATCH] Centralize the macro definition of "__packed".

2007-01-18 Thread Robert P. J. Day
On Thu, 18 Jan 2007, Tim Schmielau wrote: > On Thu, 18 Jan 2007, Robert P. J. Day wrote: > > > Centralize the attribute macro definition of "__packed" so no > > subsystem has to do that explicitly. > > > > Signed-off-by: Robert P. J. Day <[EMAIL PROTE

Re: [PATCH] Centralize the macro definition of "__packed".

2007-01-18 Thread Robert P. J. Day
On Thu, 18 Jan 2007, Tim Schmielau wrote: > On Thu, 18 Jan 2007, Robert P. J. Day wrote: > > > actually, it *appears* that the standard works this way. the macro > > "__deprecated" is defined in compiler-gcc.h with: > > > > #define __deprecated __att

[PATCH] extend the set of "__attribute__" shortcut macros

2007-01-18 Thread Robert P. J. Day
Extend the set of "__attribute__" shortcut macros, and remove identical (and now superfluous) definitions from a couple of source files. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- based on a page at robert love's blog: http://rlove.org/log/20051

can someone explain "inline" once and for all?

2007-01-19 Thread Robert P. J. Day
apologies if this is an inappropriately trivial question but this has been bugging me for a while. what is the deal with "inline"? first, there appear to be three possible ways of specifying an inline routine in the kernel source: $ grep -r "static inline " . $ grep -r "static __inline_

Re: can someone explain "inline" once and for all?

2007-01-19 Thread Robert P. J. Day
On Fri, 19 Jan 2007, Pekka Enberg wrote: > On 1/19/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > is there a simple explanation for how to *properly* define inline > > routines in the kernel? and maybe this can be added to the > > CodingStyle guide (he m

Re: can someone explain "inline" once and for all?

2007-01-19 Thread Robert P. J. Day
On Fri, 19 Jan 2007, Andreas Schwab wrote: > "Robert P. J. Day" <[EMAIL PROTECTED]> writes: > > > first, there appear to be three possible ways of specifying an > > inline routine in the kernel source: > > > > $ grep -r "static inline "

Re: can someone explain "inline" once and for all?

2007-01-19 Thread Robert P. J. Day
On Fri, 19 Jan 2007, Andreas Schwab wrote: > "Robert P. J. Day" <[EMAIL PROTECTED]> writes: > > > but in terms of strict C89 compatibility, it would seem to be a bit > > late for that given: > > > > $ grep -r "static inline " . > >

Re: can someone explain "inline" once and for all?

2007-01-19 Thread Robert P. J. Day
On Fri, 19 Jan 2007, Adrian Bunk wrote: > On Fri, Jan 19, 2007 at 03:01:44PM +0200, Pekka Enberg wrote: > > On 1/19/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > >is there a simple explanation for how to *properly* define inline > > >routines in the kernel

Re: can someone explain "inline" once and for all?

2007-01-19 Thread Robert P. J. Day
On Fri, 19 Jan 2007, Adrian Bunk wrote: > With the current implementation in the kernel (and considering that > CONFIG_FORCED_INLINING was implemented in a way that it never had > any effect), __always_inline and inline are currently equivalent. yes, that option was implemented in a half-assed so

[PATCH] Stop making "inline" imply forced inlining.

2007-01-19 Thread Robert P. J. Day
Remove the macros that define simple "inlining" to mean forced inlining, since you can (and *should*) get that effect with the CONFIG_FORCED_INLINING kernel config variable instead. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- this change was compile tested o

Re: [PATCH] Stop making "inline" imply forced inlining.

2007-01-19 Thread Robert P. J. Day
On Fri, 19 Jan 2007, Adrian Bunk wrote: > On Fri, Jan 19, 2007 at 11:56:30AM -0500, Robert P. J. Day wrote: > > > > Remove the macros that define simple "inlining" to mean forced > > inlining, since you can (and *should*) get that effect with the > >

[PATCH] Remove redundant (deprecated) CONFIG_FORCED_INLINING option.

2007-01-19 Thread Robert P. J. Day
Remove the superfluous kernel config option FORCED_UNLINING from the kernel debugging menu. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- based on adrian bunk's explanation, and the fact that i just noticed this option was scheduled for removal several months ago a

[PATCH] Remove final reference to superfluous smp_commence().

2007-01-20 Thread Robert P. J. Day
Remove the last (and commented out) invocation of the obsolete smp_commence() call. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/init/main.c b/init/main.c index 8b4a7d7..4e88bdd 100644 --- a/init/main.c +++ b/init/main.c @@ -395,11 +395,6 @@ static void

[PATCH] Introduce simple TRUE and FALSE boolean macros.

2007-01-21 Thread Robert P. J. Day
Introduce the TRUE and FALSE boolean macros so that everyone can stop re-inventing them, and remove the one occurrence in the source tree that clashes with that change. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- once this patch is applied, others can remove all

Re: [PATCH] Introduce simple TRUE and FALSE boolean macros.

2007-01-21 Thread Robert P. J. Day
On Sun, 21 Jan 2007, Nicholas Miell wrote: > On Sun, 2007-01-21 at 05:03 -0500, Robert P. J. Day wrote: > > Introduce the TRUE and FALSE boolean macros so that everyone can > > stop re-inventing them, and remove the one occurrence in the > > source tree that clashes wi

Re: [PATCH] Introduce simple TRUE and FALSE boolean macros.

2007-01-22 Thread Robert P. J. Day
On Mon, 22 Jan 2007, Nick Piggin wrote: > Robert P. J. Day wrote: > > > by adding (temporarily) the definitions of TRUE and FALSE to > > types.h, you should then (theoretically) be able to delete over > > 100 instances of those same macros being *defined* throughout the

Re: [PATCH] Introduce simple TRUE and FALSE boolean macros.

2007-01-22 Thread Robert P. J. Day
On Mon, 22 Jan 2007, Mike Galbraith wrote: > On Mon, 2007-01-22 at 06:02 -0500, Robert P. J. Day wrote: > > On Mon, 22 Jan 2007, Nick Piggin wrote: > > > > > Robert P. J. Day wrote: > > > > > > > by adding (temporarily) the definitions of TRUE

[PATCH] Change incorrect "CONFIG_INPUT_ATIXL" to "CONFIG_MOUSE_ATIXL".

2007-01-22 Thread Robert P. J. Day
Change the apparently incorrect check for CONFIG_INPUT_ATIXL in a source file to be consistent with the kernel config option CONFIG_MOUSE_ATIXL. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- this *looks* like a bug. diff --git a/drivers/input/mouse/inport.c b/drivers

identifying CONFIG variable typoes in the source tree

2007-01-23 Thread Robert P. J. Day
because it's cold outside and i was bored, i put together the following script, to be run from the top of the source tree: ==B #!/bin/sh CV=$(grep -rh "^#.*if.* CONFIG_[A-Za-z0-9]" . | grep -v endif) CVARS=$(echo "${CV}" | sed "s/.*\(CONFIG_[

Re: identifying CONFIG variable typoes in the source tree

2007-01-23 Thread Robert P. J. Day
On Tue, 23 Jan 2007, Oleg Verych wrote: > On 2007-01-23, Robert P. J. Day wrote: > [] > > what it does is scan the entire tree for lines of the form > > > > ...if... CONFIG_whatever... > > > > collects all of those CONFIG variables and, one at a time, che

Re: identifying CONFIG variable typoes in the source tree

2007-01-24 Thread Robert P. J. Day
On Wed, 24 Jan 2007, Geert Uytterhoeven wrote: > On Tue, 23 Jan 2007, Robert P. J. Day wrote: > > let's check these: > > > > $ grep -r 53C700_BE_BUS . > > ./drivers/scsi/53c700.h:#ifdef CONFIG_53C700_BE_BUS > > This is the core support for big endian

[PATCH] Add a rounddown_pow_of_two() macro to log2.h.

2007-01-25 Thread Robert P. J. Day
In the same way that include/linux/log2.h defines the roundup_pow_of_two() macro, define the rounddown_pow_of_two() macro so peopls can stop re-implementing this operation using a loop. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- compile tested on x86 using "make a

Re: Strange LKML home page!!!

2007-01-25 Thread Robert P. J. Day
isn't associated with kernel.org. > > I don't know why it happened like that. This time I shall take a > picture with my Digicam & post here. why? randy already explained that that site has nothing to do with kernel.org. why do you care? rday -- ===

[PATCH] Fix "CONFIG_X86_64_" typo in drivers/kvm/svm.c.

2007-01-25 Thread Robert P. J. Day
Fix what looks like an obvious typo in the file drivers/kvm/svm.c. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- is this, in fact, a typo? diff --git a/drivers/kvm/svm.c b/drivers/kvm/svm.c index 7397bfb..1764fb6 100644 --- a/drivers/kvm/svm.c +++ b/drivers/kvm/svm.c @@ -

[PATCH] Fix apparent "CONFIG_64_BIT" typo.

2007-01-25 Thread Robert P. J. Day
Fix apparent typo, where CONFIG_64_BIT should read CONFIG_64BIT. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/include/asm-um/elf-ppc.h b/include/asm-um/elf-ppc.h index 9971113..d3b90b7 100644 --- a/include/asm-um/elf-ppc.h +++ b/include/asm-um/elf-ppc.h @@ -11,7

[PATCH] Fix apparent typo of "CONFIG_MT_SMP".

2007-01-25 Thread Robert P. J. Day
Replace apparent typo of CONFIG_MT_SMP with CONFIG_MIPS_MT_SMP. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/arch/mips/mips-boards/sim/sim_setup.c b/arch/mips/mips-boards/sim/sim_setup.c index 2659c1c..ea2066c 100644 --- a/arch/mips/mips-boards/sim/sim_setup.c

[PATCH] Fix apparent typo "CONFIG_SERIAL_CPM_SMC".

2007-01-25 Thread Robert P. J. Day
Replace an apparent typo of CONFIG_SERIAL_CPM_SMC with CONFIG_SERIAL_CPM_SMC2. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/arch/ppc/platforms/mpc866ads_setup.c b/arch/ppc/platforms/mpc866ads_setup.c index 8a0c07e..5b05d4b 100644 --- a/arch/ppc/pla

[PATCH] Fix apparent typo CONFIG_USB_CDCETHER.

2007-01-25 Thread Robert P. J. Day
Replace the apparent typo CONFIG_USB_CDCETHER with CONFIG_USB_NET_CDCETHER. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- i *think* this is correct, but i'll leave the final decision to those higher up the food chain. diff --git a/drivers/usb/core/otg_whitelist.h b/

coding style and re-inventing the wheel way too many times

2006-12-21 Thread Robert P. J. Day
this little project of mine of submitting the occasional code "cleanup" has turned out to be way more daunting than i originally thought, given how many source files insist on constantly re-inventing the wheel. consider a couple useful macros defined in include/linux/kernel.h: #define DIV_RO

Re: [RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().

2006-12-22 Thread Robert P. J. Day
On Fri, 22 Dec 2006, Christoph Hellwig wrote: > On Wed, Dec 20, 2006 at 04:46:51PM -0800, Andrew Morton wrote: > > On Sun, 17 Dec 2006 07:43:39 -0500 (EST) > > "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > > > > > as with ARRAY_SIZE(), there are a

[PATCH] Rename FIELD_SIZEOF to MEMBER_SIZE and use in source tree.

2006-12-22 Thread Robert P. J. Day
Rename the macro FIELD_SIZEOF() in include/linux/kernel.h to MEMBER_SIZE(), and make a number of replacements in the source tree where that macro simplified the code. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- here's a reworked patch that uses a more reasonable na

Re: [PATCH] Rename FIELD_SIZEOF to MEMBER_SIZE and use in source tree.

2006-12-22 Thread Robert P. J. Day
On Fri, 22 Dec 2006, Randy Dunlap wrote: > On Fri, 22 Dec 2006 10:34:09 -0500 (EST) Robert P. J. Day wrote: > > > > > Rename the macro FIELD_SIZEOF() in include/linux/kernel.h to > > MEMBER_SIZE(), and make a number of replacements in the source tree > > where

Re: [PATCH] Remove logically superfluous comparisons from Kconfig files.

2006-12-27 Thread Robert P. J. Day
On Wed, 27 Dec 2006, Horst H. von Brand wrote: > Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > Remove Kconfig comparisons of the form FUBAR || FUBAR=n, since they > > appear to be superfluous. > > > > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>

replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2006-12-28 Thread Robert P. J. Day
is there some reason there are so many calls of the form memset(addr, 0, PAGE_SIZE) rather than the apparently equivalent invocation of clear_page(addr) the majority of architectures appear to define the clear_page() macro in their include//page.h header file, but not entirely identicall

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2006-12-30 Thread Robert P. J. Day
On Sat, 30 Dec 2006, Denis Vlasenko wrote: > On Friday 29 December 2006 07:16, Robert P. J. Day wrote: > > > > is there some reason there are so many calls of the form > > > > memset(addr, 0, PAGE_SIZE) > > > > rather than the apparently equivalent

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2006-12-30 Thread Robert P. J. Day
On Sat, 30 Dec 2006, Arjan van de Ven wrote: > rday wrote: > > ... most of the definitions of the clear_page() macro are simply > > invocations of memset(). see for yourself: > *MOST*. Not all. i did notice that. while the majority of the architectures simply define clear_page() as a macro ca

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2006-12-31 Thread Robert P. J. Day
On Sun, 31 Dec 2006, Arjan van de Ven wrote: > On Sun, 2006-12-31 at 14:39 +0100, Folkert van Heusden wrote: > > > > i don't see how that can be true, given that most of the definitions > > > > of the clear_page() macro are simply invocations of memset(). see for > > > > yourself: > > > *MOST*. N

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2006-12-31 Thread Robert P. J. Day
On Mon, 1 Jan 2007, Paul Mundt wrote: > On Sat, Dec 30, 2006 at 06:04:14PM -0500, Robert P. J. Day wrote: > > fair enough. *technically*, not every call of the form > > "memset(ptr,0,PAGE_SIZE)" necessarily represents an address that's on > > a page boundary.

[PATCH] Documentation: Explain a second alternative for multi-line macros.

2006-12-31 Thread Robert P. J. Day
Add an explanation for defining multi-line macros using the ({ }) notation to CodingStyle. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle index 9069189..1d0ddb8 100644 --- a/Documentation/CodingStyle

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2006-12-31 Thread Robert P. J. Day
On Sun, 31 Dec 2006, Muli Ben-Yehuda wrote: > On Sun, Dec 31, 2006 at 02:32:25PM -0500, Robert P. J. Day wrote: > > > Generally, inline functions are preferable to macros resembling > > functions. > > This should be stressed, IMHO. We have too many macros which

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2006-12-31 Thread Robert P. J. Day
On Sun, 31 Dec 2006, Muli Ben-Yehuda wrote: > On Sun, Dec 31, 2006 at 02:49:48PM -0500, Robert P. J. Day wrote: > > > there would appear to be *lots* of cases where the ({ }) notation > > is used when nothing is being returned. i'm not sure you can be > > that adam

[PATCH] Simplify some code to use the container_of() macro.

2006-12-31 Thread Robert P. J. Day
Simplify a number of code snippets in source and header files to use the kernel.h "container_of()" macro. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- and while we're at it, everybody can stop re-inventing the container_of() macro. :-) drivers/net/ppp_ge

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2007-01-01 Thread Robert P. J. Day
On Mon, 1 Jan 2007, Segher Boessenkool wrote: > > > In this case, the second form > > > should be used when the macro needs to return a value (and you can't > > > use an inline function for whatever reason), whereas the first form > > > should be used at all other times. > > > > that's a fair poin

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2007-01-01 Thread Robert P. J. Day
On Mon, 1 Jan 2007, Folkert van Heusden wrote: > > > regarding alignment that don't allow clear_page() to be used > > > copy_page() in the memcpy() case), but it's going to need a lot of > > Maybe these optimalisations should be in the coding style docs? i was thinking of submitting the following

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2007-01-01 Thread Robert P. J. Day
On Mon, 1 Jan 2007, Arjan van de Ven wrote: > > Given the above, some basic suggestions for page-based memory management: > > > > (a) If you need to allocate or free a single page, use the single page > > version of the routine/macro, rather than calling the multi-page > > version wit

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2007-01-01 Thread Robert P. J. Day
On Mon, 1 Jan 2007, Christoph Hellwig wrote: > On Sun, Dec 31, 2006 at 02:32:25PM -0500, Robert P. J. Day wrote: > > + (a) Enclose those statements in a do - while block: > > + > > + #define macrofun(a, b, c)

Re: Open letter to Linux kernel developers (was Re: Binary Drivers)

2007-01-02 Thread Robert P. J. Day
On Tue, 2 Jan 2007, Theodore Tso wrote: > I can very easily believe it. The US patent system and "justice" > system in the US is completely and totally insane, and companies > often feel they have to act accordingly. Remember this is the > country that has issued multi-million dollar awards to p

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2007-01-03 Thread Robert P. J. Day
On Sun, 31 Dec 2006, Arjan van de Ven wrote: > So... yes I fully agree with you that it's worth looking at the > memset( , PAGE_SIZE) users. If they are page aligned, yes absolutely > make it a clear_page(), I think that's a very good idea. However > also please check if they've been very recently

[PATCH] Replace __get_free_page() + memset(0) with get_zeroed_page() calls.

2007-01-03 Thread Robert P. J. Day
Replace the small number of combinations of __get_free_page() plus a call to memset(...,0,PAGE_SIZE) with a single call to get_zeroed_page(). Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- all of the following simplifications *look* valid, but i'm happy to be convince

Re: [PATCH] Replace __get_free_page() + memset(0) with get_zeroed_page() calls.

2007-01-03 Thread Robert P. J. Day
On Wed, 3 Jan 2007, Jiri Slaby wrote: > Robert P. J. Day wrote: > [...] > > index fd82411..b3932e5 100644 > > --- a/include/asm-m68k/sun3_pgalloc.h > > +++ b/include/asm-m68k/sun3_pgalloc.h > > @@ -36,12 +36,11 @@ static inline void pte_free(struct page *

[PATCH] Get rid of "double zeroing" of allocated pages

2007-01-03 Thread Robert P. J. Day
Simplify the few instances where a call to "get_zeroed_page()" is closely followed by an unnecessary call to memset() to clear that page. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- there appeared to be only three of these in the tree, and i'm not quite su

Re: [PATCH] Simplify some code to use the container_of() macro.

2007-01-03 Thread Robert P. J. Day
On Wed, 3 Jan 2007, Andrew Morton wrote: > On Sun, 31 Dec 2006 15:55:22 -0500 (EST) > "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > > > --- a/net/ipv4/netfilter/nf_nat_core.c > > +++ b/net/ipv4/netfilter/nf_nat_core.c > > @@ -168,7 +168,7 @@ find_appr

Re: [PATCH] Simplify some code to use the container_of() macro.

2007-01-04 Thread Robert P. J. Day
On Wed, 3 Jan 2007, Andrew Morton wrote: > On Sun, 31 Dec 2006 15:55:22 -0500 (EST) > "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > > > --- a/net/ipv4/netfilter/nf_nat_core.c > > +++ b/net/ipv4/netfilter/nf_nat_core.c > > @@ -168,7 +168,7 @@ find_appr

[PATCH] Fix misspellings collected by members of KJ list.

2007-02-21 Thread Robert P. J. Day
Fix the misspellings of "propogate", "writting" and (oh, the shame :-) "kenrel" in the source tree. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- Documentation/sysctl/kernel.txt |2 +- arch/powerpc/oprofile/op_model_cell.c |

[PATCH] kconfig: Centralize the selection of semaphore debugging in lib/Kconfig.debug.

2007-02-21 Thread Robert P. J. Day
Remove the Kconfig selection of semaphore debugging from the ALPHA and FRV Kconfig files, and centralize it in lib/Kconfig.debug. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- there doesn't seem to be much point in letting individual architectures independently defi

[PATCH] ReiserFS: Correct misspelled "REISERFS_PROC_INFO" to "CONFIG_REISERFS_PROC_INFO".

2007-02-21 Thread Robert P. J. Day
Correct the misspelling of the preprocessor check of a Kconfig option to refer to CONFIG_REISERFS_PROC_INFO and not just the incorrect REISERFS_PROC_INFO. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/fs/reiserfs/procfs.c b/fs/reiserfs/procfs.c index ecc9943..8

[PATCH] Fix "deprecated" typoes.

2007-02-22 Thread Robert P. J. Day
Fix remaining misspellings of "depreciated" to "deprecated." Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- happy now, randy? :-) Documentation/arm/Interrupts |2 +- drivers/net/hamradio/Kconfig |2 +- drivers/net/wi

[PATCH] Correct comment to refer to proper /proc file.

2007-02-22 Thread Robert P. J. Day
Correct a comment that information is exported via, not /proc/rtc, but /proc/driver/rtc. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/drivers/char/genrtc.c b/drivers/char/genrtc.c index 23b25ad..ea05265 100644 --- a/drivers/char/genrtc.c +++ b/drivers/char/ge

[PATCH][REVISED] Correct comments in genrtc.c to refer to correct /proc file.

2007-02-22 Thread Robert P. J. Day
Correct documentation in genrtc.c to refer to the correct /proc file that's used to export information: /proc/driver/rtc. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- oops ... scratch that last submission. diff --git a/drivers/char/genrtc.c b/drivers/char/genrtc.c in

Re: off topic: Dolphin massacre in Japan

2007-02-23 Thread Robert P. J. Day
On Fri, 23 Feb 2007, Aggelos wrote: ... snip ... > I' am not asking for excuse. > Nor do I feel guilty. ... snip ... > Never asked for exceptions. > Sorry for the brains of some people, though... please don't drag this out, just blacklist this person *now* and let's move on. rday - To unsubscrib

Re: trivial question regarding byte ordering

2007-02-23 Thread Robert P. J. Day
r either big or little endianness. rday -- ============ Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?

why is asm-parisc/ioctl.h subtly different from asm-generic/ioctl.h?

2007-02-24 Thread Robert P. J. Day
READ 2U --- > #define _IOC_WRITE2U > #define _IOC_READ 1U so parisc is identical except that it switches the meaning of the direction field? is there a reason for this? just curious. rday -- ============ Robert P. J. Day

[PATCH] MIPS: Remove unreferenced _IOC_SLMASK macro in ioctl.h.

2007-02-24 Thread Robert P. J. Day
Delete the definition of the apparently unreferenced macro _IOC_SLMASK. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/include/asm-mips/ioctl.h b/include/asm-mips/ioctl.h index cba641a..2036fcb 100644 --- a/include/asm-mips/ioctl.h +++ b/include/asm-mips/i

[PATCH][RFC] Make asm-generic/ioctl.h extensible by adding conditionals.

2007-02-24 Thread Robert P. J. Day
Add some preprocessor checking to asm-generic/ioctl.h to allow other ioctl.h headers to simply override what are normally trivial differences. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- as a followup to my earlier post, is it worth making this change to allow at least a

Re: ioctls.h (Re: [PATCH][RFC] Make asm-generic/ioctl.h extensible by adding conditionals.)

2007-02-24 Thread Robert P. J. Day
On Sat, 24 Feb 2007, Oleg Verych wrote: > > From: "Robert P. J. Day" > > Newsgroups: gmane.linux.kernel > > Subject: [PATCH][RFC] Make asm-generic/ioctl.h extensible by adding > > conditionals. > > Date: Sat, 24 Feb 2007 06:45:20 -0500 (EST) > > >

[PATCH] Remove redundant #ifdef __KERNEL__ checks.

2007-02-25 Thread Robert P. J. Day
Remove the redundant intermediate checks for __KERNEL__ since, as soon as one ends, the next one starts. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/include/linux/stat.h b/include/linux/stat.h index 4f8539c..a3d6342 100644 --- a/include/linux/stat.h +++ b/i

[PATCH] Kbuild: Remove "unifdef" entries for files that generate nothing.

2007-02-25 Thread Robert P. J. Day
Remove, from their corresponding Kbuild files, entries for header files that generate content-free sanitized header files. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- include/linux/Kbuild|3 --- include/linux/netfilter_ipv4/Kbuild |1 - 2 files chan

second thoughts about DEPRECATED and OBSOLETE maturity levels

2007-02-25 Thread Robert P. J. Day
t4dev/ext4 extended fs support development" maturity EXPERIMENTAL ... internally, it could still be treated as a simple dependency, and everything would still work. you know, this seemed so simple at first ... rday -- ===============

Re: [PATCH] Remove redundant #ifdef __KERNEL__ checks.

2007-02-26 Thread Robert P. J. Day
On Sun, 25 Feb 2007, H. Peter Anvin wrote: > Robert P. J. Day wrote: > > Remove the redundant intermediate checks for __KERNEL__ since, as > > soon as one ends, the next one starts. > > > > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> > > >

Re: second thoughts about DEPRECATED and OBSOLETE maturity levels

2007-02-26 Thread Robert P. J. Day
On Mon, 26 Feb 2007, Sam Ravnborg wrote: > On Sun, Feb 25, 2007 at 05:07:24PM -0500, Robert P. J. Day wrote: > > > > having championed the cause of adding those two code maturity levels > > to init/Kconfig, i just realized that implementing them as simple > >

Re: [PATCH] Remove redundant #ifdef __KERNEL__ checks.

2007-02-26 Thread Robert P. J. Day
On Mon, 26 Feb 2007, H. Peter Anvin wrote: > Robert P. J. Day wrote: > > On Sun, 25 Feb 2007, H. Peter Anvin wrote: > > > > > Robert P. J. Day wrote: > > > > Remove the redundant intermediate checks for __KERNEL__ since, as > > > > soon as one e

Re: second thoughts about DEPRECATED and OBSOLETE maturity levels

2007-03-01 Thread Robert P. J. Day
On Mon, 26 Feb 2007, Sam Ravnborg wrote: > On Sun, Feb 25, 2007 at 05:07:24PM -0500, Robert P. J. Day wrote: > > > > having championed the cause of adding those two code maturity levels > > to init/Kconfig, i just realized that implementing them as simple > >

[PATCH] Remove "decl_subsys_name" macro and single usage of it.

2007-03-01 Thread Robert P. J. Day
just uses "decl_subsys". Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- based on conversations with greg kh. compile-tested on x86. drivers/pci/hotplug/acpiphp_ibm.c |4 ++-- drivers/pci/hotplug/pci_hotplug_core.c | 16 drivers/pci/hotplug

Re: A CodingStyle suggestion

2007-02-04 Thread Robert P. J. Day
ions that shouldn't be used, the most vile one being: ret = whatever(); if (ret) { ... } when there are no more references to "ret" inside the "if" construct, which means there was no need to declare "ret" in the first place. i&

<    1   2   3   4   5   6   7   8   9   10   >