On Wed, 3 Jan 2007, Andrew Morton wrote:
> On Sun, 31 Dec 2006 15:55:22 -0500 (EST)
> "Robert P. J. Day" <[EMAIL PROTECTED]> wrote:
>
> > --- a/net/ipv4/netfilter/nf_nat_core.c
> > +++ b/net/ipv4/netfilter/nf_nat_core.c
> > @@ -168,7 +168,7 @@ find_appropriate_src(const struct nf_conntrack_tuple
> > *tuple,
> >
> > read_lock_bh(&nf_nat_lock);
> > list_for_each_entry(nat, &bysource[h], info.bysource) {
> > - ct = (struct nf_conn *)((char *)nat - offsetof(struct nf_conn,
> > data));
> > + ct = container_of(nat, struct nf_conn, data);
>
> This one isn't right. Please always carefully compile-test these things.
i was quite sure i had. i'll take another look at it.
rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
