Re: [PATCH] ext4: Variable to signed to check return code

2019-05-22 Thread Lee Jones
On Tue, 21 May 2019, Theodore Ts'o wrote: > On Tue, May 21, 2019 at 08:25:53AM +0100, Lee Jones wrote: > > A Reviewed-by to me means that a person knows the area, including > > possible side-effects a patch may cause. In this EXTx case, I do not > > consider myself a domain expert and thus am not

[PATCH v5 5/8] KVM: VMX: Load Guest CET via VMCS when CET is enabled in Guest

2019-05-22 Thread Yang Weijiang
"Load Guest CET state" bit controls whether Guest CET states will be loaded at Guest entry. Before doing that, KVM needs to check if CPU CET feature is available to Guest. Note: SHSTK and IBT features share one control MSR: MSR_IA32_{U,S}_CET, which means it's difficult to hide one feature from an

[PATCH v5 6/8] KVM: x86: Allow Guest to set supported bits in XSS

2019-05-22 Thread Yang Weijiang
Now that KVM supports setting CET related bits in XSS. Previously, KVM did not support setting any bits in XSS so hardcoded its check to inject a #GP if Guest attempted to write a non-zero value to XSS. Signed-off-by: Yang Weijiang Co-developed-by: Zhang Yi Z --- arch/x86/include/asm/kvm_host.h

[PATCH v5 3/8] KVM: x86: Fix XSAVE size calculation issue

2019-05-22 Thread Yang Weijiang
According to the SDM, Vol 2, CPUID(EAX=0xD,ECX=1) reports the XSAVE size containing all states enabled by XCR0|IA32_MSR_XSS. Signed-off-by: Yang Weijiang Co-developed-by: Zhang Yi Z --- arch/x86/kvm/cpuid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/cpuid

[PATCH v5 7/8] KVM: x86: Load Guest fpu state when accessing MSRs managed by XSAVES

2019-05-22 Thread Yang Weijiang
From: Sean Christopherson A handful of CET MSRs are not context switched through "traditional" methods, e.g. VMCS or manual switching, but rather are passed through to the guest and are saved and restored by XSAVES/XRSTORS, i.e. the guest's FPU state. Load the guest's FPU state if userspace is a

[PATCH v5 8/8] KVM: x86: Add user-space access interface for CET MSRs

2019-05-22 Thread Yang Weijiang
There're two different places storing Guest CET states, the states managed with XSAVES/XRSTORS, as restored/saved in previous patch, can be read/write directly from/to the MSRs. For those stored in VMCS fields, they're access via vmcs_read/ vmcs_write. Signed-off-by: Yang Weijiang --- arch/x86/i

[PATCH v5 1/8] KVM: VMX: Define CET VMCS fields and control bits

2019-05-22 Thread Yang Weijiang
CET(Control-flow Enforcement Technology) is an upcoming Intel® processor family feature that blocks return/jump-oriented programming (ROP) attacks. It provides the following capabilities to defend against ROP/JOP style control-flow subversion attacks: - Shadow Stack (SHSTK): A second stack for t

[PATCH v5 2/8] KVM: x86: Implement CET CPUID support for Guest

2019-05-22 Thread Yang Weijiang
CET SHSTK and IBT features are introduced here so that CPUID.(EAX=7, ECX=0):ECX[bit 7] and EDX[bit 20] reflect them. CET xsave components for supervisor and user mode are reported via CPUID.(EAX=0xD, ECX=1):ECX[bit 11] and ECX[bit 12] respectively. To make the code look clean, wrap CPUID(0xD,n>=1)

[PATCH v5 0/8] Introduce support for Guest CET feature

2019-05-22 Thread Yang Weijiang
Control-flow Enforcement Technology (CET) provides protection against Return/Jump-Oriented Programming (ROP/JOP) attack. It includes two sub-features: shadow stack (SHSTK) and indirect branch tracking (IBT). KVM modification is required to support Guest CET feature. This patch serial implemented C

[PATCH v5 4/8] KVM: VMX: Pass through CET related MSRs to Guest

2019-05-22 Thread Yang Weijiang
CET MSRs pass through Guest directly to enhance performance. CET runtime control settings are stored in MSR_IA32_{U,S}_CET, Shadow Stack Pointer(SSP) are presented in MSR_IA32_PL{0,1,2,3}_SSP, SSP table base address is stored in MSR_IA32_INT_SSP_TAB, these MSRs are defined in kernel and re-used her

Re: [PATCH] clk: mvebu: armada-37xx-periph: Fix initialization for cpu clocks

2019-05-22 Thread Ilias Apalodimas
Hi Viresh, Gregory On Mon, May 20, 2019 at 04:50:42PM +0530, Viresh Kumar wrote: > On 25-04-19, 15:33, Ilias Apalodimas wrote: > > Hi Viresh, > > > > > > > Also, during this week-end, Christian suggested that the issue might > > > > > come from the AVS support. > > > > > > > > > > Could you disab

Re: [PATCH] staging: rtl8192u: Remove an unnecessary NULL check

2019-05-22 Thread Dan Carpenter
On Tue, May 21, 2019 at 10:42:21AM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2663:47: warning: > address of array 'param->u.wpa_ie.data' will always evaluate to 'true' > [-Wpointer-bool-conversion] > (param->u.wpa_ie.len &

Re: [PATCH] clk: mvebu: armada-37xx-periph: Fix initialization for cpu clocks

2019-05-22 Thread Viresh Kumar
On 22-05-19, 10:03, Ilias Apalodimas wrote: > Hi Viresh, Gregory > On Mon, May 20, 2019 at 04:50:42PM +0530, Viresh Kumar wrote: > > On 25-04-19, 15:33, Ilias Apalodimas wrote: > > > Hi Viresh, > > > > > > > > > Also, during this week-end, Christian suggested that the issue might > > > > > > come

Re: [PATCH] Revert "Bluetooth: Align minimum encryption key size for LE and BR/EDR connections"

2019-05-22 Thread Marcel Holtmann
Hi Vasily, >> This reverts commit d5bb334a8e171b262e48f378bd2096c0ea458265. >> >> This commit breaks some HID devices, see [1] for details >> >> https://bugzilla.kernel.org/show_bug.cgi?id=203643 >> >> Signed-off-by: Vasily Khoruzhick >> Cc: sta...@vger.kernel.org > > let me have a look at th

Re: [PATCH -next v2] mm/hotplug: fix a null-ptr-deref during NUMA boot

2019-05-22 Thread Pingfan Liu
On Mon, May 13, 2019 at 11:31 PM Michal Hocko wrote: > > On Mon 13-05-19 11:20:46, Qian Cai wrote: > > On Mon, 2019-05-13 at 16:04 +0200, Michal Hocko wrote: > > > On Mon 13-05-19 09:43:59, Qian Cai wrote: > > > > On Mon, 2019-05-13 at 14:41 +0200, Michal Hocko wrote: > > > > > On Sun 12-05-19 01:

[PATCH 2/3] ARM: dts: imx6: rdu2: Disable WP for USDHC2 and USDHC3

2019-05-22 Thread Andrey Smirnov
RDU2 production units come with resistor connecting WP pin to correpsonding GPIO DNPed for both SD card slots. Drop any WP related configuration and mark both slots with "disable-wp". Reported-by: Chris Healy Signed-off-by: Andrey Smirnov Cc: Shawn Guo Cc: Fabio Estevam Cc: Lucas Stach Cc: li

[PATCH 1/3] ARM: dts: imx6: rdu2: Add node for UCS1002 USB charger chip

2019-05-22 Thread Andrey Smirnov
Add node for UCS1002 USB charger chip connected to front panel USB and replace "regulator-fixed" previously used to control VBUS. Signed-off-by: Andrey Smirnov Cc: Shawn Guo Cc: Chris Healy Cc: Fabio Estevam Cc: Lucas Stach Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel

[PATCH 3/3] ARM: dts: imx6: rdu2: Limit USBH1 to Full Speed

2019-05-22 Thread Andrey Smirnov
Cabling used to connect devices to USBH1 on RDU2 does not meet USB spec cable quality and cable length requirements to operate at High Speed, so limit the port to Full Speed only. Reported-by: Chris Healy Signed-off-by: Andrey Smirnov Cc: Shawn Guo Cc: Fabio Estevam Cc: Lucas Stach Cc: linux-

[PATCH v2 2/2] ARM: dts: vf610-zii-dev: Add QSPI node

2019-05-22 Thread Andrey Smirnov
Both rev C and rev B of the board come with two QSPI-NOR chips attached to the SoC. Add DT code describing all of this. Signed-off-by: Andrey Smirnov Cc: Shawn Guo Cc: Chris Healy Cc: Andrew Lunn Cc: Fabio Estevam Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org ---

[PATCH v2 1/2] ARM: dts: vf610-zii-dev: Fix incorrect UART2 pin assignment

2019-05-22 Thread Andrey Smirnov
UART2 is connected to PTD22/23, not PTD0/1. Fix corresponding pinmux node. Signed-off-by: Andrey Smirnov Cc: Shawn Guo Cc: Chris Healy Cc: Andrew Lunn Cc: Fabio Estevam Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/vf610-zii-dev.dtsi | 4 ++--

[PATCH v2] initramfs: Fix a missing-check bug in init/initramfs.c

2019-05-22 Thread Gen Zhang
In dir_add() and do_name(), de->name and vcollected are allocated by kstrdup(). And de->name and vcollected are dereferenced in the following codes. However, memory allocation functions such as kstrdup() may fail. Dereferencing this null pointer may cause the kernel go wrong. Thus we should check

答复: 答复: 答复: [PATCH] input: alps-fix the issue the special alps trackpoint do not work.

2019-05-22 Thread Xiaoxiao Liu
Hi Pali, Ok, and cannot you set ALPS_DUALPOINT flag based on that alps_check_is_trackpoint() result and then update alps_process_packet_ss4_v3() code to supports also V8 trackpoint packets? --> Yes, we can do like so, when we use the v8 method to process the trackpoint , the mouse speed is not id

שלום

2019-05-22 Thread Steven Utonbury
שלום, מצפה לשמוע ממך על הדוא"ל שלחתי לך קודם לכן לגבי ההפקדה שנעשו בבנק כאן על ידי הלקוח שלי מאוחר, אני צריך לתת לך את המידע על איך להשיג מטרה זו. אנא נסה לחזור אלי. בברכה סטיבן

Re: [RFC 0/4] TI camera serdes - I2C address translation draft

2019-05-22 Thread Luca Ceresoli
Hi, On 21/05/19 19:40, Mauro Carvalho Chehab wrote: > Em Tue, 8 Jan 2019 23:39:49 +0100 > Luca Ceresoli escreveu: > >> Hi, >> >> there has been some discussion on linux-media about video >> serializer/deserializer chipsets with remote I2C capabilities from TI >> [0] and Maxim [1]. I took part d

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue the special alps trackpoint do not work.

2019-05-22 Thread Pali Rohár
On Wednesday 22 May 2019 07:30:43 Xiaoxiao Liu wrote: > Hi Pali, > > Ok, and cannot you set ALPS_DUALPOINT flag based on that > alps_check_is_trackpoint() result and then update > alps_process_packet_ss4_v3() code to supports also > V8 trackpoint packets? > --> Yes, we can do like so, when we use

Re: [PATCH 1/3] dt-bindings: clk: meson: add g12b periph clock controller bindings

2019-05-22 Thread Neil Armstrong
On 21/05/2019 19:30, Martin Blumenstingl wrote: > On Tue, May 21, 2019 at 5:02 PM Neil Armstrong > wrote: >> >> Update the documentation to support clock driver for the Amlogic G12B SoC. >> >> G12B clock driver is very close, the main differences are : >> - the clock tree is duplicated for the bo

Re: [PATCH 04/12] mips: Reserve memory for the kernel image resources

2019-05-22 Thread Geert Uytterhoeven
Hi Mike, On Tue, May 21, 2019 at 5:53 PM Mike Rapoport wrote: > On Tue, May 21, 2019 at 04:56:39PM +0200, Geert Uytterhoeven wrote: > > On Wed, Apr 24, 2019 at 12:50 AM Serge Semin > > wrote: > > > The reserved_end variable had been used by the bootmem_init() code > > > to find a lowest limit o

Re: linux-next: manual merge of the pidfd tree with Linus' tree

2019-05-22 Thread Stephen Rothwell
Hi Greg, On Wed, 22 May 2019 07:52:35 +0200 Greg Kroah-Hartman wrote: > > Sorry, you are going to get a number of these types of minor conflicts > now. That's the problem of touching thousands of files :( Yeah, I expected that one I saw the commits. At least is is just after -rc1, hopefully m

Re: [PATCH 04/12] mips: Reserve memory for the kernel image resources

2019-05-22 Thread Geert Uytterhoeven
Hi Serge, On Tue, May 21, 2019 at 6:39 PM Serge Semin wrote: > On Tue, May 21, 2019 at 06:53:10PM +0300, Mike Rapoport wrote: > > On Tue, May 21, 2019 at 04:56:39PM +0200, Geert Uytterhoeven wrote: > > > On Wed, Apr 24, 2019 at 12:50 AM Serge Semin > > > wrote: > > > > The reserved_end variable

Re: linux-next: manual merge of the pidfd tree with Linus' tree

2019-05-22 Thread Christian Brauner
On May 22, 2019 9:48:33 AM GMT+02:00, Stephen Rothwell wrote: >Hi Greg, > >On Wed, 22 May 2019 07:52:35 +0200 Greg Kroah-Hartman > wrote: >> >> Sorry, you are going to get a number of these types of minor >conflicts >> now. That's the problem of touching thousands of files :( > >Yeah, I expected

Re: [PATCH 1/3] rtc: s35390a: clarify INT2 pin output modes

2019-05-22 Thread Richard Leitner
On 21/05/2019 17:54, Alexandre Belloni wrote: Hello, This seems good to me but... On 21/05/2019 16:20:22+0200, Richard Leitner wrote: --- a/drivers/rtc/rtc-s35390a.c +++ b/drivers/rtc/rtc-s35390a.c @@ -45,12 +45,13 @@ /* flag for STATUS2 */ #define S35390A_FLAG_TEST 0x01 -#define

Re: [PATCH v2] tipc: Avoid copying bytes beyond the supplied data

2019-05-22 Thread Ying Xue
On 5/20/19 11:45 AM, Chris Packham wrote: > TLV_SET is called with a data pointer and a len parameter that tells us > how many bytes are pointed to by data. When invoking memcpy() we need > to careful to only copy len bytes. > > Previously we would copy TLV_LENGTH(len) bytes which would copy an ex

Re: [PATCH 2/3] clk: meson: g12a: Add support for G12B CPUB clocks

2019-05-22 Thread Neil Armstrong
On 21/05/2019 19:49, Martin Blumenstingl wrote: > Hi Neil, > > On Tue, May 21, 2019 at 5:02 PM Neil Armstrong > wrote: >> >> Update the Meson G12A Clock driver to support the Amlogic G12B SoC. >> >> G12B clock driver is very close, the main differences are : >> - the clock tree is duplicated for

Re: [PATCH v3 3/3] arm64: dts: meson: Add minimal support for Odroid-N2

2019-05-22 Thread Neil Armstrong
On 21/05/2019 18:11, Robin Murphy wrote: > On 21/05/2019 16:19, Neil Armstrong wrote: > [...] >> +    cpu100: cpu@100 { >> +    device_type = "cpu"; >> +    compatible = "arm,cortex-a73", "arm,armv8"; > > Nit: we've recently tried to eradicate "arm,armv8" as a fallback compatib

Re: [PATCH 1/2] ARM: dts: rockchip: Add pin names for rk3288-veyron-minnie

2019-05-22 Thread Heiko Stuebner
Am Dienstag, 21. Mai 2019, 22:32:14 CEST schrieb Douglas Anderson: > We can now use the "gpio-line-names" property to provide the names for > all the pins on a board. Let's use this to provide the names for all > the pins on rk3288-veyron-minnie. > > In general the names here come straight from t

Re: [PATCH] ARM: dts: rockchip: Mark that the rk3288 timer might stop in suspend

2019-05-22 Thread Heiko Stuebner
Am Mittwoch, 22. Mai 2019, 01:49:33 CEST schrieb Douglas Anderson: > This is similar to commit e6186820a745 ("arm64: dts: rockchip: Arch > counter doesn't tick in system suspend"). Specifically on the rk3288 > it can be seen that the timer stops ticking in suspend if we end up > running through th

RE: [PATCH v5 4/6] usb: roles: add API to get usb_role_switch by node

2019-05-22 Thread Biju Das
Hi Heikki, Thanks for the feedback. > Subject: Re: [PATCH v5 4/6] usb: roles: add API to get usb_role_switch by > node > > On Mon, May 20, 2019 at 09:45:46AM +, Biju Das wrote: > > > > > > Hi Heikki, > > > > Thanks for the feedback. > > > > > Subject: Re: [PATCH v5 4/6] usb: roles: add API t

Re: linux-next: manual merge of the pidfd tree with Linus' tree

2019-05-22 Thread Stephen Rothwell
Hi Christian, On Wed, 22 May 2019 09:55:00 +0200 Christian Brauner wrote: > > On May 22, 2019 9:48:33 AM GMT+02:00, Stephen Rothwell > wrote: > >Hi Greg, > > > >On Wed, 22 May 2019 07:52:35 +0200 Greg Kroah-Hartman > > wrote: > >> > >> Sorry, you are going to get a number of these types of m

Re: [PATCH] tty_io: Fix a missing-check bug in drivers/tty/tty_io.c

2019-05-22 Thread Gen Zhang
On Wed, May 22, 2019 at 06:25:36AM +0200, Jiri Slaby wrote: > On 22. 05. 19, 3:40, Gen Zhang wrote: > > In alloc_tty_struct(), tty->dev is assigned by tty_get_device(). And it > > calls class_find_device(). And class_find_device() may return NULL. > > And tty->dev is dereferenced in the following c

Re: [PATCH 04/12] mips: Reserve memory for the kernel image resources

2019-05-22 Thread Mike Rapoport
On Wed, May 22, 2019 at 09:47:04AM +0200, Geert Uytterhoeven wrote: > Hi Mike, > > On Tue, May 21, 2019 at 5:53 PM Mike Rapoport wrote: > > On Tue, May 21, 2019 at 04:56:39PM +0200, Geert Uytterhoeven wrote: > > > On Wed, Apr 24, 2019 at 12:50 AM Serge Semin > > > wrote: > > > > The reserved_en

Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-22 Thread Amelie DELAUNAY
On 5/22/19 7:48 AM, Lee Jones wrote: > On Mon, 20 May 2019, Amelie Delaunay wrote: > >> When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does >> not exist: >> drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_probe': >> drivers/pinctrl/pinctrl-stmfx.c:652:17: error

Re: [PATCH V7 02/15] PCI: Disable MSI for Tegra194 root port

2019-05-22 Thread Vidya Sagar
On 5/22/2019 1:06 AM, Bjorn Helgaas wrote: On Tue, May 21, 2019 at 10:17:26PM +0530, Vidya Sagar wrote: On 5/21/2019 3:57 PM, Thierry Reding wrote: On Fri, May 17, 2019 at 06:08:33PM +0530, Vidya Sagar wrote: Tegra194 rootports don't generate MSI interrupts for PME events and hence MSI needs t

Re: [PATCH v2] vt: Fix a missing-check bug in drivers/tty/vt/vt.c

2019-05-22 Thread Gen Zhang
On Tue, May 21, 2019 at 10:43:11PM -0400, Nicolas Pitre wrote: > On Tue, 21 May 2019, Gen Zhang wrote: > > > On Tue, May 21, 2019 at 12:30:38AM -0400, Nicolas Pitre wrote: > > > Now imagine that MIN_NR_CONSOLES is defined to 10 instead of 1. > > > > > > What happens with allocated memory if the e

Re: [PATCH 04/12] mips: Reserve memory for the kernel image resources

2019-05-22 Thread Geert Uytterhoeven
Hi Mike, On Wed, May 22, 2019 at 10:08 AM Mike Rapoport wrote: > On Wed, May 22, 2019 at 09:47:04AM +0200, Geert Uytterhoeven wrote: > > On Tue, May 21, 2019 at 5:53 PM Mike Rapoport wrote: > > > On Tue, May 21, 2019 at 04:56:39PM +0200, Geert Uytterhoeven wrote: > > > > On Wed, Apr 24, 2019 at

Re: [PATCH] tty_io: Fix a missing-check bug in drivers/tty/tty_io.c

2019-05-22 Thread Jiri Slaby
On 22. 05. 19, 10:06, Gen Zhang wrote: > On Wed, May 22, 2019 at 06:25:36AM +0200, Jiri Slaby wrote: >> On 22. 05. 19, 3:40, Gen Zhang wrote: >>> In alloc_tty_struct(), tty->dev is assigned by tty_get_device(). And it >>> calls class_find_device(). And class_find_device() may return NULL. >>> And t

[PATCH] MIPS: TXx9: Fix boot crash in free_initmem()

2019-05-22 Thread Geert Uytterhoeven
On rbtx4927: BUG: Bad page state in process swapper pfn:1 page:804b7820 refcount:0 mapcount:-128 mapping: index:0x1 flags: 0x0() raw: 0100 0200 0001 ff7f page dumped because: nonzero mapcount Modules linked in

Re: [PATCH v3 3/3] arm64: dts: meson: Add minimal support for Odroid-N2

2019-05-22 Thread Neil Armstrong
On 21/05/2019 20:01, Martin Blumenstingl wrote: > Hi Neil, > > On Tue, May 21, 2019 at 5:20 PM Neil Armstrong > wrote: > [...] >> + hub_5v: regulator-hub_5v { >> + compatible = "regulator-fixed"; >> + regulator-name = "HUB_5V"; >> + regulator-min-m

Re: [PATCH] ARM: dts: at91sam9261ek: remove unused chosen nodes

2019-05-22 Thread Daniel Lezcano
Hi Rob, a gentle ping ... ;) On 08/04/2019 18:30, Daniel Lezcano wrote: > > Hi Rob, > > the following patch has been pushed in 2016 by commit 51f0aeb2d21f1. > > Being able to specify which timer should act as a clocksource or a > clockevent is often requested. Doing this from the driver itse

Re: [PATCH 4/5] i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq

2019-05-22 Thread Charles Keepax
On Tue, May 21, 2019 at 08:27:26PM +0300, Andy Shevchenko wrote: > On Tue, May 21, 2019 at 04:05:01PM +0100, Charles Keepax wrote: > > It makes sense to contain all the ACPI IRQ handling in a single helper > > function. > > > Note that this one is somewhat interesting, it seems the search > > thro

Re: [RFC 0/7] introduce memory hinting API for external process

2019-05-22 Thread Christian Brauner
On Wed, May 22, 2019 at 7:12 AM Daniel Colascione wrote: > > On Tue, May 21, 2019 at 4:39 AM Christian Brauner > wrote: > > > > On Tue, May 21, 2019 at 01:30:29PM +0200, Christian Brauner wrote: > > > On Tue, May 21, 2019 at 08:05:52PM +0900, Minchan Kim wrote: > > > > On Tue, May 21, 2019 at 10

Re: [PATCH RESEND] ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibrator

2019-05-22 Thread Brian Masney
Hi Stephen, On Mon, May 20, 2019 at 07:21:49AM -0700, Stephen Boyd wrote: > Quoting Brian Masney (2019-05-16 01:50:18) > > @@ -306,6 +307,36 @@ > > input-enable; > > }; > > }; > > + > > + vibrator_pin: vibrator {

[PATCH] net: macb: save/restore the remaining registers and features

2019-05-22 Thread Claudiu.Beznea
From: Claudiu Beznea SAMA5D2 SoC has a suspend mode where SoC's power is cut off. Due to this the registers content is lost after a suspend/resume cycle. The current suspend/resume implementation covers some of these registers. However there are few which were not treated (e.g. SCRT2 and USRIO).

[PATCH] mailbox: stm32_ipcc: add spinlock to fix channels concurrent access

2019-05-22 Thread Arnaud Pouliquen
Add spinlock protection on IPCC register update to avoid race condition. Without this fix, stm32_ipcc_set_bits and stm32_ipcc_clr_bits can be called in parallel for different channels. This results in register corruptions. Signed-off-by: Arnaud Pouliquen --- drivers/mailbox/stm32-ipcc.c | 37 +++

[PATCH][next] leds: TI LMU: remove redundant u8 comparisons with less than zero

2019-05-22 Thread Colin King
From: Colin Ian King The u8 variables ramp_up and ramp_down are being compared to less than zero, this will always be false. Code is redundant so remove it. Addresses-Coverity: ("Unsigned compared against 0") Signed-off-by: Colin Ian King --- drivers/leds/leds-ti-lmu-common.c | 3 --- 1 file c

Re: [PATCH v9 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

2019-05-22 Thread Shawn Guo
On Mon, May 13, 2019 at 09:05:27AM -0700, Joe Perches wrote: > On Mon, 2019-05-13 at 08:35 -0700, Angus Ainslie wrote: > > Hi Joe, > > Hi. > > > On 2019-05-13 08:11, Joe Perches wrote: > > > On Mon, 2019-05-13 at 07:55 -0700, Angus Ainslie (Purism) wrote: > > > > This is for the development kit b

Re: [PATCH v12 1/4] MAINTAINERS: add an entry for for arm64 imx devicetrees

2019-05-22 Thread Shawn Guo
On Tue, May 14, 2019 at 06:28:19AM -0700, Angus Ainslie (Purism) wrote: > Add an explicit reference to imx* devicetrees > > Signed-off-by: Angus Ainslie (Purism) > Reviewed-by: Fabio Estevam > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH v2] media:usb:zr364xx:Fix KASAN:null-ptr-deref Read in zr364xx_vidioc_querycap

2019-05-22 Thread Vandana BN
SyzKaller hit the null pointer deref while reading from uninitialized udev->product in zr364xx_vidioc_querycap(). == BUG: KASAN: null-ptr-deref in read_word_at_a_time+0xe/0x20 include/linux/compiler.h:274 Read of size 1 at addr 000

Re: [PATCH v2] media:usb:zr364xx:Fix KASAN:null-ptr-deref Read in zr364xx_vidioc_querycap

2019-05-22 Thread Hans Verkuil
On 5/22/19 10:34 AM, Vandana BN wrote: > SyzKaller hit the null pointer deref while reading from uninitialized > udev->product in zr364xx_vidioc_querycap(). > == > BUG: KASAN: null-ptr-deref in read_word_at_a_time+0xe/0x20 > include/li

Re: [PATCH lttng-modules 4/5] fix: mm: move recent_rotated pages calculation to shrink_inactive_list() (v5.2)

2019-05-22 Thread Kirill Tkhai
On 21.05.2019 23:53, Mathieu Desnoyers wrote: > - On May 21, 2019, at 4:33 PM, Michael Jeanson mjean...@efficios.com > wrote: > >> See upstream commit: >> >> commit 886cf1901db962cee5f8b82b9b260079a5e8a4eb >> Author: Kirill Tkhai >> Date: Mon May 13 17:16:51 2019 -0700 >> >>mm: move

Re: tc_classid access in skb bpf context

2019-05-22 Thread Daniel Borkmann
On 05/22/2019 01:52 AM, Matthew Cover wrote: > __sk_buff has a member tc_classid which I'm interested in accessing from the > skb bpf context. > > A bpf program which accesses skb->tc_classid compiles, but fails > verification; the specific failure is "invalid bpf_context access". > > if (skb->

[PATCH][next] scsi: hpsa: fix an uninitialized read and dereference of pointer dev

2019-05-22 Thread Colin King
From: Colin Ian King Currently the check for a lockup_detected failure exits via the label return_reset_status that reads and dereferences an uninitialized pointer dev. Fix this by ensuring dev is inintialized to null. Addresses-Coverity: ("Uninitialized pointer read") Fixes: 14991a5bade5 ("scs

Re: [PATCH] staging: rtl8723bs: Add missing blank lines

2019-05-22 Thread Jeremy Sowden
On 2019-05-21, at 21:46:55 -0300, Fabio Lima wrote: > This patch resolves the following warning from checkpatch.pl > WARNING: Missing a blank line after declarations > > Signed-off-by: Fabio Lima > --- > drivers/staging/rtl8723bs/core/rtw_debug.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-22 Thread Lee Jones
On Wed, 22 May 2019, Amelie DELAUNAY wrote: > On 5/22/19 7:48 AM, Lee Jones wrote: > > On Mon, 20 May 2019, Amelie Delaunay wrote: > > > >> When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does > >> not exist: > >> drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_pr

Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-05-22 Thread Tomasz Figa
On Tue, Apr 9, 2019 at 6:43 PM Tomasz Figa wrote: > > On Tue, Apr 9, 2019 at 6:37 PM Hans Verkuil wrote: > > > > On 4/9/19 9:11 AM, Tomasz Figa wrote: > > > On Mon, Apr 8, 2019 at 5:43 PM Hans Verkuil wrote: > > >> > > >> On 4/8/19 10:36 AM, Tomasz Figa wrote: > > >>> On Mon, Mar 25, 2019 at 10:

[PATCH] mm: Rename mm_vmscan_lru_shrink_inactive trace event variables

2019-05-22 Thread Kirill Tkhai
Rename nr_activate{0,1} into nr_activate{anon,file} since this is exported into userspace, e.g., it's shown here: /sys/kernel/debug/tracing/events/vmscan/mm_vmscan_lru_shrink_inactive/format. Now we have: field:unsigned int nr_activate0;offset:64; size:4; signed:0; field:unsigned int

Re: [RFC PATCH 0/4] KVM selftests for s390x

2019-05-22 Thread Andrew Jones
On Mon, May 20, 2019 at 01:43:06PM +0200, Paolo Bonzini wrote: > On 20/05/19 13:30, Thomas Huth wrote: > >> No objections at all, though it would be like to have ucall plumbed in > >> from the beginning. > > I'm still looking at the ucall interface ... what I don't quite get yet > > is the question

Re: [PATCH 4.19 046/105] crypto: ccree - dont map MAC key on stack

2019-05-22 Thread Pavel Machek
Hi! > The MAC hash key might be passed to us on stack. Copy it to > a slab buffer before mapping to gurantee proper DMA mapping. > > Signed-off-by: Gilad Ben-Yossef > Cc: sta...@vger.kernel.org # v4.19+ > Signed-off-by: Herbert Xu > Signed-off-by: Greg Kroah-Hartman > > --- > drivers/crypto/

Re: [PATCH v4 0/5] KVM: LAPIC: Optimize timer latency further

2019-05-22 Thread Wanpeng Li
On Mon, 20 May 2019 at 16:18, Wanpeng Li wrote: > > Advance lapic timer tries to hidden the hypervisor overhead between the > host emulated timer fires and the guest awares the timer is fired. However, > it just hidden the time between apic_timer_fn/handle_preemption_timer -> > wait_lapic_expire,

Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-05-22 Thread Hans Verkuil
On 5/22/19 10:43 AM, Tomasz Figa wrote: > On Tue, Apr 9, 2019 at 6:43 PM Tomasz Figa wrote: >> >> On Tue, Apr 9, 2019 at 6:37 PM Hans Verkuil wrote: >>> >>> On 4/9/19 9:11 AM, Tomasz Figa wrote: On Mon, Apr 8, 2019 at 5:43 PM Hans Verkuil wrote: > > On 4/8/19 10:36 AM, Tomasz Figa w

[PATCH] ARM: Add method to mach/pci.h

2019-05-22 Thread Philippe Mazenauer
Adding method pcibios_report_status() to mach/pci.h, so as to remove the extern declaration in dc21285.c, and remove missing-prototypes warning in kernel/bios32.c. ../arch/arm/kernel/bios32.c:59:6: warning: no previous prototype for ‘pcibios_report_status’ [-Wmissing-prototypes] void pcibios_rep

Re: [PATCH V7 04/15] PCI: dwc: Move config space capability search API

2019-05-22 Thread Vidya Sagar
On 5/22/2019 2:47 AM, Bjorn Helgaas wrote: On Fri, May 17, 2019 at 06:08:35PM +0530, Vidya Sagar wrote: Move PCIe config space capability search API to common DesignWare file as this can be used by both host and ep mode codes. Signed-off-by: Vidya Sagar Acked-by: Gustavo Pimentel --- Changes

Re: [PATCH 4.19 053/105] mm/mincore.c: make mincore() more conservative

2019-05-22 Thread Pavel Machek
Hi! > commit 134fca9063ad4851de767d1768180e5dede9a881 upstream. > > The semantics of what mincore() considers to be resident is not > completely clear, but Linux has always (since 2.3.52, which is when > mincore() was initially done) treated it as "page is available in page > cache". > > That's

Re: [PATCH v12 2/4] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

2019-05-22 Thread Shawn Guo
On Tue, May 14, 2019 at 06:28:20AM -0700, Angus Ainslie (Purism) wrote: > This is for the development kit board for the Librem 5. The current level > of support yields a working console and is able to boot userspace from > the network or eMMC. > > Additional subsystems that are active : > > - Bot

[PATCH v7 0/3] Extend dt bindings to support I2C on sifive devices and a fix broken IRQ in polling mode.

2019-05-22 Thread Sagar Shrikant Kadam
The patch is based on mainline v5.2-rc1 and extends DT-bindings for Opencore based I2C IP block reimplemented in FU540 SoC, available on HiFive unleashed board (Rev A00), and also provides a workaround for broken IRQ which affects the already available I2C polling mode interface in mainline, for

[PATCH v7 2/3] i2c-ocores: sifive: add support for i2c device on FU540-c000 SoC.

2019-05-22 Thread Sagar Shrikant Kadam
Update device id table for Opencore's I2C master based re-implementation used in FU540-c000 chipset on HiFive Unleashed platform. Device ID's include Sifive, soc-specific device for chip specific tweaks and sifive IP block specific device for generic programming model. Signed-off-by: Sagar Shrika

[PATCH v7 1/3] dt-bindings: i2c: extend existing opencore bindings.

2019-05-22 Thread Sagar Shrikant Kadam
Reformatted compatibility strings to one valid combination on each line. Add FU540-C000 specific device tree bindings to already available i2-ocores file. This device is available on HiFive Unleashed Rev A00 board. Move interrupt under optional property list as this can be optional. The FU540-C000

Re: [PATCH V7 13/15] phy: tegra: Add PCIe PIPE2UPHY support

2019-05-22 Thread Vidya Sagar
On 5/21/2019 4:30 PM, Thierry Reding wrote: On Fri, May 17, 2019 at 06:08:44PM +0530, Vidya Sagar wrote: Synopsys DesignWare core based PCIe controllers in Tegra 194 SoC interface with Universal PHY (UPHY) module through a PIPE2UPHY (P2U) module. For each PCIe lane of a controller, there is a P2

[PATCH v7 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC.

2019-05-22 Thread Sagar Shrikant Kadam
The i2c-ocore driver already has a polling mode interface.But it needs a workaround for FU540 Chipset on HiFive unleashed board (RevA00). There is an erratum in FU540 chip that prevents interrupt driven i2c transfers from working, and also the I2C controller's interrupt bit cannot be cleared if set

Re: [PATCH v3 2/2] tty: add rpmsg driver

2019-05-22 Thread Jiri Slaby
On 17. 05. 19, 16:27, Arnaud Pouliquen wrote: > This driver exposes a standard tty interface on top of the rpmsg > framework through the "rpmsg-tty-channel" rpmsg service. > > This driver supports multi-instances, offering a /dev/ttyRPMSGx entry > per rpmsg endpoint. > > Signed-off-by: Arnaud Pou

Re: [PATCH] arm64: break while loop if task had been rescheduled

2019-05-22 Thread Anshuman Khandual
On 05/21/2019 02:50 PM, Tengfei Fan wrote: > While printing a task's backtrace and this task isn't > current task, it is possible that task's fp and fp+8 > have the same value, so cannot break the while loop. > This can break while loop if this task had been > rescheduled during print this task's b

[PATCH] sched: idle: Support nohlt_list kernel parameter

2019-05-22 Thread zhenwei pi
Currently kernel only supports hlt&nohlt kernel parameters, all the CPUs would poll or not in idle. Guest OS can't control power in KVM virtualization, so we can only choose high performance by nohlt or CPU overcommit by hlt. nohlt_list kernel parameter allows the specified CPU(s) to poll, and othe

Re: [PATCH v3 13/13] epoll: implement epoll_create2() syscall

2019-05-22 Thread Roman Penyaev
On 2019-05-22 04:33, Andrew Morton wrote: On Thu, 16 May 2019 12:20:50 +0200 Roman Penyaev wrote: On 2019-05-16 12:03, Arnd Bergmann wrote: > On Thu, May 16, 2019 at 10:59 AM Roman Penyaev > wrote: >> >> epoll_create2() is needed to accept EPOLL_USERPOLL flags >> and size, i.e. this patch wi

Re: [PATCH v2] edac: sifive: Add EDAC platform driver for SiFive SoCs

2019-05-22 Thread James Morse
Hi Boris, On 21/05/2019 19:21, Borislav Petkov wrote: > On Tue, May 21, 2019 at 11:00:59AM +0530, Yash Shah wrote: >> The prerequisite patch (sifive_l2_cache driver) has been merged into >> mainline v5.2-rc1 >> It should be OK to merge this edac driver now. > > James? Still fine by me: Reviewed-

Re: [PATCH 4.19 038/105] ALSA: hdea/realtek - Headset fixup for System76 Gazelle (gaze14)

2019-05-22 Thread Pavel Machek
On Mon 2019-05-20 14:13:44, Greg Kroah-Hartman wrote: > From: Jeremy Soller > > commit 80a5052db75131423b67f38b21958555d7d970e4 upstream. > > On the System76 Gazelle (gaze14), there is a headset microphone input > attached to 0x1a that does not have a jack detect. In order to get it > working, t

Re: [PATCH v2 2/3] ARM: dts: rockchip: Use the GPU to cool CPU thermal zone of veyron mickey

2019-05-22 Thread Heiko Stuebner
Am Dienstag, 21. Mai 2019, 00:00:50 CEST schrieb Matthias Kaehlcke: > On rk3288 the CPU and GPU temperatures are correlated. Limit the GPU > frequency on veyron mickey to 400 MHz for CPU temperatures >= 65°C > and to 300 MHz for CPU temperatures >= 85°C. > > This matches the configuration of the d

Re: [PATCH v2 1/3] ARM: dts: rockchip: disable GPU 500 MHz OPP for veyron

2019-05-22 Thread Heiko Stuebner
Am Dienstag, 21. Mai 2019, 00:00:49 CEST schrieb Matthias Kaehlcke: > The NPLL is the only safe way to generate 500 MHz for the GPU. The > downstream Chrome OS 3.14 kernel ('official' kernel for veyron > devices) re-purposes NPLL to HDMI and hence disables the OPP for > the GPU (see https://crrev.c

[PATCH] arm: Add missing method to asm/irq_work.h

2019-05-22 Thread Philippe Mazenauer
Add missing method arch_irq_work_raise() to irq_work.h, so as to remove missing-prototypes warning in kernel/smp.c. ../arch/arm/kernel/smp.c:572:6: warning: no previous prototype for ‘arch_irq_work_raise’ [-Wmissing-prototypes] void arch_irq_work_raise(void) ^~~ Signed-off

Re: [PATCH 4.19 067/105] ext4: protect journal inodes blocks using block_validity

2019-05-22 Thread Pavel Machek
On Mon 2019-05-20 14:14:13, Greg Kroah-Hartman wrote: > From: Theodore Ts'o > > commit 345c0dbf3a30872d9b204db96b5857cd00808cae upstream. > > Add the blocks which belong to the journal inode to block_validity's > system zone so attempts to deallocate or overwrite the journal due a > corrupted fi

[PATCH -resend v2] memcg: make it work on sparse non-0-node systems

2019-05-22 Thread Jiri Slaby
We have a single node system with node 0 disabled: Scanning NUMA topology in Northbridge 24 Number of physical nodes 2 Skipping disabled node 0 Node 1 MemBase Limit fbff NODE_DATA(1) allocated [mem 0xfbfda000-0xfbfe] This causes crashes in memcg when syst

Re: [PATCH 4.19 053/105] mm/mincore.c: make mincore() more conservative

2019-05-22 Thread Michal Hocko
On Wed 22-05-19 10:57:41, Pavel Machek wrote: > Hi! > > > commit 134fca9063ad4851de767d1768180e5dede9a881 upstream. > > > > The semantics of what mincore() considers to be resident is not > > completely clear, but Linux has always (since 2.3.52, which is when > > mincore() was initially done) tre

Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-22 Thread Amelie DELAUNAY
On 5/22/19 10:41 AM, Lee Jones wrote: > On Wed, 22 May 2019, Amelie DELAUNAY wrote: >> On 5/22/19 7:48 AM, Lee Jones wrote: >>> On Mon, 20 May 2019, Amelie Delaunay wrote: >>> When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does not exist: drivers/pinctrl/pinctr

Dolgozói juttatások

2019-05-22 Thread Kapolcs Mátyás
Üdvözlöm, 2019 januárjától minden nem bér jellegű juttatás a fizetéssel megegyezően lesz megadóztatva. A változások ellenére a vállalatok több mint 55%-a meg kívánja tartani a dolgozói juttatások támogatási mértékét. A korlátlanul felhasználható juttatás kártya számos előnnyel jár a munkaválla

Re: [PATCH] staging: rtl8192u: Remove an unnecessary NULL check

2019-05-22 Thread Dan Carpenter
On Tue, May 21, 2019 at 03:57:46PM -0700, Nick Desaulniers wrote: > > > - if (param->u.wpa_ie.len > MAX_WPA_IE_LEN || > > > - (param->u.wpa_ie.len && !param->u.wpa_ie.data)) > > > > Right so, the types in this expression: > > > > param: struct ieee_param* > > param->u: *anonymous un

[PATCH 3/5] csky: Add pmu interrupt support

2019-05-22 Thread Mao Han
This patch add interrupt request and handler for csky pmu. perf can record on hardware event with this patch applied. Signed-off-by: Mao Han CC: Guo Ren CC: linux-c...@vger.kernel.org --- arch/csky/kernel/perf_event.c | 277 +++--- 1 file changed, 259 inserti

[PATCH 4/5] dt-bindings: csky: Add csky PMU bindings

2019-05-22 Thread Mao Han
This patch adds the documentation to describe that how to add pmu node in dts. Signed-off-by: Mao Han CC: Rob Herring CC: Guo Ren CC: linux-c...@vger.kernel.org --- Documentation/devicetree/bindings/csky/pmu.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100

[PATCH 5/5] csky: Fixup some error count in 810 & 860.

2019-05-22 Thread Mao Han
From: Guo Ren ck810 pmu only support event with index 0-8 and 0xd; ck860 only support event 1~4, 0xa~0x1b. So do not register unsupport event to hardware cache event, which may leader to unknown behavior. Signed-off-by: Guo Ren Signed-off-by: Mao Han CC: Guo Ren CC: linux-c...@vger.kernel.org

[PATCH 2/5] csky: Add reg-io-width property for csky pmu

2019-05-22 Thread Mao Han
csky pmu counter may have different io width. When the counter is smaller then 64 bits and counter value is smaller than the old value, it will result to a extremely large delta value. So the sampled value should be extend to 64 bits to avoid this, the extension bits base on the reg-io-width proper

[PATCH 1/5] csky: Init pmu as a device

2019-05-22 Thread Mao Han
This patch change the csky pmu initialization from arch init to device init. The pmu can be configued with information from device tree(pmu device name, irq number and etc.). Signed-off-by: Mao Han CC: Guo Ren CC: linux-c...@vger.kernel.org --- arch/csky/kernel/perf_event.c | 58 +++

[PATCH 0/5] Add pmu hardware sampling support

2019-05-22 Thread Mao Han
This patch set add hardware sampling support for csky-pmu, and also add some properties to pmu node definition. perf can record on hardware event with this patch applied. Guo Ren (1): csky: Fixup some error count in 810 & 860. Mao Han (4): csky: Init pmu as a device csky: Add reg-io-width p

Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-22 Thread Lee Jones
On Wed, 22 May 2019, Amelie DELAUNAY wrote: > On 5/22/19 10:41 AM, Lee Jones wrote: > > On Wed, 22 May 2019, Amelie DELAUNAY wrote: > >> On 5/22/19 7:48 AM, Lee Jones wrote: > >>> On Mon, 20 May 2019, Amelie Delaunay wrote: > >>> > When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node

  1   2   3   4   5   6   7   8   9   10   >