[PATCH BUGFIX] can: m_can: make m_can driver work with sleep state pinconfig

2020-06-25 Thread Lothar Waßmann
tion. Removing the bogus call to m_can_class_suspend() in the m_can_runtime_suspend() function fixes this. Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework") Fixes: 0704c5743694 ("can: m_can_platform: remove unnecessary m_can_class_resume() call") Signed

Re: [PATCH] dmaengine: imx-sdma: fix use-after-free on probe error path

2019-07-05 Thread Lothar Waßmann
> + dev_warn(&pdev->dev, "failed to get firmware from device tree\n"); > + } > You changed the braces in the wrong place! The comment applied to the previous 'if (ret)' which has an else clause with braces, so the if clause needs braces too. Lothar Waßmann

Re: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: correct the fuse word index

2019-07-05 Thread Lothar Waßmann
Hi, On Fri, 5 Jul 2019 02:46:32 + Andy Duan wrote: > From: Andy Duan Sent: Friday, July 5, 2019 12:08 AM > > From: Lothar Waßmann Sent: Thursday, July 4, > > 2019 11:46 PM > > > Hi, > > > > > > On Thu, 4 Jul 2019 22:20:15 +0800 fugang.d...@

Re: [PATCH nvmem 1/1] nvmem: imx: correct the fuse word index

2019-07-04 Thread Lothar Waßmann
fset, > buf++; > } > > - memcpy(val, (u8 *)p + offset % 4, bytes); > + memcpy(val, (u8 *)p, bytes); > > kfree(p); > With these changes you could use the 'val' pointer directly as the destination for ocotp_read() without need for an intermediate buffer. Lothar Waßmann

Re: [PATCH 2/4] input: keyboard/mouse/touchscreen/misc: Use dev_get_drvdata()

2019-07-02 Thread Lothar Waßmann
e it can remove the unnecessary step back and forth. (dev -> pdev -> > dev). > Did you check whether the compiler generates different (better) code with and without your patch? My guess is it won't. Lothar Waßmann

Re: [PATCH V2 2/4] thermal: imx_sc: add i.MX system controller thermal support

2018-11-28 Thread Lothar Waßmann
0; i < sensor_num; i++) { > + struct imx_sc_sensor *sensor = &data->sensor[i]; > + > + sensor_np = of_get_next_child(np, sensor_np); > + ret = imx_sc_thermal_get_sensor_id(sensor_np, > &sensor->resource_id); > + if (ret < 0) { > + dev_err(&pdev->dev, > + "failed to get valid sensor resource id: %d\n", > + ret); > + break; > + } > + > + ret = imx_sc_thermal_register_sensor(pdev, sensor); > + if (ret) { > + dev_err(&pdev->dev, "failed to register thermal sensor: > %d\n", > + ret); > + break; > + } > + } > + > + of_node_put(np); > + of_node_put(sensor_np); > + > + return ret; > +} > + > +static const struct of_device_id imx_sc_thermal_table[] = { > + { .compatible = "nxp,imx8qxp-sc-thermal", }, > + {}, > +}; s/{},/{}/ Lothar Waßmann

Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support

2018-11-28 Thread Lothar Waßmann
Anson Huang wrote: > Hi, Lothar > > Best Regards! > Anson Huang > > > -Original Message----- > > From: Lothar Waßmann [mailto:l...@karo-electronics.de] > > Sent: 2018年11月28日 17:04 > > To: Anson Huang > > Cc: a.zu...@towertech.it; alexandr

Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support

2018-11-28 Thread Lothar Waßmann
ranges = <0x5f00 0x0 0x5f00 0x100>; > }; > + > + rtc: rtc { > + compatible = "nxp,imx8qxp-sc-rtc"; > + }; > }; IMO this should be disabled by default. Lothar Waßmann

Re: [PATCH V2 2/4] rtc: add i.MX system controller RTC support

2018-11-28 Thread Lothar Waßmann
t = PTR_ERR(rtc); > + return ret; > + } > + > + rtc->ops = &imx_sc_rtc_ops; > + rtc->range_min = 0; > + rtc->range_max = U32_MAX; > + > + ret = rtc_register_device(rtc); > + if (ret) { > + dev_err(&pdev-&

Re: [RCF PATCH,v2,2/2] pwm: imx: Configure output to GPIO in disabled state

2018-11-26 Thread Lothar Waßmann
> >>> On Thu, Nov 22, 2018 at 03:42:14PM +, Vokáč Michal wrote: > > >>>> On 16.11.2018 09:25, Uwe Kleine-König wrote: > > >>>>> On Fri, Nov 16, 2018 at 08:34:30AM +0100, Lothar Waßmann wrote: > > >>>>>> No. You c

Re: [RCF PATCH,v2,2/2] pwm: imx: Configure output to GPIO in disabled state

2018-11-26 Thread Lothar Waßmann
Uwe Kleine-König wrote: > Hallo Lothar, > > On Mon, Nov 26, 2018 at 10:11:16AM +0100, Lothar Waßmann wrote: > > Uwe Kleine-König wrote: > > > @Lothar: if Michal did something different than you expected, please > > > tell us with a few more details. >

Re: [RCF PATCH,v2,2/2] pwm: imx: Configure output to GPIO in disabled state

2018-11-26 Thread Lothar Waßmann
gainst GND = 0V > >- against VCC = 0V > > - Measure resistance against VCC: Hi-Z > > > > The pin is in Hi-Z mode. That is fine but that does not satisfy any > > logic level. > > > > b) working variant > > - Request the GPIO, configure i

Re: [RCF PATCH,v2,2/2] pwm: imx: Configure output to GPIO in disabled state

2018-11-16 Thread Lothar Waßmann
correctly the backlight won't work as expected... The PWM driver is driving the pins, so that is where the pinctrls belong. Lothar Waßmann -- ___ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +

Re: [RCF PATCH,v2,2/2] pwm: imx: Configure output to GPIO in disabled state

2018-11-16 Thread Lothar Waßmann
rl, so that only the selected pull-up/down is relevant. The pin function and GPIO register settings don't matter at all in this case. Lothar Waßmann -- ___ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-

Re: [RFC PATCH 1/2] dt-bindings: pwm: imx: Allow switching PWM output between PWM and GPIO

2018-08-31 Thread Lothar Waßmann
Michal Vokáč wrote: > On 31.8.2018 14:45, Lothar Waßmann wrote: > > Rob Herring wrote: > > > >> On Tue, Aug 21, 2018 at 04:38:52PM +0200, Michal Vokáč wrote: > >>> Output of the PWM block of i.MX SoCs is always zero volts when the block > >>>

Re: [RFC PATCH 1/2] dt-bindings: pwm: imx: Allow switching PWM output between PWM and GPIO

2018-08-31 Thread Lothar Waßmann
-0 = <&pinctrl_backlight_gpio>; > > + pinctrl-1 = <&pinctrl_backlight_pwm>; > > +} > > + > > +pinctrl_backlight_gpio: pwm1grp-gpio { > > + fsl,pins = < > > + /* GPIO with 22kOhm pull-up */ > > + MX6QDL_PAD_GPI

Re: [PATCH 1/7] spi: add slave device size in spi_device struct

2018-08-31 Thread Lothar Waßmann
ce size */ > + if (flash->spimem->spi->size == 0) > + flash->spimem->spi->size = nor->mtd.size; > + If the 'size' is an spimem specific variable it should be added to the spi_mem struct rather than the spi_device struct. Lothar Waßmann

Re: [RFC PATCH 1/2] dt-bindings: pwm: imx: Allow switching PWM output between PWM and GPIO

2018-08-23 Thread Lothar Waßmann
in u-boot. > Unfortunately there are both types of displays. Some with an ENABLE pin, some without. Lothar Waßmann -- ___ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Ge

Re: [RFC PATCH 1/2] dt-bindings: pwm: imx: Allow switching PWM output between PWM and GPIO

2018-08-23 Thread Lothar Waßmann
Michal Vokáč wrote: > On 22.8.2018 16:10, Lothar Waßmann wrote: > > My use case is attaching different displays to the same baseboard, > > where some displays have the brightness control pin inverted with > > respect to the others. It's easy to change the compatible

Re: [RFC PATCH 1/2] dt-bindings: pwm: imx: Allow switching PWM output between PWM and GPIO

2018-08-22 Thread Lothar Waßmann
Michal Vokáč wrote: > On 22.8.2018 13:17, Lothar Waßmann wrote: > > Michal Vokáč wrote: > > > >> On 22.8.2018 08:14, Lothar Waßmann wrote: > >>> Michal Vokáč wrote: > >>> > >>>> Output of the PWM block of i.MX SoCs i

Re: [RFC PATCH 1/2] dt-bindings: pwm: imx: Allow switching PWM output between PWM and GPIO

2018-08-22 Thread Lothar Waßmann
Michal Vokáč wrote: > On 22.8.2018 08:14, Lothar Waßmann wrote: > > Michal Vokáč wrote: > > > >> Output of the PWM block of i.MX SoCs is always zero volts when the block > >> is disabled. This can caue issues when inverted PWM polarity is needed. > >&g

Re: [RFC PATCH 1/2] dt-bindings: pwm: imx: Allow switching PWM output between PWM and GPIO

2018-08-21 Thread Lothar Waßmann
Michal Vokáč wrote: > Output of the PWM block of i.MX SoCs is always zero volts when the block > is disabled. This can caue issues when inverted PWM polarity is needed. > With inverted polarity a duty cycle = 0% corresponds to solid high level > on the output. If the PWM is dissabled its output i

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-04 Thread Lothar Waßmann
work. > > > > So whatever new feature you need to introduce it needs to be done in > > such a way that the existing dtb's will continue working. > But actually existing dtb is not right since the critical power rail > missing 'regulator-always-on'. It's a fix patch for dts, not related > with following dtb/kernel break rules, just a simple dts patch. Why > should we make promise for the wrong dtbs? > Because they are living in the outside world on real devices. Lothar Waßmann

Re: [PATCH] clk: imx25: set correct parents for ssi ipg clocks

2018-03-09 Thread Lothar Waßmann
enables both clocks explicitly. So they are not unused. > > > Doing something like this is not an option for ssi, this will not work with > imx31, 35 etc. > > Therefore, I suggest setting ssi1_ipg_per as parent of ssi1_ipg. > The right wayto fix this is to add the missing ipg_per clock to the DTB rather than introducing a bogus clock relationship that doesn't exist in hardware. The sound/soc/fsl/fsl_ssi.c driver does already handle a second clock as bitclock. It only needs to be specified in the DTB: &ssi1 { clocks = <&clks 117>, <&clk 55>; clock-names = "ipg", "baud"; }; Lothar Waßmann

Re: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth

2018-03-09 Thread Lothar Waßmann
Hi, On Fri, 09 Mar 2018 10:27:12 +0100 Lucas Stach wrote: > Hi Lothar, > > Am Freitag, den 09.03.2018, 09:37 +0100 schrieb Lothar Waßmann: > > Hi, > > > > On Thu, 8 Mar 2018 16:38:32 +0100 Martin Kaiser wrote: > > > Hi Lothar, > > > > > > &

Re: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth

2018-03-09 Thread Lothar Waßmann
Hi, On Thu, 8 Mar 2018 16:38:32 +0100 Martin Kaiser wrote: > Hi Lothar, > > Thus wrote Lothar Waßmann (l...@karo-electronics.de): > > > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > > > index 9725705..cf70df2 100644 > >

Re: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth

2018-03-08 Thread Lothar Waßmann
<&sdma 29 1 0>; > dma-names = "rx", "tx"; > + fsl,fifo-depth = <15>; > status = "disabled"; > }; > You are changing the global .dtsi file. Did you test this change with all devices that are affected by it? Lothar Waßmann

[PATCH] ARM: dts: imx6dl: remove 'lcdif' node

2018-02-19 Thread Lothar Waßmann
According to the "i.MX 6Solo/6DualLite Applications Processor Reference Manual" Rev. 3, 09/2017 there is no LCDIF unit on the i.MX6DL. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6dl.dtsi | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl.dtsi

Re: [PATCH v2 BUGFIX] ARM: dts: imx6ull: fix the imx6ull-14x14-evk configuration

2018-02-05 Thread Lothar Waßmann
Hi, On Mon, 5 Feb 2018 18:37:20 +0800 Shawn Guo wrote: > On Mon, Feb 05, 2018 at 10:55:43AM +0100, Lothar Waßmann wrote: > > Hi, > > > > On Mon, 5 Feb 2018 15:56:22 +0800 Shawn Guo wrote: > > > On Fri, Jan 26, 2018 at 09:52:18AM +0100, Lothar Waßmann wrote:

Re: [PATCH v2 BUGFIX] ARM: dts: imx6ull: fix the imx6ull-14x14-evk configuration

2018-02-05 Thread Lothar Waßmann
Hi, On Mon, 5 Feb 2018 15:56:22 +0800 Shawn Guo wrote: > On Fri, Jan 26, 2018 at 09:52:18AM +0100, Lothar Waßmann wrote: > > imx6ull-14x14-evk.dts currently includes the imx6ul.dtsi file for an > > i.MX6ULL SoC which is plain wrong. > > > > Rename the current imx6ul

[PATCH v2 BUGFIX] ARM: dts: imx6ull: fix the imx6ull-14x14-evk configuration

2018-01-26 Thread Lothar Waßmann
/imx6ull.dtsi) file. Signed-off-by: Lothar Waßmann --- Changes vs v1: - The newly created .dtsi file was missing arch/arm/boot/dts/imx6ul-14x14-evk.dts | 480 +-- arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 488 arch/arm/boot/dts/imx6ull-14x14

[PATCH 1/3] ARM: dts: imx6ull: fix the i.MX6ULL UART8 configuration

2018-01-26 Thread Lothar Waßmann
UART8 on i.MX6ULL is not located on the SPBA bus like on i.MX6UL but on the (otherwise unused) AIPS-3 bus. Create the appropriate AIPS-3 bus configuration and move the uart8 definition where it belongs. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6ull.dtsi | 29

[PATCH 3/3] ARM: dts: imx6ull: address some more incompatibilites between i.MX6UL and i.MX6ULL

2018-01-26 Thread Lothar Waßmann
The i.MX6ULL doesn't have the CAAM engine nor any SIM interface. These are currently not implemented for i.MX6UL but it cannot hurt to delete the corresponding nodes from the i.MX6ULL DTB anyway. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6ull.dtsi | 6 ++ 1 file chang

[PATCH BUGFIX] ARM: dts: imx6ull: fix the imx6ull-14x14-evk configuration

2018-01-26 Thread Lothar Waßmann
/imx6ull.dtsi) file. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6ul-14x14-evk.dts | 480 +--- arch/arm/boot/dts/imx6ull-14x14-evk.dts | 5 +- 2 files changed, 5 insertions(+), 480 deletions(-) diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dts b/arch/arm/boot

[PATCH 0/3] ARM: dts: imx6ull: fix some incompatibilities between i.MX6UL and i.MX6ULL

2018-01-26 Thread Lothar Waßmann
This patchset addresses some differences between i.MX6UL and i.MX6ULL which have slipped through the cracks so far. - UART8 is not on SPBA but on AIPS-3 - i.MX6ULL has an ESAI interface in the address range of the UART8 on i.MX6UL - i.MX6ULL does not have a CAAM unit nor SIM interfaces

[PATCH 2/3] ARM: dts: imx6ull: add support for the esai interface

2018-01-26 Thread Lothar Waßmann
: Lothar Waßmann --- Documentation/devicetree/bindings/sound/fsl,esai.txt | 4 ++-- arch/arm/boot/dts/imx6ull.dtsi | 17 + sound/soc/fsl/fsl_esai.c | 1 + 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/Documentation

Re: [PATCH v2 1/2] Input: edt-ft5x06 - Add support for regulator

2018-01-23 Thread Lothar Waßmann
*reset_gpio; > > struct gpio_desc *wake_gpio; > > @@ -993,6 +995,23 @@ static int edt_ft5x06_ts_probe(struct i2c_client > > *client, > > > > tsdata->max_support_points = chip_data->max_support_points; > > > > + tsdata->vcc = de

Re: [PATCH] ARM: dts: imx: Add memory node unit name

2017-12-21 Thread Lothar Waßmann
files all have this: | memory { device_type = "memory"; reg = <0 0>; }; Thus you will end up with a 'memory' node with a reg = <0 0> entry and an additional 'memory@...' node with the correct 'reg' values. Lothar Waßmann

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-08 Thread Lothar Waßmann
Hi, On Thu, 7 Dec 2017 12:50:50 -0500 Sinan Kaya wrote: > On 12/7/2017 10:20 AM, Lothar Waßmann wrote: > > Hi, > > > > On Thu, 7 Dec 2017 09:45:31 -0500 Sinan Kaya wrote: > >> On 12/7/2017 8:10 AM, Lothar Waßmann wrote: > >>>> +void *of_fwnode_get_

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-08 Thread Lothar Waßmann
Hi, On Thu, 7 Dec 2017 12:50:50 -0500 Sinan Kaya wrote: > On 12/7/2017 10:20 AM, Lothar Waßmann wrote: > > Hi, > > > > On Thu, 7 Dec 2017 09:45:31 -0500 Sinan Kaya wrote: > >> On 12/7/2017 8:10 AM, Lothar Waßmann wrote: > >>>> +void *of_fwnode_get_

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-07 Thread Lothar Waßmann
Hi, On Thu, 7 Dec 2017 09:45:31 -0500 Sinan Kaya wrote: > On 12/7/2017 8:10 AM, Lothar Waßmann wrote: > >> +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, > >> + struct device *dev) > > Shouldn't this be 'const v

Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback

2017-12-07 Thread Lothar Waßmann
fwnode, > return 0; > } > > +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, > +struct device *dev) Shouldn't this be 'const void *of_fwnode_get_match_data' Lothar Waßmann

Re: [RESENT PATCH] drm/panel: support Innolux P097PFG panel

2017-12-04 Thread Lothar Waßmann
e_id innolux_of_match[] = { > - { .compatible = "innolux,p079zca", }, > - { } > + { .compatible = "innolux,p079zca", > + .data = &innolux_p079zca_panel_desc > + }, > + { .compatible = "innolux,p097pfg", > + .data = &innolux_p097pfg_panel_desc > + } > }; > This hunk deletes the empty entry which is required as an end of list marker! Lothar Waßmann

Re: [PATCH] rtc: add mxc driver for i.MX53

2017-11-30 Thread Lothar Waßmann
dev)) > + enable_irq_wake(pdata->irq); > + > + return 0; > +} > + > +/*! > + * This function is called to correct the system time based on the > + * current MXC RTC time relative to the time delta saved during > + * suspend. > + * > + * @param pdev not used > + * > + * @return The function always returns 0. > + */ > +static int mxc_rtc_resume(struct platform_device *pdev) > +{ > + struct rtc_drv_data *pdata = platform_get_drvdata(pdev); > + > + if (device_may_wakeup(&pdev->dev)) > + disable_irq_wake(pdata->irq); > + > + return 0; > +} > + > +static const struct of_device_id mxc_ids[] = { > + {.compatible = "fsl,imx53-rtc",}, > missing spaces after '{' and before '}' Lothar Waßmann

Re: [PATCH] rtc: add mxc driver for i.MX53

2017-11-30 Thread Lothar Waßmann
> + struct timespec tv; > > + struct resource *res; > > + struct rtc_drv_data *pdata = NULL; > > No need to initialize. > > > + void __iomem *ioaddr; > > + int ret = 0; > Same here. Lothar Waßmann

Re: [PATCH] drm/bridge: Fix lvds-encoder since the panel_bridge rework.

2017-11-15 Thread Lothar Waßmann
lvds_encoder->bridge.funcs = &funcs; > + drm_bridge_add(&lvds_encoder->bridge); > > - platform_set_drvdata(pdev, bridge); > + platform_set_drvdata(pdev, lvds_encoder); > > return 0; > } > > static int lvds_encoder_remove(struct platform_device *pdev) > { > - struct drm_bridge *bridge = platform_get_drvdata(pdev); > + struct lvds_encoder *lvds_encoder = platform_get_drvdata(pdev); > > - drm_bridge_remove(bridge); > + drm_bridge_remove(&lvds_encoder->bridge); > > return 0; > } > Tested-by: Lothar Waßmann Lothar Waßmann

Re: [PATCH 0/2] backlight: pwm_bl: prevent backlight flicker when switching PWM on

2017-11-13 Thread Lothar Waßmann
Hi, On Fri, 10 Nov 2017 12:22:15 +0100 Enric Balletbo i Serra wrote: > Hi all, > > On 08/11/17 11:48, Daniel Thompson wrote: > > On 26/10/17 13:49, Lothar Waßmann wrote: > >> These patches implement some measures to prevent backlight flicker > >> when the bac

Re: [PATCH 2/2] backlight: pwm_bl: add configurable delay between re-enabling PWM and switching backlight power on

2017-11-08 Thread Lothar Waßmann
Hi, On Wed, 8 Nov 2017 09:12:12 + Lee Jones wrote: > On Wed, 08 Nov 2017, Lothar Waßmann wrote: > > > Hi, > > > > On Tue, 7 Nov 2017 18:46:18 -0600 Rob Herring wrote: > > > On Mon, Oct 30, 2017 at 5:33 AM, Lee Jones wrote: > > > > On Fri, 27 Oct

Re: [PATCH 2/2] backlight: pwm_bl: add configurable delay between re-enabling PWM and switching backlight power on

2017-11-07 Thread Lothar Waßmann
Hi, On Tue, 7 Nov 2017 18:46:18 -0600 Rob Herring wrote: > On Mon, Oct 30, 2017 at 5:33 AM, Lee Jones wrote: > > On Fri, 27 Oct 2017, Rob Herring wrote: > > > >> On Thu, Oct 26, 2017 at 02:49:46PM +0200, Lothar Waßmann wrote: > >> > When switching the backlig

[PATCH 2/2] backlight: pwm_bl: add configurable delay between re-enabling PWM and switching backlight power on

2017-10-26 Thread Lothar Waßmann
When switching the backlight on, the LCD may need some time to adjust to the configured PWM duty cycle. Add a configurable delay between configuring the PWM and enabling the backlight regulator to account for this. Signed-off-by: Lothar Waßmann --- .../bindings/leds/backlight/pwm-backlight.txt

[PATCH 1/2] backlight: pwm_bl: Enable PWM before switching regulator on

2017-10-26 Thread Lothar Waßmann
PWM before switching backlight power on to prevent this. Signed-off-by: Lothar Waßmann --- drivers/video/backlight/pwm_bl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index 002f1ce..921f322 100644 --- a

[PATCH 0/2] backlight: pwm_bl: prevent backlight flicker when switching PWM on

2017-10-26 Thread Lothar Waßmann
These patches implement some measures to prevent backlight flicker when the backlight is being switched on for a display with an active low brightness control pin.

[PATCH 0/2] backlight: pwm_bl: prevent backlight flicker when switching PWM on

2017-10-26 Thread Lothar Waßmann
These patches implement some measures to prevent backlight flicker when the backlight is being switched on for a display with an active low brightness control pin. GIT: [PATCH 1/2] backlight: pwm_bl: Enable PWM before switching regulator GIT: [PATCH 2/2] backlight: pwm_bl: add configurable delay be

Re: [PATCH 4/9] drm/panel: simple: add support for overriding the pixel clock polarity

2017-10-25 Thread Lothar Waßmann
Hi, On Tue, 17 Oct 2017 14:45:04 +0200 Thierry Reding wrote: > On Tue, Oct 17, 2017 at 02:25:07PM +0200, Lothar Waßmann wrote: > > Hi, > > > > On Tue, 17 Oct 2017 14:14:22 +0200 Thierry Reding wrote: > > > On Wed, Oct 11, 2017 at 01:23:36PM +0200, Lothar Wa

[PATCH] ARM: dts: imx53-tx53: fix interrupt flags

2017-10-23 Thread Lothar Waßmann
Some interrupts properties are given '0' as the flags argument or no flags argument at all. Change them to use the appropriate interrupt flags. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx53-tx53-x03x.dts | 2 +- arch/arm/boot/dts/imx53-tx53.dtsi | 4 ++-- 2 files

[PATCH] ARM: dts: imx28-tx28: fix interrupt flags

2017-10-23 Thread Lothar Waßmann
Some interrupts properties are given '0' as the flags argument. Change them to use the appropriate interrupt flags. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx28-tx28.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx28-tx28.

[PATCH] ARM: dts: imx28-tx28: fix interrupt flags

2017-10-23 Thread Lothar Waßmann
Some interrupts properties are given '0' as the flags argument. Change them to use the appropriate interrupt flags. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx28-tx28.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx28-tx28.

[PATCH] ARM: dts: imx28-tx28: fix interrupt flags

2017-10-23 Thread Lothar Waßmann
Some interrupts properties are given '0' as the flags argument. Change them to use the appropriate interrupt flags. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx28-tx28.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx28-tx28.

Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property

2017-10-17 Thread Lothar Waßmann
Hi, On Wed, 18 Oct 2017 10:13:32 +0800 Shawn Guo wrote: > On Mon, Oct 16, 2017 at 10:56:32AM +0200, Lothar Waßmann wrote: > > Hi, > > > > On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-König wrote: > > > Hello, > > > > > > On Wed, Oct 11

Re: [PATCH 2/9] drm/panel: simple: simplify display_mode definitions by using macro

2017-10-17 Thread Lothar Waßmann
Hi, On Tue, 17 Oct 2017 15:08:31 +0200 Thierry Reding wrote: > On Tue, Oct 17, 2017 at 03:05:16PM +0200, Lothar Waßmann wrote: > > Hi, > > > > On Tue, 17 Oct 2017 14:09:37 +0200 Thierry Reding wrote: > > > On Wed, Oct 11, 2017 at 01:23:34PM +0200, Lothar Waßman

Re: [PATCH 2/9] drm/panel: simple: simplify display_mode definitions by using macro

2017-10-17 Thread Lothar Waßmann
Hi, On Tue, 17 Oct 2017 14:09:37 +0200 Thierry Reding wrote: > On Wed, Oct 11, 2017 at 01:23:34PM +0200, Lothar Waßmann wrote: > > Use the newly defined macro to generate the display_mode data entries > > for all panels. This reduces the code size significantly and makes th

Re: [PATCH 3/9] drm/panel: simple: make it possible to override LCD bus format

2017-10-17 Thread Lothar Waßmann
Hi, On Tue, 17 Oct 2017 14:12:40 +0200 Thierry Reding wrote: > On Wed, Oct 11, 2017 at 01:23:35PM +0200, Lothar Waßmann wrote: > > The baseboards for the Ka-Ro electronics series of i.MX modules > > use a 24bit LCD interface, no matter what LCD bus width the SoC on the > >

Re: [PATCH 4/9] drm/panel: simple: add support for overriding the pixel clock polarity

2017-10-17 Thread Lothar Waßmann
Hi, On Tue, 17 Oct 2017 14:14:22 +0200 Thierry Reding wrote: > On Wed, Oct 11, 2017 at 01:23:36PM +0200, Lothar Waßmann wrote: > > The Ka-Ro electronics MB7 baseboard has an on-board LCD->LVDS > > converter that requires a fixed pixelclk polarity, no matter what the > &

Re: [PATCH 1/9] drm/panel: simple: add a macro for defining display modes in a simpler and less error prone way

2017-10-17 Thread Lothar Waßmann
Hi, On Tue, 17 Oct 2017 14:08:18 +0200 Thierry Reding wrote: > On Wed, Oct 11, 2017 at 01:23:33PM +0200, Lothar Waßmann wrote: > > Create a macro that eases the definition of display mode parameters by > > accecpting the parameters: > > freq, hactive, hfront-porch,

Re: [PATCH 6/7] ARM: dts: imx6ul: add support for TXUL modules on TXUL-Mainboard

2017-10-17 Thread Lothar Waßmann
Hi, On Mon, 16 Oct 2017 18:33:17 -0200 Fabio Estevam wrote: > Hi Lothar, > > On Fri, Oct 13, 2017 at 7:43 AM, Lothar Waßmann > wrote: > > > +/ { > > + aliases { > > + lcdif_24bit_pins_a = &pinctrl_disp0_3; > > + mmc

[PATCHv3 02/12] ARM: dts: imx6-tx6: remove obsolete eeti,egalax_ts

2017-10-17 Thread Lothar Waßmann
The display, that incorporates this touchpanel is obsolete and won't be supported any more. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6dl-tx6u-811x.dts | 23 +-- arch/arm/boot/dts/imx6dl-tx6u-81xx-mb7.dts | 22 +- arch/arm/boot/dts/

[PATCHv3 05/12] ARM: dts: imx6-tx6: improve ethernet related pinctrl setup

2017-10-17 Thread Lothar Waßmann
pinctrl settings from the PHY subnode to the FEC node. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6qdl-tx6.dtsi | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi index a50bf71

[PATCHv3 10/12] ARM: dts: imx6-tx6: add a .dtsi file for the MB7 baseboard

2017-10-17 Thread Lothar Waßmann
Move the MB7 specific settings to a separate .dtsi file to facilitate supporting more module variants with this baseboard. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6dl-tx6u-81xx-mb7.dts | 9 +-- arch/arm/boot/dts/imx6q-tx6q-11x0-mb7.dts | 42 + arch/arm/boot/dts

[PATCHv3 11/12] ARM: dts: imx: add support for TX6QP

2017-10-17 Thread Lothar Waßmann
-DIMM Temp. Range -40°C to 105°C Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/Makefile | 2 + arch/arm/boot/dts/imx6qp-tx6qp-8037.dts | 86 +++ arch/arm/boot/dts/imx6qp-tx6qp-8137.dts | 90 + 3 files changed, 178

[PATCHv3 07/12] ARM: dts: imx6-tx6: convert to using simple-audio-card

2017-10-17 Thread Lothar Waßmann
Convert the DTS sound setup to use the simple-audio-card driver. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6qdl-tx6.dtsi | 50 -- 1 file changed, 42 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot

[PATCHv3 01/12] ARM: dts: imx6-tx6: update model property to match current module HW revision

2017-10-17 Thread Lothar Waßmann
The current TX6Q module HW revision is 3 reflected in the module name suffix '-1030' (-1130 for LVDS). Change the model string to prevent confusion about what DTS file to use for these modules. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6q-tx6q-1010.dts | 4 ++-- arch/ar

[PATCHv3 06/12] ARM: dts: imx6-tx6: specify ethernet phy reset post-delay

2017-10-17 Thread Lothar Waßmann
Under certain circumstances the ethernet PHY cannot be detected on Ka-Ro electronics TX6 modules. Using a phy-reset-post-delay of at least 2ms alleviates this problem. Define it to 10ms to be on the safe side. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6qdl-tx6.dtsi | 1 + 1 file

[PATCHv3 04/12] ARM: dts: imx6-tx6: add trickle-charge config for DS1339

2017-10-17 Thread Lothar Waßmann
As the DS1339 driver now supports enabling the trickle charge feature via DTB, add the appropriate properties to utilize this feature. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6qdl-tx6.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b

[PATCHv3 03/12] ARM: dts: imx6-tx6: remove obsolete ipu1 alias

2017-10-17 Thread Lothar Waßmann
The 'ipu1' alias is already defined in imx6q.dtsi. There is no need to redefine it here. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6q-tx6q-11x0-mb7.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6q-tx6q-11x0-mb7.dts b/arch/arm/boot/dts/imx6q

[PATCHv3 00/12] ARM: dts: imx6: Update dts files for the Ka-Ro TX6 module series

2017-10-17 Thread Lothar Waßmann
Please ignore the V2 series. I accidentally sent the patches from a wrong directory. This patchset updates the dts files for the Ka-Ro electronics GmbH TX6 module series and adds some include files to facilitate supporting various SoM/baseboard combinations. Changes vs. v2: - resent the correct p

[PATCHv3 12/12] ARM: dts: imx: add support for TX6 modules on MB7 baseboard

2017-10-17 Thread Lothar Waßmann
Create .dts files for various Ka-Ro electronics TX modules on the MB7 baseboard. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/Makefile | 8 arch/arm/boot/dts/imx6dl-tx6s-8034-mb7.dts | 48 arch/arm/boot/dts/imx6dl-tx6s-8035-mb7.dts | 48

[PATCHv3 09/12] ARM: dts: imx6-tx6: move display configuration to .dtsi file

2017-10-17 Thread Lothar Waßmann
Currently the display (LCD or LVDS) configuration is duplicated with slight variations in each TX6 module specific file. Move it to an include file for simplification and consistency. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts| 74 +-- arch/arm/boot

[PATCHv3 08/12] ARM: dts: imx6-tx6: add support for I2C bus recovery

2017-10-17 Thread Lothar Waßmann
Define the required properties to enable I2C bus recovery supported by the I2C subsystem. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6qdl-tx6.dtsi | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch

[PATCH 11/12] ARM: dts: imx: add support for TX6QP

2017-10-17 Thread Lothar Waßmann
-DIMM Temp. Range -40°C to 105°C Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/Makefile | 2 + arch/arm/boot/dts/imx6qp-tx6qp-8037.dts | 86 +++ arch/arm/boot/dts/imx6qp-tx6qp-8137.dts | 90 + 3 files changed, 178

[PATCH 06/12] ARM: dts: imx6-tx6: specify ethernet phy reset post-delay

2017-10-17 Thread Lothar Waßmann
Under certain circumstances the ethernet PHY cannot be detected on Ka-Ro electronics TX6 modules. Using a phy-reset-post-delay of at least 2ms alleviates this problem. Define it to 10ms to be on the safe side. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6qdl-tx6.dtsi | 1 + 1 file

[PATCH 02/12] ARM: dts: imx6-tx6: remove obsolete eeti,egalax_ts

2017-10-17 Thread Lothar Waßmann
The display, that incorporates this touchpanel is obsolete and won't be supported any more. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6dl-tx6u-811x.dts | 23 +-- arch/arm/boot/dts/imx6dl-tx6u-81xx-mb7.dts | 22 +- arch/arm/boot/dts/

[PATCH 07/12] ARM: dts: imx6-tx6: convert to using simple-audio-card

2017-10-17 Thread Lothar Waßmann
Convert the DTS sound setup to use the simple-audio-card driver. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6qdl-tx6.dtsi | 50 -- 1 file changed, 42 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot

[PATCH 08/12] ARM: dts: imx6-tx6: add support for I2C bus recovery

2017-10-17 Thread Lothar Waßmann
Define the required properties to enable I2C bus recovery supported by the I2C subsystem. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6qdl-tx6.dtsi | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch

[PATCH 05/12] ARM: dts: imx6-tx6: improve ethernet related pinctrl setup

2017-10-17 Thread Lothar Waßmann
pinctrl settings from the PHY subnode to the FEC node. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6qdl-tx6.dtsi | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi index a50bf71

[PATCH 04/12] ARM: dts: imx6-tx6: add trickle-charge config for DS1339

2017-10-17 Thread Lothar Waßmann
As the DS1339 driver now supports enabling the trickle charge feature via DTB, add the appropriate properties to utilize this feature. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6qdl-tx6.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b

[PATCH 12/12] ARM: dts: imx: add support for TX6 modules on MB7 baseboard

2017-10-17 Thread Lothar Waßmann
Create .dts files for various Ka-Ro electronics TX modules on the MB7 baseboard. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/Makefile | 8 arch/arm/boot/dts/imx6dl-tx6s-8034-mb7.dts | 48 arch/arm/boot/dts/imx6dl-tx6s-8035-mb7.dts | 48

[PATCH 10/12] ARM: dts: imx6-tx6: add a .dtsi file for the MB7 baseboard

2017-10-17 Thread Lothar Waßmann
Move the MB7 specific settings to a separate .dtsi file to facilitate supporting more module variants with this baseboard. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6dl-tx6u-81xx-mb7.dts | 9 +-- arch/arm/boot/dts/imx6q-tx6q-11x0-mb7.dts | 42 + arch/arm/boot/dts

[PATCH 09/12] ARM: dts: imx6-tx6: move display configuration to .dtsi file

2017-10-17 Thread Lothar Waßmann
Currently the display (LCD or LVDS) configuration is duplicated with slight variations in each TX6 module specific file. Move it to an include file for simplification and consistency. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts| 74 +-- arch/arm/boot

[PATCH 01/12] ARM: dts: imx6-tx6: update model property to match current module HW revision

2017-10-17 Thread Lothar Waßmann
The current TX6Q module HW revision is 3 reflected in the module name suffix '-1030' (-1130 for LVDS). Change the model string to prevent confusion about what DTS file to use for these modules. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6q-tx6q-1010.dts | 4 ++-- arch/ar

[PATCH 03/12] ARM: dts: imx6-tx6: remove obsolete ipu1 alias

2017-10-17 Thread Lothar Waßmann
The 'ipu1' alias is already defined in imx6q.dtsi. There is no need to redefine it here. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6q-tx6q-11x0-mb7.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6q-tx6q-11x0-mb7.dts b/arch/arm/boot/dts/imx6q

[PATCHv2 00/12] ARM: dts: imx6: Update dts files for the Ka-Ro TX6 module series

2017-10-17 Thread Lothar Waßmann
This patchset updates the dts files for the Ka-Ro electronics GmbH TX6 module series and adds some include files to facilitate supporting various SoM/baseboard combinations. Changes vs. v1: - rebased to imx/dt branch - eliminate use of 'interrupts-extended' property according to Uwe Kleine-König

Re: [PATCH 4/9] drm/panel: simple: add support for overriding the pixel clock polarity

2017-10-16 Thread Lothar Waßmann
Hi, On Mon, 16 Oct 2017 17:13:29 -0500 Rob Herring wrote: > On Wed, Oct 11, 2017 at 6:23 AM, Lothar Waßmann > wrote: > > The Ka-Ro electronics MB7 baseboard has an on-board LCD->LVDS > > converter that requires a fixed pixelclk polarity, no matter what the > > pan

Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property

2017-10-16 Thread Lothar Waßmann
Hi, On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-König wrote: > Hello, > > On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Waßmann wrote: > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts > > b/arch/arm/boot/dts/imx28-tx28.dts > > index 211e67d..3c852f7 100644

[PATCH 5/7] ARM: dts: imx6ul-txul: use interrupts-extended property

2017-10-13 Thread Lothar Waßmann
Use the 'interrupts-extended' property instead of pairs of 'interrupt-parent', 'interrupts' properties. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6ul-tx6ul.dtsi | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/arm

[PATCH 2/7] ARM: dts: imx6ul-txul: specify ethernet phy reset post-delay

2017-10-13 Thread Lothar Waßmann
Under certain circumstances the ethernet PHY cannot be detected on Ka-Ro electronics TXUL modules. Using a phy-reset-post-delay of > 5ms alleviates this problem. Specify a value of 10ms to be on the safe side. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6ul-tx6ul.dtsi | 1 + 1 f

[PATCH 7/7] ARM: dts: imx6ul-txul: add support for TXUL modules on MB7 baseboard

2017-10-13 Thread Lothar Waßmann
Add a dtsi file for TXUL modules on the MB7 baseboard and use it to create dts files for the various TXUL module variants on the MB7 baseboard. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/Makefile | 5 +- arch/arm/boot/dts/imx6ul-txul-5010-mb7.dts | 48

[PATCH 4/7] ARM: dts: imx6ul-txul: use panel-simple driver for LCD

2017-10-13 Thread Lothar Waßmann
Convert the TXUL board support to use the panel-simple driver. The now obsolete 'display-timings' node is kept for compatibility with U-Boot, which derives its display configuration therefrom. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/imx6ul-tx6ul.

[PATCH 6/7] ARM: dts: imx6ul: add support for TXUL modules on TXUL-Mainboard

2017-10-13 Thread Lothar Waßmann
Add .dts files for the TXUL module variants TXUL-5010, TXUL-5011, TXUL-8013 on the TXUL-Mainboard. Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/Makefile| 6 +- arch/arm/boot/dts/imx6ul-tx6ul-mainboard.dts | 271 -- arch/arm/boot/dts

[PATCH 3/7] ARM: dts: imx6ul: add support for TXUL-8013

2017-10-13 Thread Lothar Waßmann
. Range -40°C to 85°C Signed-off-by: Lothar Waßmann --- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/imx6ull-txul-8013.dts | 69 + 2 files changed, 71 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/imx6ull-txul-8013.dts

[PATCH 0/7] ARM: dts: imx6ul: Update dts files for the Ka-Ro TXUL module series

2017-10-13 Thread Lothar Waßmann
This patch set brings the Ka-Ro electronics GmbH TXUL board support up to date and adds support for the TXUL modules on the MB7 baseboard.

  1   2   3   4   5   >