Anson Huang <anson.hu...@nxp.com> wrote: > Hi, Lothar > > Best Regards! > Anson Huang > > > -----Original Message----- > > From: Lothar Waßmann [mailto:l...@karo-electronics.de] > > Sent: 2018年11月28日 17:04 > > To: Anson Huang <anson.hu...@nxp.com> > > Cc: a.zu...@towertech.it; alexandre.bell...@bootlin.com; > > robh...@kernel.org; mark.rutl...@arm.com; catalin.mari...@arm.com; > > will.dea...@arm.com; Aisheng DONG <aisheng.d...@nxp.com>; Andy Gross > > <andy.gr...@linaro.org>; a...@arndb.de; horms+rene...@verge.net.au; > > he...@sntech.de; bjorn.anders...@linaro.org; enric.balle...@collabora.com; > > amit.kuche...@linaro.org; ezequ...@collabora.com; o...@lixom.net; > > shawn...@kernel.org; linux-...@vger.kernel.org; devicet...@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > > dl-linux-imx <linux-...@nxp.com> > > Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller > > RTC support > > > > Hi, > > > > On Tue, 27 Nov 2018 09:41:46 +0000 Anson Huang wrote: > > > Add i.MX8QXP system controller RTC support. > > > > > > Signed-off-by: Anson Huang <anson.hu...@nxp.com> > > > --- > > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > index 9155d45..ef57db6 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > @@ -433,4 +433,8 @@ > > > #size-cells = <1>; > > > ranges = <0x5f000000 0x0 0x5f000000 0x1000000>; > > > }; > > > + > > > + rtc: rtc { > > > + compatible = "nxp,imx8qxp-sc-rtc"; > > > + }; > > > }; > > IMO this should be disabled by default. > > This module is NOT depending on any board design, should it be enabled by > default in soc dtsi? > Like wdog etc.. > What about existing users (if there are any), which would have a new device appearing when updating the DTB?
Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | i...@karo-electronics.de ___________________________________________________________
