Hi Luis,
On Fri, Jan 11, 2019 at 9:53 AM Luis Machado wrote:
>
> Hi,
>
> For the sake of keeping things organized and easier to review, i've broken
> up the previous change into smaller pieces.
>
> Luis Machado (6):
> Make the default target only build the utils
> Remove utils/utils_sanity.sh
On Wed, May 16, 2018 at 11:41 PM, Thierry Escande
wrote:
> Hi Lisa,
>
>
> On 17/05/2018 02:10, Lisa Nguyen wrote:
>>
>> Hi Thierry,
>>
>> On Wed, May 16, 2018 at 6:28 AM, Thierry Escande
>> wrote:
>>>
>>> The governor needs to be set t
Hi Thierry,
On Wed, May 16, 2018 at 6:28 AM, Thierry Escande
wrote:
> The governor needs to be set to 'userspace' before setting the original
> frequency back.
>
> This fixes cpufreq_06.sh that otherwise logs 'sh: echo: I/O error'
> messages in its log file.
>
> Signed-off-by: Thierry Escande
>
On 16 October 2017 at 20:03, Li Zhijian wrote:
> at commit aea49c3: functions: Fix logic for get_os() function
> To determine which OS the scripts are running on, check if the
> build.prop file exists instead of using the lsb_release command.
> If it does, then the scripts are running on Androi
On 16 October 2017 at 20:02, Li Zhijian wrote:
> 'ps' have different output between Android and ubuntu, and test suite
> use get_os to determine which OS the scripts are running on.
>
> at commit 84479a38, thermal: Get correct PID for heat_cpu based on OS
> this patch want to get PID based on OS,
Hi Li,
On 13 October 2017 at 02:51, Li Zhijian wrote:
> Signed-off-by: Li Zhijian
Can you add a brief commit message to why this change is necessary and
send an updated patch please?
Thanks,
Lisa
> ---
> thermal/thermal_06.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/thermal/t
On 5 September 2017 at 03:01, Xiang Dai wrote:
> Hi!
>
> I test with below two cpu to test:
> - Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
>
> With below action:
> make -C cpuidle cpuidle_killer
> make -C thermal run_tests
>
> It shows several thermal zone and cooling device on my machine.
> But th
Hi,
On 29 August 2017 at 19:23, Dai Xiang wrote:
> Hi!
>
> I test with below two cpu to test:
> - Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
> - Intel(R) Atom(TM) CPU S1240 @ 1.60GHz
>
> With below action:
> make -C cpuidle cpuidle_killer
> make -C cputopology run_tests
>
> Both cpu fail with cput
On 16 May 2016 at 14:21, Lisa Nguyen wrote:
> On 12 May 2016 at 03:02, Saul Romero wrote:
>> Hello Daniel:
>> Where do you want me to elaborate more about this fix? Is it in the comments
>> section so amend the patch?
>> Thanks!
>
> Hi Saul,
>
> You&
On 12 May 2016 at 03:02, Saul Romero wrote:
> Hello Daniel:
> Where do you want me to elaborate more about this fix? Is it in the comments
> section so amend the patch?
> Thanks!
Hi Saul,
You'd elaborate more about your fix in your commit message. So far
your commit message is, "Changes in cpuf
Hi Saul,
On 4 May 2016 at 03:54, Saul Romero wrote:
> ---
You're missing a commit message and a Signed-off-by line. Can you
resend the patch with those two items included please?
Assuming this is the latest commit you made, you can use the 'git
commit --amend -s' command to make the updates.
>
Hi Daniel,
On 22 February 2016 at 07:19, David Brown wrote:
> On Fri, Feb 19, 2016 at 02:32:40PM +, Daniel Lezcano wrote:
>
>> From: Daniel Lezcano
>
>
> Did you mean to have these patches authored by your @free.fr address,
> but sent from Linaro?
>
>> Subject: Re: [PATCH 1/6] Change options
Merged.
https://git.linaro.org/power/pm-qa.git/commit/e66966ef6a08cd3b491ee1df5c6c5d33baaf1f1c
Will add a entry for this in the PM-QA wiki.
Thanks,
Lisa
On 22 April 2015 at 04:10, Vincent Guittot wrote:
> On 21 April 2015 at 21:25, Larry Bassel wrote:
>> Add test which verifies capacity calcu
Update the README file with bugs, questions, and contribution
sections and fix the format for readability.
Signed-off-by: Lisa Nguyen
---
Changes in v2:
* Removed references to LAVA
* Rewritten Additional Notes section of README
* Replace the phrase "Linux devices" with hardware
On 15 April 2015 at 02:06, Amit Kucheria wrote:
> On Wed, Apr 15, 2015 at 3:32 AM, Lisa Nguyen wrote:
>> Update the README file with bugs, questions, and contribution
>> sections and fix the format for readability.
>>
>> Signed-off-by: Lisa Nguye
Update the README file with bugs, questions, and contribution
sections and fix the format for readability.
Signed-off-by: Lisa Nguyen
---
README | 46 +++---
1 file changed, 39 insertions(+), 7 deletions(-)
diff --git a/README b/README
index 2eef1c4
On 5 April 2015 at 22:43, Amit Kucheria wrote:
> On Fri, Apr 3, 2015 at 1:09 AM, Larry Bassel wrote:
>> Add test which verifies capacity calculation on arm
>> architecture platforms.
>>
>> Since there isn't yet a similar calculation done
>> for arm64 platforms, this architecture isn't supported
>
Applied with Vincent's ack:
http://git.linaro.org/power/pm-qa.git/commit/04211670ed04645fe44e1244aa799658423bac47
Thanks! :)
On 1 April 2015 at 00:23, Vincent Guittot wrote:
> On 3 March 2015 at 22:02, Larry Bassel wrote:
>> Add test which checks and prints scheduler domain flags.
>>
>> Signed
Gentle ping and friendly reminder that I need someone to ack Larry's
cpu capacity script before I can merge it :)
On 24 March 2015 at 08:12, Larry Bassel wrote:
> On 24 Mar 15 12:10, Amit Kucheria wrote:
>> Larry,
>>
>> Could you also please attach the output of the script on your test platform?
On 3 March 2015 at 13:02, Larry Bassel wrote:
>
> Add test which checks and prints scheduler domain flags.
>
> Signed-off-by: Larry Bassel
> ---
> cputopology/cputopology_03.sh | 109
> +
> cputopology/cputopology_03.txt | 1 +
> 2 files changed, 110 i
On 25 February 2015 at 05:52, Vincent Guittot
wrote:
> On 24 February 2015 at 21:53, Vincent Guittot
> wrote:
>> On 24 February 2015 at 01:58, Lisa Nguyen wrote:
>>> [Adding Mike Turquette as another possible reviewer]
>>>
>>> On 7 February 2015 at 16
[Adding Mike Turquette as another possible reviewer]
On 7 February 2015 at 16:08, Larry Bassel wrote:
> Add test which checks and prints scheduler domain flags.
>
> Signed-off-by: Larry Bassel
> ---
> cputopology/cputopology_03.sh | 74
> ++
> cputopolo
Couple patches to ensure that PM-QA scripts will run in order
and remove unnecessary checks in cpuidle_08 and cpuidle_09
scripts.
Lisa Nguyen (2):
Test: Add sort function
cpufreq: Remove unnecessary checks
Test.mk |2 +-
cpufreq/cpufreq_08.sh |3 ---
cpufreq
The check function already determines if a subtest fails, passes, or
skips. No need to check for the return value of the command.
Signed-off-by: Lisa Nguyen
---
cpufreq/cpufreq_08.sh |3 ---
cpufreq/cpufreq_09.sh |6 --
2 files changed, 9 deletions(-)
diff --git a/cpufreq
Use the built-in sort function to ensure that the PM-QA
scripts will run in order. Some platforms may run
makefile versions greater than 3.82.
See the following link for details:
https://lists.gnu.org/archive/html/info-gnu/2010-07/msg00023.html
Signed-off-by: Lisa Nguyen
---
Test.mk |2
Update the Android makefiles to include new test numbers to
run cputopology_sanity.sh, cpuhotplug_00.sh (formerly
1_sanity_check.sh), and cpuhotplug_99.sh (formerly
z_sanity_check.sh).
Signed-off-by: Lisa Nguyen
---
cpuhotplug/Android.mk |4 +---
cputopology/Android.mk |2 +-
2 files
Every test module has a sanity script. Add one for cputopology
to check for topology entries for all cpus.
Signed-off-by: Lisa Nguyen
---
cputopology/cputopology_sanity.sh | 49
cputopology/cputopology_sanity.txt |1 +
2 files changed, 50 insertions
z_sanity_check.sh doesn't have a meaningful name. Rename it to
cpuhotplug_99 as the last script to run to see if all cpus are back
online after running previous cpuhotplug scripts.
Signed-off-by: Lisa Nguyen
---
cpuhotplug/cpuhotplug_99.sh |
1_sanity_check.sh script didn't have a meaningful name. Rename it to
cpuhotplug_00 as the first script to check if all cpus are online
before the other cpuhotplug scripts begin.
Signed-off-by: Lisa Nguyen
---
cpuhotplug/1_sanity_check.sh |
look good, then update the Android makefiles to include
the new test names. The PM-QA wiki[2] will be updated as well.
[1] http://lists.linaro.org/pipermail/linaro-dev/2015-February/017797.html
[2] https://wiki.linaro.org/WorkingGroups/PowerManagement/
Resources/TestSuite/PmQaSpecification
Lisa
On 1 February 2015 at 22:00, Amit Kucheria wrote:
> On Mon, Feb 2, 2015 at 7:34 AM, Lisa Nguyen wrote:
>> Set the sampling_rate to zero if the sampling_rate attribute cannot
>> be found in either directories listed in the if condition. This will
>> also resolve minor bugs wh
On 1 February 2015 at 22:03, Amit Kucheria wrote:
> On Mon, Feb 2, 2015 at 7:34 AM, Lisa Nguyen wrote:
>> With this new change, the final result for the cpufreq_09
>> script will always show up and be counted in LAVA.
>
> Why?
I'll look into this in detail. It
On 1 February 2015 at 22:02, Amit Kucheria wrote:
> On Mon, Feb 2, 2015 at 7:34 AM, Lisa Nguyen wrote:
>> Before searching for specific governors, check to see if the
>> scaling_available_governors attribute exists first. It is to add
>> more error handling.
>
>
On 1 February 2015 at 21:44, Amit Kucheria wrote:
> On Mon, Feb 2, 2015 at 7:34 AM, Lisa Nguyen wrote:
>> In PM-QA, there are programs written in C (e.g. cpuidle_killer,
>> uevent_reader) that run in the background while some scripts are
>> being.
>>
>> However,
On 1 February 2015 at 22:16, Amit Kucheria wrote:
> On Mon, Feb 2, 2015 at 11:40 AM, Amit Kucheria
> wrote:
>> Hi Lisa,
>>
>> On Mon, Feb 2, 2015 at 7:34 AM, Lisa Nguyen wrote:
>>> Changes in v2:
>>> - Reorganized previous patchset and rec
The check function already determines if a subtest fails, passes, or
skips. No need to check for the return value of the command.
Signed-off-by: Lisa Nguyen
---
cpufreq/cpufreq_08.sh |3 ---
cpufreq/cpufreq_09.sh |6 --
2 files changed, 9 deletions(-)
diff --git a/cpufreq
Use the built-in sort function to ensure that the PM-QA
scripts will run in order. Some platforms may have
makefile versions greater than 3.82.
See the following link for details:
https://lists.gnu.org/archive/html/info-gnu/2010-07/msg00023.html
Signed-off-by: Lisa Nguyen
---
Test.mk |2
With this new change, the final result for the cpufreq_09
script will always show up and be counted in LAVA.
Signed-off-by: Lisa Nguyen
---
cpufreq/cpufreq_09.sh |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/cpufreq/cpufreq_09.sh b/cpufreq/cpufreq_09.sh
index
Before searching for specific governors, check to see if the
scaling_available_governors attribute exists first. It is to add
more error handling.
Signed-off-by: Lisa Nguyen
---
cpufreq/cpufreq_05.sh | 83 +++--
1 file changed, 45 insertions(+), 38
Additional checks to see if a directory or file exists.
Signed-off-by: Lisa Nguyen
---
cpufreq/cpufreq_sanity.sh |3 +--
cpuhotplug/cpuhotplug_07.sh |5 -
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/cpufreq/cpufreq_sanity.sh b/cpufreq/cpufreq_sanity.sh
index
Signed-off-by: Lisa Nguyen
---
cpufreq/cpufreq_03.sh |3 --
cpufreq/cpufreq_04.sh |2 +-
cpufreq/cpufreq_05.sh |6 ++-
cpufreq/cpufreq_06.sh | 10 +---
cpufreq/cpufreq_07.sh | 32 ++--
cpufreq/cpufreq_08.sh
Silence the grep results by using the -q option. The extra output
that some grep commands print out would be more useful in
debugging situations.
Signed-off-by: Lisa Nguyen
---
cpuhotplug/cpuhotplug_06.sh |2 +-
cpuhotplug/cpuhotplug_07.sh |4 ++--
2 files changed, 3 insertions(+), 3
Add an if condition to check if the log directory exists. Create
one if it doesn't already exist.
Signed-off-by: Lisa Nguyen
---
include/suspend_functions.sh |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/suspend_functions.sh b/include/suspend_functio
Signed-off-by: Lisa Nguyen
---
cpuhotplug/Android.mk |4 +---
cputopology/Android.mk |2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/cpuhotplug/Android.mk b/cpuhotplug/Android.mk
index fabb70a..ac0ff0b 100644
--- a/cpuhotplug/Android.mk
+++ b/cpuhotplug/Android.mk
Every test module has a sanity script. Add one for cputopology
to check for topology entries for all cpus.
Signed-off-by: Lisa Nguyen
---
cputopology/cputopology_sanity.sh | 49
cputopology/cputopology_sanity.txt |1 +
2 files changed, 50 insertions
In PM-QA, there are programs written in C (e.g. cpuidle_killer,
uevent_reader) that run in the background while some scripts are
being.
However, remove the extra slash and period when it's not necessary
and create variables to store the path of these programs.
Signed-off-by: Lisa N
Set the sampling_rate to zero if the sampling_rate attribute cannot
be found in either directories listed in the if condition. This will
also resolve minor bugs where the sampling_rate is missing.
Signed-off-by: Lisa Nguyen
---
include/functions.sh |4 +++-
1 file changed, 3 insertions
Add an entry in Switches.sh to export and set the hotplug_allow_cpu0
variable to zero. This will resolve Android issues where invalid
comparisons cannot be made in the cpuhotplug scripts. Android runs
the Switches.sh script before it runs any test modules.
Signed-off-by: Lisa Nguyen
The value of the thermal_try_max variable does not change
when running PM-QA. There is no reason to check if the value is
zero if it's hardly used at all.
Signed-off-by: Lisa Nguyen
---
Switches.sh |3 ---
thermal/thermal_06.sh |5 -
2 files changed, 8 deletions(-)
z_sanity_check.sh doesn't have a meaningful name. Rename it to
cpuhotplug_99 as the last script to run to see if all cpus are back
online after running previous cpuhotplug scripts.
Signed-off-by: Lisa Nguyen
---
cpuhotplug/cpuhotplug_99.sh |
e the
cpuidle_03 test case.
4. Update the PM-QA wiki with new test cases and their descriptions:
https://wiki.linaro.org/WorkingGroups/PowerManagement/Resources/TestSuite/PmQaSpecification
Comments and/or questions are highly encouraged.
Lisa Nguyen (25):
Fix path to library files and change sh
1_sanity_check.sh script didn't have a meaningful name. Rename it to
cpuhotplug_00 as the first script to check if all cpus are online
before the other cpuhotplug scripts begin.
Signed-off-by: Lisa Nguyen
---
cpuhotplug/1_sanity_check.sh |
'source' is a BASH keyword. Edit the path to the library files by
using the POSIX version of the 'source' keyword.
Also change the interpreter from #!/bin/bash to #!/bin/sh.
Signed-off-by: Lisa Nguyen
---
cpufreq/cpufreq_01.sh |4 ++--
cpufreq/cpufreq_02
The syntax for arrays, foo[index], is defined in BASH. Replace BASH
arrays with ones that are POSIX compliant.
Signed-off-by: Lisa Nguyen
---
cpufreq/cpufreq_06.sh| 20
include/functions.sh | 14 +++
include/thermal_functions.sh | 54
Remove unused variables and rename some variables to avoid conflicts
since they are global. Also, renaming variables will make it easier
to understand what variables are assigned to them.
Signed-off-by: Lisa Nguyen
---
cpuhotplug/cpuhotplug_02.sh |6 +-
cpuhotplug/cpuhotplug_03.sh |5
Instead of using a command to check if the user is root,
use the is_root() function to perform that check in the
cpuidle_03.sh script
Signed-off-by: Lisa Nguyen
---
cpuidle/cpuidle_03.sh |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cpuidle/cpuidle_03.sh b/cpuidle
Using double equals to evaluate whether two conditions are
equal is considered BASH syntax. The POSIX compliant version
uses one equal sign for evaluating.
Signed-off-by: Lisa Nguyen
---
cpufreq/cpufreq_03.sh|2 +-
cpufreq/cpufreq_04.sh|2 +-
cpufreq/cpufreq_07.sh
Remove signals that begin with SIG* since that is considered a
bashism. Use the POSIX-compliant version to list signals to be
used with the trap command.
Signed-off-by: Lisa Nguyen
---
cpufreq/cpufreq_05.sh |2 +-
cpufreq/cpufreq_06.sh |2 +-
cpufreq/cpufreq_07.sh |2 +-
cpufreq
Fix the syntax to get the current cpu id number with
the POSIX version.
Signed-off-by: Lisa Nguyen
---
cpuhotplug/cpuhotplug_03.sh |2 +-
cpuhotplug/cpuhotplug_04.sh |2 +-
cpuhotplug/cpuhotplug_05.sh |2 +-
cpuhotplug/cpuhotplug_06.sh |2 +-
cpuhotplug/cpuhotplug_07.sh |2
$RANDOM is a BASH defined variable. Rewrite the randomize()
function to be POSIX-compliant.
Signed-off-by: Lisa Nguyen
---
cpuhotplug/cpuhotplug_08.sh | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/cpuhotplug/cpuhotplug_08.sh b/cpuhotplug/cpuhotplug_08.sh
Thanks for pointing that out, Sanjay :)
On 27 January 2015 at 04:01, sanjay r wrote:
> $checkbashisms -f suspend/*.sh
>
> possible bashism in suspend/suspend_05.sh line 48 (let ...):
> let timer_sleep="$args_power_sleep"
> possible bashism in suspend/suspend_05.sh line 68 (let ...):
> let
On 19 January 2015 at 22:59, Amit Kucheria wrote:
> On Tue, Jan 20, 2015 at 6:06 AM, Lisa Nguyen wrote:
>> Update the Android makefiles in cputopology and cpuhotplug
>> since a few subtests have been added or renamed. Remove
>> unnecessary whitespace detected by checkpatch
On 19 January 2015 at 22:57, Amit Kucheria wrote:
> On Tue, Jan 20, 2015 at 6:06 AM, Lisa Nguyen wrote:
>> Rename z_sanity_check.sh script to cpuhotplug_09.sh to give it a
>> more meaningful name and to check if all cpus are back online after
>> running previous cpuhotplu
On 19 January 2015 at 22:55, Amit Kucheria wrote:
> On Tue, Jan 20, 2015 at 6:06 AM, Lisa Nguyen wrote:
>> [ It's been long overdue and PM-QA gets a makeover... ]
>
> Indeed.
>
>> This patchset primarily fixes Linaro Bug# 772
>> (https://bugs.linaro.org/show_bu
Rename z_sanity_check.sh script to cpuhotplug_09.sh to give it a
more meaningful name and to check if all cpus are back online after
running previous cpuhotplug tests.
Signed-off-by: Lisa Nguyen
---
cpuhotplug/cpuhotplug_09.sh | 39 +++
cpuhotplug
clear of what the function does.
Signed-off-by: Lisa Nguyen
---
cpuhotplug/1_sanity_check.sh | 39 ---
cpuhotplug/cpuhotplug_00.sh | 39 +++
2 files changed, 39 insertions(+), 39 deletions(-)
delete mode 100755
Remove thermal_try_max variable since it is not used anywhere in
PM-QA nor does its value change at any point.
Signed-off-by: Lisa Nguyen
---
Switches.sh |3 ---
1 file changed, 3 deletions(-)
diff --git a/Switches.sh b/Switches.sh
index e01d4c5..111d5cb 100644
--- a/Switches.sh
+++ b
Update the Android makefiles in cputopology and cpuhotplug
since a few subtests have been added or renamed. Remove
unnecessary whitespace detected by checkpatch as well.
Signed-off-by: Lisa Nguyen
---
cpufreq/Android.mk |2 +-
cpuhotplug/Android.mk | 18 ++
cpuidle
Currently, the suspend test module is disabled by default, but
make the suspend scripts more POSIX-compliant to be consistent
with other scripts.
Signed-off-by: Lisa Nguyen
---
include/suspend_functions.sh | 20 +---
suspend/suspend_01.sh|9 -
suspend
p" at the end.
Signed-off-by: Lisa Nguyen
---
cpufreq/cpufreq_06.sh | 11 +--
cpufreq/cpufreq_08.sh |5 ++---
cpufreq/cpufreq_09.sh |4 ++--
3 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/cpufreq/cpufreq_06.sh b/cpufreq/cpufreq_06.sh
index 9159c9e..75369bf 10
After renaming 1_sanity_script.sh and z_sanity_script.sh to
cpuhotplug_00.sh and cpuhotplug_09.sh respectively, provide the
text files for these scripts that contain the description of
these tests.
Signed-off-by: Lisa Nguyen
---
cpuhotplug/1_sanity_check.txt |1 -
cpuhotplug/cpuhotplug_00
Remove bashism in cpuhotplug scripts. $RANDOM is an internal BASH
function, so remove it to follow POSIX standards.
Signed-off-by: Lisa Nguyen
---
cpuhotplug/1_sanity_check.sh|7 +++
cpuhotplug/cpuhotplug_01.sh |5 ++---
cpuhotplug/cpuhotplug_02.sh | 21
Remove bashisms in the cpufreq test module in addition to
renaming variables to more meaningful names and minor cleanups.
Signed-off-by: Lisa Nguyen
---
cpufreq/cpufreq_01.sh |4 ++--
cpufreq/cpufreq_02.sh |5 ++---
cpufreq/cpufreq_03.sh | 13 ++--
cpufreq
Use the sort built-in function to ensure that scripts
will be executed in order depending on make version.
See the following link for details on return value of
the built-in wildcard function:
https://lists.gnu.org/archive/html/info-gnu/2010-07/msg00023.html
Signed-off-by: Lisa Nguyen
Remove bashisms in utils_sanity.sh script.
Signed-off-by: Lisa Nguyen
---
utils/utils_sanity.sh |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/utils/utils_sanity.sh b/utils/utils_sanity.sh
index 84f4905..c5bdcd7 100755
--- a/utils/utils_sanity.sh
+++ b/utils
Add cputopology_sanity script to check for topology entries for
all cpus. Also, all test modules have a sanity script, so add one
for cputopology test module.
Signed-off-by: Lisa Nguyen
---
cputopology/cputopology_sanity.sh | 49 +
1 file changed, 49
Remove bashisms in the cputopology scripts.
Signed-off-by: Lisa Nguyen
---
cputopology/cputopology_01.sh |9 -
cputopology/cputopology_02.sh |5 ++---
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/cputopology/cputopology_01.sh b/cputopology/cputopology_01.sh
Remove bashism in thermal scripts and remove thermal_try_max
variable as it is not used anywhere else nor does its value
changes. Rename variables to something more meaningful and
improve format for readability.
Signed-off-by: Lisa Nguyen
---
thermal/thermal_00.sh | 22
Export hotplug_allow_cpu0 to resolve invalid comparison errors from
cpuhotplug scripts in Android.
Signed-off-by: Lisa Nguyen
---
Switches.sh |3 +++
1 file changed, 3 insertions(+)
diff --git a/Switches.sh b/Switches.sh
index cc59992..e01d4c5 100644
--- a/Switches.sh
+++ b/Switches.sh
Remove bashisms in cpuidle test module to make them POSIX-compliant.
Also do some minor cleanups to make the scripts readable.
Signed-off-by: Lisa Nguyen
---
cpuidle/cpuidle_01.sh | 21 +
cpuidle/cpuidle_02.sh |7 +++
cpuidle/cpuidle_03.sh | 17
.
However, suspend_functions.sh has not been fully tested since
the suspend test module is currently disabled by default in PM-QA.
Signed-off-by: Lisa Nguyen
---
include/functions.sh | 248 --
include/suspend_functions.sh |4 +-
include
like the
cpuidle_03 test case.
Comments and/or questions are highly encouraged.
Lisa Nguyen (18):
functions: Remove bashisms in function scripts
cpuidle: Remove bashisms in cpuidle test module
cputopology: Remove bashisms in cputopology test module
cpufreq: Remove bashisms in cpufreq
patch merged.
Thanks for the ack, Sanjay.
On 4 September 2014 23:34, Sanjay Singh Rawat wrote:
>
> On Friday 05 September 2014 11:54 AM, Lisa Nguyen wrote:
>>
>> Resolve the "ls: Unknown option '-1'" error in the Android shell
>> by removing -1v o
Resolve the "ls: Unknown option '-1'" error in the Android shell
by removing -1v option from ls command used to find number of
cpus on a platform.
Reported-by: Naresh Kamboju
Signed-off-by: Lisa Nguyen
---
include/functions.sh |2 +-
1 file changed, 1 insertion(+),
Hi,
I am checking with the linaro-dev mailing list to see if anyone is
still using these outdated PM-QA scripts:
https://git.linaro.org/qa/test-definitions.git/tree/HEAD:/common/scripts/pm-qa
I'm planning to delete them by the end of this week if there aren't
any objections :)
Lisa
Create a global variable that will look for number of cpus
for a platform and use it in multiple functions to make the
code simplier to read.
Signed-off-by: Lisa Nguyen
---
Changes from v1 to v2:
- Edit the command to grab the number of cpus by
adding the -1v option, showing the cpu numbers in
Remove the pass and fail count variables from the check()
function as all the pass/fail/skip counts are done inside
the log_end() function.
Signed-off-by: Lisa Nguyen
---
Note: This was supposed to be part of the refactored
pass/skip/fail code, but it got overlooked.
include/functions.sh
Create a global variable that will look for number of cpus
for a platform and use it in multiple functions to make the
code simplier to read.
Signed-off-by: Lisa Nguyen
---
cpufreq/cpufreq_05.sh |6 +++---
cpuhotplug/cpuhotplug_sanity.sh |1 -
include/functions.sh
follow up patch to update the pwrmgmt test definition, so LAVA
can record PM-QA results accurately.
Signed-off-by: Lisa Nguyen
---
Changes from v3 to v4:
- Fix syntax errors that were undetected (e.g. space between
a condition and end square bracket in an if statement) that
affected the pass/fail
On 29 July 2014 19:36, Lisa Nguyen wrote:
> Focus on returning the results of each test script rather
> than the results of each subtest. This will help to keep the
> number of PM-QA test results consistent across multiple boards
> regardless of number of frequencies, cores, etc.
follow up patch to update the pwrmgmt test definition, so LAVA
can record PM-QA results accurately.
Signed-off-by: Lisa Nguyen
---
Change from v2 to v3:
- Fix a silly increment error for skip count cause I
didn't look closely enough
Changes from v1 to v2:
- Rewrite test_status_show() function
follow up patch to update the pwrmgmt test definition, so LAVA
can record PM-QA results accurately.
Signed-off-by: Lisa Nguyen
---
Changes from v1 to v2:
- Rewrite test_status_show() function
- Add description and log_skip() function in thermal_05
- Moved skip/fail/pass counts to log_end() function
On 28 July 2014 13:38, Lisa Nguyen wrote:
> On 27 July 2014 23:16, Sanjay Singh Rawat wrote:
>>
>>
>> On Friday 25 July 2014 04:32 AM, Lisa Nguyen wrote:
>>>
>>> Focus on returning the results of each test script rather
>>> than the results of eac
On 27 July 2014 23:16, Sanjay Singh Rawat wrote:
>
>
> On Friday 25 July 2014 04:32 AM, Lisa Nguyen wrote:
>>
>> Focus on returning the results of each test script rather
>> than the results of each subtest. This will help to keep the
>> number of pm-qa test r
sible that
the logic can be improved, or my explanation can be clearer. Also,
once the final version of this patch is accepted and merged, then
there will be a follow up patch to update the pwrmgmt test
definition, so LAVA can record PM-QA results accurately.
Signed-off-by: Lisa Nguyen
---
cp
To make pm-qa consistent, all thermal subtests should say "ok" or
"err" instead of "pass" or "fail". The remaining subtests in pm-qa
follow the ok/err scheme.
Signed-off-by: Lisa Nguyen
---
include/thermal_functions.sh |4 ++--
1 file changed, 2 ins
Modify Test.mk to resolve the following build error:
make: [uncheck] Error 1 (ignored).
Signed-off-by: Lisa Nguyen
---
Changes from v1 to v2:
- Forgot to add @ to silence the shell command
---
Test.mk |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Test.mk b/Test.mk
Modify Test.mk to resolve the following build error:
make: [uncheck] Error 1 (ignored).
Signed-off-by: Lisa Nguyen
---
Test.mk |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Test.mk b/Test.mk
index 89e5cd9..9fad2c4 100644
--- a/Test.mk
+++ b/Test.mk
@@ -22,7 +22,7
By default, cpuhotplug does not run on cpu0. However, if
we want to allow cpuhotplug to run on cpu0, then we must
pass the parameter, hotplug_allow_cpu0=1, to make check.
Signed-off-by: Lisa Nguyen
---
Changes from v3 to v4:
- Remove =~ symbol and rewrote test condition in
check_cpuhotplug_files
By default, cpuhotplug does not run on cpu0. However, if
we want to allow cpuhotplug to run on cpu0, then we must
pass the parameter, hotplug_allow_cpu0=1, to make check.
Signed-off-by: Lisa Nguyen
---
Changes from v2 to v3:
- Renamed is_cpu0_allowed() function to is_cpu0_hotplug_allowed
1 - 100 of 103 matches
Mail list logo
